Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
I think this might be the same case exposed here: https://code.google.com/p/gerrit/issues/detail?id=3267 On 06/01, Greg Sheremeta wrote: It's hard to manually reproduce the conditions. You can close this ticket and I'll just let you know if I see it again. - Original Message - From: Eyal Edri ee...@redhat.com To: Greg Sheremeta gsher...@redhat.com Cc: infra infra@ovirt.org Sent: Wednesday, May 27, 2015 9:03:04 AM Subject: Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1 - Original Message - From: Eyal Edri ee...@redhat.com To: Greg Sheremeta gsher...@redhat.com Cc: infra infra@ovirt.org Sent: Tuesday, May 26, 2015 7:35:50 PM Subject: Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1 - Original Message - From: Greg Sheremeta gsher...@redhat.com To: infra infra@ovirt.org Sent: Tuesday, May 26, 2015 7:25:05 PM Subject: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1 Why is this patch (which is merged!) -1 verified from jenkins? https://gerrit.ovirt.org/#/c/41296/ (May be related to the bug I've already reported on Jenkins / gerrit integration) it looks like jenkins isn't dropping the -1 from verified even if a second build successeded. i changed the gerrit settings so it will give +1 on verify to see if that's the case, so now you will see +1 verify and +code review, if we don't want ci to +verify then we can just not use the verify flag and stick to the code review which looks to be working. can you check if this still happens? after i changed the settings. e. Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gsher...@redhat.com ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgpoVy6bQxaIy.pgp Description: PGP signature ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
It's hard to manually reproduce the conditions. You can close this ticket and I'll just let you know if I see it again. - Original Message - From: Eyal Edri ee...@redhat.com To: Greg Sheremeta gsher...@redhat.com Cc: infra infra@ovirt.org Sent: Wednesday, May 27, 2015 9:03:04 AM Subject: Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1 - Original Message - From: Eyal Edri ee...@redhat.com To: Greg Sheremeta gsher...@redhat.com Cc: infra infra@ovirt.org Sent: Tuesday, May 26, 2015 7:35:50 PM Subject: Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1 - Original Message - From: Greg Sheremeta gsher...@redhat.com To: infra infra@ovirt.org Sent: Tuesday, May 26, 2015 7:25:05 PM Subject: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1 Why is this patch (which is merged!) -1 verified from jenkins? https://gerrit.ovirt.org/#/c/41296/ (May be related to the bug I've already reported on Jenkins / gerrit integration) it looks like jenkins isn't dropping the -1 from verified even if a second build successeded. i changed the gerrit settings so it will give +1 on verify to see if that's the case, so now you will see +1 verify and +code review, if we don't want ci to +verify then we can just not use the verify flag and stick to the code review which looks to be working. can you check if this still happens? after i changed the settings. e. Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gsher...@redhat.com ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
- Original Message - From: Eyal Edri ee...@redhat.com To: Greg Sheremeta gsher...@redhat.com Cc: infra infra@ovirt.org Sent: Tuesday, May 26, 2015 7:35:50 PM Subject: Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1 - Original Message - From: Greg Sheremeta gsher...@redhat.com To: infra infra@ovirt.org Sent: Tuesday, May 26, 2015 7:25:05 PM Subject: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1 Why is this patch (which is merged!) -1 verified from jenkins? https://gerrit.ovirt.org/#/c/41296/ (May be related to the bug I've already reported on Jenkins / gerrit integration) it looks like jenkins isn't dropping the -1 from verified even if a second build successeded. i changed the gerrit settings so it will give +1 on verify to see if that's the case, so now you will see +1 verify and +code review, if we don't want ci to +verify then we can just not use the verify flag and stick to the code review which looks to be working. can you check if this still happens? after i changed the settings. e. Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gsher...@redhat.com ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Re: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
- Original Message - From: Greg Sheremeta gsher...@redhat.com To: infra infra@ovirt.org Sent: Tuesday, May 26, 2015 7:25:05 PM Subject: [TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1 Why is this patch (which is merged!) -1 verified from jenkins? https://gerrit.ovirt.org/#/c/41296/ (May be related to the bug I've already reported on Jenkins / gerrit integration) it looks like jenkins isn't dropping the -1 from verified even if a second build successeded. i changed the gerrit settings so it will give +1 on verify to see if that's the case, so now you will see +1 verify and +code review, if we don't want ci to +verify then we can just not use the verify flag and stick to the code review which looks to be working. e. Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gsher...@redhat.com ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
[TICKET] gerrit marked patch as still -1, but jenkins supposedly removed the -1
Why is this patch (which is merged!) -1 verified from jenkins? https://gerrit.ovirt.org/#/c/41296/ (May be related to the bug I've already reported on Jenkins / gerrit integration) Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gsher...@redhat.com ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
