Re: [urgent] call for developers - upstream jenkins: Build Queue (543) WAS: Fwd: [ovirt-devel] gerrit+ci improvement proposal
As a first contention measure to alleviate the flood, I've changed the way findbugs is triggered to get triggered only on verified +1 (it will set code review flag on pass or failure, and will run on drafts, can't use more than one condition for the trigger). On 06/09, Max Kovgan wrote: hi, Dear Developers! We are aware of the urge and pressure to push your patches a.s.a.p before the code freeze. Howeever, with current flow of patch updates, we currently have an overloaded CI, which will result in a very long waiting time for jobs to start SO, in order to reduce that time, please make sure you are using DRAFTs [1] for early stage patches [during human reviews] how to use drafts: 1) using plain git push - refer to [1] 2) using git review plugin if you've installed git review plugin: git review -D -r repo branch example with repo origin and branch master: git review -D -r origin master plugin can be installed as explained here: [2] [1] http://stackoverflow.com/questions/18106064/how-to-push-drafts-to-gerrit [2] http://www.mediawiki.org/wiki/Gerrit/git-review#Fedora.2FCentOS N.B. Using drafts is the only alternative for adding 2 new gerrit flags. If you have better ideas - you are still welcome to suggest. Earlier today I did some mining on gerrit patches status: out of ~1400 open patches ~350 are drafts, which was incouraging. Yet out of all 66 committers for those patches only 6 are using drafts: In [25]: for c in changes: : if c.get('status') != 'DRAFT': : continue : saints.add(c.get('owner').get('name')) : In [26]: saints Out[26]: {u'Alon Bar-Lev', u'Liron Aravot', u'Martin Mucha', u'Nir Soffer', u'Piotr Kliczewski', u'Tomer Saban'} Kudos. Max Kovgan Senior Software Engineer Red Hat - EMEA ENG Virtualization RD Tel.: +972 9769 2060 Email: mkovgan [at] redhat [dot] com Web: http://www.redhat.com RHT Global #: 82-72060 - Forwarded Message - From: Oved Ourfali oourf...@redhat.com To: Eyal Edri ee...@redhat.com Cc: Oved Ourfali ov...@redhat.com, de...@ovirt.org, infra infra@ovirt.org Sent: Sunday, June 7, 2015 10:05:23 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal On Jun 7, 2015 10:00 AM, Eyal Edri ee...@redhat.com wrote: - Original Message - From: Oved Ourfali ov...@redhat.com To: Eyal Edri ee...@redhat.com Cc: infra@ovirt.org, de...@ovirt.org Sent: Sunday, June 7, 2015 9:55:56 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Eyal Edri ee...@redhat.com To: Eli Mesika emes...@redhat.com Cc: Oved Ourfali ov...@redhat.com, de...@ovirt.org, infra@ovirt.org Sent: Sunday, June 7, 2015 9:52:15 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Eli Mesika emes...@redhat.com To: Oved Ourfali ov...@redhat.com Cc: Eyal Edri ee...@redhat.com, infra@ovirt.org, de...@ovirt.org Sent: Thursday, June 4, 2015 3:49:05 PM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Oved Ourfali ov...@redhat.com To: Eyal Edri ee...@redhat.com Cc: de...@ovirt.org, infra@ovirt.org Sent: Thursday, June 4, 2015 10:03:02 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Eyal Edri ee...@redhat.com To: Sandro Bonazzola sbona...@redhat.com Cc: infra@ovirt.org, de...@ovirt.org Sent: Thursday, June 4, 2015 9:46:40 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Sandro Bonazzola sbona...@redhat.com To: Eyal Edri ee...@redhat.com, Max Kovgan mkov...@redhat.com Cc: de...@ovirt.org, infra@ovirt.org Sent: Thursday, June 4, 2015 9:11:10 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal Il 03/06/2015 21:46, Eyal Edri ha scritto: - Original Message - From: Max Kovgan mkov...@redhat.com To: de...@ovirt.org Cc: infra@ovirt.org Sent: Wednesday, June 3, 2015 8:22:54 PM Subject: [ovirt-devel] gerrit+ci improvement proposal Hi everyone! We really want to have reliable and snappy CI: to allow short cycles and encourage developers to write tests. # Problem Many patches are neither ready for review nor for CI upon submission, which is OK. But running all the jobs on those patches with limited resources results in: overloaded resources,
[urgent] call for developers - upstream jenkins: Build Queue (543) WAS: Fwd: [ovirt-devel] gerrit+ci improvement proposal
hi, Dear Developers! We are aware of the urge and pressure to push your patches a.s.a.p before the code freeze. Howeever, with current flow of patch updates, we currently have an overloaded CI, which will result in a very long waiting time for jobs to start SO, in order to reduce that time, please make sure you are using DRAFTs [1] for early stage patches [during human reviews] how to use drafts: 1) using plain git push - refer to [1] 2) using git review plugin if you've installed git review plugin: git review -D -r repo branch example with repo origin and branch master: git review -D -r origin master plugin can be installed as explained here: [2] [1] http://stackoverflow.com/questions/18106064/how-to-push-drafts-to-gerrit [2] http://www.mediawiki.org/wiki/Gerrit/git-review#Fedora.2FCentOS N.B. Using drafts is the only alternative for adding 2 new gerrit flags. If you have better ideas - you are still welcome to suggest. Earlier today I did some mining on gerrit patches status: out of ~1400 open patches ~350 are drafts, which was incouraging. Yet out of all 66 committers for those patches only 6 are using drafts: In [25]: for c in changes: : if c.get('status') != 'DRAFT': : continue : saints.add(c.get('owner').get('name')) : In [26]: saints Out[26]: {u'Alon Bar-Lev', u'Liron Aravot', u'Martin Mucha', u'Nir Soffer', u'Piotr Kliczewski', u'Tomer Saban'} Kudos. Max Kovgan Senior Software Engineer Red Hat - EMEA ENG Virtualization RD Tel.: +972 9769 2060 Email: mkovgan [at] redhat [dot] com Web: http://www.redhat.com RHT Global #: 82-72060 - Forwarded Message - From: Oved Ourfali oourf...@redhat.com To: Eyal Edri ee...@redhat.com Cc: Oved Ourfali ov...@redhat.com, de...@ovirt.org, infra infra@ovirt.org Sent: Sunday, June 7, 2015 10:05:23 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal On Jun 7, 2015 10:00 AM, Eyal Edri ee...@redhat.com wrote: - Original Message - From: Oved Ourfali ov...@redhat.com To: Eyal Edri ee...@redhat.com Cc: infra@ovirt.org, de...@ovirt.org Sent: Sunday, June 7, 2015 9:55:56 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Eyal Edri ee...@redhat.com To: Eli Mesika emes...@redhat.com Cc: Oved Ourfali ov...@redhat.com, de...@ovirt.org, infra@ovirt.org Sent: Sunday, June 7, 2015 9:52:15 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Eli Mesika emes...@redhat.com To: Oved Ourfali ov...@redhat.com Cc: Eyal Edri ee...@redhat.com, infra@ovirt.org, de...@ovirt.org Sent: Thursday, June 4, 2015 3:49:05 PM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Oved Ourfali ov...@redhat.com To: Eyal Edri ee...@redhat.com Cc: de...@ovirt.org, infra@ovirt.org Sent: Thursday, June 4, 2015 10:03:02 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Eyal Edri ee...@redhat.com To: Sandro Bonazzola sbona...@redhat.com Cc: infra@ovirt.org, de...@ovirt.org Sent: Thursday, June 4, 2015 9:46:40 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Sandro Bonazzola sbona...@redhat.com To: Eyal Edri ee...@redhat.com, Max Kovgan mkov...@redhat.com Cc: de...@ovirt.org, infra@ovirt.org Sent: Thursday, June 4, 2015 9:11:10 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal Il 03/06/2015 21:46, Eyal Edri ha scritto: - Original Message - From: Max Kovgan mkov...@redhat.com To: de...@ovirt.org Cc: infra@ovirt.org Sent: Wednesday, June 3, 2015 8:22:54 PM Subject: [ovirt-devel] gerrit+ci improvement proposal Hi everyone! We really want to have reliable and snappy CI: to allow short cycles and encourage developers to write tests. # Problem Many patches are neither ready for review nor for CI upon submission, which is OK. But running all the jobs on those patches with limited resources results in: overloaded resources, slow response time, unhappy developers. # Proposed Solution To run less jobs we know we don’t need to, thus making more resources for the jobs we need to run. We have been experimenting to make our CI stabler and quicker to respond by using gerrit flags. This has improved in both directions very well internally.
Re: [urgent] call for developers - upstream jenkins: Build Queue (543) WAS: Fwd: [ovirt-devel] gerrit+ci improvement proposal
Thanks! Max Kovgan Senior Software Engineer Red Hat - EMEA ENG Virtualization RD Tel.: +972 9769 2060 Email: mkovgan [at] redhat [dot] com Web: http://www.redhat.com RHT Global #: 82-72060 - Original Message - From: David Caro dcaro...@redhat.com To: Max Kovgan mkov...@redhat.com Cc: de...@ovirt.org, infra@ovirt.org Sent: Tuesday, June 9, 2015 6:41:16 PM Subject: Re: [urgent] call for developers - upstream jenkins: Build Queue (543) WAS: Fwd: [ovirt-devel] gerrit+ci improvement proposal As a first contention measure to alleviate the flood, I've changed the way findbugs is triggered to get triggered only on verified +1 (it will set code review flag on pass or failure, and will run on drafts, can't use more than one condition for the trigger). On 06/09, Max Kovgan wrote: hi, Dear Developers! We are aware of the urge and pressure to push your patches a.s.a.p before the code freeze. Howeever, with current flow of patch updates, we currently have an overloaded CI, which will result in a very long waiting time for jobs to start SO, in order to reduce that time, please make sure you are using DRAFTs [1] for early stage patches [during human reviews] how to use drafts: 1) using plain git push - refer to [1] 2) using git review plugin if you've installed git review plugin: git review -D -r repo branch example with repo origin and branch master: git review -D -r origin master plugin can be installed as explained here: [2] [1] http://stackoverflow.com/questions/18106064/how-to-push-drafts-to-gerrit [2] http://www.mediawiki.org/wiki/Gerrit/git-review#Fedora.2FCentOS N.B. Using drafts is the only alternative for adding 2 new gerrit flags. If you have better ideas - you are still welcome to suggest. Earlier today I did some mining on gerrit patches status: out of ~1400 open patches ~350 are drafts, which was incouraging. Yet out of all 66 committers for those patches only 6 are using drafts: In [25]: for c in changes: : if c.get('status') != 'DRAFT': : continue : saints.add(c.get('owner').get('name')) : In [26]: saints Out[26]: {u'Alon Bar-Lev', u'Liron Aravot', u'Martin Mucha', u'Nir Soffer', u'Piotr Kliczewski', u'Tomer Saban'} Kudos. Max Kovgan Senior Software Engineer Red Hat - EMEA ENG Virtualization RD Tel.: +972 9769 2060 Email: mkovgan [at] redhat [dot] com Web: http://www.redhat.com RHT Global #: 82-72060 - Forwarded Message - From: Oved Ourfali oourf...@redhat.com To: Eyal Edri ee...@redhat.com Cc: Oved Ourfali ov...@redhat.com, de...@ovirt.org, infra infra@ovirt.org Sent: Sunday, June 7, 2015 10:05:23 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal On Jun 7, 2015 10:00 AM, Eyal Edri ee...@redhat.com wrote: - Original Message - From: Oved Ourfali ov...@redhat.com To: Eyal Edri ee...@redhat.com Cc: infra@ovirt.org, de...@ovirt.org Sent: Sunday, June 7, 2015 9:55:56 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Eyal Edri ee...@redhat.com To: Eli Mesika emes...@redhat.com Cc: Oved Ourfali ov...@redhat.com, de...@ovirt.org, infra@ovirt.org Sent: Sunday, June 7, 2015 9:52:15 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Eli Mesika emes...@redhat.com To: Oved Ourfali ov...@redhat.com Cc: Eyal Edri ee...@redhat.com, infra@ovirt.org, de...@ovirt.org Sent: Thursday, June 4, 2015 3:49:05 PM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Oved Ourfali ov...@redhat.com To: Eyal Edri ee...@redhat.com Cc: de...@ovirt.org, infra@ovirt.org Sent: Thursday, June 4, 2015 10:03:02 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Eyal Edri ee...@redhat.com To: Sandro Bonazzola sbona...@redhat.com Cc: infra@ovirt.org, de...@ovirt.org Sent: Thursday, June 4, 2015 9:46:40 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal - Original Message - From: Sandro Bonazzola sbona...@redhat.com To: Eyal Edri ee...@redhat.com, Max Kovgan mkov...@redhat.com Cc: de...@ovirt.org, infra@ovirt.org Sent: Thursday, June 4, 2015 9:11:10 AM Subject: Re: [ovirt-devel] gerrit+ci improvement proposal Il 03/06/2015 21:46, Eyal Edri ha scritto: - Original Message - From: Max Kovgan mkov...@redhat.com To: de...@ovirt.org Cc: infra@ovirt.org Sent: Wednesday, June 3, 2015 8:22:54 PM Subject: [ovirt-devel] gerrit+ci improvement proposal