Re: Can not rebase or push updates to patches with different author

[Shlomo Ben David]

Hi Anton,

I still didn't update other projects to the default rules.
I'll update them when I return to the office.

BR,

Shlomi Ben-David

בתאריך 20 באוק׳ 2016 04:27 PM,‏ "Anton Marchukov"  כתב:

> Hello Shlomi.
>
> I also had to add it to:
>
> ovirt-engine-sdk
> ovirt-engine-sdk-java
> ovirt-engine-sdk-js
> ovirt-engine-sdk-tests
>
> May it be that defaults are not sane enough for this particular rule?
>
>
> On Wed, Oct 19, 2016 at 11:50 PM, Shlomo Ben David 
> wrote:
>
>> Hi,
>>
>> This permission was set for project owners only,
>> But in this specific case I think that it's the right solution, because
>> these projects have customized permissions.
>>
>> Thanks a lot Anton.
>>
>> BR,
>>
>> Shlomi Ben-David
>>
>> בתאריך 19 באוק׳ 2016 15:34,‏ "Tal Nisan"  כתב:
>>
>> Makes perfect sense for maintainers as we have to rebase or sometimes
>>> post minor updates (e.g. commit message) for patches that we are not the
>>> authors of.
>>> As for non maintainer users it is of small to no benefit at all so I
>>> think it's the best course of action.
>>>
>>> Thanks.
>>>
>>>
>>> On Wed, Oct 19, 2016 at 3:31 PM, Anton Marchukov 
>>> wrote:
>>>
 FYI. I have added Forge Author Identity to corresponding maintainers
 groups for master and stables branches of ovirt-engine

 On Wed, Oct 19, 2016 at 1:37 PM, Anton Marchukov 
 wrote:

> Hello Shlomi.
>
> May it be related to your permissions generalization work? This is
> something to consider/check.
>
> Anton.
>
>
>
> On Wed, Oct 19, 2016 at 1:26 PM, Tal Nisan  wrote:
>
>> Hi,
>>
>> Up till not long ago it was possible to rebase or push updates to
>> patches even if I was not the author of the patch, now I've noticed that
>> when trying to do so I encounter "invalid author" error.
>> For maintainers (especially in the stable branches) this is crucial
>> and makes the cycle much shorter as no intervention from the original
>> author is needed on trivial rebases, can you please restore the old 
>> state?
>>
>> Tal.
>>
>>
>> ___
>> Infra mailing list
>> Infra@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>
>
> --
> Anton Marchukov
> Senior Software Engineer - RHEV CI - Red Hat
>
>


 --
 Anton Marchukov
 Senior Software Engineer - RHEV CI - Red Hat


>>>
>
>
> --
> Anton Marchukov
> Senior Software Engineer - RHEV CI - Red Hat
>
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Can not rebase or push updates to patches with different author

[Sandro Bonazzola]

On Thu, Oct 20, 2016 at 3:27 PM, Anton Marchukov 
wrote:

> Hello Shlomi.
>
> I also had to add it to:
>
> ovirt-engine-sdk
> ovirt-engine-sdk-java
> ovirt-engine-sdk-js
> ovirt-engine-sdk-tests
>
> May it be that defaults are not sane enough for this particular rule?
>

I guess in some cases owner is not set.



>
>
> On Wed, Oct 19, 2016 at 11:50 PM, Shlomo Ben David 
> wrote:
>
>> Hi,
>>
>> This permission was set for project owners only,
>> But in this specific case I think that it's the right solution, because
>> these projects have customized permissions.
>>
>> Thanks a lot Anton.
>>
>> BR,
>>
>> Shlomi Ben-David
>>
>> בתאריך 19 באוק׳ 2016 15:34,‏ "Tal Nisan"  כתב:
>>
>> Makes perfect sense for maintainers as we have to rebase or sometimes
>>> post minor updates (e.g. commit message) for patches that we are not the
>>> authors of.
>>> As for non maintainer users it is of small to no benefit at all so I
>>> think it's the best course of action.
>>>
>>> Thanks.
>>>
>>>
>>> On Wed, Oct 19, 2016 at 3:31 PM, Anton Marchukov 
>>> wrote:
>>>
 FYI. I have added Forge Author Identity to corresponding maintainers
 groups for master and stables branches of ovirt-engine

 On Wed, Oct 19, 2016 at 1:37 PM, Anton Marchukov 
 wrote:

> Hello Shlomi.
>
> May it be related to your permissions generalization work? This is
> something to consider/check.
>
> Anton.
>
>
>
> On Wed, Oct 19, 2016 at 1:26 PM, Tal Nisan  wrote:
>
>> Hi,
>>
>> Up till not long ago it was possible to rebase or push updates to
>> patches even if I was not the author of the patch, now I've noticed that
>> when trying to do so I encounter "invalid author" error.
>> For maintainers (especially in the stable branches) this is crucial
>> and makes the cycle much shorter as no intervention from the original
>> author is needed on trivial rebases, can you please restore the old 
>> state?
>>
>> Tal.
>>
>>
>> ___
>> Infra mailing list
>> Infra@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>
>
> --
> Anton Marchukov
> Senior Software Engineer - RHEV CI - Red Hat
>
>


 --
 Anton Marchukov
 Senior Software Engineer - RHEV CI - Red Hat


>>>
>
>
> --
> Anton Marchukov
> Senior Software Engineer - RHEV CI - Red Hat
>
>
> ___
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
>


-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com

___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Can not rebase or push updates to patches with different author

[Shlomo Ben David]

Hi,

This permission was set for project owners only,
But in this specific case I think that it's the right solution, because
these projects have customized permissions.

Thanks a lot Anton.

BR,

Shlomi Ben-David

בתאריך 19 באוק׳ 2016 15:34,‏ "Tal Nisan"  כתב:

> Makes perfect sense for maintainers as we have to rebase or sometimes post
> minor updates (e.g. commit message) for patches that we are not the authors
> of.
> As for non maintainer users it is of small to no benefit at all so I think
> it's the best course of action.
>
> Thanks.
>
>
> On Wed, Oct 19, 2016 at 3:31 PM, Anton Marchukov 
> wrote:
>
>> FYI. I have added Forge Author Identity to corresponding maintainers
>> groups for master and stables branches of ovirt-engine
>>
>> On Wed, Oct 19, 2016 at 1:37 PM, Anton Marchukov 
>> wrote:
>>
>>> Hello Shlomi.
>>>
>>> May it be related to your permissions generalization work? This is
>>> something to consider/check.
>>>
>>> Anton.
>>>
>>>
>>>
>>> On Wed, Oct 19, 2016 at 1:26 PM, Tal Nisan  wrote:
>>>
 Hi,

 Up till not long ago it was possible to rebase or push updates to
 patches even if I was not the author of the patch, now I've noticed that
 when trying to do so I encounter "invalid author" error.
 For maintainers (especially in the stable branches) this is crucial and
 makes the cycle much shorter as no intervention from the original author is
 needed on trivial rebases, can you please restore the old state?

 Tal.


 ___
 Infra mailing list
 Infra@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/infra


>>>
>>>
>>> --
>>> Anton Marchukov
>>> Senior Software Engineer - RHEV CI - Red Hat
>>>
>>>
>>
>>
>> --
>> Anton Marchukov
>> Senior Software Engineer - RHEV CI - Red Hat
>>
>>
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Can not rebase or push updates to patches with different author

[Anton Marchukov]

FYI. I have added Forge Author Identity to corresponding maintainers groups
for master and stables branches of ovirt-engine

On Wed, Oct 19, 2016 at 1:37 PM, Anton Marchukov 
wrote:

> Hello Shlomi.
>
> May it be related to your permissions generalization work? This is
> something to consider/check.
>
> Anton.
>
>
>
> On Wed, Oct 19, 2016 at 1:26 PM, Tal Nisan  wrote:
>
>> Hi,
>>
>> Up till not long ago it was possible to rebase or push updates to patches
>> even if I was not the author of the patch, now I've noticed that when
>> trying to do so I encounter "invalid author" error.
>> For maintainers (especially in the stable branches) this is crucial and
>> makes the cycle much shorter as no intervention from the original author is
>> needed on trivial rebases, can you please restore the old state?
>>
>> Tal.
>>
>>
>> ___
>> Infra mailing list
>> Infra@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>
>
> --
> Anton Marchukov
> Senior Software Engineer - RHEV CI - Red Hat
>
>


-- 
Anton Marchukov
Senior Software Engineer - RHEV CI - Red Hat
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Can not rebase or push updates to patches with different author

[Tal Nisan]

Hi,

Up till not long ago it was possible to rebase or push updates to patches
even if I was not the author of the patch, now I've noticed that when
trying to do so I encounter "invalid author" error.
For maintainers (especially in the stable branches) this is crucial and
makes the cycle much shorter as no intervention from the original author is
needed on trivial rebases, can you please restore the old state?

Tal.
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra