Re: Jenkins CI granting excessive +1s
On Tue, Jun 16, 2015 at 08:48:17PM +0200, dcaro wrote: On 06/16, Eyal Edri wrote: Sounds like a bug. Jenkins should only use the CI flag and not change CR and V flags. Might have been a misunderstanding. David, can you fix it so Jenkins will only update CI flag? Can someone pass me an example of the patch that had the reviews? It's possible that previously the jobs were manually modified to only set the ci flag and we updated them on yaml and the manual changes got reverted. Having a sample patch would allow me to trim down the list of possible jobs that give that review. That can be prevented globally easily, but until all projects have the ci flag we can't enforce it globally. See for example https://gerrit.ovirt.org/#/c/42362/ Patch Set 5: Code-Review+1 Continuous-Integration+1 Verified+1 in a later run seems to have fixed this Patch Set 6: Continuous-Integration+1 ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Re: Jenkins CI granting excessive +1s
I just rolled out the CI flag to all the projects this morning, restricting jenkins to set only that flag, did that happen again after it? On 06/17, Dan Kenigsberg wrote: On Tue, Jun 16, 2015 at 08:48:17PM +0200, dcaro wrote: On 06/16, Eyal Edri wrote: Sounds like a bug. Jenkins should only use the CI flag and not change CR and V flags. Might have been a misunderstanding. David, can you fix it so Jenkins will only update CI flag? Can someone pass me an example of the patch that had the reviews? It's possible that previously the jobs were manually modified to only set the ci flag and we updated them on yaml and the manual changes got reverted. Having a sample patch would allow me to trim down the list of possible jobs that give that review. That can be prevented globally easily, but until all projects have the ci flag we can't enforce it globally. See for example https://gerrit.ovirt.org/#/c/42362/ Patch Set 5: Code-Review+1 Continuous-Integration+1 Verified+1 in a later run seems to have fixed this Patch Set 6: Continuous-Integration+1 -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgpHxDvi58vIn.pgp Description: PGP signature ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Re: Jenkins CI granting excessive +1s
On Wed, Jun 17, 2015 at 03:05:52PM +0200, dcaro wrote: I just rolled out the CI flag to all the projects this morning, restricting jenkins to set only that flag, did that happen again after it? No, all seems clear now. Thanks. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Jenkins CI granting excessive +1s
As of yesterday, Jenkins CI starting granting CR+1, V+1 and CI+1 for every patchset that it successfully passed. Was this change somehow intentional? It is confusing and unwanted. Only a human developer can give a meaningful Code-Review. Only a human user/QE can say that a patch solved the relevant bug and grant it Verfied+1. The flags that Jenkins grant are meaningless. Can this be stopped? Jenkins should give CI+1 if it's happe with a patch, or CI-1 if it is has not yet run (or failed). Regards, Dan. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Re: Jenkins CI granting excessive +1s
Sounds like a bug. Jenkins should only use the CI flag and not change CR and V flags. Might have been a misunderstanding. David, can you fix it so Jenkins will only update CI flag? E. Eyal Edri Supervisor, RHEV CI Red Hat From: Dan Kenigsberg Sent: Jun 16, 2015 7:06 PM To: infra@ovirt.org Cc: ee...@redhat.com; dc...@redhat.com Subject: Jenkins CI granting excessive +1s As of yesterday, Jenkins CI starting granting CR+1, V+1 and CI+1 for every patchset that it successfully passed. Was this change somehow intentional? It is confusing and unwanted. Only a human developer can give a meaningful Code-Review. Only a human user/QE can say that a patch solved the relevant bug and grant it Verfied+1. The flags that Jenkins grant are meaningless. Can this be stopped? Jenkins should give CI+1 if it's happe with a patch, or CI-1 if it is has not yet run (or failed). Regards, Dan. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Re: Jenkins CI granting excessive +1s
On 06/16, Eyal Edri wrote: Sounds like a bug. Jenkins should only use the CI flag and not change CR and V flags. Might have been a misunderstanding. David, can you fix it so Jenkins will only update CI flag? Can someone pass me an example of the patch that had the reviews? It's possible that previously the jobs were manually modified to only set the ci flag and we updated them on yaml and the manual changes got reverted. Having a sample patch would allow me to trim down the list of possible jobs that give that review. That can be prevented globally easily, but until all projects have the ci flag we can't enforce it globally. E. Eyal Edri Supervisor, RHEV CI Red Hat From: Dan Kenigsberg Sent: Jun 16, 2015 7:06 PM To: infra@ovirt.org Cc: ee...@redhat.com; dc...@redhat.com Subject: Jenkins CI granting excessive +1s As of yesterday, Jenkins CI starting granting CR+1, V+1 and CI+1 for every patchset that it successfully passed. Was this change somehow intentional? It is confusing and unwanted. Only a human developer can give a meaningful Code-Review. Only a human user/QE can say that a patch solved the relevant bug and grant it Verfied+1. The flags that Jenkins grant are meaningless. Can this be stopped? Jenkins should give CI+1 if it's happe with a patch, or CI-1 if it is has not yet run (or failed). Regards, Dan. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 pgp80eK7zahH6.pgp Description: PGP signature ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
