Re: Problem with submit of 5982acfcd055, please check
On Thu, Oct 29, 2015 at 05:16:06PM +0100, Anton Marchukov wrote: > Hello Dan. > > As a follow up to our conversation on IRC regarding failure to submit > https://gerrit.ovirt.org/#/c/47035/ > > ssh -p 29418 gerrit.ovirt.org gerrit review --submit 5982acfcd055 > error: rule error: Cannot submit draft patch sets > > $ ssh -p 29418 gerrit.ovirt.org gerrit review --publish 5982acfcd055 > error: Cannot publish this draft patch set > > Looks like I have found what happened. That change looks to be in a draft > state indeed, e.g. it is shown as such under "Patch Sets" menu and it may > be in "ready to submit" state possiblly due to > https://code.google.com/p/gerrit/issues/detail?id=2844 gerrit bug. > > Also there were no "Publish draft" rights set, so you may not see "Publish" > button due to that. Now I have added "publish draft" right to > "vdsm-maintainers" group and you should see Publish button and then would > be able to do publish and submit. > > Please check when you ahve time and let us know if that solved the problem > or not. Thanks Anton. Published and merged this awkward patch. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Problem with submit of 5982acfcd055, please check
Hello Dan. As a follow up to our conversation on IRC regarding failure to submit https://gerrit.ovirt.org/#/c/47035/ ssh -p 29418 gerrit.ovirt.org gerrit review --submit 5982acfcd055 error: rule error: Cannot submit draft patch sets $ ssh -p 29418 gerrit.ovirt.org gerrit review --publish 5982acfcd055 error: Cannot publish this draft patch set Looks like I have found what happened. That change looks to be in a draft state indeed, e.g. it is shown as such under "Patch Sets" menu and it may be in "ready to submit" state possiblly due to https://code.google.com/p/gerrit/issues/detail?id=2844 gerrit bug. Also there were no "Publish draft" rights set, so you may not see "Publish" button due to that. Now I have added "publish draft" right to "vdsm-maintainers" group and you should see Publish button and then would be able to do publish and submit. Please check when you ahve time and let us know if that solved the problem or not. Anton. -- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
