Re: [PATCH] distgit/pagure: Increase the cross-project ACLs

2019-04-02 Thread Stephen John Smoogen 
+1

On Thu, 28 Mar 2019 at 05:59, Pierre-Yves Chibon  wrote:
>
> This just makes pagure accept to generate project-less API tokens
> with these two ACLs.
>
> Signed-off-by: Pierre-Yves Chibon 
> ---
>  roles/distgit/pagure/templates/pagure.cfg | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/roles/distgit/pagure/templates/pagure.cfg 
> b/roles/distgit/pagure/templates/pagure.cfg
> index a66b3278b..385b80464 100644
> --- a/roles/distgit/pagure/templates/pagure.cfg
> +++ b/roles/distgit/pagure/templates/pagure.cfg
> @@ -273,10 +273,8 @@ USER_ACLS = [
>  CROSS_PROJECT_ACLS = [
>  'fork_project',
>  'modify_project',
> -{% if env == 'staging' %}
>  'pull_request_create',
>  'pull_request_comment',
> -{% endif %}
>  ]
>
>  ADMIN_API_ACLS = [
> --
> 2.20.1
> ___
> infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org



-- 
Stephen J Smoogen.
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: [PATCH] distgit/pagure: Increase the cross-project ACLs

2019-03-29 Thread Tomas Tomecek 
On Thu, Mar 28, 2019 at 10:59 AM Pierre-Yves Chibon  wrote:
>
> This just makes pagure accept to generate project-less API tokens
> with these two ACLs.
>
> Signed-off-by: Pierre-Yves Chibon 
> ---
>  roles/distgit/pagure/templates/pagure.cfg | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/roles/distgit/pagure/templates/pagure.cfg 
> b/roles/distgit/pagure/templates/pagure.cfg
> index a66b3278b..385b80464 100644
> --- a/roles/distgit/pagure/templates/pagure.cfg
> +++ b/roles/distgit/pagure/templates/pagure.cfg
> @@ -273,10 +273,8 @@ USER_ACLS = [
>  CROSS_PROJECT_ACLS = [
>  'fork_project',
>  'modify_project',
> -{% if env == 'staging' %}
>  'pull_request_create',
>  'pull_request_comment',
> -{% endif %}
>  ]
>
>  ADMIN_API_ACLS = [
> --
> 2.20.1

+1

To some extent, me and Michal Konecny were able to verify this on stg.

This change is needed for the-new-hotness and packit to enable pull
request workflow in production.
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: [PATCH] distgit/pagure: Increase the cross-project ACLs

2019-03-28 Thread Kevin Fenzi 
On 3/28/19 2:58 AM, Pierre-Yves Chibon wrote:
> This just makes pagure accept to generate project-less API tokens
> with these two ACLs.
> 
> Signed-off-by: Pierre-Yves Chibon 
> ---
>  roles/distgit/pagure/templates/pagure.cfg | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/roles/distgit/pagure/templates/pagure.cfg 
> b/roles/distgit/pagure/templates/pagure.cfg
> index a66b3278b..385b80464 100644
> --- a/roles/distgit/pagure/templates/pagure.cfg
> +++ b/roles/distgit/pagure/templates/pagure.cfg
> @@ -273,10 +273,8 @@ USER_ACLS = [
>  CROSS_PROJECT_ACLS = [
>  'fork_project',
>  'modify_project',
> -{% if env == 'staging' %}
>  'pull_request_create',
>  'pull_request_comment',
> -{% endif %}
>  ]
>  
>  ADMIN_API_ACLS = [

+1 here, sounds like a good thing to have.

kevin





signature.asc
Description: OpenPGP digital signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

[PATCH] distgit/pagure: Increase the cross-project ACLs

2019-03-28 Thread Pierre-Yves Chibon 
This just makes pagure accept to generate project-less API tokens
with these two ACLs.

Signed-off-by: Pierre-Yves Chibon 
---
 roles/distgit/pagure/templates/pagure.cfg | 2 --
 1 file changed, 2 deletions(-)

diff --git a/roles/distgit/pagure/templates/pagure.cfg 
b/roles/distgit/pagure/templates/pagure.cfg
index a66b3278b..385b80464 100644
--- a/roles/distgit/pagure/templates/pagure.cfg
+++ b/roles/distgit/pagure/templates/pagure.cfg
@@ -273,10 +273,8 @@ USER_ACLS = [
 CROSS_PROJECT_ACLS = [
 'fork_project',
 'modify_project',
-{% if env == 'staging' %}
 'pull_request_create',
 'pull_request_comment',
-{% endif %}
 ]
 
 ADMIN_API_ACLS = [
-- 
2.20.1
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org