Re: FBR: Apply MBS PR#1185 to fix Module Stream Expansion with new platform streams
LGTM +1 On Wed, Mar 27, 2019 at 1:29 PM Kevin Fenzi wrote: > +1 > > kevin > > > ___ > infrastructure mailing list -- infrastructure@lists.fedoraproject.org > To unsubscribe send an email to > infrastructure-le...@lists.fedoraproject.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org > ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
Re: FBR: Apply MBS PR#1185 to fix Module Stream Expansion with new platform streams
+1 kevin signature.asc Description: OpenPGP digital signature ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
Re: FBR: Apply MBS PR#1185 to fix Module Stream Expansion with new platform streams
> On Wed, 27 Mar 2019 at 02:02, Jan Kaluža > I don't see this causing a breakage now, but I am wondering if the > test is 'fragile' because once those versions are EOL, then won't it > break because various tools (pdc/bodhi) may return something up the > stack that you can't build against it anyway? I'm not sure we have addressed this issue generally. Grepping the code for "EOL" and similar things only shows that you cannot submit module once it is EOL, but I was not able to find out any code which would prevent you to building module against EOLed module. I will ask Matt Prahl who should know more and create ticket to address that if it's needed. But I think it is not blocker for this FBR. Regards, Jan Kaluza ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
Re: FBR: Apply MBS PR#1185 to fix Module Stream Expansion with new platform streams
On Wed, 27 Mar 2019 at 02:02, Jan Kaluža wrote: > > Hi, > > Mohan filled MBS issue https://pagure.io/fm-orchestrator/issue/1184 and asked > us to fix and deploy that during the freeze to unblock him. I therefore want > to ask for +1 to deploy this small patch (already merged upstream): > https://pagure.io/fm-orchestrator/pull-request/1185#request_diff . > > I think the issue is well described in the PR, unit-test and MBS issue > tracker, so I won't repeat myself here. I hope that's OK. > I don't see this causing a breakage now, but I am wondering if the test is 'fragile' because once those versions are EOL, then won't it break because various tools (pdc/bodhi) may return something up the stack that you can't build against it anyway? > Regards, > Jan Kaluza > ___ > infrastructure mailing list -- infrastructure@lists.fedoraproject.org > To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org -- Stephen J Smoogen. ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
Re: FBR: Apply MBS PR#1185 to fix Module Stream Expansion with new platform streams
+1 On Wed, Mar 27, 2019 at 7:02 AM Jan Kaluža wrote: > > Hi, > > Mohan filled MBS issue https://pagure.io/fm-orchestrator/issue/1184 and asked > us to fix and deploy that during the freeze to unblock him. I therefore want > to ask for +1 to deploy this small patch (already merged upstream): > https://pagure.io/fm-orchestrator/pull-request/1185#request_diff . > > I think the issue is well described in the PR, unit-test and MBS issue > tracker, so I won't repeat myself here. I hope that's OK. > > Regards, > Jan Kaluza > ___ > infrastructure mailing list -- infrastructure@lists.fedoraproject.org > To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
FBR: Apply MBS PR#1185 to fix Module Stream Expansion with new platform streams
Hi, Mohan filled MBS issue https://pagure.io/fm-orchestrator/issue/1184 and asked us to fix and deploy that during the freeze to unblock him. I therefore want to ask for +1 to deploy this small patch (already merged upstream): https://pagure.io/fm-orchestrator/pull-request/1185#request_diff . I think the issue is well described in the PR, unit-test and MBS issue tracker, so I won't repeat myself here. I hope that's OK. Regards, Jan Kaluza ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
