Re: FBR: no CI requirements for modules
On Mon, Apr 23, 2018 at 11:28:19AM +0200, Pierre-Yves Chibon wrote: > Good Morning Everyone, > > I re-wrote last week the script fixing the git hooks in dist-git, but its work > is getting overridden by the old script running in a cron (that Kevin fixed > this > week-end). That's a fail in Subject, let's try again in a new email Sorry for the noise, Pierre signature.asc Description: PGP signature ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Re: FBR: no CI requirements for modules
Good Morning Everyone, I re-wrote last week the script fixing the git hooks in dist-git, but its work is getting overridden by the old script running in a cron (that Kevin fixed this week-end). So I would like to replace the cron running the old script with a cron running the new script: Here is the diff: diff --git a/ roles/gitolite/check_fedmsg_hooks/tasks/main.yml b/ roles/gitolite/check_fedmsg_hooks/tasks/main.yml index d357a7d83..bea193af1 100644 --- a/ roles/gitolite/check_fedmsg_hooks/tasks/main.yml +++ b/ roles/gitolite/check_fedmsg_hooks/tasks/main.yml @@ -8,7 +8,7 @@ minute=10 hour="0,12" user=pagure -job="/usr/local/bin/git-check-perms /srv/git/repositories --check=fedmsg-hook -f" +job="/usr/local/bin/distgit_check_hook.py" tags: - git - gitolite Note, we could make this run more often as it runs in a few minutes (the forks being the slowest namespace, the other namespace run under a minute). Thoughts? Pierre signature.asc Description: PGP signature ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Re: FBR: no CI requirements for modules
Thanks! This is done now: https://greenwave-web-greenwave.app.os.fedoraproject.org/api/v1.0/policies I fixed two other little things while I was in there: - https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/?id=01d70107fca595715931861e80a7e642f9df191b - https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/?id=a0314660d8e09990b3c5f23dc419e83cdaf48358 signature.asc Description: PGP signature ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Re: FBR: no CI requirements for modules
+1 kevin signature.asc Description: OpenPGP digital signature ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Re: FBR: no CI requirements for modules
On Fri, Apr 20, 2018 at 11:03:15AM -0400, Ralph Bean wrote:
> Modules are configure to require some test cases that never actually
> get run for them. This patch should treat them instead like we do
> epel: no CI requirements.
>
> Any +1s?
>
> diff --git a/roles/openshift-apps/greenwave/templates/configmap.yml
> b/roles/openshift-apps/greenwave/templates/configmap.yml
> index 44eb013..c88bb9d 100644
> --- a/roles/openshift-apps/greenwave/templates/configmap.yml
> +++ b/roles/openshift-apps/greenwave/templates/configmap.yml
> @@ -91,7 +91,6 @@ data:
> --- !Policy
> id: "taskotron_release_critical_tasks_for_testing"
> product_versions:
> - - fedora-28-modular
>- fedora-28
>- fedora-27
>- fedora-26
> @@ -103,7 +102,6 @@ data:
> --- !Policy
> id: "taskotron_release_critical_tasks_for_stable"
> product_versions:
> - - fedora-28-modular
>- fedora-28
>- fedora-27
>- fedora-26
> @@ -113,8 +111,9 @@ data:
> rules:
>- !PassingTestCaseRule {test_case_name: dist.rpmdeplint}
> --- !Policy
> -id: "no_requirements_for_epel_testing"
> +id: "no_requirements_testing"
> product_versions:
> + - fedora-28-modular
>- fedora-epel-7
>- fedora-epel-6
> decision_context: bodhi_update_push_testing
> @@ -122,8 +121,9 @@ data:
> relevance_value: koji_build
> rules: []
> --- !Policy
> -id: "no_requirements_for_epel_stable"
> +id: "no_requirements_for_stable"
> product_versions:
> + - fedora-28-modular
>- fedora-epel-7
>- fedora-epel-6
> decision_context: bodhi_update_push_stable
+1 for me
Pierre
signature.asc
Description: PGP signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
FBR: no CI requirements for modules
Discussed in #fedora-admin just now.
Modules are configure to require some test cases that never actually
get run for them. This patch should treat them instead like we do
epel: no CI requirements.
Any +1s?
diff --git a/roles/openshift-apps/greenwave/templates/configmap.yml
b/roles/openshift-apps/greenwave/templates/configmap.yml
index 44eb013..c88bb9d 100644
--- a/roles/openshift-apps/greenwave/templates/configmap.yml
+++ b/roles/openshift-apps/greenwave/templates/configmap.yml
@@ -91,7 +91,6 @@ data:
--- !Policy
id: "taskotron_release_critical_tasks_for_testing"
product_versions:
- - fedora-28-modular
- fedora-28
- fedora-27
- fedora-26
@@ -103,7 +102,6 @@ data:
--- !Policy
id: "taskotron_release_critical_tasks_for_stable"
product_versions:
- - fedora-28-modular
- fedora-28
- fedora-27
- fedora-26
@@ -113,8 +111,9 @@ data:
rules:
- !PassingTestCaseRule {test_case_name: dist.rpmdeplint}
--- !Policy
-id: "no_requirements_for_epel_testing"
+id: "no_requirements_testing"
product_versions:
+ - fedora-28-modular
- fedora-epel-7
- fedora-epel-6
decision_context: bodhi_update_push_testing
@@ -122,8 +121,9 @@ data:
relevance_value: koji_build
rules: []
--- !Policy
-id: "no_requirements_for_epel_stable"
+id: "no_requirements_for_stable"
product_versions:
+ - fedora-28-modular
- fedora-epel-7
- fedora-epel-6
decision_context: bodhi_update_push_stable
signature.asc
Description: PGP signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
