Re: FBR MBS: Fix traceback when reusing components from module build with different buildrequires.
+1 here too. It's easy to revert by downgrading the rpm if it blows up.
On Fri, Apr 20, 2018 at 11:42:33AM +0200, Mikolaj Izdebski wrote:
> +1
>
> On 04/20/2018 08:36 AM, Jan Kaluža wrote:
> > Hi,
> >
> > this is FBR to fix MBS traceback which prevents builds of modules in
> > situation when new build-require is added to a module Foo. Currently, MBS
> > tries to check what was the commit hash ("ref") of such buildrequired
> > module in previous build of Foo, but it fails with KeyError, because the
> > previous Foo module build did not build-required this newly added
> > build-required module.
> >
> > Full traceback is here:
> >
> > Traceback (most recent call last):
> > File
> > "/usr/lib/python2.7/site-packages/module_build_service/scheduler/consumer.py",
> > line 240, in process_message
> > further_work = handler(conf, session, msg) or []
> > File
> > "/usr/lib/python2.7/site-packages/module_build_service/scheduler/handlers/modules.py",
> > line 292, in wait
> > if attempt_to_reuse_all_components(builder, session, build):
> > File
> > "/usr/lib/python2.7/site-packages/module_build_service/utils/reuse.py",
> > line 140, in attempt_to_reuse_all_components
> > previous_module_build = _get_reusable_module(session, module)
> > File
> > "/usr/lib/python2.7/site-packages/module_build_service/utils/reuse.py",
> > line 123, in _get_reusable_module
> > ref2 = old_xmd['mbs']['buildrequires'][br_module_name].get('ref')
> > KeyError: 'platform'
> >
> > Fixed patch [1] addresses this by catching the KeyError in this code block.
> > It has been tested on staging and I verified it fixes this issue.
> >
> > [1]
> > https://src.fedoraproject.org/rpms/module-build-service/c/9d3a4923631efca2f9e7e3baf6b1bf15294d66fd?branch=epel7
> >
> > Regards,
> > Jan Kaluza
> > ___
> > infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> > To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
> >
>
> --
> Mikolaj Izdebski
> Senior Software Engineer, Red Hat
> IRC: mizdebsk
> ___
> infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
signature.asc
Description: PGP signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Re: FBR MBS: Fix traceback when reusing components from module build with different buildrequires.
+1
On 04/20/2018 08:36 AM, Jan Kaluža wrote:
> Hi,
>
> this is FBR to fix MBS traceback which prevents builds of modules in
> situation when new build-require is added to a module Foo. Currently, MBS
> tries to check what was the commit hash ("ref") of such buildrequired module
> in previous build of Foo, but it fails with KeyError, because the previous
> Foo module build did not build-required this newly added build-required
> module.
>
> Full traceback is here:
>
> Traceback (most recent call last):
> File
> "/usr/lib/python2.7/site-packages/module_build_service/scheduler/consumer.py",
> line 240, in process_message
> further_work = handler(conf, session, msg) or []
> File
> "/usr/lib/python2.7/site-packages/module_build_service/scheduler/handlers/modules.py",
> line 292, in wait
> if attempt_to_reuse_all_components(builder, session, build):
> File
> "/usr/lib/python2.7/site-packages/module_build_service/utils/reuse.py", line
> 140, in attempt_to_reuse_all_components
> previous_module_build = _get_reusable_module(session, module)
> File
> "/usr/lib/python2.7/site-packages/module_build_service/utils/reuse.py", line
> 123, in _get_reusable_module
> ref2 = old_xmd['mbs']['buildrequires'][br_module_name].get('ref')
> KeyError: 'platform'
>
> Fixed patch [1] addresses this by catching the KeyError in this code block.
> It has been tested on staging and I verified it fixes this issue.
>
> [1]
> https://src.fedoraproject.org/rpms/module-build-service/c/9d3a4923631efca2f9e7e3baf6b1bf15294d66fd?branch=epel7
>
> Regards,
> Jan Kaluza
> ___
> infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
>
--
Mikolaj Izdebski
Senior Software Engineer, Red Hat
IRC: mizdebsk
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
FBR MBS: Fix traceback when reusing components from module build with different buildrequires.
Hi,
this is FBR to fix MBS traceback which prevents builds of modules in situation
when new build-require is added to a module Foo. Currently, MBS tries to check
what was the commit hash ("ref") of such buildrequired module in previous build
of Foo, but it fails with KeyError, because the previous Foo module build did
not build-required this newly added build-required module.
Full traceback is here:
Traceback (most recent call last):
File
"/usr/lib/python2.7/site-packages/module_build_service/scheduler/consumer.py",
line 240, in process_message
further_work = handler(conf, session, msg) or []
File
"/usr/lib/python2.7/site-packages/module_build_service/scheduler/handlers/modules.py",
line 292, in wait
if attempt_to_reuse_all_components(builder, session, build):
File "/usr/lib/python2.7/site-packages/module_build_service/utils/reuse.py",
line 140, in attempt_to_reuse_all_components
previous_module_build = _get_reusable_module(session, module)
File "/usr/lib/python2.7/site-packages/module_build_service/utils/reuse.py",
line 123, in _get_reusable_module
ref2 = old_xmd['mbs']['buildrequires'][br_module_name].get('ref')
KeyError: 'platform'
Fixed patch [1] addresses this by catching the KeyError in this code block. It
has been tested on staging and I verified it fixes this issue.
[1]
https://src.fedoraproject.org/rpms/module-build-service/c/9d3a4923631efca2f9e7e3baf6b1bf15294d66fd?branch=epel7
Regards,
Jan Kaluza
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
