Re: Upstream for dist-git [RFC]

2015-04-17 Thread Kevin Fenzi
On Thu, 16 Apr 2015 09:42:44 +0200
Miroslav Suchý msu...@redhat.com wrote:

 Hi,
 Adam Šamalík took dist-git files from fedora-infra ansible.git. He
 separated what belongs to dist-git itself and what is Fedora specific
 and with cooperation of Dan Mach and Palo Babinčák he created
 upstream for dist-git:
 
   https://github.com/release-engineering/dist-git
 
 This is first attempt and request for comments.

Great idea/work. ;) 

 The changes from ansible.git version are described here:
   https://github.com/release-engineering/dist-git/blob/master/changes.txt
 and he extracted some code to be configuration driven:
   
 https://github.com/release-engineering/dist-git/blob/master/configs/dist-git/dist-git.conf
 
 Feel free to experiment with this project and we are looking for your
 questions and comments.

Will try and find time to do so. 
 
 I have one question thou:
 There is no license information in files header but two files:
   scripts/httpd/upload.cgi - GPLv1
   scripts/dist-git/pkgdb_sync_git_branches.py - GPLv2+
 Everything else is without license.

All the work in the ansible repo should be covered under the FPCA, so
without any explicit license I would think it would be MIT. We could
see about getting a list of folks who worked on it and getting them to
put it under GPLv2+ if you like. Or we could just stay with MIT?

 Can I assume that we can realease the code under GPLv2+?
 The author of upload.cgi seems to be Kevin F. - Kevin, are you
 willing to change license your file to GPLv2+ so we have uniform
 license across all files?

I did not author that file. ;) 

It was written by Jesse Keating in 2010. We could try and contact him I
suppose?

 
 Future plans:
  1) Listen to your initial feedback and do alternations according to
 your feedback 2) After license clarification, announce this project
 to Red Hat and CentOS rel-engs and ask them to merge their changes of
 dist-git to this upstream. 3) Get this package into Fedora
 distribution 4) Change Fedora dist-git server to use this package.
 
  10) Enjoy the benefits of common upstream.

:) Excellent. 

kevin
 



pgpGN4fV_7tN9.pgp
Description: OpenPGP digital signature
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure

Re: Upstream for dist-git [RFC]

2015-04-17 Thread Miroslav Suchy
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 04/17/2015 05:01 PM, Kevin Fenzi wrote:
 All the work in the ansible repo should be covered under the FPCA,
 so without any explicit license I would think it would be MIT. We
 could see about getting a list of folks who worked on it and
 getting them to put it under GPLv2+ if you like. Or we could just
 stay with MIT?

Any free license is fine. MIT is fine as well.

Mirek
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBAgAGBQJVMSRLAAoJEODXORnxaDVAukUQAJfYWLHFfmovo/2j5E/JrQlh
e63jCBKlClIreHtfDJIDYUvbVX4/eBr1tv9HkNIHpG0G/4hesUmauIIDlG/wLlRH
im4qLZSLe2jK1+arQCLf2TeiFm7OCNZ6idb0+5Hn83OTySquVsUq9upARGJ6CZ5x
4iYLf8o7lDgAG8H30O10tOTa+njDNJ+iPU70t5xG2eUbhi6LYwkMFeNS1+go12YS
Fr7dud7lwoMnf9vmDo7sxvUS3zziglAs/b6WmoYceiyCxOEEkGKlvS8l99qB8/eg
sPhs2Si8NHp/fG4Rcj5HgXEi+t8b5xtIQb067LdeeG8ZxEE8emzh1QDNSglLBtcr
0yqRI9Y76LOWb30msXMYUWWNGrvAdCL4ON8027gbD53VOZw3HEhpk3TG2HEhLhyR
lDWh/5Qrmx/PXBnt42U6UXQAo2CjUHnlie1L6ihlPLRgDcC9bEJKS/2GeJCm/ZHp
QVopJWOlkCl0zbTM9KZWXI4oQaVUvIAq/KsTtjXeBu48fjjlbGuMqHS5Q1pw+C7v
VmxXgBUhFnmtk+clLph6xG5V79T0Arf6+GV0Ow4GgUNYaYL2vjagzIhy6Pn0dYer
42hfTbquyUmzNCBvjuJzGFZdBbtgT/z/ZtALeQnNkH51ayqKwfWB2YmN4A+FhIJ6
7asVU8BKjeS3GJ6NGRsz
=Ty9E
-END PGP SIGNATURE-
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure

Re: Upstream for dist-git [RFC]

2015-04-17 Thread Pierre-Yves Chibon
On Thu, Apr 16, 2015 at 09:42:44AM +0200, Miroslav Suchý wrote:
 Hi,
 Adam Šamalík took dist-git files from fedora-infra ansible.git. He separated 
 what belongs to dist-git itself and what is
 Fedora specific and with cooperation of Dan Mach and Palo Babinčák he created 
 upstream for dist-git:
 
   https://github.com/release-engineering/dist-git
 
 This is first attempt and request for comments.
 
 The changes from ansible.git version are described here:
   https://github.com/release-engineering/dist-git/blob/master/changes.txt
 and he extracted some code to be configuration driven:
   
 https://github.com/release-engineering/dist-git/blob/master/configs/dist-git/dist-git.conf
 
 Feel free to experiment with this project and we are looking for your 
 questions and comments.
 
 
 I have one question thou:
 There is no license information in files header but two files:
   scripts/httpd/upload.cgi - GPLv1

Unless I am mistaken, the file says just GPL without specifying a version, which
according to our wiki page [1] means:

GNU General Public License (no version)
A GPL or LGPL licensed package that lacks any statement of what version that
it's licensed under in the source code/program output/accompanying docs is
technically licensed under *any* version of the GPL or LGPL, not just the
version in whatever COPYING file they include. 

So seems to me that this is not a problem :)

[1] https://fedoraproject.org/wiki/Licensing:Main


I do have a few questions about the project itself though :)

- Any special reason to use tito? It seems the spec file generated isn't quite
  complete (cf the %description) and I have heard a couple of horror story about
  it so I am kinda curious to know what it brings.

- While I find having a single upstream place a great idea I wonder how this
  will do in practice. For example, I know Fedora has been wanted to move away
  from md5 into sha for a while. How will this work then for the other
  instances? Are RH and CentOS also going to make the move? At the same time as
  Fedora?
  Basically, I was wondering between sharing a RPM vs sharing an ansible
  playbook which one might be easier in the long term.

- Out of curiosity, would the dist-git systemd service conflict with the
  git-daemon one?

- The two cron files are empty is this desired?

- Finally, recently I was wondering about changing the upload.cgi which is a
  little bit painful to debug when something goes south by a simple one-file
  flask application that would do the same.
  Anyone has any thoughts on this idea?

Turned out I found more questions that I thought, hope you don't mind :)


Thanks,
Pierre
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure

Re: Upstream for dist-git [RFC]

2015-04-17 Thread Mathieu Bridon
On Fri, 2015-04-17 at 17:18 +0200, Pierre-Yves Chibon wrote:
 - Finally, recently I was wondering about changing the upload.cgi which is a
   little bit painful to debug when something goes south by a simple one-file
   flask application that would do the same.
   Anyone has any thoughts on this idea?

I've been thinking about this exact same point for about 3 years, ever
since I deployed that upload.cgi script into my infrastructure at
$previous_dayjob.

As a coincidence, I've spent most of today reworking the way pyrpkg
interacts with the lookaside cache, the end goal being to move away from
md5.

And with the thought of replacing that upload.cgi script in the back of
my head, I've made sure to make the code modular enough that we could
just add a new class to talk to a hypothetical Flask app you'd write in
the future.

I'm nowhere near ready to send those patches though (I'll probably need
a few more days to finish implementing it and test it properly), but be
sure that replacing upload.cgi should eventually become much easier, at
least from the pyrpkg side. :)


-- 
Mathieu

___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure

Upstream for dist-git [RFC]

2015-04-16 Thread Miroslav Suchý
Hi,
Adam Šamalík took dist-git files from fedora-infra ansible.git. He separated 
what belongs to dist-git itself and what is
Fedora specific and with cooperation of Dan Mach and Palo Babinčák he created 
upstream for dist-git:

  https://github.com/release-engineering/dist-git

This is first attempt and request for comments.

The changes from ansible.git version are described here:
  https://github.com/release-engineering/dist-git/blob/master/changes.txt
and he extracted some code to be configuration driven:
  
https://github.com/release-engineering/dist-git/blob/master/configs/dist-git/dist-git.conf

Feel free to experiment with this project and we are looking for your questions 
and comments.


I have one question thou:
There is no license information in files header but two files:
  scripts/httpd/upload.cgi - GPLv1
  scripts/dist-git/pkgdb_sync_git_branches.py - GPLv2+
Everything else is without license.
Can I assume that we can realease the code under GPLv2+?
The author of upload.cgi seems to be Kevin F. - Kevin, are you willing to 
change license your file to GPLv2+ so we have
uniform license across all files?

Future plans:
 1) Listen to your initial feedback and do alternations according to your 
feedback
 2) After license clarification, announce this project to Red Hat and CentOS 
rel-engs and ask them to merge their
changes of dist-git to this upstream.
 3) Get this package into Fedora distribution
 4) Change Fedora dist-git server to use this package.

 10) Enjoy the benefits of common upstream.

-- 
Miroslav Suchy, RHCA
Red Hat, Senior Software Engineer, #brno, #devexp, #fedora-buildsys
___
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure