Re: [Intel-gfx] [PATCH v3] drm/i915: start adding dp mst audio
Hi Jani,
Thanks for review. I will split this patch.
Regards,
Libin
> -Original Message-
> From: Jani Nikula [mailto:jani.nik...@linux.intel.com]
> Sent: Friday, November 25, 2016 10:23 PM
> To: Yang, Libin ; intel-gfx@lists.freedesktop.org;
> ville.syrj...@linux.intel.com; Vetter, Daniel ;
> ti...@suse.de
> Cc: Yang, Libin ; Libin Yang
> ; Pandiyan, Dhinakaran
> ; Vivi, Rodrigo
> Subject: Re: [PATCH v3] drm/i915: start adding dp mst audio
>
> On Mon, 14 Nov 2016, libin.y...@intel.com wrote:
> > From: Libin Yang
> >
> > (This patch is developed by Dave Airlie
> > originally)
> >
> > This patch adds support for DP MST audio in i915.
> >
> > Enable audio codec when DP MST is enabled if has_audio flag is set.
> > Disable audio codec when DP MST is disabled if has_audio flag is set.
> >
> > Another separated patches to support DP MST audio will be implemented
> > in audio driver.
> >
> > v2:
> > Rebased.
> > v3:
> > refine to support updated intel_audio_codec_enable()
>
> I view this patch different from usual because this regressed and was
> reverted before. Please split this up to three patches:
>
> 1) Do intel_dp_mst_info() in i915_debugfs.c. The information printed
>looks at the sink, not pipe config, so this is not dependent on the
>rest.
>
> 2) Abstract intel_ddi_is_audio_enabled(). It's a nice clean
>non-functional change.
>
> 3) The rest. The last patch *must* reference the original commit and the
>revert:
>
>3708d5e082c3 ("drm/i915: start adding dp mst audio")
>be754b101f70 ("Revert "drm/i915: start adding dp mst audio"")
>
>Please rename the patch title to something like, "enable dp mst
>audio" to distinguish.
>
> If the split had been done originally, we would only have reverted part 3, not
> all of it. Please do it now.
>
> More comments inline.
>
> >
> > Signed-off-by: Libin Yang
> > Signed-off-by: Dhinakaran Pandiyan
> > Reviewed-by: Lyude
> > Signed-off-by: Rodrigo Vivi
> > Link:
> > http://patchwork.freedesktop.org/patch/msgid/1474334681-22690-6-git-se
> > nd-email-dhinakaran.pandi...@intel.com
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 19 ++-
> > drivers/gpu/drm/i915/intel_ddi.c| 20 +++-
> > drivers/gpu/drm/i915/intel_dp_mst.c | 18 ++
> > drivers/gpu/drm/i915/intel_drv.h| 2 ++
> > 4 files changed, 53 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> > b/drivers/gpu/drm/i915/i915_debugfs.c
> > index bce3880..3442381 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -2893,6 +2893,20 @@ static void intel_dp_info(struct seq_file *m,
> > &intel_dp->aux);
> > }
> >
> > +static void intel_dp_mst_info(struct seq_file *m,
> > + struct intel_connector *intel_connector) {
> > + struct intel_encoder *intel_encoder = intel_connector->encoder;
> > + struct intel_dp_mst_encoder *intel_mst =
> > + enc_to_mst(&intel_encoder->base);
> > + struct intel_digital_port *intel_dig_port = intel_mst->primary;
> > + struct intel_dp *intel_dp = &intel_dig_port->dp;
> > + bool has_audio = drm_dp_mst_port_has_audio(&intel_dp->mst_mgr,
> > + intel_connector->port);
> > +
> > + seq_printf(m, "\taudio support: %s\n", yesno(has_audio)); }
> > +
> > static void intel_hdmi_info(struct seq_file *m,
> > struct intel_connector *intel_connector) { @@ -
> 2935,7
> > +2949,10 @@ static void intel_connector_info(struct seq_file *m,
> > switch (connector->connector_type) {
> > case DRM_MODE_CONNECTOR_DisplayPort:
> > case DRM_MODE_CONNECTOR_eDP:
> > - intel_dp_info(m, intel_connector);
> > + if (intel_encoder->type == INTEL_OUTPUT_DP_MST)
> > + intel_dp_mst_info(m, intel_connector);
> > + else
> > + intel_dp_info(m, intel_connector);
>
> The above two hunks make up patch 1/3.
>
> > break;
> > case DRM_MODE_CONNECTOR_LVDS:
> > if (intel_encoder->type == INTEL_OUTPUT_LVDS) diff --git
> > a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > index 0ad4e16..b1e3442 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -1951,6 +1951,19 @@ void intel_ddi_prepare_link_retrain(struct
> intel_dp *intel_dp)
> > udelay(600);
> > }
> >
> > +bool intel_ddi_is_audio_enabled(struct drm_i915_private *dev_priv,
> > +struct intel_crtc *intel_crtc)
> > +{
> > + u32 temp;
> > +
> > + if (intel_display_power_is_enabled(dev_priv,
> POWER_DOMAIN_AUDIO)) {
> > + temp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD);
> > + if (temp & AUDIO_OUTPUT_ENABLE(intel_crtc->pipe))
> > + return true;
> > + }
> > + return false;
> > +}
> > +
> > void intel_ddi_get_config(struct intel_enc
Re: [Intel-gfx] [PATCH i-g-t 1/4 v4] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to lib/igt_aux, lib/igt_kmod.
On Fri, Oct 28, 2016 at 12:31:26PM +0300, Marius Vlad wrote: > diff --git a/lib/Makefile.am b/lib/Makefile.am > index 4c0893d..e1737bd 100644 > --- a/lib/Makefile.am > +++ b/lib/Makefile.am > @@ -34,6 +34,8 @@ AM_CFLAGS += $(CAIRO_CFLAGS) Missed adding the CFLAGS for KMOD and PROCPS. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] Fwd: 4.8.x : [drm:ffffffffa0454792] *ERROR* failed to update link training
Whilst 4.7.10 is fine, the current 4.8.10 kernel spews that message in dmesg during boot and later can't be undocked any longer - the vt7 display then will stay black forever. Switching to another vt works fine FWIW. Update: attached dmesg -- Toralf PGP: C4EACDDE 0076E94E Linux version 4.8.10-hardened (root@t44) (gcc version 4.9.3 (Gentoo Hardened 4.9.3 p1.5, pie-0.6.4) ) #1 SMP Fri Nov 25 00:19:25 CET 2016 Command line: BOOT_IMAGE=/boot/vmlinuz-4.8.10-hardened root=/dev/sda3 ro pax_size_overflow_report_only no_console_suspend x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers' x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers' x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers' x86/fpu: xstate_offset[2]: 576, xstate_sizes[2]: 256 x86/fpu: Enabled xstate features 0x7, context size is 832 bytes, using 'standard' format. x86/fpu: Using 'eager' FPU context switches. e820: BIOS-provided physical RAM map: BIOS-e820: [mem 0x-0x0009cfff] usable BIOS-e820: [mem 0x0009d000-0x0009] reserved BIOS-e820: [mem 0x000e-0x000f] reserved BIOS-e820: [mem 0x0010-0xaf70afff] usable BIOS-e820: [mem 0xaf70b000-0xbcc0efff] reserved BIOS-e820: [mem 0xbcc0f000-0xbce7efff] ACPI NVS BIOS-e820: [mem 0xbce7f000-0xbcefefff] ACPI data BIOS-e820: [mem 0xbceff000-0xbf9f] reserved BIOS-e820: [mem 0xf800-0xfbff] reserved BIOS-e820: [mem 0xfe101000-0xfe112fff] reserved BIOS-e820: [mem 0xfec0-0xfec00fff] reserved BIOS-e820: [mem 0xfed08000-0xfed08fff] reserved BIOS-e820: [mem 0xfed1-0xfed19fff] reserved BIOS-e820: [mem 0xfed1c000-0xfed1] reserved BIOS-e820: [mem 0xfee0-0xfee00fff] reserved BIOS-e820: [mem 0xffc0-0x] reserved BIOS-e820: [mem 0x0001-0x00033e5f] usable NX (Execute Disable) protection: active SMBIOS 2.7 present. DMI: LENOVO 20AQCTO1WW/20AQCTO1WW, BIOS GJET91WW (2.41 ) 09/21/2016 e820: update [mem 0x-0x0fff] usable ==> reserved e820: remove [mem 0x000a-0x000f] usable e820: last_pfn = 0x33e600 max_arch_pfn = 0x4 MTRR default type: write-back MTRR fixed ranges enabled: 0-9 write-back A-B uncachable C-F write-protect MTRR variable ranges enabled: 0 base 00C000 mask 7FC000 uncachable 1 base 00BE00 mask 7FFE00 uncachable 2 base 00BD00 mask 7FFF00 uncachable 3 base 00BCF0 mask 70 uncachable 4 disabled 5 disabled 6 disabled 7 disabled 8 disabled 9 disabled x86/PAT: Configuration [0-7]: WB WC UC- UC WB WC UC- WT e820: last_pfn = 0xaf70b max_arch_pfn = 0x4 found SMP MP-table at [mem 0x000f0100-0x000f010f] mapped at [880f0100] Scanning 1 areas for low memory corruption Base memory trampoline at [88097000] 97000 size 24576 Using GB pages for direct mapping BRK [0x0216c000, 0x0216cfff] PGTABLE ACPI: Early table checksum verification disabled ACPI: RSDP 0x000F0120 24 (v02 LENOVO) ACPI: XSDT 0xBCEFE170 E4 (v01 LENOVO TP-GJ2410 PTEC 0002) ACPI: FACP 0xBCEF9000 00010C (v05 LENOVO TP-GJ2410 PTEC 0002) ACPI: DSDT 0xBCEE3000 010FAD (v01 LENOVO TP-GJ2410 INTL 20120711) ACPI: FACS 0xBCD7A000 40 ACPI: DBGP 0xBCEFC000 34 (v01 LENOVO TP-GJ2410 PTEC 0002) ACPI: ECDT 0xBCEFB000 52 (v01 LENOVO TP-GJ2410 PTEC 0002) ACPI: HPET 0xBCEF8000 38 (v01 LENOVO TP-GJ2410 PTEC 0002) ACPI: APIC 0xBCEF7000 98 (v01 LENOVO TP-GJ2410 PTEC 0002) ACPI: MCFG 0xBCEF6000 3C (v01 LENOVO TP-GJ2410 PTEC 0002) ACPI: SSDT 0xBCEF5000 33 (v01 LENOVO TP-SSDT1 0100 INTL 20120711) ACPI: SSDT 0xBCEF4000 000486 (v01 LENOVO TP-SSDT2 0200 INTL 20120711) ACPI: SSDT 0xBCEE2000 0009CB (v01 LENOVO SataAhci 1000 INTL 20120711) ACPI: SSDT 0xBCEE1000 000152 (v01 LENOVO Rmv_Batt 1000 INTL 20120711) ACPI: SSDT 0xBCEE 0007F5 (v01 LENOVO Cpu0Ist 3000 INTL 20120711) ACPI: SSDT 0xBCEDF000 000AD8 (v01 LENOVO CpuPm3000 INTL 20120711) ACPI: SSDT 0xBCEDD000 00125C (v01 LENOVO SaSsdt 3000 INTL 20120711) ACPI: SSDT 0xBCEDC000 000379 (v01 LENOVO CppcTabl 1000 INTL 20120711) ACPI: PCCT 0xBCEDB000 6E (v05 LENOVO TP-GJ2410 PTEC 0002) ACPI: SSDT 0xBCEDA000 000AC4 (v01 LENOVO Cpc_Tabl 1000 INTL 20120711) ACPI: TCPA 0xBCED9000 32 (v02 PTLLENOVO 0604 LNVO 0001) ACPI: UEFI 0xBCED8000 42 (v01 LENOVO TP-GJ2410 PTEC 0002) ACPI: MSDM 0xBCCE2000 55 (v03 LENOVO TP-GJ2410 PTEC 00
[Intel-gfx] 4.8.x : [drm:ffffffffa0454792] *ERROR* failed to update link training
Whilst 4.7.10 is fine, the current 4.8.10 kernel spews that message in dmesg during boot and later can't be undocked any longer - the vt7 display then will stay black forever. Switching to another vt works fine FWIW. -- Toralf PGP: C4EACDDE 0076E94E ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
