Re: [Intel-gfx] [PATCH v2 20/34] xen: convert put_page() to put_user_page*()
On 05.08.19 00:49, john.hubb...@gmail.com wrote:
From: John Hubbard
For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().
This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").
This also handles pages[i] == NULL cases, thanks to an approach
that is actually written by Juergen Gross.
Signed-off-by: Juergen Gross
Signed-off-by: John Hubbard
Cc: Boris Ostrovsky
Cc: xen-de...@lists.xenproject.org
---
Hi Juergen,
Say, this is *exactly* what you proposed in your gup.patch, so
I've speculatively added your Signed-off-by above, but need your
approval before that's final. Let me know please...
Yes, that's fine with me.
Juergen
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] Linux Kernel 5.1.21 (i915)
On 8/4/19 8:11 PM, Nathaniel Russell wrote: > I'm getting an error message when the uvcvideo module is loaded into > the kernel. Can somebody help me figure this out please? > Looks more like it is related to i915 driver: [ 18.728238] [ cut here ] [ 18.728248] timed out waiting for port C ready: got 0x20, expected 0xe0 [ 18.728705] WARNING: CPU: 1 PID: 239 at drivers/gpu/drm/i915/intel_display.c:1614 vlv_wait_port_ready+0x8d/0xd0 [i915] [ 18.728708] Modules linked in: uvcvideo videobuf2_vmalloc videobuf2_memops rtsx_usb videobuf2_v4l2 videodev videobuf2_common btusb btrtl btbcm btintel bluetooth ecdh_generic joydev intel_xhci_usb_role_switch wmi_bmof dell_wmi roles sparse_keymap iwlmvm mac80211 dell_smm_hwmon dell_laptop ledtrig_audio dell_smbios dell_wmi_descriptor dcdbas coretemp hwmon iwlwifi intel_rapl cfg80211 intel_powerclamp kvm_intel psmouse kvm i915 irqbypass evdev crct10dif_pclmul crc32_pclmul crc32c_intel serio_raw cec ghash_clmulni_intel intel_cstate rc_core drm_kms_helper snd_hda_intel tpm_crb tpm_tis ac drm intel_gtt tpm_tis_core snd_hda_codec battery agpgart i2c_algo_bit snd_hda_core wmi fb_sys_fops snd_hwdep snd_pcm syscopyarea fan thermal sdhci_pci snd_timer sysfillrect snd dell_rbtn sysimgblt mei_txe cqhci sdhci tpm i2c_hid hid mei video mmc_core processor_thermal_device rfkill int340x_thermal_zone int3400_thermal intel_soc_dts_iosf acpi_thermal_rel soundcore i2c_i801 xhci_pci button xhci_hcd [ 18.728876] pinctrl_cherryview i2c_core lpc_ich pcc_cpufreq loop [ 18.728897] CPU: 1 PID: 239 Comm: kworker/u4:3 Not tainted 5.1.21 #3 [ 18.728901] Hardware name: Dell Inc. Inspiron 15-3552/001T3K, BIOS 4.2.0 10/27/2017 [ 18.728916] Workqueue: events_unbound async_run_entry_fn [ 18.729188] RIP: 0010:vlv_wait_port_ready+0x8d/0xd0 [i915] Full dmesg is reattached. -- ~Randy [0.00] Linux version 5.1.21 (r...@dad.example.net) (gcc version 9.1.0 (GCC)) #3 SMP Sun Aug 4 14:54:49 CDT 2019 [0.00] Command line: BOOT_IMAGE=/bzImage root=/dev/sda1 ro vga = normal psmouse.synaptics_intertouch=1 [0.00] x86/fpu: x87 FPU will use FXSAVE [0.00] BIOS-provided physical RAM map: [0.00] BIOS-e820: [mem 0x-0x0009d7ff] usable [0.00] BIOS-e820: [mem 0x0009d800-0x0009] reserved [0.00] BIOS-e820: [mem 0x000e-0x000f] reserved [0.00] BIOS-e820: [mem 0x0010-0x3fff] usable [0.00] BIOS-e820: [mem 0x4000-0x401f] reserved [0.00] BIOS-e820: [mem 0x4020-0x7a7e8fff] usable [0.00] BIOS-e820: [mem 0x7a7e9000-0x7a86afff] reserved [0.00] BIOS-e820: [mem 0x7a86b000-0x7a87cfff] ACPI data [0.00] BIOS-e820: [mem 0x7a87d000-0x7b5abfff] ACPI NVS [0.00] BIOS-e820: [mem 0x7b5ac000-0x7ba3bfff] reserved [0.00] BIOS-e820: [mem 0x7ba3c000-0x7bc07fff] usable [0.00] BIOS-e820: [mem 0x7bc08000-0x7bfc4fff] reserved [0.00] BIOS-e820: [mem 0x7bfc5000-0x7bff] usable [0.00] BIOS-e820: [mem 0xe00f8000-0xe00f8fff] reserved [0.00] BIOS-e820: [mem 0xfed01000-0xfed01fff] reserved [0.00] BIOS-e820: [mem 0xfed08000-0xfed08fff] reserved [0.00] BIOS-e820: [mem 0xff98-0x] reserved [0.00] BIOS-e820: [mem 0x0001-0x00017fff] usable [0.00] NX (Execute Disable) protection: active [0.00] SMBIOS 2.8 present. [0.00] DMI: Dell Inc. Inspiron 15-3552/001T3K, BIOS 4.2.0 10/27/2017 [0.00] tsc: Detected 1600.000 MHz processor [0.003345] e820: update [mem 0x-0x0fff] usable ==> reserved [0.003349] e820: remove [mem 0x000a-0x000f] usable [0.003363] last_pfn = 0x18 max_arch_pfn = 0x4 [0.003370] MTRR default type: uncachable [0.003372] MTRR fixed ranges enabled: [0.003374] 0-9 write-back [0.003376] A-B uncachable [0.003378] C-F write-protect [0.003379] MTRR variable ranges enabled: [0.003382] 0 base 0 mask F8000 write-back [0.003384] 1 base 07C80 mask FFF80 uncachable [0.003387] 2 base 07D00 mask FFF00 uncachable [0.003389] 3 base 07E00 mask FFE00 uncachable [0.003391] 4 base 1 mask F8000 write-back [0.003392] 5 disabled [0.003393] 6 disabled [0.003394] 7 disabled [0.003668] x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT [0.003912] e820: update [mem 0x7c80-0x] usable ==> reserved [0.003923] last_pfn = 0x7c000 max_arch_pfn = 0x4 [0.010562] found SMP MP-table at [mem 0x000fdad0-0x000fdadf] [0.011124] BRK [0x160601000, 0x160601fff]
Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Don't fail on HuC early init errors
On Sun, 04 Aug 2019 22:18:51 +0200, Patchwork wrote: == Series Details == Series: Don't fail on HuC early init errors URL : https://patchwork.freedesktop.org/series/64668/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6624 -> Patchwork_13866 Summary --- **FAILURE** Serious unknown changes coming with Patchwork_13866 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_13866, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/ Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_13866: ### IGT changes ### Possible regressions * igt@runner@aborted: - fi-cml-u2: NOTRUN -> [FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/fi-cml-u2/igt@run...@aborted.html hmm, looks unrelated (this CML is not using guc/huc at all) <7>[9.344398] [drm:intel_uc_init_early [i915]] enable_guc=0 (guc:no submission:no huc:no) ... <4>[ 486.270801] [ cut here ] <4>[ 486.270843] list_add corruption. prev->next should be next (8883c0fe17d8), but was 8883cb29c5a8. (prev=8883cb29c5a8). ... <4>[ 486.270889] Call Trace: <4>[ 486.270945] __i915_request_commit+0x35c/0x6a0 [i915] <4>[ 486.270991] ? __i915_request_create+0x22c/0x4d0 [i915] <4>[ 486.271030] __engine_park+0x64/0x200 [i915] <4>[ 486.271067] __intel_wakeref_put_last+0x14/0x60 [i915] <4>[ 486.271104] __igt_reset_engine+0x2be/0x490 [i915] <4>[ 486.27] ? __trace_bprintk+0x57/0x80 <4>[ 486.271160] __i915_subtests+0xb8/0x210 [i915] <4>[ 486.271205] ? __i915_live_teardown+0x70/0x70 [i915] <4>[ 486.271248] ? __intel_gt_live_setup+0x10/0x10 [i915] <4>[ 486.271287] intel_hangcheck_live_selftests+0xa5/0x100 [i915] <4>[ 486.271332] __run_selftests+0x112/0x170 [i915] <4>[ 486.271376] i915_live_selftests+0x2c/0x60 [i915] <4>[ 486.271410] i915_pci_probe+0x93/0x1b0 [i915] <4>[ 486.271414] ? _raw_spin_unlock_irqrestore+0x39/0x60 <4>[ 486.271419] pci_device_probe+0x9e/0x120 <4>[ 486.271423] really_probe+0xea/0x3d0 <4>[ 486.271426] driver_probe_device+0x10b/0x120 <4>[ 486.271429] device_driver_attach+0x4a/0x50 <4>[ 486.271431] __driver_attach+0x97/0x130 <4>[ 486.271434] ? device_driver_attach+0x50/0x50 <4>[ 486.271436] bus_for_each_dev+0x74/0xc0 <4>[ 486.271440] bus_add_driver+0x13f/0x210 <4>[ 486.271442] ? 0xa0822000 <4>[ 486.271444] driver_register+0x56/0xe0 <4>[ 486.271446] ? 0xa0822000 <4>[ 486.271449] do_one_initcall+0x58/0x300 <4>[ 486.271452] ? do_init_module+0x1d/0x1f6 <4>[ 486.271455] ? rcu_read_lock_sched_held+0x6f/0x80 <4>[ 486.271458] ? kmem_cache_alloc_trace+0x2d1/0x300 <4>[ 486.271462] do_init_module+0x56/0x1f6 <4>[ 486.271465] load_module+0x25bd/0x2a40 <4>[ 486.271477] ? __se_sys_finit_module+0xd3/0xf0 <4>[ 486.271479] __se_sys_finit_module+0xd3/0xf0 <4>[ 486.271487] do_syscall_64+0x55/0x1c0 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915: Teach execbuffer to take the engine wakeref not GT
== Series Details == Series: series starting with [CI,1/2] drm/i915: Teach execbuffer to take the engine wakeref not GT URL : https://patchwork.freedesktop.org/series/64665/ State : success == Summary == CI Bug Log - changes from CI_DRM_6623_full -> Patchwork_13865_full Summary --- **SUCCESS** No regressions found. Known issues Here are the changes found in Patchwork_13865_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_eio@reset-stress: - shard-skl: [PASS][1] -> [FAIL][2] ([fdo#109661]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/shard-skl10/igt@gem_...@reset-stress.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/shard-skl3/igt@gem_...@reset-stress.html * igt@gem_persistent_relocs@forked-thrash-inactive: - shard-iclb: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/shard-iclb1/igt@gem_persistent_rel...@forked-thrash-inactive.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/shard-iclb7/igt@gem_persistent_rel...@forked-thrash-inactive.html * igt@i915_suspend@debugfs-reader: - shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/shard-apl2/igt@i915_susp...@debugfs-reader.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/shard-apl2/igt@i915_susp...@debugfs-reader.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-skl: [PASS][7] -> [INCOMPLETE][8] ([fdo#110741]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/shard-skl9/igt@kms_cursor_...@pipe-a-cursor-suspend.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/shard-skl5/igt@kms_cursor_...@pipe-a-cursor-suspend.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [PASS][9] -> [FAIL][10] ([fdo#102670]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/shard-skl9/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/shard-skl1/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][11] -> [FAIL][12] ([fdo#105363]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/shard-skl5/igt@kms_f...@flip-vs-expired-vblank-interruptible.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/shard-skl2/igt@kms_f...@flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt: - shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/shard-iclb2/igt@kms_frontbuffer_track...@fbc-1p-primscrn-indfb-msflip-blt.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/shard-iclb2/igt@kms_frontbuffer_track...@fbc-1p-primscrn-indfb-msflip-blt.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc: - shard-hsw: [PASS][15] -> [SKIP][16] ([fdo#109271]) +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/shard-hsw5/igt@kms_frontbuffer_track...@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/shard-hsw6/igt@kms_frontbuffer_track...@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt: - shard-skl: [PASS][17] -> [FAIL][18] ([fdo#103167]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/shard-skl10/igt@kms_frontbuffer_track...@psr-1p-primscrn-shrfb-plflip-blt.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/shard-skl3/igt@kms_frontbuffer_track...@psr-1p-primscrn-shrfb-plflip-blt.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/shard-skl10/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/shard-skl3/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html * igt@kms_psr@psr2_sprite_blt: - shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +2 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/shard-iclb4/igt@kms_psr@psr2_sprite_blt.html Possible fixes * igt@gem_exec_suspend@basic-s3: - shard-skl: [INCOMPLETE][23] ([fdo#104108]) -> [PASS][24] [23]:
[Intel-gfx] ✗ Fi.CI.BAT: failure for Don't fail on HuC early init errors
== Series Details == Series: Don't fail on HuC early init errors URL : https://patchwork.freedesktop.org/series/64668/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6624 -> Patchwork_13866 Summary --- **FAILURE** Serious unknown changes coming with Patchwork_13866 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_13866, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/ Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_13866: ### IGT changes ### Possible regressions * igt@runner@aborted: - fi-cml-u2: NOTRUN -> [FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/fi-cml-u2/igt@run...@aborted.html Known issues Here are the changes found in Patchwork_13866 that come from known issues: ### IGT changes ### Issues hit * igt@i915_selftest@live_hangcheck: - fi-cml-u2: [PASS][2] -> [INCOMPLETE][3] ([fdo#110566]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6624/fi-cml-u2/igt@i915_selftest@live_hangcheck.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/fi-cml-u2/igt@i915_selftest@live_hangcheck.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [PASS][4] -> [FAIL][5] ([fdo#109485]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6624/fi-kbl-7500u/igt@kms_chamel...@hdmi-hpd-fast.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/fi-kbl-7500u/igt@kms_chamel...@hdmi-hpd-fast.html Possible fixes * igt@i915_module_load@reload: - fi-blb-e6850: [INCOMPLETE][6] ([fdo#107718]) -> [PASS][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6624/fi-blb-e6850/igt@i915_module_l...@reload.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/fi-blb-e6850/igt@i915_module_l...@reload.html * igt@i915_selftest@live_execlists: - fi-skl-gvtdvm: [DMESG-FAIL][8] ([fdo#08]) -> [PASS][9] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6624/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-icl-u2: [FAIL][10] ([fdo#109483]) -> [PASS][11] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6624/fi-icl-u2/igt@kms_chamel...@hdmi-hpd-fast.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/fi-icl-u2/igt@kms_chamel...@hdmi-hpd-fast.html * igt@kms_frontbuffer_tracking@basic: - fi-icl-u2: [FAIL][12] ([fdo#103167]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6624/fi-icl-u2/igt@kms_frontbuffer_track...@basic.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/fi-icl-u2/igt@kms_frontbuffer_track...@basic.html [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483 [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485 [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566 [fdo#08]: https://bugs.freedesktop.org/show_bug.cgi?id=08 Participating hosts (55 -> 45) -- Missing(10): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-icl-y fi-byt-clapper fi-bdw-samus Build changes - * CI: CI-20190529 -> None * Linux: CI_DRM_6624 -> Patchwork_13866 CI-20190529: 20190529 CI_DRM_6624: 2bb7df95d4e058e61d9de39f1b97404592708d24 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5120: b3138fbea79d5d7935e53530b90efe3e816236f4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13866: 24721ffd71eaf3bab0236318d53b49419bed5454 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 24721ffd71ea drm/i915/uc: Don't fail on HuC early init errors 8ce238830fc6 drm/i915/uc: Remove redundant GuC support checks 7627d5a6eb80 drm/i915/huc: Prefer intel_huc_is_supported 326254b19fd1 drm/i915/guc: Prefer intel_guc_is_submission_supported == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13866/ ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 4/4] drm/i915/uc: Don't fail on HuC early init errors
Since commit 301efe96f777 ("drm/i915/uc: Don't fail on HuC
firmware failure") we can continue driver load after error
during HuC firmware load or authentication, but we could
still fail on any error during early HuC initialization.
Change that by ignoring HuC related errors until hardware
initialization phase where we can decide about next steps.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Chris Wilson
---
drivers/gpu/drm/i915/gt/uc/intel_huc.c | 7 ++-
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 8
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c
b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
index 66b2d5fdb317..faaf8ad5ba89 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
@@ -52,6 +52,11 @@ static int intel_huc_rsa_data_create(struct intel_huc *huc)
struct i915_vma *vma;
size_t copied;
void *vaddr;
+ int err;
+
+ err = i915_inject_load_error(gt->i915, -ENXIO);
+ if (err)
+ return err;
/*
* HuC firmware will sit above GUC_GGTT_TOP and will not map
@@ -115,8 +120,8 @@ int intel_huc_init(struct intel_huc *huc)
void intel_huc_fini(struct intel_huc *huc)
{
- intel_uc_fw_fini(>fw);
intel_huc_rsa_data_destroy(huc);
+ intel_uc_fw_fini(>fw);
}
/**
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 1ddd252419ec..e87b7904ab7a 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -316,14 +316,14 @@ int intel_uc_init(struct intel_uc *uc)
if (intel_uc_supports_huc(uc)) {
ret = intel_huc_init(huc);
if (ret)
- goto err_guc;
+ goto out_huc;
}
return 0;
-err_guc:
- intel_guc_fini(guc);
- return ret;
+out_huc:
+ intel_uc_fw_cleanup_fetch(>fw);
+ return 0;
}
void intel_uc_fini(struct intel_uc *uc)
--
2.19.2
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/4] Don't fail on HuC early init errors
Next step to ignore all HuC related errors Michal Wajdeczko (4): drm/i915/guc: Prefer intel_guc_is_submission_supported drm/i915/huc: Prefer intel_huc_is_supported drm/i915/uc: Remove redundant GuC support checks drm/i915/uc: Don't fail on HuC early init errors drivers/gpu/drm/i915/gt/uc/intel_guc.c | 8 drivers/gpu/drm/i915/gt/uc/intel_huc.c | 9 +++-- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 19 +-- 3 files changed, 16 insertions(+), 20 deletions(-) -- 2.19.2 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 3/4] drm/i915/uc: Remove redundant GuC support checks
Since commit db81bc6eb9c0 ("drm/i915/uc: Consider enable_guc
modparam during fw selection") we have started using firmware
status as main indicator of the GuC support. No need to use
same checks twice.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Chris Wilson
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index fe526698eee2..1ddd252419ec 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -306,9 +306,6 @@ int intel_uc_init(struct intel_uc *uc)
if (!intel_uc_supports_guc(uc))
return 0;
- if (!intel_uc_fw_supported(>fw))
- return -ENODEV;
-
/* XXX: GuC submission is unavailable for now */
GEM_BUG_ON(intel_uc_supports_guc_submission(uc));
@@ -336,8 +333,6 @@ void intel_uc_fini(struct intel_uc *uc)
if (!intel_uc_supports_guc(uc))
return;
- GEM_BUG_ON(!intel_uc_fw_supported(>fw));
-
if (intel_uc_supports_huc(uc))
intel_huc_fini(>huc);
@@ -351,7 +346,7 @@ static int __uc_sanitize(struct intel_uc *uc)
struct intel_guc *guc = >guc;
struct intel_huc *huc = >huc;
- GEM_BUG_ON(!intel_uc_fw_supported(>fw));
+ GEM_BUG_ON(!intel_uc_supports_guc(uc));
intel_huc_sanitize(huc);
intel_guc_sanitize(guc);
@@ -429,8 +424,6 @@ int intel_uc_init_hw(struct intel_uc *uc)
if (!intel_uc_supports_guc(uc))
return 0;
- GEM_BUG_ON(!intel_uc_fw_supported(>fw));
-
ret = uc_init_wopcm(uc);
if (ret)
goto err_out;
@@ -530,8 +523,6 @@ void intel_uc_fini_hw(struct intel_uc *uc)
if (!intel_guc_is_running(guc))
return;
- GEM_BUG_ON(!intel_uc_fw_supported(>fw));
-
if (intel_uc_supports_guc_submission(uc))
intel_guc_submission_disable(guc);
--
2.19.2
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 2/4] drm/i915/huc: Prefer intel_huc_is_supported
No need to dance with intel_uc_supports_huc(uc) as we can directly use intel_huc_is_supported(huc) Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris Wilson --- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c b/drivers/gpu/drm/i915/gt/uc/intel_huc.c index ef54053c5ef9..66b2d5fdb317 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.c @@ -187,7 +187,7 @@ int intel_huc_check_status(struct intel_huc *huc) intel_wakeref_t wakeref; u32 status = 0; - if (!intel_uc_supports_huc(>uc)) + if (!intel_huc_is_supported(huc)) return -ENODEV; with_intel_runtime_pm(>i915->runtime_pm, wakeref) -- 2.19.2 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 1/4] drm/i915/guc: Prefer intel_guc_is_submission_supported
No need to use intel_uc_supports_guc_submission(uc) as we
can directly use intel_guc_is_submission_supported(guc)
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Chris Wilson
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
index 0ee8139885a5..f9c33062249f 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
@@ -145,7 +145,7 @@ static u32 guc_ctl_feature_flags(struct intel_guc *guc)
{
u32 flags = 0;
- if (!intel_uc_supports_guc_submission(_to_gt(guc)->uc))
+ if (!intel_guc_is_submission_supported(guc))
flags |= GUC_CTL_DISABLE_SCHEDULER;
return flags;
@@ -155,7 +155,7 @@ static u32 guc_ctl_ctxinfo_flags(struct intel_guc *guc)
{
u32 flags = 0;
- if (intel_uc_supports_guc_submission(_to_gt(guc)->uc)) {
+ if (intel_guc_is_submission_supported(guc)) {
u32 ctxnum, base;
base = intel_guc_ggtt_offset(guc, guc->stage_desc_pool);
@@ -291,7 +291,7 @@ int intel_guc_init(struct intel_guc *guc)
if (ret)
goto err_ads;
- if (intel_uc_supports_guc_submission(>uc)) {
+ if (intel_guc_is_submission_supported(guc)) {
/*
* This is stuff we need to have available at fw load time
* if we are planning to enable submission later
@@ -330,7 +330,7 @@ void intel_guc_fini(struct intel_guc *guc)
i915_ggtt_disable_guc(gt->ggtt);
- if (intel_uc_supports_guc_submission(>uc))
+ if (intel_guc_is_submission_supported(guc))
intel_guc_submission_fini(guc);
intel_guc_ct_fini(>ct);
--
2.19.2
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pmu: Use GT parked for estimating RC6 while asleep (rev2)
== Series Details == Series: drm/i915/pmu: Use GT parked for estimating RC6 while asleep (rev2) URL : https://patchwork.freedesktop.org/series/56583/ State : success == Summary == CI Bug Log - changes from CI_DRM_6622_full -> Patchwork_13864_full Summary --- **SUCCESS** No regressions found. Known issues Here are the changes found in Patchwork_13864_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-iclb4/igt@gem_exec_balan...@smoke.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-iclb6/igt@gem_exec_balan...@smoke.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-skl: [PASS][3] -> [INCOMPLETE][4] ([fdo#104108] / [fdo#107807]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-skl9/igt@i915_pm_...@system-suspend-execbuf.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-skl8/igt@i915_pm_...@system-suspend-execbuf.html * igt@i915_suspend@forcewake: - shard-hsw: [PASS][5] -> [INCOMPLETE][6] ([fdo#103540]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-hsw6/igt@i915_susp...@forcewake.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-hsw4/igt@i915_susp...@forcewake.html - shard-glk: [PASS][7] -> [INCOMPLETE][8] ([fdo#103359] / [k.org#198133]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-glk6/igt@i915_susp...@forcewake.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-glk6/igt@i915_susp...@forcewake.html - shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([fdo#107713]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-iclb4/igt@i915_susp...@forcewake.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-iclb3/igt@i915_susp...@forcewake.html - shard-snb: [PASS][11] -> [INCOMPLETE][12] ([fdo#105411]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-snb4/igt@i915_susp...@forcewake.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-snb6/igt@i915_susp...@forcewake.html - shard-apl: [PASS][13] -> [INCOMPLETE][14] ([fdo#103927]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-apl3/igt@i915_susp...@forcewake.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-apl2/igt@i915_susp...@forcewake.html - shard-skl: [PASS][15] -> [INCOMPLETE][16] ([fdo#104108]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-skl10/igt@i915_susp...@forcewake.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-skl10/igt@i915_susp...@forcewake.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [PASS][17] -> [FAIL][18] ([fdo#105363]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-skl5/igt@kms_f...@flip-vs-expired-vblank.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-skl9/igt@kms_f...@flip-vs-expired-vblank.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render: - shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#103167]) +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-iclb7/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-spr-indfb-draw-render.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-iclb2/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-spr-indfb-draw-render.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#108145] / [fdo#110403]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-skl5/igt@kms_plane_alpha_bl...@pipe-c-coverage-7efc.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-skl9/igt@kms_plane_alpha_bl...@pipe-c-coverage-7efc.html * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf: - shard-skl: [PASS][23] -> [DMESG-WARN][24] ([fdo#106885]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-skl2/igt@kms_plane_multi...@atomic-pipe-c-tiling-yf.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-skl2/igt@kms_plane_multi...@atomic-pipe-c-tiling-yf.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#108341]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-iclb6/igt@kms_psr@no_drrs.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13864/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_basic: - shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) [27]:
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Remove stale kerneldoc for internal MOCS functions
== Series Details == Series: drm/i915/gt: Remove stale kerneldoc for internal MOCS functions URL : https://patchwork.freedesktop.org/series/64649/ State : success == Summary == CI Bug Log - changes from CI_DRM_6622_full -> Patchwork_13863_full Summary --- **SUCCESS** No regressions found. Known issues Here are the changes found in Patchwork_13863_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-iclb4/igt@gem_exec_balan...@smoke.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-iclb6/igt@gem_exec_balan...@smoke.html * igt@gem_softpin@noreloc-s3: - shard-skl: [PASS][3] -> [INCOMPLETE][4] ([fdo#104108] / [fdo#107773]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-skl6/igt@gem_soft...@noreloc-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-skl5/igt@gem_soft...@noreloc-s3.html * igt@kms_big_fb@y-tiled-64bpp-rotate-0: - shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-iclb4/igt@kms_big...@y-tiled-64bpp-rotate-0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-iclb7/igt@kms_big...@y-tiled-64bpp-rotate-0.html * igt@kms_cursor_legacy@flip-vs-cursor-legacy: - shard-apl: [PASS][7] -> [INCOMPLETE][8] ([fdo#103927]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-apl8/igt@kms_cursor_leg...@flip-vs-cursor-legacy.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-apl4/igt@kms_cursor_leg...@flip-vs-cursor-legacy.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-skl: [PASS][9] -> [INCOMPLETE][10] ([fdo#109507]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-skl5/igt@kms_f...@flip-vs-suspend-interruptible.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-skl3/igt@kms_f...@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw: - shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +3 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-iclb7/igt@kms_frontbuffer_track...@fbc-1p-pri-indfb-multidraw.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-iclb2/igt@kms_frontbuffer_track...@fbc-1p-pri-indfb-multidraw.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][13] -> [FAIL][14] ([fdo#108145] / [fdo#110403]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-skl5/igt@kms_plane_alpha_bl...@pipe-c-coverage-7efc.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-skl6/igt@kms_plane_alpha_bl...@pipe-c-coverage-7efc.html * igt@kms_psr@psr2_basic: - shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-iclb2/igt@kms_psr@psr2_basic.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-iclb6/igt@kms_psr@psr2_basic.html * igt@prime_busy@hang-blt: - shard-hsw: [PASS][17] -> [INCOMPLETE][18] ([fdo#103540]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-hsw6/igt@prime_b...@hang-blt.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-hsw5/igt@prime_b...@hang-blt.html Possible fixes * igt@i915_pm_rpm@legacy-planes-dpms: - shard-iclb: [INCOMPLETE][19] ([fdo#107713] / [fdo#108840] / [fdo#109960]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-iclb7/igt@i915_pm_...@legacy-planes-dpms.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-iclb2/igt@i915_pm_...@legacy-planes-dpms.html * igt@i915_suspend@debugfs-reader: - shard-apl: [DMESG-WARN][21] ([fdo#108566]) -> [PASS][22] +6 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-apl2/igt@i915_susp...@debugfs-reader.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-apl6/igt@i915_susp...@debugfs-reader.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-skl: [INCOMPLETE][23] ([fdo#110741]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6622/shard-skl2/igt@kms_cursor_...@pipe-b-cursor-suspend.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13863/shard-skl5/igt@kms_cursor_...@pipe-b-cursor-suspend.html * igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding: - shard-skl: [FAIL][25] ([fdo#103232]) -> [PASS][26] [25]:
[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915: Get transcoder power domain before reading its register (rev2)
== Series Details == Series: series starting with [v2,1/2] drm/i915: Get transcoder power domain before reading its register (rev2) URL : https://patchwork.freedesktop.org/series/64639/ State : success == Summary == CI Bug Log - changes from CI_DRM_6619_full -> Patchwork_13860_full Summary --- **SUCCESS** No regressions found. Known issues Here are the changes found in Patchwork_13860_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-iclb1/igt@gem_exec_balan...@smoke.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-iclb8/igt@gem_exec_balan...@smoke.html * igt@i915_pm_rpm@i2c: - shard-hsw: [PASS][3] -> [FAIL][4] ([fdo#104097]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-hsw6/igt@i915_pm_...@i2c.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-hsw6/igt@i915_pm_...@i2c.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-skl: [PASS][5] -> [INCOMPLETE][6] ([fdo#104108] / [fdo#107807]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-skl6/igt@i915_pm_...@system-suspend-execbuf.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-skl8/igt@i915_pm_...@system-suspend-execbuf.html * igt@i915_suspend@sysfs-reader: - shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +7 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-apl1/igt@i915_susp...@sysfs-reader.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-apl4/igt@i915_susp...@sysfs-reader.html * igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding: - shard-skl: [PASS][9] -> [FAIL][10] ([fdo#103232]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-skl2/igt@kms_cursor_...@pipe-c-cursor-256x256-sliding.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-skl6/igt@kms_cursor_...@pipe-c-cursor-256x256-sliding.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][11] -> [FAIL][12] ([fdo#105363]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-skl10/igt@kms_f...@flip-vs-expired-vblank-interruptible.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-skl6/igt@kms_f...@flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite: - shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +7 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-iclb1/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-iclb8/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [PASS][15] -> [FAIL][16] ([fdo#108145]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-skl9/igt@kms_plane_alpha_bl...@pipe-b-constant-alpha-min.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-skl4/igt@kms_plane_alpha_bl...@pipe-b-constant-alpha-min.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +3 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-iclb2/igt@kms_psr@psr2_cursor_render.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-iclb3/igt@kms_psr@psr2_cursor_render.html * igt@kms_setmode@basic: - shard-apl: [PASS][19] -> [FAIL][20] ([fdo#99912]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-apl4/igt@kms_setm...@basic.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-apl3/igt@kms_setm...@basic.html * igt@perf@blocking: - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#110728]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-skl9/igt@p...@blocking.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-skl8/igt@p...@blocking.html Possible fixes * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [FAIL][23] ([fdo#102670]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-skl9/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13860/shard-skl4/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-apl: [FAIL][25] ([fdo#105363]) -> [PASS][26] [25]:
[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915: Hide unshrinkable context objects from the shrinker
== Series Details == Series: series starting with [CI,1/2] drm/i915: Hide unshrinkable context objects from the shrinker URL : https://patchwork.freedesktop.org/series/64638/ State : success == Summary == CI Bug Log - changes from CI_DRM_6619_full -> Patchwork_13859_full Summary --- **SUCCESS** No regressions found. Known issues Here are the changes found in Patchwork_13859_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-iclb1/igt@gem_exec_balan...@smoke.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-iclb7/igt@gem_exec_balan...@smoke.html * igt@i915_suspend@fence-restore-untiled: - shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +2 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-apl3/igt@i915_susp...@fence-restore-untiled.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-apl7/igt@i915_susp...@fence-restore-untiled.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-hsw: [PASS][5] -> [INCOMPLETE][6] ([fdo#103540]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-hsw5/igt@kms_f...@flip-vs-suspend-interruptible.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-hsw4/igt@kms_f...@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-stridechange: - shard-iclb: [PASS][7] -> [FAIL][8] ([fdo#103167]) +4 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-iclb3/igt@kms_frontbuffer_track...@fbc-stridechange.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-iclb7/igt@kms_frontbuffer_track...@fbc-stridechange.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [PASS][9] -> [FAIL][10] ([fdo#108145]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-skl9/igt@kms_plane_alpha_bl...@pipe-b-constant-alpha-min.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-skl3/igt@kms_plane_alpha_bl...@pipe-b-constant-alpha-min.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103166]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-iclb6/igt@kms_plane_low...@pipe-a-tiling-y.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-iclb6/igt@kms_plane_low...@pipe-a-tiling-y.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#108341]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-iclb6/igt@kms_psr@no_drrs.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) +5 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-iclb2/igt@kms_psr@psr2_cursor_render.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-iclb8/igt@kms_psr@psr2_cursor_render.html * igt@kms_setmode@basic: - shard-apl: [PASS][17] -> [FAIL][18] ([fdo#99912]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-apl4/igt@kms_setm...@basic.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-apl2/igt@kms_setm...@basic.html * igt@perf@blocking: - shard-skl: [PASS][19] -> [FAIL][20] ([fdo#110728]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-skl9/igt@p...@blocking.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-skl8/igt@p...@blocking.html Possible fixes * igt@gem_softpin@noreloc-s3: - shard-apl: [DMESG-WARN][21] ([fdo#108566]) -> [PASS][22] +1 similar issue [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-apl5/igt@gem_soft...@noreloc-s3.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-apl7/igt@gem_soft...@noreloc-s3.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [FAIL][23] ([fdo#102670]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-skl9/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13859/shard-skl3/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [FAIL][25] ([fdo#105363]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6619/shard-skl8/igt@kms_f...@flip-vs-expired-vblank.html [26]:
[Intel-gfx] ✓ Fi.CI.IGT: success for Refactor to expand subslice mask (rev 2)
== Series Details == Series: Refactor to expand subslice mask (rev 2) URL : https://patchwork.freedesktop.org/series/64636/ State : success == Summary == CI Bug Log - changes from CI_DRM_6618_full -> Patchwork_13858_full Summary --- **SUCCESS** No regressions found. Known issues Here are the changes found in Patchwork_13858_full that come from known issues: ### IGT changes ### Issues hit * igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen: - shard-hsw: [PASS][1] -> [INCOMPLETE][2] ([fdo#103540]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-hsw5/igt@kms_cursor_...@pipe-c-cursor-128x128-offscreen.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-hsw2/igt@kms_cursor_...@pipe-c-cursor-128x128-offscreen.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: - shard-hsw: [PASS][3] -> [FAIL][4] ([fdo#105767]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-hsw2/igt@kms_cursor_leg...@2x-long-cursor-vs-flip-legacy.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-hsw4/igt@kms_cursor_leg...@2x-long-cursor-vs-flip-legacy.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [PASS][5] -> [FAIL][6] ([fdo#102670]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl6/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl6/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][7] -> [FAIL][8] ([fdo#105363]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl3/igt@kms_f...@flip-vs-expired-vblank-interruptible.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl2/igt@kms_f...@flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite: - shard-iclb: [PASS][9] -> [FAIL][10] ([fdo#103167]) +5 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb3/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-iclb7/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt: - shard-skl: [PASS][11] -> [FAIL][12] ([fdo#103167]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@kms_frontbuffer_track...@psr-1p-primscrn-shrfb-plflip-blt.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl7/igt@kms_frontbuffer_track...@psr-1p-primscrn-shrfb-plflip-blt.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][13] -> [FAIL][14] ([fdo#108145]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl7/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103166]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb2/igt@kms_plane_low...@pipe-a-tiling-y.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-iclb6/igt@kms_plane_low...@pipe-a-tiling-y.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +2 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_setmode@basic: - shard-apl: [PASS][19] -> [FAIL][20] ([fdo#99912]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl4/igt@kms_setm...@basic.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-apl8/igt@kms_setm...@basic.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-apl: [PASS][21] -> [DMESG-WARN][22] ([fdo#108566]) +5 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl8/igt@kms_vbl...@pipe-a-ts-continuation-suspend.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-apl4/igt@kms_vbl...@pipe-a-ts-continuation-suspend.html - shard-skl: [PASS][23] -> [INCOMPLETE][24] ([fdo#104108]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@kms_vbl...@pipe-a-ts-continuation-suspend.html [24]:
[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Teach execbuffer to take the engine wakeref not GT
== Series Details == Series: series starting with [CI,1/2] drm/i915: Teach execbuffer to take the engine wakeref not GT URL : https://patchwork.freedesktop.org/series/64665/ State : success == Summary == CI Bug Log - changes from CI_DRM_6623 -> Patchwork_13865 Summary --- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/ Known issues Here are the changes found in Patchwork_13865 that come from known issues: ### IGT changes ### Issues hit * igt@i915_selftest@live_hangcheck: - fi-icl-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#108569]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-kbl-7567u: [PASS][3] -> [WARN][4] ([fdo#109380]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/fi-kbl-7567u/igt@kms_chamel...@common-hpd-after-suspend.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/fi-kbl-7567u/igt@kms_chamel...@common-hpd-after-suspend.html * igt@kms_frontbuffer_tracking@basic: - fi-hsw-peppy: [PASS][5] -> [DMESG-WARN][6] ([fdo#102614]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/fi-hsw-peppy/igt@kms_frontbuffer_track...@basic.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/fi-hsw-peppy/igt@kms_frontbuffer_track...@basic.html * igt@kms_pipe_crc_basic@read-crc-pipe-c: - fi-kbl-7567u: [PASS][7] -> [SKIP][8] ([fdo#109271]) +23 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/fi-kbl-7567u/igt@kms_pipe_crc_ba...@read-crc-pipe-c.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/fi-kbl-7567u/igt@kms_pipe_crc_ba...@read-crc-pipe-c.html * igt@vgem_basic@dmabuf-fence: - fi-icl-u3: [PASS][9] -> [DMESG-WARN][10] ([fdo#107724]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/fi-icl-u3/igt@vgem_ba...@dmabuf-fence.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/fi-icl-u3/igt@vgem_ba...@dmabuf-fence.html Possible fixes * igt@gem_exec_suspend@basic-s3: - fi-blb-e6850: [INCOMPLETE][11] ([fdo#107718]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/fi-blb-e6850/igt@gem_exec_susp...@basic-s3.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/fi-blb-e6850/igt@gem_exec_susp...@basic-s3.html * igt@kms_busy@basic-flip-c: - fi-kbl-7500u: [SKIP][13] ([fdo#109271] / [fdo#109278]) -> [PASS][14] +2 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/fi-kbl-7500u/igt@kms_b...@basic-flip-c.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/fi-kbl-7500u/igt@kms_b...@basic-flip-c.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-icl-u2: [FAIL][15] ([fdo#109483]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6623/fi-icl-u2/igt@kms_chamel...@hdmi-hpd-fast.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/fi-icl-u2/igt@kms_chamel...@hdmi-hpd-fast.html [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380 [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483 Participating hosts (55 -> 47) -- Missing(8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes - * CI: CI-20190529 -> None * Linux: CI_DRM_6623 -> Patchwork_13865 CI-20190529: 20190529 CI_DRM_6623: cd58db46a031e373917b8b0ee5f4ccb9dca7ff74 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5120: b3138fbea79d5d7935e53530b90efe3e816236f4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13865: b87d4bff0e1e08087c1473473714e7bf63782012 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == b87d4bff0e1e drm/i915: Replace struct_mutex for batch pool serialisation d801b688cc3b drm/i915: Teach execbuffer to take the engine wakeref not GT == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13865/ ___ Intel-gfx mailing list
[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Separate pinning of pages from i915_vma_insert()
== Series Details == Series: drm/i915: Separate pinning of pages from i915_vma_insert() URL : https://patchwork.freedesktop.org/series/64635/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6618_full -> Patchwork_13857_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_13857_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_13857_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_13857_full: ### IGT changes ### Possible regressions * igt@i915_selftest@mock_hugepages: - shard-skl: [PASS][1] -> [DMESG-FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl5/igt@i915_selftest@mock_hugepages.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13857/shard-skl9/igt@i915_selftest@mock_hugepages.html - shard-hsw: [PASS][3] -> [DMESG-FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-hsw4/igt@i915_selftest@mock_hugepages.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13857/shard-hsw4/igt@i915_selftest@mock_hugepages.html - shard-glk: [PASS][5] -> [DMESG-FAIL][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-glk8/igt@i915_selftest@mock_hugepages.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13857/shard-glk7/igt@i915_selftest@mock_hugepages.html - shard-snb: [PASS][7] -> [DMESG-FAIL][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-snb7/igt@i915_selftest@mock_hugepages.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13857/shard-snb7/igt@i915_selftest@mock_hugepages.html - shard-iclb: [PASS][9] -> [DMESG-FAIL][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb6/igt@i915_selftest@mock_hugepages.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13857/shard-iclb7/igt@i915_selftest@mock_hugepages.html - shard-apl: [PASS][11] -> [DMESG-FAIL][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl2/igt@i915_selftest@mock_hugepages.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13857/shard-apl2/igt@i915_selftest@mock_hugepages.html Known issues Here are the changes found in Patchwork_13857_full that come from known issues: ### IGT changes ### Issues hit * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-skl: [PASS][13] -> [INCOMPLETE][14] ([fdo#110741]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl6/igt@kms_cursor_...@pipe-b-cursor-suspend.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13857/shard-skl3/igt@kms_cursor_...@pipe-b-cursor-suspend.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: - shard-hsw: [PASS][15] -> [FAIL][16] ([fdo#105767]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-hsw2/igt@kms_cursor_leg...@2x-long-cursor-vs-flip-legacy.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13857/shard-hsw1/igt@kms_cursor_leg...@2x-long-cursor-vs-flip-legacy.html * igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions: - shard-hsw: [PASS][17] -> [FAIL][18] ([fdo#103355]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-hsw2/igt@kms_cursor_leg...@cursor-vs-flip-atomic-transitions.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13857/shard-hsw6/igt@kms_cursor_leg...@cursor-vs-flip-atomic-transitions.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: [PASS][19] -> [FAIL][20] ([fdo#105363]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-glk2/igt@kms_f...@2x-flip-vs-expired-vblank-interruptible.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13857/shard-glk8/igt@kms_f...@2x-flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-hsw: [PASS][21] -> [INCOMPLETE][22] ([fdo#103540]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-hsw6/igt@kms_f...@flip-vs-suspend-interruptible.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13857/shard-hsw2/igt@kms_f...@flip-vs-suspend-interruptible.html * igt@kms_flip@plain-flip-fb-recreate-interruptible: - shard-skl: [PASS][23] -> [FAIL][24] ([fdo#100368]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@kms_f...@plain-flip-fb-recreate-interruptible.html [24]:
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Teach execbuffer to take the engine wakeref not GT
== Series Details == Series: series starting with [CI,1/2] drm/i915: Teach execbuffer to take the engine wakeref not GT URL : https://patchwork.freedesktop.org/series/64665/ State : warning == Summary == $ dim checkpatch origin/drm-tip d801b688cc3b drm/i915: Teach execbuffer to take the engine wakeref not GT b87d4bff0e1e drm/i915: Replace struct_mutex for batch pool serialisation -:305: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #305: new file mode 100644 -:310: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #310: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:1: +/* -:311: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #311: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:2: + * SPDX-License-Identifier: MIT -:493: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #493: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:1: +/* -:494: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #494: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:2: + * SPDX-License-Identifier: MIT -:533: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #533: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:1: +/* -:534: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #534: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:2: + * SPDX-License-Identifier: MIT -:550: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #550: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:18: + spinlock_t lock; total: 0 errors, 7 warnings, 1 checks, 605 lines checked ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [CI 1/2] drm/i915: Teach execbuffer to take the engine wakeref not GT
In the next patch, we would like to couple into the engine wakeref to
free the batch pool on idling. The caveat here is that we therefore want
to track the engine wakeref more precisely and to hold it instead of the
broader GT wakeref as we process the ioctl.
v2: Avoid introducing odd semantics for a shortlived timeline->mutex
acquisition interface.
Signed-off-by: Chris Wilson
Reviewed-by: Tvrtko Ursulin
---
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 42 +--
1 file changed, 29 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 4db4463089ce..8d90498eaf46 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -2139,14 +2139,40 @@ static int eb_pin_context(struct i915_execbuffer *eb,
struct intel_context *ce)
if (err)
return err;
+ /*
+* Take a local wakeref for preparing to dispatch the execbuf as
+* we expect to access the hardware fairly frequently in the
+* process, and require the engine to be kept awake between accesses.
+* Upon dispatch, we acquire another prolonged wakeref that we hold
+* until the timeline is idle, which in turn releases the wakeref
+* taken on the engine, and the parent device.
+*/
+ err = intel_context_timeline_lock(ce);
+ if (err)
+ goto err_unpin;
+
+ intel_context_enter(ce);
+ intel_context_timeline_unlock(ce);
+
eb->engine = ce->engine;
eb->context = ce;
return 0;
+
+err_unpin:
+ intel_context_unpin(ce);
+ return err;
}
static void eb_unpin_context(struct i915_execbuffer *eb)
{
- intel_context_unpin(eb->context);
+ struct intel_context *ce = eb->context;
+ struct intel_timeline *tl = ce->ring->timeline;
+
+ mutex_lock(>mutex);
+ intel_context_exit(ce);
+ mutex_unlock(>mutex);
+
+ intel_context_unpin(ce);
}
static unsigned int
@@ -2426,18 +2452,9 @@ i915_gem_do_execbuffer(struct drm_device *dev,
if (unlikely(err))
goto err_destroy;
- /*
-* Take a local wakeref for preparing to dispatch the execbuf as
-* we expect to access the hardware fairly frequently in the
-* process. Upon first dispatch, we acquire another prolonged
-* wakeref that we hold until the GPU has been idle for at least
-* 100ms.
-*/
- intel_gt_pm_get(>gt);
-
err = i915_mutex_lock_interruptible(dev);
if (err)
- goto err_rpm;
+ goto err_context;
err = eb_select_engine(, file, args);
if (unlikely(err))
@@ -2602,8 +2619,7 @@ i915_gem_do_execbuffer(struct drm_device *dev,
eb_unpin_context();
err_unlock:
mutex_unlock(>struct_mutex);
-err_rpm:
- intel_gt_pm_put(>gt);
+err_context:
i915_gem_context_put(eb.gem_context);
err_destroy:
eb_destroy();
--
2.23.0.rc1
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [CI 2/2] drm/i915: Replace struct_mutex for batch pool serialisation
Switch to tracking activity via i915_active on individual nodes, only
keeping a list of retired objects in the cache, and reaping the cache
when the engine itself idles.
Signed-off-by: Chris Wilson
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/i915/Makefile | 2 +-
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 58 +++---
drivers/gpu/drm/i915/gem/i915_gem_object.c| 1 -
.../gpu/drm/i915/gem/i915_gem_object_types.h | 1 -
drivers/gpu/drm/i915/gem/i915_gem_pm.c| 4 +-
drivers/gpu/drm/i915/gt/intel_engine.h| 1 -
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 11 +-
drivers/gpu/drm/i915/gt/intel_engine_pm.c | 2 +
drivers/gpu/drm/i915/gt/intel_engine_pool.c | 177 ++
drivers/gpu/drm/i915/gt/intel_engine_pool.h | 34
.../gpu/drm/i915/gt/intel_engine_pool_types.h | 29 +++
drivers/gpu/drm/i915/gt/intel_engine_types.h | 6 +-
drivers/gpu/drm/i915/gt/mock_engine.c | 2 +
drivers/gpu/drm/i915/i915_debugfs.c | 68 ---
drivers/gpu/drm/i915/i915_gem_batch_pool.c| 132 -
drivers/gpu/drm/i915/i915_gem_batch_pool.h| 26 ---
16 files changed, 289 insertions(+), 265 deletions(-)
create mode 100644 drivers/gpu/drm/i915/gt/intel_engine_pool.c
create mode 100644 drivers/gpu/drm/i915/gt/intel_engine_pool.h
create mode 100644 drivers/gpu/drm/i915/gt/intel_engine_pool_types.h
delete mode 100644 drivers/gpu/drm/i915/i915_gem_batch_pool.c
delete mode 100644 drivers/gpu/drm/i915/i915_gem_batch_pool.h
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 331b19cc8247..a1016858d014 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -71,6 +71,7 @@ obj-y += gt/
gt-y += \
gt/intel_breadcrumbs.o \
gt/intel_context.o \
+ gt/intel_engine_pool.o \
gt/intel_engine_cs.o \
gt/intel_engine_pm.o \
gt/intel_gt.o \
@@ -124,7 +125,6 @@ i915-y += \
$(gem-y) \
i915_active.o \
i915_cmd_parser.o \
- i915_gem_batch_pool.o \
i915_gem_evict.o \
i915_gem_fence_reg.o \
i915_gem_gtt.o \
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 8d90498eaf46..0c8c909743f1 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -16,6 +16,7 @@
#include "gem/i915_gem_ioctls.h"
#include "gt/intel_context.h"
+#include "gt/intel_engine_pool.h"
#include "gt/intel_gt.h"
#include "gt/intel_gt_pm.h"
@@ -1198,25 +1199,26 @@ static int __reloc_gpu_alloc(struct i915_execbuffer *eb,
unsigned int len)
{
struct reloc_cache *cache = >reloc_cache;
- struct drm_i915_gem_object *obj;
+ struct intel_engine_pool_node *pool;
struct i915_request *rq;
struct i915_vma *batch;
u32 *cmd;
int err;
- obj = i915_gem_batch_pool_get(>engine->batch_pool, PAGE_SIZE);
- if (IS_ERR(obj))
- return PTR_ERR(obj);
+ pool = intel_engine_pool_get(>engine->pool, PAGE_SIZE);
+ if (IS_ERR(pool))
+ return PTR_ERR(pool);
- cmd = i915_gem_object_pin_map(obj,
+ cmd = i915_gem_object_pin_map(pool->obj,
cache->has_llc ?
I915_MAP_FORCE_WB :
I915_MAP_FORCE_WC);
- i915_gem_object_unpin_pages(obj);
- if (IS_ERR(cmd))
- return PTR_ERR(cmd);
+ if (IS_ERR(cmd)) {
+ err = PTR_ERR(cmd);
+ goto out_pool;
+ }
- batch = i915_vma_instance(obj, vma->vm, NULL);
+ batch = i915_vma_instance(pool->obj, vma->vm, NULL);
if (IS_ERR(batch)) {
err = PTR_ERR(batch);
goto err_unmap;
@@ -1232,6 +1234,10 @@ static int __reloc_gpu_alloc(struct i915_execbuffer *eb,
goto err_unpin;
}
+ err = intel_engine_pool_mark_active(pool, rq);
+ if (err)
+ goto err_request;
+
err = reloc_move_to_gpu(rq, vma);
if (err)
goto err_request;
@@ -1257,7 +1263,7 @@ static int __reloc_gpu_alloc(struct i915_execbuffer *eb,
cache->rq_size = 0;
/* Return with batch mapping (cmd) still pinned */
- return 0;
+ goto out_pool;
skip_request:
i915_request_skip(rq, err);
@@ -1266,7 +1272,9 @@ static int __reloc_gpu_alloc(struct i915_execbuffer *eb,
err_unpin:
i915_vma_unpin(batch);
err_unmap:
- i915_gem_object_unpin_map(obj);
+ i915_gem_object_unpin_map(pool->obj);
+out_pool:
+ intel_engine_pool_put(pool);
return err;
}
@@ -2010,18 +2018,17 @@ static int i915_reset_gen7_sol_offsets(struct
i915_request *rq)
static struct i915_vma *eb_parse(struct i915_execbuffer *eb, bool is_master)
{
-
[Intel-gfx] ✓ Fi.CI.IGT: success for add more probe failures
== Series Details == Series: add more probe failures URL : https://patchwork.freedesktop.org/series/64629/ State : success == Summary == CI Bug Log - changes from CI_DRM_6618_full -> Patchwork_13856_full Summary --- **SUCCESS** No regressions found. Known issues Here are the changes found in Patchwork_13856_full that come from known issues: ### IGT changes ### Issues hit * igt@i915_suspend@debugfs-reader: - shard-apl: [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl2/igt@i915_susp...@debugfs-reader.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-apl6/igt@i915_susp...@debugfs-reader.html * igt@kms_cursor_crc@pipe-b-cursor-256x256-random: - shard-hsw: [PASS][3] -> [INCOMPLETE][4] ([fdo#103540]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-hsw5/igt@kms_cursor_...@pipe-b-cursor-256x256-random.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-hsw2/igt@kms_cursor_...@pipe-b-cursor-256x256-random.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [PASS][5] -> [FAIL][6] ([fdo#102670]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl6/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-skl2/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html * igt@kms_flip@dpms-vs-vblank-race: - shard-glk: [PASS][7] -> [FAIL][8] ([fdo#103060]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-glk2/igt@kms_f...@dpms-vs-vblank-race.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-glk7/igt@kms_f...@dpms-vs-vblank-race.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [PASS][9] -> [FAIL][10] ([fdo#105363]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl7/igt@kms_f...@flip-vs-expired-vblank.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-skl8/igt@kms_f...@flip-vs-expired-vblank.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite: - shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +2 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb3/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-iclb8/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103166]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb2/igt@kms_plane_low...@pipe-a-tiling-x.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-iclb4/igt@kms_plane_low...@pipe-a-tiling-x.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) +2 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-skl: [PASS][17] -> [INCOMPLETE][18] ([fdo#104108]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl1/igt@kms_vbl...@pipe-b-ts-continuation-suspend.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-skl10/igt@kms_vbl...@pipe-b-ts-continuation-suspend.html * igt@perf@blocking: - shard-skl: [PASS][19] -> [FAIL][20] ([fdo#110728]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl3/igt@p...@blocking.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-skl3/igt@p...@blocking.html Possible fixes * igt@gem_eio@reset-stress: - shard-skl: [FAIL][21] ([fdo#109661]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@gem_...@reset-stress.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-skl6/igt@gem_...@reset-stress.html * igt@gem_tiled_swapping@non-threaded: - shard-apl: [DMESG-WARN][23] ([fdo#108686]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl2/igt@gem_tiled_swapp...@non-threaded.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13856/shard-apl6/igt@gem_tiled_swapp...@non-threaded.html * igt@i915_pm_rpm@i2c: - shard-hsw: [FAIL][25] ([fdo#104097]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-hsw5/igt@i915_pm_...@i2c.html [26]:
Re: [Intel-gfx] [PATCH v6 00/24] Associate ddc adapters with connectors
On Tue, Jul 30, 2019 at 04:01:23PM +0100, Emil Velikov wrote: > On 2019/07/26, Andrzej Pietrasiewicz wrote: > > It is difficult for a user to know which of the i2c adapters is for which > > drm connector. This series addresses this problem. > > > > The idea is to have a symbolic link in connector's sysfs directory, e.g.: > > > > ls -l /sys/class/drm/card0-HDMI-A-1/ddc > > lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \ > > -> ../../../../soc/1388.i2c/i2c-2 > > > > The user then knows that their card0-HDMI-A-1 uses i2c-2 and can e.g. run > > ddcutil: > > > > ddcutil -b 2 getvcp 0x10 > > VCP code 0x10 (Brightness): current value =90, max value = 100 > > > > The first patch in the series adds struct i2c_adapter pointer to struct > > drm_connector. If the field is used by a particular driver, then an > > appropriate symbolic link is created by the generic code, which is also > > added > > by this patch. > > > > Patch 2 adds a new variant of drm_connector_init(), see the changelog > > below. > > > > Patches 3..24 are examples of how to convert a driver to this new scheme. > > > > v1..v2: > > > > - used fixed name "ddc" for the symbolic link in order to make it easy for > > userspace to find the i2c adapter > > > > v2..v3: > > > > - converted as many drivers as possible. > > > > v3..v4: > > > > - added Reviewed-by for patch 01/23 > > - moved "ddc" field assignment to before drm_connector_init() is called > > in msm, vc4, sti, mgag200, ast, amdgpu, radeon > > - simplified the code in amdgpu and radeon at the expense of some lines > > exceeding 80 characters as per Alex Deucher's suggestion > > - added i915 > > > > v4..v5: > > > > - changed "include " to "struct i2c_adapter;" > > in drm_connector.h, consequently, added "include " > > in drm_sysfs.c. > > - added "drm_connector_init_with_ddc()" variant to ensure that the ddc > > field of drm_connector is preserved accross its invocation > > - accordingly changed invocations of drm_connector_init() in the > > touched drivers to use the new variant > > > > v5..v6: > > > > - improved subject line of patch 1 > > - added kernel-doc for drm_connector_init_with_ddc() > > - improved kernel-doc for the ddc field of struct drm_connector > > - added Reviewed-by in patches 17 and 18 > > - added Acked-by in patch 2 > > - made the ownership of ddc i2c_adapter explicit in all patches, > > this made the affected patches much simpler > > > > @Benjamin > > @Shawn > > > > There were your Acked-by or Reviewed-by for some patches in v4, but now > > that the patches use the newly added function I'm not sure I can still > > include those tags without you actually confirming. Can I? Or can you > > please re-review? > > > > TODO: nouveau, gma500, omapdrm, panel-simple - if applicable. > > Other drivers are either already converted or don't mention neither > > "ddc" nor "i2c_adapter". > > > Another way to check is to look for drm_get_edid. Sadly that also > highlights aux. dp/mst instances, which expose the DDC in another way. > > For example comparing the diff stat wrt the following command shows > git grep -wc drm_get_edid -- drivers/gpu/drm/ There's also drm_do_get_edid, which points to the adv7511 bridge as a good candidate. > > > > .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 96 > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c:1 > - as pointed out by Alex - mix of aux dp/mst and normal > > > drivers/gpu/drm/ast/ast_mode.c| 13 +- > > drivers/gpu/drm/bridge/analogix-anx78xx.c:1 > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1 > - not applicable: aux dp/mst > > > > drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 +- > > drivers/gpu/drm/bridge/sii902x.c:1 > - normal instance(?) that should be updated at some point. > > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 +- > > drivers/gpu/drm/bridge/tc358767.c:1 > - not applicable: aux dp/mst > > > drivers/gpu/drm/bridge/ti-tfp410.c| 6 +- > > drivers/gpu/drm/drm_dp_mst_topology.c:3 > - not applicable: aux dp/mst > > > drivers/gpu/drm/drm_connector.c | 35 + > > drivers/gpu/drm/drm_sysfs.c | 8 + > > drivers/gpu/drm/drm_edid.c:7 > drivers/gpu/drm/drm_probe_helper.c:1 > - unrelated > > > drivers/gpu/drm/exynos/exynos_hdmi.c | 6 +- > > drivers/gpu/drm/gma500/cdv_intel_dp.c:3 > drivers/gpu/drm/gma500/cdv_intel_hdmi.c:2 > drivers/gpu/drm/gma500/oaktrail_hdmi.c:1 > drivers/gpu/drm/gma500/oaktrail_lvds.c:2 > drivers/gpu/drm/gma500/psb_intel_modes.c:1 > drivers/gpu/drm/gma500/psb_intel_sdvo.c:2 > - should be updated at some point (as you pointed out). > > > drivers/gpu/drm/i915/display/intel_hdmi.c | 12 +- > drivers/gpu/drm/i915/intel_connector.c:1 > drivers/gpu/drm/i915/intel_crt.c:2 > - not too sure here > > drivers/gpu/drm/i915/intel_dp.c:2 > - not applicable: aux dp/mst > > drivers/gpu/drm/i915/intel_lvds.c:1 >
Re: [Intel-gfx] [PATCH v6 00/24] Associate ddc adapters with connectors
Hi Andrzej, On Fri, Jul 26, 2019 at 07:22:54PM +0200, Andrzej Pietrasiewicz wrote: > It is difficult for a user to know which of the i2c adapters is for which > drm connector. This series addresses this problem. > > The idea is to have a symbolic link in connector's sysfs directory, e.g.: > > ls -l /sys/class/drm/card0-HDMI-A-1/ddc > lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \ > -> ../../../../soc/1388.i2c/i2c-2 > > The user then knows that their card0-HDMI-A-1 uses i2c-2 and can e.g. run > ddcutil: > > ddcutil -b 2 getvcp 0x10 > VCP code 0x10 (Brightness): current value =90, max value = 100 > > The first patch in the series adds struct i2c_adapter pointer to struct > drm_connector. If the field is used by a particular driver, then an > appropriate symbolic link is created by the generic code, which is also added > by this patch. > > Patch 2 adds a new variant of drm_connector_init(), see the changelog > below. > > Patches 3..24 are examples of how to convert a driver to this new scheme. > > v1..v2: > > - used fixed name "ddc" for the symbolic link in order to make it easy for > userspace to find the i2c adapter > > v2..v3: > > - converted as many drivers as possible. > > v3..v4: > > - added Reviewed-by for patch 01/23 > - moved "ddc" field assignment to before drm_connector_init() is called > in msm, vc4, sti, mgag200, ast, amdgpu, radeon > - simplified the code in amdgpu and radeon at the expense of some lines > exceeding 80 characters as per Alex Deucher's suggestion > - added i915 > > v4..v5: > > - changed "include " to "struct i2c_adapter;" > in drm_connector.h, consequently, added "include " > in drm_sysfs.c. > - added "drm_connector_init_with_ddc()" variant to ensure that the ddc > field of drm_connector is preserved accross its invocation > - accordingly changed invocations of drm_connector_init() in the > touched drivers to use the new variant > > v5..v6: > > - improved subject line of patch 1 > - added kernel-doc for drm_connector_init_with_ddc() > - improved kernel-doc for the ddc field of struct drm_connector > - added Reviewed-by in patches 17 and 18 > - added Acked-by in patch 2 > - made the ownership of ddc i2c_adapter explicit in all patches, > this made the affected patches much simpler > > @Benjamin > @Shawn > > There were your Acked-by or Reviewed-by for some patches in v4, but now > that the patches use the newly added function I'm not sure I can still > include those tags without you actually confirming. Can I? Or can you > please re-review? > > TODO: nouveau, gma500, omapdrm, panel-simple - if applicable. omapdrm is moving to a new helper that creates connectors for a set of bridges, so I'll handle it there. It may require adding a ddc field to drm_bridge. > Other drivers are either already converted or don't mention neither > "ddc" nor "i2c_adapter". > > Andrzej Pietrasiewicz (24): > drm: Add ddc link in sysfs created by drm_connector > drm: Add drm_connector_init() variant with ddc > drm/exynos: Provide ddc symlink in connector's sysfs > drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory > drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory > drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory > drm/sun4i: hdmi: Provide ddc symlink in sun4i hdmi connector sysfs > directory > drm/mediatek: Provide ddc symlink in hdmi connector sysfs directory > drm/tegra: Provide ddc symlink in output connector sysfs directory > drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs > drm/imx: imx-tve: Provide ddc symlink in connector's sysfs > drm/vc4: Provide ddc symlink in connector sysfs directory > drm: zte: Provide ddc symlink in hdmi connector sysfs directory > drm: zte: Provide ddc symlink in vga connector sysfs directory > drm/tilcdc: Provide ddc symlink in connector sysfs directory > drm: sti: Provide ddc symlink in hdmi connector sysfs directory > drm/mgag200: Provide ddc symlink in connector sysfs directory > drm/ast: Provide ddc symlink in connector sysfs directory > drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs > directory > drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory > drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs > directory > drm/amdgpu: Provide ddc symlink in connector sysfs directory > drm/radeon: Provide ddc symlink in connector sysfs directory > drm/i915: Provide ddc symlink in hdmi connector sysfs directory > > .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 96 > drivers/gpu/drm/ast/ast_mode.c| 13 +- > drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 +- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 +- > drivers/gpu/drm/bridge/ti-tfp410.c| 6 +- > drivers/gpu/drm/drm_connector.c | 35 + > drivers/gpu/drm/drm_sysfs.c | 8 + >
Re: [Intel-gfx] [PATCH v6 01/24] drm: Add ddc link in sysfs created by drm_connector
Hi Andrzej,
On Sun, Aug 04, 2019 at 03:04:37PM +0300, Laurent Pinchart wrote:
> Hi Andrzej,
>
> Thank you for the patch, and sorry for the late review (I've been
> travelling for the past few weeks).
>
> On Fri, Jul 26, 2019 at 07:22:55PM +0200, Andrzej Pietrasiewicz wrote:
> > Add generic code which creates symbolic links in sysfs, pointing to ddc
> > interface used by a particular video output. For example:
> >
> > ls -l /sys/class/drm/card0-HDMI-A-1/ddc
> > lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \
> > -> ../../../../soc/1388.i2c/i2c-2
> >
> > This makes it easy for user to associate a display with its ddc adapter
> > and use e.g. ddcutil to control the chosen monitor.
> >
> > This patch adds an i2c_adapter pointer to struct drm_connector. Particular
> > drivers can then use it instead of using their own private instance. If a
> > connector contains a ddc, then create a symbolic link in sysfs.
> >
> > Signed-off-by: Andrzej Pietrasiewicz
> > Acked-by: Daniel Vetter
> > Reviewed-by: Andrzej Hajda
> > ---
> > drivers/gpu/drm/drm_sysfs.c | 8
> > include/drm/drm_connector.h | 11 +++
> > 2 files changed, 19 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
> > index ad10810bc972..e962a9d45f7e 100644
> > --- a/drivers/gpu/drm/drm_sysfs.c
> > +++ b/drivers/gpu/drm/drm_sysfs.c
> > @@ -14,6 +14,7 @@
> > #include
> > #include
> > #include
> > +#include
> > #include
> > #include
> >
> > @@ -294,6 +295,9 @@ int drm_sysfs_connector_add(struct drm_connector
> > *connector)
> > /* Let userspace know we have a new connector */
> > drm_sysfs_hotplug_event(dev);
> >
> > + if (connector->ddc)
> > + return sysfs_create_link(>kdev->kobj,
> > +>ddc->dev.kobj, "ddc");
> > return 0;
> > }
> >
> > @@ -301,6 +305,10 @@ void drm_sysfs_connector_remove(struct drm_connector
> > *connector)
> > {
> > if (!connector->kdev)
> > return;
> > +
> > + if (connector->ddc)
> > + sysfs_remove_link(>kdev->kobj, "ddc");
> > +
> > DRM_DEBUG("removing \"%s\" from sysfs\n",
> > connector->name);
> >
> > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> > index 4c30d751487a..33a6fff85fdb 100644
> > --- a/include/drm/drm_connector.h
> > +++ b/include/drm/drm_connector.h
> > @@ -41,6 +41,7 @@ struct drm_property;
> > struct drm_property_blob;
> > struct drm_printer;
> > struct edid;
> > +struct i2c_adapter;
> >
> > enum drm_connector_force {
> > DRM_FORCE_UNSPECIFIED,
> > @@ -1311,6 +1312,16 @@ struct drm_connector {
> > * [0]: progressive, [1]: interlaced
> > */
> > int audio_latency[2];
> > +
> > + /**
> > +* @ddc: associated ddc adapter.
> > +* A connector usually has its associated ddc adapter. If a driver uses
> > +* this field, then an appropriate symbolic link is created in connector
> > +* sysfs directory to make it easy for the user to tell which i2c
> > +* adapter is for a particular display.
>
> The first sentence isn't very clear. The rest is mixing "ddc adapter"
> and "i2c adapter". How about the following ?
>
> "When the connector carries DDC signals, this field points to the I2C
> adapter connected to the DDC signals, if any. When this field is not
> NULL a symbolic link is created in the connector's sysfs directory to
> expose the I2C adapter used by the connector."
>
> Should we also mention that the field isn't meant to be set directly,
> but shall be set with drm_connector_init_with_ddc() ?
>
> "This field shall not be set directly by drivers, use
> drm_connector_init_with_ddc() instead."
I should have read patch 02/24 before answering this :-)
> I'm also slightly concerned about the lifetime of this pointer, and what
> would happen if the I2C adapter disappears while the connector is still
> exposed to userspace, but I suppose this isn't a new issue, existing
> code likely suffers from this.
>
> With the updated documentation,
>
> Reviewed-by: Laurent Pinchart
I've just realised that this patch has been applied already. I'll send
the above as a documentation update patch.
> > +*/
> > + struct i2c_adapter *ddc;
> > +
> > /**
> > * @null_edid_counter: track sinks that give us all zeros for the EDID.
> > * Needed to workaround some HW bugs where we get all 0s
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dmc: Load DMC on TGL
== Series Details == Series: drm/i915/dmc: Load DMC on TGL URL : https://patchwork.freedesktop.org/series/64628/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6618_full -> Patchwork_13855_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_13855_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_13855_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_13855_full: ### IGT changes ### Possible regressions * igt@perf_pmu@busy-idle-no-semaphores-vecs0: - shard-apl: [PASS][1] -> [DMESG-WARN][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl8/igt@perf_...@busy-idle-no-semaphores-vecs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13855/shard-apl6/igt@perf_...@busy-idle-no-semaphores-vecs0.html * igt@runner@aborted: - shard-apl: NOTRUN -> [FAIL][3] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13855/shard-apl6/igt@run...@aborted.html Known issues Here are the changes found in Patchwork_13855_full that come from known issues: ### IGT changes ### Issues hit * igt@i915_selftest@live_hangcheck: - shard-iclb: [PASS][4] -> [INCOMPLETE][5] ([fdo#107713] / [fdo#108569]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb6/igt@i915_selftest@live_hangcheck.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13855/shard-iclb6/igt@i915_selftest@live_hangcheck.html * igt@kms_color@pipe-c-ctm-0-5: - shard-skl: [PASS][6] -> [FAIL][7] ([fdo#108682]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl7/igt@kms_co...@pipe-c-ctm-0-5.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13855/shard-skl9/igt@kms_co...@pipe-c-ctm-0-5.html * igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size: - shard-iclb: [PASS][8] -> [INCOMPLETE][9] ([fdo#107713]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb3/igt@kms_cursor_leg...@cursor-vs-flip-atomic-transitions-varying-size.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13855/shard-iclb7/igt@kms_cursor_leg...@cursor-vs-flip-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [PASS][10] -> [FAIL][11] ([fdo#102670]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl6/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13855/shard-skl4/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html * igt@kms_frontbuffer_tracking@fbc-stridechange: - shard-iclb: [PASS][12] -> [FAIL][13] ([fdo#103167]) +4 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb2/igt@kms_frontbuffer_track...@fbc-stridechange.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13855/shard-iclb7/igt@kms_frontbuffer_track...@fbc-stridechange.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt: - shard-skl: [PASS][14] -> [FAIL][15] ([fdo#103167]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@kms_frontbuffer_track...@psr-1p-primscrn-shrfb-plflip-blt.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13855/shard-skl1/igt@kms_frontbuffer_track...@psr-1p-primscrn-shrfb-plflip-blt.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes: - shard-apl: [PASS][16] -> [DMESG-WARN][17] ([fdo#108566]) +1 similar issue [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl5/igt@kms_pl...@plane-panning-bottom-right-suspend-pipe-a-planes.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13855/shard-apl3/igt@kms_pl...@plane-panning-bottom-right-suspend-pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][18] -> [FAIL][19] ([fdo#108145]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13855/shard-skl1/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][20] -> [SKIP][21] ([fdo#109441]) +2 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [21]:
Re: [Intel-gfx] [PATCH v6 01/24] drm: Add ddc link in sysfs created by drm_connector
Hi Andrzej,
Thank you for the patch, and sorry for the late review (I've been
travelling for the past few weeks).
On Fri, Jul 26, 2019 at 07:22:55PM +0200, Andrzej Pietrasiewicz wrote:
> Add generic code which creates symbolic links in sysfs, pointing to ddc
> interface used by a particular video output. For example:
>
> ls -l /sys/class/drm/card0-HDMI-A-1/ddc
> lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \
> -> ../../../../soc/1388.i2c/i2c-2
>
> This makes it easy for user to associate a display with its ddc adapter
> and use e.g. ddcutil to control the chosen monitor.
>
> This patch adds an i2c_adapter pointer to struct drm_connector. Particular
> drivers can then use it instead of using their own private instance. If a
> connector contains a ddc, then create a symbolic link in sysfs.
>
> Signed-off-by: Andrzej Pietrasiewicz
> Acked-by: Daniel Vetter
> Reviewed-by: Andrzej Hajda
> ---
> drivers/gpu/drm/drm_sysfs.c | 8
> include/drm/drm_connector.h | 11 +++
> 2 files changed, 19 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
> index ad10810bc972..e962a9d45f7e 100644
> --- a/drivers/gpu/drm/drm_sysfs.c
> +++ b/drivers/gpu/drm/drm_sysfs.c
> @@ -14,6 +14,7 @@
> #include
> #include
> #include
> +#include
> #include
> #include
>
> @@ -294,6 +295,9 @@ int drm_sysfs_connector_add(struct drm_connector
> *connector)
> /* Let userspace know we have a new connector */
> drm_sysfs_hotplug_event(dev);
>
> + if (connector->ddc)
> + return sysfs_create_link(>kdev->kobj,
> + >ddc->dev.kobj, "ddc");
> return 0;
> }
>
> @@ -301,6 +305,10 @@ void drm_sysfs_connector_remove(struct drm_connector
> *connector)
> {
> if (!connector->kdev)
> return;
> +
> + if (connector->ddc)
> + sysfs_remove_link(>kdev->kobj, "ddc");
> +
> DRM_DEBUG("removing \"%s\" from sysfs\n",
> connector->name);
>
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index 4c30d751487a..33a6fff85fdb 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -41,6 +41,7 @@ struct drm_property;
> struct drm_property_blob;
> struct drm_printer;
> struct edid;
> +struct i2c_adapter;
>
> enum drm_connector_force {
> DRM_FORCE_UNSPECIFIED,
> @@ -1311,6 +1312,16 @@ struct drm_connector {
>* [0]: progressive, [1]: interlaced
>*/
> int audio_latency[2];
> +
> + /**
> + * @ddc: associated ddc adapter.
> + * A connector usually has its associated ddc adapter. If a driver uses
> + * this field, then an appropriate symbolic link is created in connector
> + * sysfs directory to make it easy for the user to tell which i2c
> + * adapter is for a particular display.
The first sentence isn't very clear. The rest is mixing "ddc adapter"
and "i2c adapter". How about the following ?
"When the connector carries DDC signals, this field points to the I2C
adapter connected to the DDC signals, if any. When this field is not
NULL a symbolic link is created in the connector's sysfs directory to
expose the I2C adapter used by the connector."
Should we also mention that the field isn't meant to be set directly,
but shall be set with drm_connector_init_with_ddc() ?
"This field shall not be set directly by drivers, use
drm_connector_init_with_ddc() instead."
I'm also slightly concerned about the lifetime of this pointer, and what
would happen if the I2C adapter disappears while the connector is still
exposed to userspace, but I suppose this isn't a new issue, existing
code likely suffers from this.
With the updated documentation,
Reviewed-by: Laurent Pinchart
> + */
> + struct i2c_adapter *ddc;
> +
> /**
>* @null_edid_counter: track sinks that give us all zeros for the EDID.
>* Needed to workaround some HW bugs where we get all 0s
--
Regards,
Laurent Pinchart
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/syncobj: Convert syncobj_idr to XArray
== Series Details == Series: series starting with [1/2] drm/syncobj: Convert syncobj_idr to XArray URL : https://patchwork.freedesktop.org/series/64620/ State : success == Summary == CI Bug Log - changes from CI_DRM_6618_full -> Patchwork_13854_full Summary --- **SUCCESS** No regressions found. Known issues Here are the changes found in Patchwork_13854_full that come from known issues: ### IGT changes ### Issues hit * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-glk: [PASS][1] -> [FAIL][2] ([fdo#105363]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-glk4/igt@kms_f...@flip-vs-expired-vblank-interruptible.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13854/shard-glk1/igt@kms_f...@flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite: - shard-iclb: [PASS][3] -> [FAIL][4] ([fdo#103167]) +6 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb4/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13854/shard-iclb4/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt: - shard-skl: [PASS][5] -> [FAIL][6] ([fdo#103167]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@kms_frontbuffer_track...@psr-1p-primscrn-shrfb-plflip-blt.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13854/shard-skl9/igt@kms_frontbuffer_track...@psr-1p-primscrn-shrfb-plflip-blt.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: - shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +5 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl7/igt@kms_pipe_crc_ba...@suspend-read-crc-pipe-b.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13854/shard-apl4/igt@kms_pipe_crc_ba...@suspend-read-crc-pipe-b.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][9] -> [FAIL][10] ([fdo#108145]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13854/shard-skl9/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103166]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb2/igt@kms_plane_low...@pipe-a-tiling-x.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13854/shard-iclb4/igt@kms_plane_low...@pipe-a-tiling-x.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109441]) +2 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13854/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_setmode@basic: - shard-apl: [PASS][15] -> [FAIL][16] ([fdo#99912]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl4/igt@kms_setm...@basic.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13854/shard-apl2/igt@kms_setm...@basic.html Possible fixes * igt@gem_eio@reset-stress: - shard-skl: [FAIL][17] ([fdo#109661]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@gem_...@reset-stress.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13854/shard-skl9/igt@gem_...@reset-stress.html * igt@gem_tiled_swapping@non-threaded: - shard-apl: [DMESG-WARN][19] ([fdo#108686]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl2/igt@gem_tiled_swapp...@non-threaded.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13854/shard-apl3/igt@gem_tiled_swapp...@non-threaded.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [DMESG-WARN][21] ([fdo#108566]) -> [PASS][22] +2 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl7/igt@i915_susp...@fence-restore-tiled2untiled.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13854/shard-apl4/igt@i915_susp...@fence-restore-tiled2untiled.html * igt@kms_cursor_edge_walk@pipe-b-64x64-top-edge: - shard-iclb: [INCOMPLETE][23] ([fdo#107713]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb4/igt@kms_cursor_edge_w...@pipe-b-64x64-top-edge.html [24]:
[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Flush any deferred RCU cleanup before switching off GEM (rev2)
== Series Details == Series: drm/i915: Flush any deferred RCU cleanup before switching off GEM (rev2) URL : https://patchwork.freedesktop.org/series/64612/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6615_full -> Patchwork_13852_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_13852_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_13852_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_13852_full: ### IGT changes ### Possible regressions * igt@i915_selftest@live_hugepages: - shard-skl: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6615/shard-skl4/igt@i915_selftest@live_hugepages.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13852/shard-skl3/igt@i915_selftest@live_hugepages.html Known issues Here are the changes found in Patchwork_13852_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_ctx_isolation@bcs0-s3: - shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +3 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6615/shard-kbl4/igt@gem_ctx_isolat...@bcs0-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13852/shard-kbl4/igt@gem_ctx_isolat...@bcs0-s3.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110854]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6615/shard-iclb4/igt@gem_exec_balan...@smoke.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13852/shard-iclb7/igt@gem_exec_balan...@smoke.html * igt@i915_pm_rpm@i2c: - shard-hsw: [PASS][7] -> [FAIL][8] ([fdo#104097]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6615/shard-hsw6/igt@i915_pm_...@i2c.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13852/shard-hsw2/igt@i915_pm_...@i2c.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6615/shard-apl8/igt@i915_susp...@fence-restore-tiled2untiled.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13852/shard-apl7/igt@i915_susp...@fence-restore-tiled2untiled.html * igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen: - shard-iclb: [PASS][11] -> [INCOMPLETE][12] ([fdo#107713]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6615/shard-iclb4/igt@kms_cursor_...@pipe-a-cursor-128x42-offscreen.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13852/shard-iclb7/igt@kms_cursor_...@pipe-a-cursor-128x42-offscreen.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [PASS][13] -> [FAIL][14] ([fdo#102670]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6615/shard-skl5/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13852/shard-skl6/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [PASS][15] -> [FAIL][16] ([fdo#105363]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6615/shard-skl1/igt@kms_f...@flip-vs-expired-vblank.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13852/shard-skl2/igt@kms_f...@flip-vs-expired-vblank.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-hsw: [PASS][17] -> [INCOMPLETE][18] ([fdo#103540]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6615/shard-hsw2/igt@kms_f...@flip-vs-suspend-interruptible.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13852/shard-hsw5/igt@kms_f...@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render: - shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#103167]) +5 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6615/shard-iclb3/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13852/shard-iclb2/igt@kms_frontbuffer_track...@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt: - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#103167]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6615/shard-skl9/igt@kms_frontbuffer_track...@psr-1p-primscrn-shrfb-plflip-blt.html [22]:
