Re: [Intel-gfx] [PATCH v5] vfio/pci: Add support for opregion v2.1+
On 2021.03.26 01:09:53 +0800, Fred Gao wrote:
> Before opregion version 2.0 VBT data is stored in opregion mailbox #4,
> but when VBT data exceeds 6KB size and cannot be within mailbox #4
> then from opregion v2.0+, Extended VBT region, next to opregion is
> used to hold the VBT data, so the total size will be opregion size plus
> extended VBT region size.
>
> Since opregion v2.0 with physical host VBT address would not be
> practically available for end user and guest can not directly access
> host physical address, so it is not supported.
>
> Cc: Zhenyu Wang
> Signed-off-by: Swee Yee Fonn
> Signed-off-by: Fred Gao
> ---
Reviewed-by: Zhenyu Wang
Hi, Alex, pls let us know if you have other concern to merge this one.
Thanks!
> drivers/vfio/pci/vfio_pci_igd.c | 53 +
> 1 file changed, 53 insertions(+)
>
> diff --git a/drivers/vfio/pci/vfio_pci_igd.c b/drivers/vfio/pci/vfio_pci_igd.c
> index e66dfb0178ed..228df565e9bc 100644
> --- a/drivers/vfio/pci/vfio_pci_igd.c
> +++ b/drivers/vfio/pci/vfio_pci_igd.c
> @@ -21,6 +21,10 @@
> #define OPREGION_SIZE(8 * 1024)
> #define OPREGION_PCI_ADDR0xfc
>
> +#define OPREGION_RVDA0x3ba
> +#define OPREGION_RVDS0x3c2
> +#define OPREGION_VERSION 0x16
> +
> static size_t vfio_pci_igd_rw(struct vfio_pci_device *vdev, char __user *buf,
> size_t count, loff_t *ppos, bool iswrite)
> {
> @@ -58,6 +62,7 @@ static int vfio_pci_igd_opregion_init(struct
> vfio_pci_device *vdev)
> u32 addr, size;
> void *base;
> int ret;
> + u16 version;
>
> ret = pci_read_config_dword(vdev->pdev, OPREGION_PCI_ADDR, &addr);
> if (ret)
> @@ -83,6 +88,54 @@ static int vfio_pci_igd_opregion_init(struct
> vfio_pci_device *vdev)
>
> size *= 1024; /* In KB */
>
> + /*
> + * Support opregion v2.1+
> + * When VBT data exceeds 6KB size and cannot be within mailbox #4, then
> + * the Extended VBT region next to opregion is used to hold the VBT
> data.
> + * RVDA (Relative Address of VBT Data from Opregion Base) and RVDS
> + * (Raw VBT Data Size) from opregion structure member are used to hold
> the
> + * address from region base and size of VBT data. RVDA/RVDS are not
> + * defined before opregion 2.0.
> + *
> + * opregion 2.1+: RVDA is unsigned, relative offset from
> + * opregion base, and should point to the end of opregion.
> + * otherwise, exposing to userspace to allow read access to everything
> between
> + * the OpRegion and VBT is not safe.
> + * RVDS is defined as size in bytes.
> + *
> + * opregion 2.0: rvda is the physical VBT address.
> + * Since rvda is HPA it cannot be directly used in guest.
> + * And it should not be practically available for end user,so it is not
> supported.
> + */
> + version = le16_to_cpu(*(__le16 *)(base + OPREGION_VERSION));
> + if (version >= 0x0200) {
> + u64 rvda;
> + u32 rvds;
> +
> + rvda = le64_to_cpu(*(__le64 *)(base + OPREGION_RVDA));
> + rvds = le32_to_cpu(*(__le32 *)(base + OPREGION_RVDS));
> + if (rvda && rvds) {
> + /* no support for opregion v2.0 with physical VBT
> address */
> + if (version == 0x0200) {
> + memunmap(base);
> + pci_err(vdev->pdev,
> + "IGD assignment does not support
> opregion v2.0 with an extended VBT region\n");
> + return -EINVAL;
> + }
> +
> + if (rvda != size) {
> + memunmap(base);
> + pci_err(vdev->pdev,
> + "Extended VBT does not follow opregion
> on version 0x%04x\n",
> + version);
> + return -EINVAL;
> + }
> +
> + /* region size for opregion v2.0+: opregion and VBT
> size. */
> + size += rvds;
> + }
> + }
> +
> if (size != OPREGION_SIZE) {
> memunmap(base);
> base = memremap(addr, size, MEMREMAP_WB);
> --
> 2.24.1.1.gb6d4d82bd5
>
signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v3 12/16] drm/i915/uapi: introduce drm_i915_gem_create_ext
On 28/03/2021 23:57, Daniele Ceraolo Spurio wrote:
From: Bommu Krishnaiah
Same old gem_create but with now with extensions support. This is needed
to support various upcoming usecases. For now we use the extensions
mechanism to support PAVP.
Signed-off-by: Bommu Krishnaiah
Signed-off-by: Matthew Auld
Cc: Joonas Lahtinen
Cc: Matthew Auld
Cc: Telukuntla Sreedhar
---
drivers/gpu/drm/i915/gem/i915_gem_create.c | 41 ++-
drivers/gpu/drm/i915/i915_drv.c| 2 +-
include/uapi/drm/i915_drm.h| 47 ++
3 files changed, 88 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_create.c
b/drivers/gpu/drm/i915/gem/i915_gem_create.c
index 45d60e3d98e3..3ad3413c459f 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_create.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_create.c
@@ -7,6 +7,7 @@
#include "gem/i915_gem_region.h"
#include "i915_drv.h"
+#include "i915_user_extensions.h"
static int
i915_gem_create(struct drm_file *file,
@@ -91,6 +92,35 @@ i915_gem_dumb_create(struct drm_file *file,
&args->size, &args->handle);
}
+struct create_ext {
+ struct drm_i915_private *i915;
+};
+
+static int __create_setparam(struct drm_i915_gem_object_param *args,
+struct create_ext *ext_data)
+{
+ if (!(args->param & I915_OBJECT_PARAM)) {
+ DRM_DEBUG("Missing I915_OBJECT_PARAM namespace\n");
+ return -EINVAL;
+ }
+
+ return -EINVAL;
+}
+
+static int create_setparam(struct i915_user_extension __user *base, void *data)
+{
+ struct drm_i915_gem_create_ext_setparam ext;
+
+ if (copy_from_user(&ext, base, sizeof(ext)))
+ return -EFAULT;
+
+ return __create_setparam(&ext.param, data);
+}
+
+static const i915_user_extension_fn create_extensions[] = {
+ [I915_GEM_CREATE_EXT_SETPARAM] = create_setparam,
+};
+
/**
* Creates a new mm object and returns a handle to it.
* @dev: drm device pointer
@@ -102,10 +132,19 @@ i915_gem_create_ioctl(struct drm_device *dev, void *data,
struct drm_file *file)
{
struct drm_i915_private *i915 = to_i915(dev);
- struct drm_i915_gem_create *args = data;
+ struct create_ext ext_data = { .i915 = i915 };
+ struct drm_i915_gem_create_ext *args = data;
+ int ret;
i915_gem_flush_free_objects(i915);
+ ret = i915_user_extensions(u64_to_user_ptr(args->extensions),
+ create_extensions,
+ ARRAY_SIZE(create_extensions),
+ &ext_data);
+ if (ret)
+ return ret;
+
return i915_gem_create(file,
intel_memory_region_by_type(i915,
INTEL_MEMORY_SYSTEM),
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 02d5b2b6ee39..f13e1ca2087b 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1707,7 +1707,7 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
DRM_IOCTL_DEF_DRV(I915_GEM_THROTTLE, i915_gem_throttle_ioctl,
DRM_RENDER_ALLOW),
DRM_IOCTL_DEF_DRV(I915_GEM_ENTERVT, drm_noop,
DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
DRM_IOCTL_DEF_DRV(I915_GEM_LEAVEVT, drm_noop,
DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
- DRM_IOCTL_DEF_DRV(I915_GEM_CREATE, i915_gem_create_ioctl,
DRM_RENDER_ALLOW),
+ DRM_IOCTL_DEF_DRV(I915_GEM_CREATE_EXT, i915_gem_create_ioctl,
DRM_RENDER_ALLOW),
DRM_IOCTL_DEF_DRV(I915_GEM_PREAD, i915_gem_pread_ioctl,
DRM_RENDER_ALLOW),
DRM_IOCTL_DEF_DRV(I915_GEM_PWRITE, i915_gem_pwrite_ioctl,
DRM_RENDER_ALLOW),
DRM_IOCTL_DEF_DRV(I915_GEM_MMAP, i915_gem_mmap_ioctl, DRM_RENDER_ALLOW),
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index 7a2088eccc9f..d5e502269a55 100644
--- a/include/uapi/drm/i915_drm.h
+++ b/include/uapi/drm/i915_drm.h
@@ -392,6 +392,7 @@ typedef struct _drm_i915_sarea {
#define DRM_IOCTL_I915_GEM_ENTERVTDRM_IO(DRM_COMMAND_BASE +
DRM_I915_GEM_ENTERVT)
#define DRM_IOCTL_I915_GEM_LEAVEVTDRM_IO(DRM_COMMAND_BASE +
DRM_I915_GEM_LEAVEVT)
#define DRM_IOCTL_I915_GEM_CREATE DRM_IOWR(DRM_COMMAND_BASE +
DRM_I915_GEM_CREATE, struct drm_i915_gem_create)
+#define DRM_IOCTL_I915_GEM_CREATE_EXT DRM_IOWR(DRM_COMMAND_BASE +
DRM_I915_GEM_CREATE, struct drm_i915_gem_create_ext)
#define DRM_IOCTL_I915_GEM_PREAD DRM_IOW (DRM_COMMAND_BASE +
DRM_I915_GEM_PREAD, struct drm_i915_gem_pread)
#define DRM_IOCTL_I915_GEM_PWRITE DRM_IOW (DRM_COMMAND_BASE +
DRM_I915_GEM_PWRITE, struct drm_i915_gem_pwrite)
#define DRM_IOCTL_I915_GEM_MMAP DRM_IOWR(DRM_COMMAND_BASE +
DRM_I915_GEM_MMAP, struct drm_i915_gem_mmap)
@@ -729,6 +730,27 @@ struct drm_i915_gem_create {
__u32 pad;
};
+struct drm_i915_gem_crea
Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/3] lib: Add helper for reading modparam values
On Thu, 18 Mar 2021 at 16:24, Tvrtko Ursulin
wrote:
>
> From: Tvrtko Ursulin
>
> Add __igt_params_get for simple reading of modparams.
>
> Signed-off-by: Tvrtko Ursulin
> ---
> lib/igt_params.c | 26 ++
> lib/igt_params.h | 2 ++
> 2 files changed, 28 insertions(+)
>
> diff --git a/lib/igt_params.c b/lib/igt_params.c
> index c06416988baa..1dc6de77b2e0 100644
> --- a/lib/igt_params.c
> +++ b/lib/igt_params.c
> @@ -156,6 +156,32 @@ int igt_params_open(int device)
> return params;
> }
>
> +/**
> + * __igt_params_get:
> + * @device: fd of the device
> + * @parameter: the name of the parameter to set
to get
> + *
> + * This reads the value of the modparam.
> + *
> + * Returns:
> + * A nul-terminated string, must be freed by caller after use, or NULL
> + * on failure.
> + */
> +char *__igt_params_get(int device, const char *parameter)
> +{
> + char *str;
> + int dir;
> +
> + dir = igt_params_open(device);
> + if (dir < 0)
> + return NULL;
> +
> + str = igt_sysfs_get(dir, parameter);
> + close(dir);
> +
> + return str;
> +}
Reviewed-by: Matthew Auld
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning
Hi,
On 3/22/21 5:02 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> gcc-11 warns that intel_dp_check_mst_status() has a local array of
> fourteen bytes and passes the last four bytes into a function that
> expects a six-byte array:
>
> drivers/gpu/drm/i915/display/intel_dp.c: In function
> ‘intel_dp_check_mst_status’:
> drivers/gpu/drm/i915/display/intel_dp.c:4556:22: error:
> ‘drm_dp_channel_eq_ok’ reading 6 bytes from a region of size 4
> [-Werror=stringop-overread]
> 4556 | !drm_dp_channel_eq_ok(&esi[10],
> intel_dp->lane_count)) {
> |
> ^~~~
> drivers/gpu/drm/i915/display/intel_dp.c:4556:22: note: referencing argument 1
> of type ‘const u8 *’ {aka ‘const unsigned char *’}
> In file included from drivers/gpu/drm/i915/display/intel_dp.c:38:
> include/drm/drm_dp_helper.h:1459:6: note: in a call to function
> ‘drm_dp_channel_eq_ok’
> 1459 | bool drm_dp_channel_eq_ok(const u8 link_status[DP_LINK_STATUS_SIZE],
> | ^~~~
>
> Clearly something is wrong here, but I can't quite figure out what.
> Changing the array size to 16 bytes avoids the warning, but is
> probably the wrong solution here.
The drm displayport-helpers indeed expect a 6 bytes buffer, but they
usually only consume 4 bytes.
I don't think that changing the DP_DPRX_ESI_LEN is a good fix here,
since it is used in multiple places, but the esi array already gets
zero-ed out by its initializer, so we can just pass 2 extra 0 bytes
to give drm_dp_channel_eq_ok() call the 6 byte buffer its prototype
specifies by doing this:
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index 897711d9d7d3..147962d4ad06 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4538,7 +4538,11 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
drm_WARN_ON_ONCE(&i915->drm, intel_dp->active_mst_links < 0);
for (;;) {
- u8 esi[DP_DPRX_ESI_LEN] = {};
+ /*
+* drm_dp_channel_eq_ok() expects a 6 byte large buffer, but
+* the ESI info only contains 4 bytes, pass 2 extra 0 bytes.
+*/
+ u8 esi[DP_DPRX_ESI_LEN + 2] = {};
bool handled;
int retry;
So i915 devs, would such a fix be acceptable ?
Regards,
Hans
>
> Signed-off-by: Arnd Bergmann
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 8c12d5375607..830e2515f119 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -65,7 +65,7 @@
> #include "intel_vdsc.h"
> #include "intel_vrr.h"
>
> -#define DP_DPRX_ESI_LEN 14
> +#define DP_DPRX_ESI_LEN 16
>
> /* DP DSC throughput values used for slice count calculations KPixels/s */
> #define DP_DSC_PEAK_PIXEL_RATE 272
>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.BUILD: failure for treewide: address gcc-11 -Wstringop-overread warnings (rev4)
== Series Details == Series: treewide: address gcc-11 -Wstringop-overread warnings (rev4) URL : https://patchwork.freedesktop.org/series/88295/ State : failure == Summary == Applying: x86: compressed: avoid gcc-11 -Wstringop-overread warning Applying: x86: tboot: avoid Wstringop-overread-warning error: corrupt patch at line 14 error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0002 x86: tboot: avoid Wstringop-overread-warning When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 06/11] cgroup: fix -Wzero-length-bounds warnings
On Mon, Mar 22, 2021 at 05:02:44PM +0100, Arnd Bergmann wrote: > I'm not sure what is expected to happen for such a configuration, > presumably these functions are never calls in that case. Yes, the functions you patched would only be called from subsystems or there should be no way to obtain a struct cgroup_subsys reference anyway (hence it's ok to always branch as if ss==NULL). I'd prefer a variant that wouldn't compile the affected codepaths when there are no subsystems registered, however, I couldn't come up with a way how to do it without some preprocessor ugliness. Reviewed-by: Michal Koutný signature.asc Description: Digital signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/i915: Default fence expiry test
On Thu, 18 Mar 2021 at 16:24, Tvrtko Ursulin
wrote:
>
> From: Tvrtko Ursulin
>
> Basic test to check that default fence expiry works as expected.
>
> Relies on the modparam to run quicker.
>
> Signed-off-by: Tvrtko Ursulin
> ---
> tests/Makefile.sources| 3 +
> tests/i915/gem_watchdog.c | 376 ++
> tests/meson.build | 1 +
> 3 files changed, 380 insertions(+)
> create mode 100644 tests/i915/gem_watchdog.c
>
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 4f24fb3a15a5..e992285fedc5 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -463,6 +463,9 @@ gem_userptr_blits_SOURCES = i915/gem_userptr_blits.c
> TESTS_progs += gem_wait
> gem_wait_SOURCES = i915/gem_wait.c
>
> +TESTS_progs += gem_watchdog
> +gem_exec_watchdog_SOURCES = i915/gem_watchdog.c
> +
> TESTS_progs += gem_workarounds
> gem_workarounds_SOURCES = i915/gem_workarounds.c
>
> diff --git a/tests/i915/gem_watchdog.c b/tests/i915/gem_watchdog.c
> new file mode 100644
> index ..f86d3d4c7437
> --- /dev/null
> +++ b/tests/i915/gem_watchdog.c
> @@ -0,0 +1,376 @@
> +/*
> + * Copyright © 2021 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +#include "config.h"
> +
> +#include
> +#include
> +#include
> +
> +#include "i915/gem.h"
> +#include "igt.h"
> +#include "igt_params.h"
> +#include "sw_sync.h"
> +
> +#define EWATCHDOG EINTR
> +
> +static struct drm_i915_query_engine_info *__engines__;
> +
> +static int __i915_query(int fd, struct drm_i915_query *q)
> +{
> + if (igt_ioctl(fd, DRM_IOCTL_I915_QUERY, q))
> + return -errno;
> + return 0;
> +}
> +
> +static int
> +__i915_query_items(int fd, struct drm_i915_query_item *items, uint32_t
> n_items)
> +{
> + struct drm_i915_query q = {
> + .num_items = n_items,
> + .items_ptr = to_user_pointer(items),
> + };
> + return __i915_query(fd, &q);
> +}
> +
> +#define i915_query_items(fd, items, n_items) do { \
> + igt_assert_eq(__i915_query_items(fd, items, n_items), 0); \
> + errno = 0; \
> + } while (0)
> +
> +static unsigned int default_timeout_wait_s;
> +static const unsigned int watchdog_us = 500 * 1000;
> +
> +static unsigned int
> +wait_timeout(int i915, igt_spin_t **spin, unsigned int num_engines,
> +unsigned int wait_us, unsigned int expect)
> +{
> + unsigned int count_idle = 0, count_fence = 0, count_started = 0, i;
> + bool started[num_engines];
> +
> + memset(started, 0, sizeof(started));
> +
> + while (count_started < num_engines) {
> + for (i = 0; i < num_engines; i++) {
> + if (started[i])
> + continue;
> +
> + if (igt_spin_has_started(spin[i])) {
> + started[i] = true;
> + count_started++;
> + }
> + }
> + }
for_each {
igt_spin_busywait_until_started(spin[i])
}
Might be slightly simpler?
Reviewed-by: Matthew Auld
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active()
Fix the
Documentation/gpu/i915:22: /drivers/gpu/drm/i915/intel_runtime_pm.c:423:
WARNING: Inline strong start-string without end-string.
warning from the htmldocs build.
Fixes: 9d58aa46291d ("drm/i915: Fix the GT fence revocation runtime PM logic")
Reported-by: Stephen Rothwell
Cc: Chris Wilson
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
b/drivers/gpu/drm/i915/intel_runtime_pm.c
index dba8df1ff5a9e..eaf7688f517d0 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -420,7 +420,7 @@ intel_wakeref_t intel_runtime_pm_get(struct
intel_runtime_pm *rpm)
* already active and ensures that it is powered up. It is illegal to try
* and access the HW should intel_runtime_pm_get_if_active() report failure.
*
- * If @ignore_usecount=true, a reference will be acquired even if there is no
+ * If @ignore_usecount is true, a reference will be acquired even if there is
no
* user requiring the device to be powered up (dev->power.usage_count == 0).
* If the function returns false in this case then it's guaranteed that the
* device's runtime suspend hook has been called already or that it will be
--
2.27.0
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915/pmu: Do not report 100% RC6 if not supported
From: Tvrtko Ursulin
We use GT parked status to estimate RC6 while not in use, however if RC6
is not supported to start with that does not work very well and produces a
false 100% RC6 readout.
Fix by not advancing the estimated RC6 counter when feature is not
supported.
Signed-off-by: Tvrtko Ursulin
Fixes: 1fe699e30113 ("drm/i915/pmu: Fix sleep under atomic in RC6 readout")
Reported-by: Eero T Tamminen
---
drivers/gpu/drm/i915/i915_pmu.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
index 41651ac255fa..02fe0d22c470 100644
--- a/drivers/gpu/drm/i915/i915_pmu.c
+++ b/drivers/gpu/drm/i915/i915_pmu.c
@@ -191,7 +191,10 @@ static u64 get_rc6(struct intel_gt *gt)
* on top of the last known real value, as the approximated RC6
* counter value.
*/
- val = ktime_since_raw(pmu->sleep_last);
+ if (gt->rc6.supported)
+ val = ktime_since_raw(pmu->sleep_last);
+ else
+ val = 0;
val += pmu->sample[__I915_SAMPLE_RC6].cur;
}
--
2.27.0
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active()
== Series Details == Series: drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active() URL : https://patchwork.freedesktop.org/series/88579/ State : warning == Summary == $ dim checkpatch origin/drm-tip 74c8738d1c0b drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active() -:9: WARNING:USE_RELATIVE_PATH: use relative pathname instead of absolute in changelog text #9: Documentation/gpu/i915:22: /drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string. total: 0 errors, 1 warnings, 0 checks, 8 lines checked ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active()
== Series Details == Series: drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active() URL : https://patchwork.freedesktop.org/series/88579/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/3] tests/i915/gem_watchdog: Exercise long rendering chains
On Thu, 18 Mar 2021 at 16:24, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Test to demonstrate a problem with the proposed default fence expiry > semantics where long rendering chain get silently broken. > > If we had fence error propagation (no clear agreement whether to do it or > not) maybe userspace would see if, assuming fence status is looked at, but > overall potential rendering corruption is the story in any case. > > Note that this is not a single long batch but just a long queue of work > which. Could be viewed as heavy system load as well (like virtualisation > or other types of resource sharing). > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active()
== Series Details ==
Series: drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active()
URL : https://patchwork.freedesktop.org/series/88579/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9915 -> Patchwork_19880
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/index.html
Possible new issues
---
Here are the unknown changes that may have been introduced in Patchwork_19880:
### IGT changes ###
Suppressed
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@core_hotunplug@unbind-rebind:
- {fi-tgl-dsi}: [PASS][1] -> [DMESG-WARN][2]
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-tgl-dsi/igt@core_hotunp...@unbind-rebind.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/fi-tgl-dsi/igt@core_hotunp...@unbind-rebind.html
Known issues
Here are the changes found in Patchwork_19880 that come from known issues:
### IGT changes ###
Issues hit
* igt@amdgpu/amd_basic@query-info:
- fi-tgl-u2: NOTRUN -> [SKIP][3] ([fdo#109315])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/fi-tgl-u2/igt@amdgpu/amd_ba...@query-info.html
* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-tgl-u2: NOTRUN -> [SKIP][4] ([fdo#109315] / [i915#2575]) +16
similar issues
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/fi-tgl-u2/igt@amdgpu/amd_cs_...@fork-compute0.html
* igt@gem_huc_copy@huc-copy:
- fi-tgl-u2: NOTRUN -> [SKIP][5] ([i915#2190])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/fi-tgl-u2/igt@gem_huc_c...@huc-copy.html
* igt@kms_chamelium@dp-hpd-fast:
- fi-tgl-u2: NOTRUN -> [SKIP][6] ([fdo#109284] / [fdo#111827]) +8
similar issues
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/fi-tgl-u2/igt@kms_chamel...@dp-hpd-fast.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-u2: NOTRUN -> [SKIP][7] ([fdo#109285])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/fi-tgl-u2/igt@kms_force_connector_ba...@force-load-detect.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-u2: NOTRUN -> [SKIP][8] ([i915#3301])
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/fi-tgl-u2/igt@prime_v...@basic-userptr.html
* igt@prime_vgem@basic-write:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#402])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-tgl-y/igt@prime_v...@basic-write.html
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/fi-tgl-y/igt@prime_v...@basic-write.html
Possible fixes
* igt@prime_vgem@basic-read:
- fi-tgl-y: [DMESG-WARN][11] ([i915#402]) -> [PASS][12] +1
similar issue
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-tgl-y/igt@prime_v...@basic-read.html
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/fi-tgl-y/igt@prime_v...@basic-read.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (43 -> 40)
--
Additional (1): fi-tgl-u2
Missing(4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-
* Linux: CI_DRM_9915 -> Patchwork_19880
CI-20190529: 20190529
CI_DRM_9915: d649c4056f6466b84ec22786985908d377893f85 @
git://anongit.freedesktop.org/gfx-ci/linux
IGT_6048: 8231f28f49255b8a71777351830c18fb7a7c6171 @
git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19880: 74c8738d1c0b6bea438c8a7ad0edbde5540354b8 @
git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
74c8738d1c0b drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active()
== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/index.html
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/pmu: Do not report 100% RC6 if not supported
== Series Details == Series: drm/i915/pmu: Do not report 100% RC6 if not supported URL : https://patchwork.freedesktop.org/series/88580/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' /home/cidrm/kernel/Documentation/gpu/i915:22: ./drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 1/2] drm/i915: Split out glk_plane_min_cdclk()
From: Ville Syrjälä
Split the glk+ stuff into it's own version of the .min_cdclk()
vfunc.
Signed-off-by: Ville Syrjälä
---
.../drm/i915/display/skl_universal_plane.c| 53 ---
1 file changed, 35 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 7ffd7b570b54..5127489a0446 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -287,21 +287,41 @@ bool icl_is_hdr_plane(struct drm_i915_private *dev_priv,
enum plane_id plane_id)
}
static void
-skl_plane_ratio(const struct intel_crtc_state *crtc_state,
- const struct intel_plane_state *plane_state,
+glk_plane_ratio(const struct intel_plane_state *plane_state,
unsigned int *num, unsigned int *den)
{
- struct drm_i915_private *dev_priv =
to_i915(plane_state->uapi.plane->dev);
const struct drm_framebuffer *fb = plane_state->hw.fb;
if (fb->format->cpp[0] == 8) {
- if (DISPLAY_VER(dev_priv) >= 10) {
- *num = 10;
- *den = 8;
- } else {
- *num = 9;
- *den = 8;
- }
+ *num = 10;
+ *den = 8;
+ } else {
+ *num = 1;
+ *den = 1;
+ }
+}
+
+static int glk_plane_min_cdclk(const struct intel_crtc_state *crtc_state,
+ const struct intel_plane_state *plane_state)
+{
+ unsigned int pixel_rate = intel_plane_pixel_rate(crtc_state,
plane_state);
+ unsigned int num, den;
+
+ glk_plane_ratio(plane_state, &num, &den);
+
+ /* two pixels per clock */
+ return DIV_ROUND_UP(pixel_rate * num, 2 * den);
+}
+
+static void
+skl_plane_ratio(const struct intel_plane_state *plane_state,
+ unsigned int *num, unsigned int *den)
+{
+ const struct drm_framebuffer *fb = plane_state->hw.fb;
+
+ if (fb->format->cpp[0] == 8) {
+ *num = 9;
+ *den = 8;
} else {
*num = 1;
*den = 1;
@@ -311,15 +331,10 @@ skl_plane_ratio(const struct intel_crtc_state *crtc_state,
static int skl_plane_min_cdclk(const struct intel_crtc_state *crtc_state,
const struct intel_plane_state *plane_state)
{
- struct drm_i915_private *dev_priv =
to_i915(plane_state->uapi.plane->dev);
- unsigned int num, den;
unsigned int pixel_rate = intel_plane_pixel_rate(crtc_state,
plane_state);
+ unsigned int num, den;
- skl_plane_ratio(crtc_state, plane_state, &num, &den);
-
- /* two pixels per clock on glk+ */
- if (DISPLAY_VER(dev_priv) >= 10)
- den *= 2;
+ skl_plane_ratio(plane_state, &num, &den);
return DIV_ROUND_UP(pixel_rate * num, den);
}
@@ -1965,12 +1980,15 @@ skl_universal_plane_create(struct drm_i915_private
*dev_priv,
plane->min_width = icl_plane_min_width;
plane->max_width = icl_plane_max_width;
plane->max_height = icl_plane_max_height;
+ plane->min_cdclk = glk_plane_min_cdclk;
} else if (DISPLAY_VER(dev_priv) >= 10) {
plane->max_width = glk_plane_max_width;
plane->max_height = skl_plane_max_height;
+ plane->min_cdclk = glk_plane_min_cdclk;
} else {
plane->max_width = skl_plane_max_width;
plane->max_height = skl_plane_max_height;
+ plane->min_cdclk = skl_plane_min_cdclk;
}
plane->max_stride = skl_plane_max_stride;
@@ -1978,7 +1996,6 @@ skl_universal_plane_create(struct drm_i915_private
*dev_priv,
plane->disable_plane = skl_disable_plane;
plane->get_hw_state = skl_plane_get_hw_state;
plane->check_plane = skl_plane_check;
- plane->min_cdclk = skl_plane_min_cdclk;
if (plane_id == PLANE_PRIMARY) {
plane->need_async_flip_disable_wa = IS_DISPLAY_RANGE(dev_priv,
--
2.26.2
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 2/2] drm/i915: Update plane ratio for icl+
From: Ville Syrjälä
According to bspec icl+ no longer need any extra cdclk guardband
for 64bpp formats. Make it so.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/skl_universal_plane.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 5127489a0446..098636c811a8 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -286,6 +286,15 @@ bool icl_is_hdr_plane(struct drm_i915_private *dev_priv,
enum plane_id plane_id)
icl_hdr_plane_mask() & BIT(plane_id);
}
+static int icl_plane_min_cdclk(const struct intel_crtc_state *crtc_state,
+ const struct intel_plane_state *plane_state)
+{
+ unsigned int pixel_rate = intel_plane_pixel_rate(crtc_state,
plane_state);
+
+ /* two pixels per clock */
+ return DIV_ROUND_UP(pixel_rate, 2);
+}
+
static void
glk_plane_ratio(const struct intel_plane_state *plane_state,
unsigned int *num, unsigned int *den)
@@ -1980,7 +1989,7 @@ skl_universal_plane_create(struct drm_i915_private
*dev_priv,
plane->min_width = icl_plane_min_width;
plane->max_width = icl_plane_max_width;
plane->max_height = icl_plane_max_height;
- plane->min_cdclk = glk_plane_min_cdclk;
+ plane->min_cdclk = icl_plane_min_cdclk;
} else if (DISPLAY_VER(dev_priv) >= 10) {
plane->max_width = glk_plane_max_width;
plane->max_height = skl_plane_max_height;
--
2.26.2
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Do not report 100% RC6 if not supported
== Series Details == Series: drm/i915/pmu: Do not report 100% RC6 if not supported URL : https://patchwork.freedesktop.org/series/88580/ State : success == Summary == CI Bug Log - changes from CI_DRM_9915 -> Patchwork_19881 Summary --- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/index.html Known issues Here are the changes found in Patchwork_19881 that come from known issues: ### IGT changes ### Issues hit * igt@amdgpu/amd_basic@query-info: - fi-tgl-u2: NOTRUN -> [SKIP][1] ([fdo#109315]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/fi-tgl-u2/igt@amdgpu/amd_ba...@query-info.html * igt@amdgpu/amd_cs_nop@fork-compute0: - fi-tgl-u2: NOTRUN -> [SKIP][2] ([fdo#109315] / [i915#2575]) +16 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/fi-tgl-u2/igt@amdgpu/amd_cs_...@fork-compute0.html * igt@gem_huc_copy@huc-copy: - fi-tgl-u2: NOTRUN -> [SKIP][3] ([i915#2190]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/fi-tgl-u2/igt@gem_huc_c...@huc-copy.html * igt@i915_pm_rpm@module-reload: - fi-kbl-guc: [PASS][4] -> [SKIP][5] ([fdo#109271]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-kbl-guc/igt@i915_pm_...@module-reload.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/fi-kbl-guc/igt@i915_pm_...@module-reload.html * igt@i915_selftest@live@sanitycheck: - fi-kbl-7500u: [PASS][6] -> [DMESG-WARN][7] ([i915#2605]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-kbl-7500u/igt@i915_selftest@l...@sanitycheck.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/fi-kbl-7500u/igt@i915_selftest@l...@sanitycheck.html * igt@kms_chamelium@dp-hpd-fast: - fi-tgl-u2: NOTRUN -> [SKIP][8] ([fdo#109284] / [fdo#111827]) +8 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/fi-tgl-u2/igt@kms_chamel...@dp-hpd-fast.html * igt@kms_force_connector_basic@force-load-detect: - fi-tgl-u2: NOTRUN -> [SKIP][9] ([fdo#109285]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/fi-tgl-u2/igt@kms_force_connector_ba...@force-load-detect.html * igt@prime_self_import@basic-with_one_bo_two_files: - fi-tgl-y: [PASS][10] -> [DMESG-WARN][11] ([i915#402]) +1 similar issue [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html * igt@prime_vgem@basic-userptr: - fi-tgl-u2: NOTRUN -> [SKIP][12] ([i915#3301]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/fi-tgl-u2/igt@prime_v...@basic-userptr.html Possible fixes * igt@prime_vgem@basic-read: - fi-tgl-y: [DMESG-WARN][13] ([i915#402]) -> [PASS][14] +1 similar issue [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-tgl-y/igt@prime_v...@basic-read.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/fi-tgl-y/igt@prime_v...@basic-read.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (43 -> 40) -- Additional (1): fi-tgl-u2 Missing(4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build changes - * Linux: CI_DRM_9915 -> Patchwork_19881 CI-20190529: 20190529 CI_DRM_9915: d649c4056f6466b84ec22786985908d377893f85 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6048: 8231f28f49255b8a71777351830c18fb7a7c6171 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19881: 70172722a3ae24af0d4b7868642ed1b51d50ce31 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 70172722a3ae drm/i915/pmu: Do not report 100% RC6 if not supported == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/index.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 17/18] vfio/mdev: Remove kobj from mdev_parent_ops->create()
On Tue, 23 Mar 2021 14:55:34 -0300 Jason Gunthorpe wrote: > The kobj here is a type-erased version of mdev_type, which is already > stored in the struct mdev_device being passed in. It was only ever used to > compute the type_group_id, which is now extracted directly from the mdev. > > Signed-off-by: Jason Gunthorpe > --- > drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +- > drivers/s390/cio/vfio_ccw_ops.c | 2 +- > drivers/s390/crypto/vfio_ap_ops.c | 2 +- > drivers/vfio/mdev/mdev_core.c | 2 +- > include/linux/mdev.h | 3 +-- > samples/vfio-mdev/mbochs.c| 2 +- > samples/vfio-mdev/mdpy.c | 2 +- > samples/vfio-mdev/mtty.c | 2 +- > 8 files changed, 8 insertions(+), 9 deletions(-) Reviewed-by: Cornelia Huck ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 18/18] vfio/mdev: Correct the function signatures for the mdev_type_attributes
On Tue, 23 Mar 2021 14:55:35 -0300 Jason Gunthorpe wrote: > The driver core standard is to pass in the properly typed object, the > properly typed attribute and the buffer data. It stems from the root > kobject method: > > ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *attr,..) > > Each subclass of kobject should provide their own function with the same > signature but more specific types, eg struct device uses: > > ssize_t (*show)(struct device *dev, struct device_attribute *attr,..) > > In this case the existing signature is: > > ssize_t (*show)(struct kobject *kobj, struct device *dev,..) > > Where kobj is a 'struct mdev_type *' and dev is 'mdev_type->parent->dev'. > > Change the mdev_type related sysfs attribute functions to: > > ssize_t (*show)(struct mdev_type *mtype, struct mdev_type_attribute > *attr,..) > > In order to restore type safety and match the driver core standard > > There are no current users of 'attr', but if it is ever needed it would be > hard to add in retroactively, so do it now. > > Signed-off-by: Jason Gunthorpe > --- > drivers/gpu/drm/i915/gvt/gvt.c| 21 +++-- > drivers/s390/cio/vfio_ccw_ops.c | 15 +-- > drivers/s390/crypto/vfio_ap_ops.c | 12 +++- > drivers/vfio/mdev/mdev_core.c | 14 -- > drivers/vfio/mdev/mdev_sysfs.c| 11 ++- > include/linux/mdev.h | 11 +++ > samples/vfio-mdev/mbochs.c| 26 +++--- > samples/vfio-mdev/mdpy.c | 24 ++-- > samples/vfio-mdev/mtty.c | 18 +- > 9 files changed, 90 insertions(+), 62 deletions(-) Reviewed-by: Cornelia Huck ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Skip display interruption setup when display is not available
On Mon, Mar 22, 2021 at 01:58:03PM -0700, José Roberto de Souza wrote:
> Return ealier in the functions doing interruption setup for GEN8+ also
> adding a warning in gen8_de_irq_handler() to let us know that
> something else is still missing.
>
> Cc: Ville Syrjälä
> Cc: Lucas De Marchi
Reviewed-by: Radhakrishna Sripada
> Signed-off-by: José Roberto de Souza
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_irq.c | 39 +++--
> 1 file changed, 32 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 44aed4cbf894..875829f8a190 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -2421,6 +2421,8 @@ gen8_de_irq_handler(struct drm_i915_private *dev_priv,
> u32 master_ctl)
> u32 iir;
> enum pipe pipe;
>
> + drm_WARN_ON_ONCE(&dev_priv->drm, !HAS_DISPLAY(dev_priv));
> +
> if (master_ctl & GEN8_DE_MISC_IRQ) {
> iir = intel_uncore_read(&dev_priv->uncore, GEN8_DE_MISC_IIR);
> if (iir) {
> @@ -3058,14 +3060,13 @@ static void cnp_display_clock_wa(struct
> drm_i915_private *dev_priv)
> }
> }
>
> -static void gen8_irq_reset(struct drm_i915_private *dev_priv)
> +static void gen8_display_irq_reset(struct drm_i915_private *dev_priv)
> {
> struct intel_uncore *uncore = &dev_priv->uncore;
> enum pipe pipe;
>
> - gen8_master_intr_disable(dev_priv->uncore.regs);
> -
> - gen8_gt_irq_reset(&dev_priv->gt);
> + if (!HAS_DISPLAY(dev_priv))
> + return;
>
> intel_uncore_write(uncore, EDP_PSR_IMR, 0x);
> intel_uncore_write(uncore, EDP_PSR_IIR, 0x);
> @@ -3077,6 +3078,16 @@ static void gen8_irq_reset(struct drm_i915_private
> *dev_priv)
>
> GEN3_IRQ_RESET(uncore, GEN8_DE_PORT_);
> GEN3_IRQ_RESET(uncore, GEN8_DE_MISC_);
> +}
> +
> +static void gen8_irq_reset(struct drm_i915_private *dev_priv)
> +{
> + struct intel_uncore *uncore = &dev_priv->uncore;
> +
> + gen8_master_intr_disable(dev_priv->uncore.regs);
> +
> + gen8_gt_irq_reset(&dev_priv->gt);
> + gen8_display_irq_reset(dev_priv);
> GEN3_IRQ_RESET(uncore, GEN8_PCU_);
>
> if (HAS_PCH_SPLIT(dev_priv))
> @@ -3092,6 +3103,9 @@ static void gen11_display_irq_reset(struct
> drm_i915_private *dev_priv)
> u32 trans_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
> BIT(TRANSCODER_C) | BIT(TRANSCODER_D);
>
> + if (!HAS_DISPLAY(dev_priv))
> + return;
> +
> intel_uncore_write(uncore, GEN11_DISPLAY_INT_CTL, 0);
>
> if (INTEL_GEN(dev_priv) >= 12) {
> @@ -3714,6 +3728,9 @@ static void gen8_de_irq_postinstall(struct
> drm_i915_private *dev_priv)
> BIT(TRANSCODER_C) | BIT(TRANSCODER_D);
> enum pipe pipe;
>
> + if (!HAS_DISPLAY(dev_priv))
> + return;
> +
> if (INTEL_GEN(dev_priv) <= 10)
> de_misc_masked |= GEN8_DE_MISC_GSE;
>
> @@ -3797,6 +3814,16 @@ static void gen8_irq_postinstall(struct
> drm_i915_private *dev_priv)
> gen8_master_intr_enable(dev_priv->uncore.regs);
> }
>
> +static void gen11_de_irq_postinstall(struct drm_i915_private *dev_priv)
> +{
> + if (!HAS_DISPLAY(dev_priv))
> + return;
> +
> + gen8_de_irq_postinstall(dev_priv);
> +
> + intel_uncore_write(&dev_priv->uncore, GEN11_DISPLAY_INT_CTL,
> +GEN11_DISPLAY_IRQ_ENABLE);
> +}
>
> static void gen11_irq_postinstall(struct drm_i915_private *dev_priv)
> {
> @@ -3807,12 +3834,10 @@ static void gen11_irq_postinstall(struct
> drm_i915_private *dev_priv)
> icp_irq_postinstall(dev_priv);
>
> gen11_gt_irq_postinstall(&dev_priv->gt);
> - gen8_de_irq_postinstall(dev_priv);
> + gen11_de_irq_postinstall(dev_priv);
>
> GEN3_IRQ_INIT(uncore, GEN11_GU_MISC_, ~gu_misc_masked, gu_misc_masked);
>
> - intel_uncore_write(&dev_priv->uncore, GEN11_DISPLAY_INT_CTL,
> GEN11_DISPLAY_IRQ_ENABLE);
> -
> if (HAS_MASTER_UNIT_IRQ(dev_priv)) {
> dg1_master_intr_enable(uncore->regs);
> intel_uncore_posting_read(&dev_priv->uncore,
> DG1_MSTR_UNIT_INTR);
> --
> 2.31.0
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Do not set any power wells when there is no display
On Mon, Mar 22, 2021 at 01:58:04PM -0700, José Roberto de Souza wrote:
> Power wells are only part of display block and not necessary when
> running a headless driver.
>
> Cc: Lucas De Marchi
Reviewed-by: Radhakrishna Sripada
> Signed-off-by: José Roberto de Souza
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c
> b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 7e0eaa872350..e6a3b3e6b1f7 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -4673,7 +4673,10 @@ int intel_power_domains_init(struct drm_i915_private
> *dev_priv)
>* The enabling order will be from lower to higher indexed wells,
>* the disabling order is reversed.
>*/
> - if (IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv)) {
> + if (!HAS_DISPLAY(dev_priv)) {
> + power_domains->power_well_count = 0;
> + err = 0;
> + } else if (IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv)) {
> err = set_power_wells_mask(power_domains, tgl_power_wells,
> BIT_ULL(TGL_DISP_PW_TC_COLD_OFF));
> } else if (IS_ROCKETLAKE(dev_priv)) {
> --
> 2.31.0
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: skip display initialization when there is no display
On Mon, Mar 22, 2021 at 01:58:05PM -0700, José Roberto de Souza wrote:
> Display features should not be initialized or de-initialized when there
> is no display. Skip modeset initialization, output setup, plane, crtc,
> encoder, connector registration, display cdclk and rawclk
> initialization, display core initialization, etc.
>
> Skip the functionality at as high level as possible, and remove any
> redundant checks. If the functionality is conditional to *other* display
> checks, do not add more. If the un-initialization has checks for
> initialization, do not add more.
>
> We explicitly do not care about any GMCH/VLV/CHV code paths, as they've
> always had and will have display.
>
> Cc: Lucas De Marchi
Reviewed-by: Radhakrishna Sripada
> Signed-off-by: José Roberto de Souza
> Signed-off-by: Jani Nikula
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 44 +++
> .../drm/i915/display/intel_display_power.c| 36 +++
> drivers/gpu/drm/i915/display/intel_dp.c | 6 +++
> drivers/gpu/drm/i915/display/intel_gmbus.c| 3 --
> drivers/gpu/drm/i915/display/intel_hotplug.c | 12 +
> drivers/gpu/drm/i915/display/intel_pps.c | 5 ++-
> drivers/gpu/drm/i915/i915_drv.c | 28 +---
> drivers/gpu/drm/i915/i915_suspend.c | 6 +++
> 8 files changed, 120 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 7b38b9a38b85..b10bf7e06ee7 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -1613,6 +1613,9 @@ u32 intel_plane_fb_max_stride(struct drm_i915_private
> *dev_priv,
> struct intel_crtc *crtc;
> struct intel_plane *plane;
>
> + if (!HAS_DISPLAY(dev_priv))
> + return 0;
> +
> /*
>* We assume the primary plane for pipe A has
>* the highest stride limits of them all,
> @@ -4629,6 +4632,9 @@ int intel_display_suspend(struct drm_device *dev)
> struct drm_atomic_state *state;
> int ret;
>
> + if (!HAS_DISPLAY(dev_priv))
> + return 0;
> +
> state = drm_atomic_helper_suspend(dev);
> ret = PTR_ERR_OR_ZERO(state);
> if (ret)
> @@ -12239,6 +12245,9 @@ static const struct drm_mode_config_funcs
> intel_mode_funcs = {
> */
> void intel_init_display_hooks(struct drm_i915_private *dev_priv)
> {
> + if (!HAS_DISPLAY(dev_priv))
> + return;
> +
> intel_init_cdclk_hooks(dev_priv);
> intel_init_audio_hooks(dev_priv);
>
> @@ -12281,8 +12290,12 @@ void intel_init_display_hooks(struct
> drm_i915_private *dev_priv)
>
> void intel_modeset_init_hw(struct drm_i915_private *i915)
> {
> - struct intel_cdclk_state *cdclk_state =
> - to_intel_cdclk_state(i915->cdclk.obj.state);
> + struct intel_cdclk_state *cdclk_state;
> +
> + if (!HAS_DISPLAY(i915))
> + return;
> +
> + cdclk_state = to_intel_cdclk_state(i915->cdclk.obj.state);
>
> intel_update_cdclk(i915);
> intel_dump_cdclk_config(&i915->cdclk.hw, "Current CDCLK");
> @@ -12598,6 +12611,9 @@ int intel_modeset_init_noirq(struct drm_i915_private
> *i915)
> /* FIXME: completely on the wrong abstraction layer */
> intel_power_domains_init_hw(i915, false);
>
> + if (!HAS_DISPLAY(i915))
> + return 0;
> +
> intel_csr_ucode_init(i915);
>
> i915->modeset_wq = alloc_ordered_workqueue("i915_modeset", 0);
> @@ -12648,6 +12664,9 @@ int intel_modeset_init_nogem(struct drm_i915_private
> *i915)
> struct intel_crtc *crtc;
> int ret;
>
> + if (!HAS_DISPLAY(i915))
> + return 0;
> +
> intel_init_pm(i915);
>
> intel_panel_sanitize_ssc(i915);
> @@ -12660,13 +12679,11 @@ int intel_modeset_init_nogem(struct
> drm_i915_private *i915)
> INTEL_NUM_PIPES(i915),
> INTEL_NUM_PIPES(i915) > 1 ? "s" : "");
>
> - if (HAS_DISPLAY(i915)) {
> - for_each_pipe(i915, pipe) {
> - ret = intel_crtc_init(i915, pipe);
> - if (ret) {
> - intel_mode_config_cleanup(i915);
> - return ret;
> - }
> + for_each_pipe(i915, pipe) {
> + ret = intel_crtc_init(i915, pipe);
> + if (ret) {
> + intel_mode_config_cleanup(i915);
> + return ret;
> }
> }
>
> @@ -13602,6 +13619,9 @@ void intel_display_resume(struct drm_device *dev)
> struct drm_modeset_acquire_ctx ctx;
> int ret;
>
> + if (!HAS_DISPLAY(dev_priv))
> + return;
> +
> dev_priv->modeset_restore_state = NULL;
> if (state)
> state->acquire_ctx = &ctx;
> @@ -13651,6 +13671,9 @@ static void intel_hpd_poll_fini(struct
> drm_i9
[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: Split out glk_plane_min_cdclk()
== Series Details == Series: series starting with [1/2] drm/i915: Split out glk_plane_min_cdclk() URL : https://patchwork.freedesktop.org/series/88588/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' /home/cidrm/kernel/Documentation/gpu/i915:22: ./drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active()
== Series Details == Series: drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active() URL : https://patchwork.freedesktop.org/series/88579/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9915_full -> Patchwork_19880_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_19880_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19880_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_19880_full: ### IGT changes ### Possible regressions * igt@gem_eio@unwedge-stress: - shard-snb: NOTRUN -> [FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-snb2/igt@gem_...@unwedge-stress.html * igt@i915_selftest@mock@memory_region: - shard-skl: [PASS][2] -> [INCOMPLETE][3] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-skl9/igt@i915_selftest@mock@memory_region.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-skl2/igt@i915_selftest@mock@memory_region.html Known issues Here are the changes found in Patchwork_19880_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_create@create-clear: - shard-skl: [PASS][4] -> [FAIL][5] ([i915#3160]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-skl9/igt@gem_cre...@create-clear.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-skl2/igt@gem_cre...@create-clear.html * igt@gem_ctx_persistence@legacy-engines-mixed: - shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) +6 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-snb5/igt@gem_ctx_persiste...@legacy-engines-mixed.html * igt@gem_eio@suspend: - shard-skl: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-skl4/igt@gem_...@suspend.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-skl1/igt@gem_...@suspend.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-skl: NOTRUN -> [SKIP][9] ([fdo#109271]) +127 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-skl10/igt@gem_exec_fair@basic-f...@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][10] -> [FAIL][11] ([i915#2842]) +2 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-tglb2/igt@gem_exec_fair@basic-pace-sh...@rcs0.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-tglb8/igt@gem_exec_fair@basic-pace-sh...@rcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842]) +2 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-kbl3/igt@gem_exec_fair@basic-p...@vecs0.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-kbl4/igt@gem_exec_fair@basic-p...@vecs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [PASS][14] -> [FAIL][15] ([i915#2842]) +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-glk2/igt@gem_exec_fair@basic-throt...@rcs0.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-glk7/igt@gem_exec_fair@basic-throt...@rcs0.html * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - shard-snb: NOTRUN -> [SKIP][16] ([fdo#109271]) +365 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-snb5/igt@gem_exec_fl...@basic-batch-kernel-default-cmd.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-apl: NOTRUN -> [FAIL][17] ([i915#2389]) +7 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-apl7/igt@gem_exec_reloc@basic-many-act...@rcs0.html * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-skl: NOTRUN -> [FAIL][18] ([i915#2389]) +3 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-skl8/igt@gem_exec_reloc@basic-wide-act...@bcs0.html * igt@gem_exec_reloc@basic-wide-active@rcs0: - shard-kbl: NOTRUN -> [FAIL][19] ([i915#2389]) +4 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-kbl1/igt@gem_exec_reloc@basic-wide-act...@rcs0.html * igt@gem_fenced_exec_thrash@no-spare-fences: - shard-snb: NOTRUN -> [INCOMPLETE][20] ([i915#2055]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19880/shard-snb5/igt@gem_fenced_exec_thr...
[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Split out glk_plane_min_cdclk()
== Series Details ==
Series: series starting with [1/2] drm/i915: Split out glk_plane_min_cdclk()
URL : https://patchwork.freedesktop.org/series/88588/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9915 -> Patchwork_19882
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/index.html
Known issues
Here are the changes found in Patchwork_19882 that come from known issues:
### IGT changes ###
Issues hit
* igt@amdgpu/amd_basic@query-info:
- fi-tgl-u2: NOTRUN -> [SKIP][1] ([fdo#109315])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-tgl-u2/igt@amdgpu/amd_ba...@query-info.html
* igt@amdgpu/amd_basic@semaphore:
- fi-icl-y: NOTRUN -> [SKIP][2] ([fdo#109315]) +17 similar issues
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-icl-y/igt@amdgpu/amd_ba...@semaphore.html
* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-tgl-u2: NOTRUN -> [SKIP][3] ([fdo#109315] / [i915#2575]) +16
similar issues
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-tgl-u2/igt@amdgpu/amd_cs_...@fork-compute0.html
* igt@gem_huc_copy@huc-copy:
- fi-tgl-u2: NOTRUN -> [SKIP][4] ([i915#2190])
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-tgl-u2/igt@gem_huc_c...@huc-copy.html
- fi-icl-y: NOTRUN -> [SKIP][5] ([i915#2190])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-icl-y/igt@gem_huc_c...@huc-copy.html
* igt@gem_ringfill@basic-all:
- fi-tgl-y: [PASS][6] -> [DMESG-WARN][7] ([i915#402]) +1 similar
issue
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-tgl-y/igt@gem_ringf...@basic-all.html
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-tgl-y/igt@gem_ringf...@basic-all.html
* igt@kms_chamelium@dp-crc-fast:
- fi-icl-y: NOTRUN -> [SKIP][8] ([fdo#109284] / [fdo#111827]) +8
similar issues
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-icl-y/igt@kms_chamel...@dp-crc-fast.html
* igt@kms_chamelium@dp-hpd-fast:
- fi-tgl-u2: NOTRUN -> [SKIP][9] ([fdo#109284] / [fdo#111827]) +8
similar issues
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-tgl-u2/igt@kms_chamel...@dp-hpd-fast.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-u2: NOTRUN -> [SKIP][10] ([fdo#109285])
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-tgl-u2/igt@kms_force_connector_ba...@force-load-detect.html
- fi-icl-y: NOTRUN -> [SKIP][11] ([fdo#109285])
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-icl-y/igt@kms_force_connector_ba...@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-icl-y: NOTRUN -> [SKIP][12] ([fdo#109278])
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-icl-y/igt@kms_pipe_crc_ba...@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_mmap_gtt:
- fi-icl-y: NOTRUN -> [SKIP][13] ([fdo#110189]) +3 similar issues
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-icl-y/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-u2: NOTRUN -> [SKIP][14] ([i915#3301])
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-tgl-u2/igt@prime_v...@basic-userptr.html
- fi-icl-y: NOTRUN -> [SKIP][15] ([i915#3301])
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-icl-y/igt@prime_v...@basic-userptr.html
Possible fixes
* igt@prime_vgem@basic-read:
- fi-tgl-y: [DMESG-WARN][16] ([i915#402]) -> [PASS][17] +1
similar issue
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-tgl-y/igt@prime_v...@basic-read.html
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-tgl-y/igt@prime_v...@basic-read.html
Warnings
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [SKIP][18] ([fdo#109271]) -> [FAIL][19] ([i915#3049])
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-kbl-guc/igt@i915_pm_...@basic-pci-d3-state.html
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/fi-kbl-guc/igt@i915_pm_...@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]
[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Do not report 100% RC6 if not supported
== Series Details == Series: drm/i915/pmu: Do not report 100% RC6 if not supported URL : https://patchwork.freedesktop.org/series/88580/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9915_full -> Patchwork_19881_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_19881_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19881_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_19881_full: ### IGT changes ### Possible regressions * igt@i915_pm_sseu@full-enable: - shard-skl: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-skl1/igt@i915_pm_s...@full-enable.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-skl4/igt@i915_pm_s...@full-enable.html Known issues Here are the changes found in Patchwork_19881_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_create@create-massive: - shard-snb: NOTRUN -> [DMESG-WARN][3] ([i915#3002]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-snb5/igt@gem_cre...@create-massive.html * igt@gem_ctx_persistence@legacy-engines-mixed-process: - shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +2 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-snb5/igt@gem_ctx_persiste...@legacy-engines-mixed-process.html * igt@gem_ctx_persistence@many-contexts: - shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2410]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-tglb6/igt@gem_ctx_persiste...@many-contexts.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-tglb7/igt@gem_ctx_persiste...@many-contexts.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-kbl3/igt@gem_exec_fair@basic-p...@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-kbl1/igt@gem_exec_fair@basic-p...@rcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842]) +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-tglb5/igt@gem_exec_fair@basic-p...@vecs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-tglb1/igt@gem_exec_fair@basic-p...@vecs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-glk2/igt@gem_exec_fair@basic-throt...@rcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-glk6/igt@gem_exec_fair@basic-throt...@rcs0.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-apl: NOTRUN -> [FAIL][13] ([i915#2389]) +7 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-apl1/igt@gem_exec_reloc@basic-many-act...@rcs0.html * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-skl: NOTRUN -> [FAIL][14] ([i915#2389]) +3 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-skl10/igt@gem_exec_reloc@basic-wide-act...@bcs0.html * igt@gem_exec_reloc@basic-wide-active@rcs0: - shard-kbl: NOTRUN -> [FAIL][15] ([i915#2389]) +4 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-kbl2/igt@gem_exec_reloc@basic-wide-act...@rcs0.html * igt@gem_exec_whisper@basic-contexts-priority: - shard-glk: [PASS][16] -> [DMESG-WARN][17] ([i915#118] / [i915#95]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-glk8/igt@gem_exec_whis...@basic-contexts-priority.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-glk9/igt@gem_exec_whis...@basic-contexts-priority.html * igt@gem_mmap_gtt@big-copy-xy: - shard-iclb: [PASS][18] -> [FAIL][19] ([i915#307]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-iclb2/igt@gem_mmap_...@big-copy-xy.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-iclb6/igt@gem_mmap_...@big-copy-xy.html * igt@gem_pread@exhaustion: - shard-snb: NOTRUN -> [WARN][20] ([i915#2658]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19881/shard-snb6/igt@gem_pr...@exhaustion.html * igt@gem_pwrite@basic-exhaustion: - shard-skl: NOTRUN -> [WARN][21] ([i915#2658]) [21]: https://intel-gfx-ci.
Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix pre-skl DP AUX precharge length
On Thu, Mar 18, 2021 at 08:10:38PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> DP v1.1+ says:
> "The DisplayPort transmitter, which is the driving end for a request
> transaction, pre-charges the AUX-CH+ and AUX-CH- to a common mode
> voltage by transmitting 10 to 16 consecutive 0’s in Manchester II code.
> After the active pre-charge, the transmitter sends an AUX Sync pattern.
> The AUX Sync pattern must be as follows:
> Start with 16 consecutive 0s in Manchester-II code, which results in
> a transition from low to high in the middle of each bit period.
> Including active pre-charge pulses, there shall be 26 to 32
> consecutive 0s before the end of the AUX_SYNC pattern."
>
> BDW bspec says:
> "Used to determine the precharge time for the Aux Channel. During this
> time the Aux Channel will drive the SYNC pattern. Every microsecond
> gives one additional SYNC pulse beyond the hard coded 26 SYNC pulses.
> The value is the number of microseconds times 2. Default is 3 decimal
> which gives 6us of precharge which is 6 extra SYN pulses for a total
> of 32."
>
> CPT bspec says the same thing apart from:
> "... Default is 5 decimal which gives 10us of precharge which is 10
> extra SYNC pulses for a total of 36."
>
> So it looks like to match the max of 32 of the DP spec we should just
> always program this extra precharge time to 3.
>
> Unfortunately g4x/ibx bspec doesn't have this clarification, but
> since the cpt default was still the same 5 as for g4x/ibx let's
> assume the behaviour was always the same.
I did a bit more archaeology and found the following:
commit e3421a189447 ("drm/i915: enable DP/eDP for Sandybridge/Cougarpoint")
added the precharge==3 for snb.
commit 092945e11c5b ("drm/i915/dp: Use auxch precharge value of 5 everywhere")
tried to change it to be 5 for snb.
commit 6b4e0a93ff6e ("Revert "drm/i915/dp: Use auxch precharge value of 5
everywhere"")
went back to 3 for snb due to a regression.
So I think the value of 5 was just always wrong, but I guess very
few display actually get upset if we do too many SYNCs. Also DP 1.0
did not specify any max value for this, whereas DP 1.1+ added the
max==32 wording.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 9 ++---
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index eaebf123310a..d5443d6d6123 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -126,12 +126,7 @@ static u32 g4x_get_aux_send_ctl(struct intel_dp
> *intel_dp,
> struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
> struct drm_i915_private *dev_priv =
> to_i915(dig_port->base.base.dev);
> - u32 precharge, timeout;
> -
> - if (IS_GEN(dev_priv, 6))
> - precharge = 3;
> - else
> - precharge = 5;
> + u32 timeout;
>
> if (IS_BROADWELL(dev_priv))
> timeout = DP_AUX_CH_CTL_TIME_OUT_600us;
> @@ -145,7 +140,7 @@ static u32 g4x_get_aux_send_ctl(struct intel_dp *intel_dp,
> timeout |
> DP_AUX_CH_CTL_RECEIVE_ERROR |
> (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
> -(precharge << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
> +(3 << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
> (aux_clock_divider << DP_AUX_CH_CTL_BIT_CLOCK_2X_SHIFT);
> }
>
> --
> 2.26.2
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 2/2] drm/i915: Reuse intel_adjusted_rate() for pfit pixel rate adjustment
From: Ville Syrjälä
Replace the hand rolled pfit downscale calculations with
intel_adjusted_rate().
Signed-off-by: Ville Syrjälä
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 6 ++---
.../gpu/drm/i915/display/intel_atomic_plane.h | 4
drivers/gpu/drm/i915/display/intel_display.c | 23 +--
3 files changed, 13 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index 3f830b70b0c1..5f0a5ea474eb 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -133,9 +133,9 @@ intel_plane_destroy_state(struct drm_plane *plane,
kfree(plane_state);
}
-static unsigned int intel_adjusted_rate(const struct drm_rect *src,
- const struct drm_rect *dst,
- unsigned int rate)
+unsigned int intel_adjusted_rate(const struct drm_rect *src,
+const struct drm_rect *dst,
+unsigned int rate)
{
unsigned int src_w, src_h, dst_w, dst_h;
diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.h
b/drivers/gpu/drm/i915/display/intel_atomic_plane.h
index 5c78a087ed86..dc4d05e75e1c 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.h
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.h
@@ -10,6 +10,7 @@
struct drm_plane;
struct drm_property;
+struct drm_rect;
struct intel_atomic_state;
struct intel_crtc;
struct intel_crtc_state;
@@ -18,6 +19,9 @@ struct intel_plane_state;
extern const struct drm_plane_helper_funcs intel_plane_helper_funcs;
+unsigned int intel_adjusted_rate(const struct drm_rect *src,
+const struct drm_rect *dst,
+unsigned int rate);
unsigned int intel_plane_pixel_rate(const struct intel_crtc_state *crtc_state,
const struct intel_plane_state
*plane_state);
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/drm/i915/display/intel_display.c
index d74b263c5f4e..472e691286c6 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -3978,7 +3978,7 @@ static bool intel_crtc_supports_double_wide(const struct
intel_crtc *crtc)
static u32 ilk_pipe_pixel_rate(const struct intel_crtc_state *crtc_state)
{
u32 pixel_rate = crtc_state->hw.pipe_mode.crtc_clock;
- unsigned int pipe_w, pipe_h, pfit_w, pfit_h;
+ struct drm_rect src;
/*
* We only use IF-ID interlacing. If we ever use
@@ -3988,23 +3988,12 @@ static u32 ilk_pipe_pixel_rate(const struct
intel_crtc_state *crtc_state)
if (!crtc_state->pch_pfit.enabled)
return pixel_rate;
- pipe_w = crtc_state->pipe_src_w;
- pipe_h = crtc_state->pipe_src_h;
+ drm_rect_init(&src, 0, 0,
+ crtc_state->pipe_src_w << 16,
+ crtc_state->pipe_src_h << 16);
- pfit_w = drm_rect_width(&crtc_state->pch_pfit.dst);
- pfit_h = drm_rect_height(&crtc_state->pch_pfit.dst);
-
- if (pipe_w < pfit_w)
- pipe_w = pfit_w;
- if (pipe_h < pfit_h)
- pipe_h = pfit_h;
-
- if (drm_WARN_ON(crtc_state->uapi.crtc->dev,
- !pfit_w || !pfit_h))
- return pixel_rate;
-
- return div_u64(mul_u32_u32(pixel_rate, pipe_w * pipe_h),
- pfit_w * pfit_h);
+ return intel_adjusted_rate(&src, &crtc_state->pch_pfit.dst,
+ pixel_rate);
}
static void intel_mode_from_crtc_timings(struct drm_display_mode *mode,
--
2.26.2
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 1/2] drm/i915: Extract intel_adjusted_rate()
From: Ville Syrjälä
Extract a small helper to calculate the downscaling
adjusted pixel rate/data rate/etc.
Signed-off-by: Ville Syrjälä
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 27 +--
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index c3f2962aa1eb..3f830b70b0c1 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -133,25 +133,36 @@ intel_plane_destroy_state(struct drm_plane *plane,
kfree(plane_state);
}
-unsigned int intel_plane_pixel_rate(const struct intel_crtc_state *crtc_state,
- const struct intel_plane_state *plane_state)
+static unsigned int intel_adjusted_rate(const struct drm_rect *src,
+ const struct drm_rect *dst,
+ unsigned int rate)
{
unsigned int src_w, src_h, dst_w, dst_h;
- unsigned int pixel_rate = crtc_state->pixel_rate;
- src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
- src_h = drm_rect_height(&plane_state->uapi.src) >> 16;
- dst_w = drm_rect_width(&plane_state->uapi.dst);
- dst_h = drm_rect_height(&plane_state->uapi.dst);
+ src_w = drm_rect_width(src) >> 16;
+ src_h = drm_rect_height(src) >> 16;
+ dst_w = drm_rect_width(dst);
+ dst_h = drm_rect_height(dst);
/* Downscaling limits the maximum pixel rate */
dst_w = min(src_w, dst_w);
dst_h = min(src_h, dst_h);
- return DIV_ROUND_UP_ULL(mul_u32_u32(pixel_rate, src_w * src_h),
+ return DIV_ROUND_UP_ULL(mul_u32_u32(rate, src_w * src_h),
dst_w * dst_h);
}
+unsigned int intel_plane_pixel_rate(const struct intel_crtc_state *crtc_state,
+ const struct intel_plane_state *plane_state)
+{
+ if (!plane_state->uapi.visible)
+ return 0;
+
+ return intel_adjusted_rate(&plane_state->uapi.src,
+ &plane_state->uapi.dst,
+ crtc_state->pixel_rate);
+}
+
unsigned int intel_plane_data_rate(const struct intel_crtc_state *crtc_state,
const struct intel_plane_state *plane_state)
{
--
2.26.2
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: Extract intel_adjusted_rate()
== Series Details == Series: series starting with [1/2] drm/i915: Extract intel_adjusted_rate() URL : https://patchwork.freedesktop.org/series/88592/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' /home/cidrm/kernel/Documentation/gpu/i915:22: ./drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Split out glk_plane_min_cdclk()
== Series Details == Series: series starting with [1/2] drm/i915: Split out glk_plane_min_cdclk() URL : https://patchwork.freedesktop.org/series/88588/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9915_full -> Patchwork_19882_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_19882_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19882_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_19882_full: ### IGT changes ### Possible regressions * igt@gem_ctx_isolation@preservation-s3@vecs0: - shard-iclb: [PASS][1] -> [DMESG-WARN][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-iclb2/igt@gem_ctx_isolation@preservation...@vecs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-iclb1/igt@gem_ctx_isolation@preservation...@vecs0.html * igt@gem_eio@unwedge-stress: - shard-snb: NOTRUN -> [FAIL][3] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-snb6/igt@gem_...@unwedge-stress.html Known issues Here are the changes found in Patchwork_19882_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_create@create-clear: - shard-glk: [PASS][4] -> [FAIL][5] ([i915#1888] / [i915#3160]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-glk2/igt@gem_cre...@create-clear.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-glk3/igt@gem_cre...@create-clear.html * igt@gem_create@create-massive: - shard-snb: NOTRUN -> [DMESG-WARN][6] ([i915#3002]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-snb5/igt@gem_cre...@create-massive.html * igt@gem_ctx_persistence@legacy-engines-mixed: - shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1099]) +4 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-snb2/igt@gem_ctx_persiste...@legacy-engines-mixed.html * igt@gem_eio@in-flight-contexts-10ms: - shard-tglb: [PASS][8] -> [TIMEOUT][9] ([i915#3063]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-tglb8/igt@gem_...@in-flight-contexts-10ms.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-tglb8/igt@gem_...@in-flight-contexts-10ms.html * igt@gem_exec_capture@pi@vcs0: - shard-skl: [PASS][10] -> [INCOMPLETE][11] ([i915#2369]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-skl8/igt@gem_exec_capture@p...@vcs0.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-skl3/igt@gem_exec_capture@p...@vcs0.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-skl: NOTRUN -> [SKIP][12] ([fdo#109271]) +142 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-skl9/igt@gem_exec_fair@basic-f...@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842]) +3 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-tglb2/igt@gem_exec_fair@basic-pace-sh...@rcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-tglb8/igt@gem_exec_fair@basic-pace-sh...@rcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-kbl: [PASS][15] -> [FAIL][16] ([i915#2842]) +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-kbl3/igt@gem_exec_fair@basic-p...@vecs0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-kbl6/igt@gem_exec_fair@basic-p...@vecs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [PASS][17] -> [FAIL][18] ([i915#2842]) +2 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-glk2/igt@gem_exec_fair@basic-throt...@rcs0.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-glk2/igt@gem_exec_fair@basic-throt...@rcs0.html * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - shard-snb: NOTRUN -> [SKIP][19] ([fdo#109271]) +247 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-snb2/igt@gem_exec_fl...@basic-batch-kernel-default-cmd.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-apl: NOTRUN -> [FAIL][20] ([i915#2389]) +7 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19882/shard-apl7/igt@gem_exec_reloc@basic-many-act...@rcs0.html * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-skl: NOTRUN -> [FAIL][21
[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Extract intel_adjusted_rate()
== Series Details == Series: series starting with [1/2] drm/i915: Extract intel_adjusted_rate() URL : https://patchwork.freedesktop.org/series/88592/ State : success == Summary == CI Bug Log - changes from CI_DRM_9915 -> Patchwork_19883 Summary --- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/index.html Known issues Here are the changes found in Patchwork_19883 that come from known issues: ### IGT changes ### Issues hit * igt@amdgpu/amd_basic@query-info: - fi-tgl-u2: NOTRUN -> [SKIP][1] ([fdo#109315]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/fi-tgl-u2/igt@amdgpu/amd_ba...@query-info.html * igt@amdgpu/amd_cs_nop@fork-compute0: - fi-tgl-u2: NOTRUN -> [SKIP][2] ([fdo#109315] / [i915#2575]) +16 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/fi-tgl-u2/igt@amdgpu/amd_cs_...@fork-compute0.html * igt@gem_flink_basic@flink-lifetime: - fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +2 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-tgl-y/igt@gem_flink_ba...@flink-lifetime.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/fi-tgl-y/igt@gem_flink_ba...@flink-lifetime.html * igt@gem_huc_copy@huc-copy: - fi-tgl-u2: NOTRUN -> [SKIP][5] ([i915#2190]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/fi-tgl-u2/igt@gem_huc_c...@huc-copy.html * igt@kms_chamelium@dp-hpd-fast: - fi-tgl-u2: NOTRUN -> [SKIP][6] ([fdo#109284] / [fdo#111827]) +8 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/fi-tgl-u2/igt@kms_chamel...@dp-hpd-fast.html * igt@kms_force_connector_basic@force-load-detect: - fi-tgl-u2: NOTRUN -> [SKIP][7] ([fdo#109285]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/fi-tgl-u2/igt@kms_force_connector_ba...@force-load-detect.html * igt@prime_vgem@basic-userptr: - fi-tgl-u2: NOTRUN -> [SKIP][8] ([i915#3301]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/fi-tgl-u2/igt@prime_v...@basic-userptr.html * igt@runner@aborted: - fi-kbl-r: NOTRUN -> [FAIL][9] ([i915#1569] / [i915#192] / [i915#193] / [i915#194]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/fi-kbl-r/igt@run...@aborted.html - fi-bdw-5557u: NOTRUN -> [FAIL][10] ([i915#1602] / [i915#2029]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/fi-bdw-5557u/igt@run...@aborted.html Possible fixes * igt@prime_vgem@basic-read: - fi-tgl-y: [DMESG-WARN][11] ([i915#402]) -> [PASS][12] +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/fi-tgl-y/igt@prime_v...@basic-read.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/fi-tgl-y/igt@prime_v...@basic-read.html [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1569]: https://gitlab.freedesktop.org/drm/intel/issues/1569 [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602 [i915#192]: https://gitlab.freedesktop.org/drm/intel/issues/192 [i915#193]: https://gitlab.freedesktop.org/drm/intel/issues/193 [i915#194]: https://gitlab.freedesktop.org/drm/intel/issues/194 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (43 -> 40) -- Additional (1): fi-tgl-u2 Missing(4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build changes - * Linux: CI_DRM_9915 -> Patchwork_19883 CI-20190529: 20190529 CI_DRM_9915: d649c4056f6466b84ec22786985908d377893f85 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6048: 8231f28f49255b8a71777351830c18fb7a7c6171 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19883: e0b48d80f98a2669a06d45cc16201761cafab5a1 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == e0b48d80f98a drm/i915: Reuse intel_adjusted_rate() for pfit pixel rate adjustment cb25fe3f8a68 drm/i915: Extract intel_adjusted_rate() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/index.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/
[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Extract intel_adjusted_rate()
== Series Details == Series: series starting with [1/2] drm/i915: Extract intel_adjusted_rate() URL : https://patchwork.freedesktop.org/series/88592/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9915_full -> Patchwork_19883_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_19883_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19883_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_19883_full: ### IGT changes ### Possible regressions * igt@i915_pm_rpm@pm-caching: - shard-iclb: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-iclb8/igt@i915_pm_...@pm-caching.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-iclb7/igt@i915_pm_...@pm-caching.html * igt@i915_selftest@mock@buddy: - shard-skl: [PASS][3] -> [DMESG-FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-skl9/igt@i915_selftest@m...@buddy.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-skl2/igt@i915_selftest@m...@buddy.html * igt@kms_cursor_edge_walk@pipe-a-256x256-top-edge: - shard-skl: [PASS][5] -> [DMESG-WARN][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-skl10/igt@kms_cursor_edge_w...@pipe-a-256x256-top-edge.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-skl8/igt@kms_cursor_edge_w...@pipe-a-256x256-top-edge.html Known issues Here are the changes found in Patchwork_19883_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_ctx_isolation@preservation-s3@rcs0: - shard-skl: [PASS][7] -> [INCOMPLETE][8] ([i915#198]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-skl1/igt@gem_ctx_isolation@preservation...@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-skl10/igt@gem_ctx_isolation@preservation...@rcs0.html * igt@gem_ctx_persistence@legacy-engines-mixed: - shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1099]) +5 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-snb5/igt@gem_ctx_persiste...@legacy-engines-mixed.html * igt@gem_ctx_persistence@many-contexts: - shard-tglb: [PASS][10] -> [FAIL][11] ([i915#2410]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-tglb6/igt@gem_ctx_persiste...@many-contexts.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-tglb8/igt@gem_ctx_persiste...@many-contexts.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-skl: NOTRUN -> [SKIP][12] ([fdo#109271]) +128 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-skl1/igt@gem_exec_fair@basic-f...@rcs0.html * igt@gem_exec_fair@basic-none-vip@rcs0: - shard-glk: [PASS][13] -> [FAIL][14] ([i915#2842]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-glk5/igt@gem_exec_fair@basic-none-...@rcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-glk3/igt@gem_exec_fair@basic-none-...@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][15] -> [FAIL][16] ([i915#2842]) +3 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-tglb2/igt@gem_exec_fair@basic-pace-sh...@rcs0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-tglb6/igt@gem_exec_fair@basic-pace-sh...@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: [PASS][17] -> [FAIL][18] ([i915#2842]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9915/shard-kbl3/igt@gem_exec_fair@basic-p...@vcs0.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-kbl4/igt@gem_exec_fair@basic-p...@vcs0.html * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - shard-snb: NOTRUN -> [SKIP][19] ([fdo#109271]) +299 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-snb5/igt@gem_exec_fl...@basic-batch-kernel-default-cmd.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-apl: NOTRUN -> [FAIL][20] ([i915#2389]) +7 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/shard-apl3/igt@gem_exec_reloc@basic-many-act...@rcs0.html * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-skl: NOTRUN -> [FAIL][21] ([i915#2389]) +3 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19883/sha
