Re: [Intel-gfx] [PATCH] drm/i915: fix spelling mistake "resseting" -> "resetting"

[Mukesh Ojha]

On 4/18/2019 4:36 PM, Colin King wrote:

From: Colin Ian King 

There is a spelling mistake in a gvt_dbg_core debug message. Fix it.

Signed-off-by: Colin Ian King 



Reviewed-by: Mukesh Ojha 

Cheers,
-Mukesh


---
  drivers/gpu/drm/i915/gvt/vgpu.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c
index 44ce3c2b9ac1..d1e818f2b521 100644
--- a/drivers/gpu/drm/i915/gvt/vgpu.c
+++ b/drivers/gpu/drm/i915/gvt/vgpu.c
@@ -533,7 +533,7 @@ void intel_gvt_reset_vgpu_locked(struct intel_vgpu *vgpu, 
bool dmlr,
intel_engine_mask_t resetting_eng = dmlr ? ALL_ENGINES : engine_mask;
  
  	gvt_dbg_core("--\n");

-   gvt_dbg_core("resseting vgpu%d, dmlr %d, engine_mask %08x\n",
+   gvt_dbg_core("resetting vgpu%d, dmlr %d, engine_mask %08x\n",
 vgpu->id, dmlr, engine_mask);
  
  	vgpu->resetting_eng = resetting_eng;

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2] gpu:drm: Remove duplicate headers

[Mukesh Ojha]

On 3/29/2019 12:32 AM, Jagadeesh Pagadala wrote:

On Thu, Mar 28, 2019 at 04:12:10PM +0200, Laurent Pinchart wrote:

Hi Jagadeesh,

On Thu, Mar 28, 2019 at 09:32:06PM +0530, Jagadeesh Pagadala wrote:

On Thu, Mar 28, 2019 at 08:51:24AM +0200, Laurent Pinchart wrote:

On Thu, Mar 28, 2019 at 02:41:56AM +0530, jagdsh.li...@gmail.com wrote:

From: Jagadeesh Pagadala 

Remove duplicate headers which are included twice.

Could you, while at it, also sort the existing #include statements
alphabetically ? This should help avoiding similar issues in the future.


Signed-off-by: Jagadeesh Pagadala 



Reviewed-by: Mukesh Ojha 

-Mukesh


---
  drivers/gpu/drm/bridge/panel.c   | 1 -
  drivers/gpu/drm/i915/intel_display.c | 7 ---
  2 files changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 38eeaf8..eb9567d 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -15,7 +15,6 @@
  #include 
  #include 
  #include 
-#include 
  
  struct panel_bridge {

struct drm_bridge bridge;
diff --git a/drivers/gpu/drm/i915/intel_display.c 
b/drivers/gpu/drm/i915/intel_display.c
index ccb6163..1166342 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -51,14 +51,7 @@
  #include "intel_dsi.h"
  #include "intel_frontbuffer.h"
  
-#include "intel_drv.h"

-#include "intel_dsi.h"
-#include "intel_frontbuffer.h"
-
-#include "i915_drv.h"
-#include "i915_gem_clflush.h"
  #include "i915_reset.h"
-#include "i915_trace.h"
  
  /* Primary plane formats for gen <= 3 */

  static const u32 i8xx_primary_formats[] = {

 From c9a68b204fe4bb013c2b8481ca8239c957dd69cc Mon Sep 17 00:00:00 2001
From: Jagadeesh Pagadala 
Date: Thu, 28 Mar 2019 21:20:12 +0530
Subject: [PATCH] gpu:drm: sort the existing #includes alphabetically

Hi Laurent,

Hopefully this helps.

It does, thanks. If you squash it with your original patch and send a
v2, you can add my

Reviewed-by: Laurent Pinchart 


Signed-off-by: Jagadeesh Pagadala 
---
  drivers/gpu/drm/bridge/panel.c   | 2 +-
  drivers/gpu/drm/i915/intel_display.c | 4 ++--
  2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index eb9567d..000ba7c 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -9,11 +9,11 @@
   */
  
  #include 

-#include 
  #include 
  #include 
  #include 
  #include 
+#include 
  #include 
  
  struct panel_bridge {

diff --git a/drivers/gpu/drm/i915/intel_display.c 
b/drivers/gpu/drm/i915/intel_display.c
index 1166342..7956e89 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -46,13 +46,13 @@
  
  #include "i915_drv.h"

  #include "i915_gem_clflush.h"
+#include "i915_reset.h"
  #include "i915_trace.h"
+
  #include "intel_drv.h"
  #include "intel_dsi.h"
  #include "intel_frontbuffer.h"
  
-#include "i915_reset.h"

-
  /* Primary plane formats for gen <= 3 */
  static const u32 i8xx_primary_formats[] = {
DRM_FORMAT_C8,

--
Regards,

Laurent Pinchart

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] gpu:drm: Remove duplicate headers

[Mukesh Ojha]

On 3/28/2019 2:41 AM, jagdsh.li...@gmail.com wrote:

From: Jagadeesh Pagadala 

Remove duplicate headers which are included twice.

Signed-off-by: Jagadeesh Pagadala 



Reviewed-by: Mukesh Ojha 

-Mukesh


---
  drivers/gpu/drm/bridge/panel.c   | 1 -
  drivers/gpu/drm/i915/intel_display.c | 7 ---
  2 files changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 38eeaf8..eb9567d 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -15,7 +15,6 @@
  #include 
  #include 
  #include 
-#include 
  
  struct panel_bridge {

struct drm_bridge bridge;
diff --git a/drivers/gpu/drm/i915/intel_display.c 
b/drivers/gpu/drm/i915/intel_display.c
index ccb6163..1166342 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -51,14 +51,7 @@
  #include "intel_dsi.h"
  #include "intel_frontbuffer.h"
  
-#include "intel_drv.h"

-#include "intel_dsi.h"
-#include "intel_frontbuffer.h"
-
-#include "i915_drv.h"
-#include "i915_gem_clflush.h"
  #include "i915_reset.h"
-#include "i915_trace.h"
  
  /* Primary plane formats for gen <= 3 */

  static const u32 i8xx_primary_formats[] = {

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx