Re: [Intel-gfx] [CI v2 1/2] drm/i915/guc: Update GuC power domain states
Quoting Chris Wilson (2018-09-10 16:34:36) > Quoting Michal Wajdeczko (2018-09-10 11:41:49) > > We should update GuC power domain states also when GuC submission > > is disabled, otherwise GuC might complain or ignore our requests. > > This seems to be required for all currently released GuC firmwares. > > Was it expected to fix the live_guc selftest? Might be worth mentioning > Testcase: igt/drv_selftest/live_guc > in that case. Yes. It was because HAX wasn't to enable guc live I thought it was going to be, but to clear guc submission. My bad for not reading before speaking. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [CI v2 1/2] drm/i915/guc: Update GuC power domain states
Quoting Srivatsa, Anusha (2018-09-10 17:39:30) > > > >-Original Message- > >From: Wajdeczko, Michal > >Sent: Monday, September 10, 2018 3:42 AM > >To: intel-gfx@lists.freedesktop.org > >Cc: Wajdeczko, Michal ; Spotswood, John A > >; Srivatsa, Anusha ; > >Lis, Tomasz ; Ceraolo Spurio, Daniele > > > >Subject: [CI v2 1/2] drm/i915/guc: Update GuC power domain states > > > >We should update GuC power domain states also when GuC submission is > >disabled, otherwise GuC might complain or ignore our requests. > >This seems to be required for all currently released GuC firmwares. > > > >v2: it is only needed by pre-Gen11 firmwares > > > >Signed-off-by: Michal Wajdeczko > >Cc: John Spotswood > >Cc: Anusha Srivatsa > >Cc: Tomasz Lis > >Cc: Daniele Ceraolo Spurio > Reviewed-by: Anusha Srivatsa And pushed. Thanks for the patch and review, -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [CI v2 1/2] drm/i915/guc: Update GuC power domain states
>-Original Message-
>From: Wajdeczko, Michal
>Sent: Monday, September 10, 2018 3:42 AM
>To: intel-gfx@lists.freedesktop.org
>Cc: Wajdeczko, Michal ; Spotswood, John A
>; Srivatsa, Anusha ;
>Lis, Tomasz ; Ceraolo Spurio, Daniele
>
>Subject: [CI v2 1/2] drm/i915/guc: Update GuC power domain states
>
>We should update GuC power domain states also when GuC submission is
>disabled, otherwise GuC might complain or ignore our requests.
>This seems to be required for all currently released GuC firmwares.
>
>v2: it is only needed by pre-Gen11 firmwares
>
>Signed-off-by: Michal Wajdeczko
>Cc: John Spotswood
>Cc: Anusha Srivatsa
>Cc: Tomasz Lis
>Cc: Daniele Ceraolo Spurio
Reviewed-by: Anusha Srivatsa
>---
> drivers/gpu/drm/i915/intel_uc.c | 4
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
>index 7c95697..b1b3e81 100644
>--- a/drivers/gpu/drm/i915/intel_uc.c
>+++ b/drivers/gpu/drm/i915/intel_uc.c
>@@ -401,6 +401,10 @@ int intel_uc_init_hw(struct drm_i915_private *i915)
> ret = intel_guc_submission_enable(guc);
> if (ret)
> goto err_communication;
>+ } else if (INTEL_GEN(i915) < 11) {
>+ ret = intel_guc_sample_forcewake(guc);
>+ if (ret)
>+ goto err_communication;
> }
>
> dev_info(i915->drm.dev, "GuC firmware version %u.%u\n",
>--
>1.9.1
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [CI v2 1/2] drm/i915/guc: Update GuC power domain states
Quoting Michal Wajdeczko (2018-09-10 11:41:49) > We should update GuC power domain states also when GuC submission > is disabled, otherwise GuC might complain or ignore our requests. > This seems to be required for all currently released GuC firmwares. Was it expected to fix the live_guc selftest? Might be worth mentioning Testcase: igt/drv_selftest/live_guc in that case. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [CI v2 1/2] drm/i915/guc: Update GuC power domain states
We should update GuC power domain states also when GuC submission
is disabled, otherwise GuC might complain or ignore our requests.
This seems to be required for all currently released GuC firmwares.
v2: it is only needed by pre-Gen11 firmwares
Signed-off-by: Michal Wajdeczko
Cc: John Spotswood
Cc: Anusha Srivatsa
Cc: Tomasz Lis
Cc: Daniele Ceraolo Spurio
---
drivers/gpu/drm/i915/intel_uc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index 7c95697..b1b3e81 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -401,6 +401,10 @@ int intel_uc_init_hw(struct drm_i915_private *i915)
ret = intel_guc_submission_enable(guc);
if (ret)
goto err_communication;
+ } else if (INTEL_GEN(i915) < 11) {
+ ret = intel_guc_sample_forcewake(guc);
+ if (ret)
+ goto err_communication;
}
dev_info(i915->drm.dev, "GuC firmware version %u.%u\n",
--
1.9.1
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
