Re: [Intel-gfx] [PATCH] DRM/i915: Don't clone SDVO LVDS with analog.

[Daniel Vetter]

On Sat, Oct 13, 2012 at 02:30:15PM +0200, Egbert Eich wrote:
 SDVO LVDS are not clonable as the input mode gets adjusted by
 the LVDS encoder.
 
 Signed-off-by: Egbert Eich e...@suse.de

Imo cloning should simply die outright. Patch applied, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] DRM/i915: Don't clone SDVO LVDS with analog.

[Egbert Eich]

SDVO LVDS are not clonable as the input mode gets adjusted by
the LVDS encoder.

Signed-off-by: Egbert Eich e...@suse.de
---
 drivers/gpu/drm/i915/intel_sdvo.c |6 ++
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_sdvo.c 
b/drivers/gpu/drm/i915/intel_sdvo.c
index d192ce4..d2e8c9f 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -2286,10 +2286,8 @@ intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int 
device)
intel_sdvo_connector-output_flag = SDVO_OUTPUT_LVDS1;
}
 
-   /* SDVO LVDS is cloneable because the SDVO encoder does the upscaling,
-* as opposed to native LVDS, where we upscale with the panel-fitter
-* (and hence only the native LVDS resolution could be cloned). */
-   intel_sdvo-base.cloneable = true;
+   /* SDVO LVDS is not cloneable because the input mode gets adjusted by 
the encoder */
+   intel_sdvo-base.cloneable = false;
 
intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo);
if (!intel_sdvo_create_enhance_property(intel_sdvo, 
intel_sdvo_connector))
-- 
1.7.6.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx