Re: [Intel-gfx] [PATCH] drm/i915/bdw: Disable execlists by default

2014-08-19 Thread Daniel Vetter 
On Mon, Aug 18, 2014 at 4:55 PM, Paulo Zanoni przan...@gmail.com wrote:
 2014-08-18 5:29 GMT-03:00 Jani Nikula jani.nik...@linux.intel.com:
 On Fri, 15 Aug 2014, Damien Lespiau damien.lesp...@intel.com wrote:
 We still have a few missing bits and pieces to have execlists enabled by
 default eg. the error capture or the render state initialization and so
 it wouldn't be wise to enable it by default on BDW just yet.

 Also,

 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82740

 Yes, please! I can't boot BDW anymore without this.

 Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com
 Tested-by: Paulo Zanoni paulo.r.zan...@intel.com

So execlist is only possible with full ppgtt (or at least that should
be the case) and full ppgtt is disabled by default. Obviously that
doesn't match the reality, but the bug also doesn't have dmesg
attached to check for that and fix the underlying thing?

I'll try to merge this meanwhile if the wifi here doesn't fall over again.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Disable execlists by default

2014-08-18 Thread Jani Nikula 
On Fri, 15 Aug 2014, Damien Lespiau damien.lesp...@intel.com wrote:
 We still have a few missing bits and pieces to have execlists enabled by
 default eg. the error capture or the render state initialization and so
 it wouldn't be wise to enable it by default on BDW just yet.

Also,

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82740

 Cc: Daniel Vetter daniel.vet...@ffwll.ch
 Cc: Thomas Daniel thomas.dan...@intel.com
 Signed-off-by: Damien Lespiau damien.lesp...@intel.com
 ---
  drivers/gpu/drm/i915/i915_params.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/drivers/gpu/drm/i915/i915_params.c 
 b/drivers/gpu/drm/i915/i915_params.c
 index 0886aca..139f490 100644
 --- a/drivers/gpu/drm/i915/i915_params.c
 +++ b/drivers/gpu/drm/i915/i915_params.c
 @@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = {
   .vbt_sdvo_panel_type = -1,
   .enable_rc6 = -1,
   .enable_fbc = -1,
 - .enable_execlists = -1,
 + .enable_execlists = 0,
   .enable_hangcheck = true,
   .enable_ppgtt = -1,
   .enable_psr = 0,
 @@ -122,7 +122,7 @@ MODULE_PARM_DESC(enable_ppgtt,
  module_param_named(enable_execlists, i915.enable_execlists, int, 0400);
  MODULE_PARM_DESC(enable_execlists,
   Override execlists usage. 
 - (-1=auto [default], 0=disabled, 1=enabled));
 + (-1=auto, 0=disabled [default], 1=enabled));
  
  module_param_named(enable_psr, i915.enable_psr, int, 0600);
  MODULE_PARM_DESC(enable_psr, Enable PSR (default: false));
 -- 
 1.8.3.1

 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Disable execlists by default

2014-08-18 Thread Paulo Zanoni 
2014-08-18 5:29 GMT-03:00 Jani Nikula jani.nik...@linux.intel.com:
 On Fri, 15 Aug 2014, Damien Lespiau damien.lesp...@intel.com wrote:
 We still have a few missing bits and pieces to have execlists enabled by
 default eg. the error capture or the render state initialization and so
 it wouldn't be wise to enable it by default on BDW just yet.

 Also,

 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82740

Yes, please! I can't boot BDW anymore without this.

Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com
Tested-by: Paulo Zanoni paulo.r.zan...@intel.com


 Cc: Daniel Vetter daniel.vet...@ffwll.ch
 Cc: Thomas Daniel thomas.dan...@intel.com
 Signed-off-by: Damien Lespiau damien.lesp...@intel.com
 ---
  drivers/gpu/drm/i915/i915_params.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/drivers/gpu/drm/i915/i915_params.c 
 b/drivers/gpu/drm/i915/i915_params.c
 index 0886aca..139f490 100644
 --- a/drivers/gpu/drm/i915/i915_params.c
 +++ b/drivers/gpu/drm/i915/i915_params.c
 @@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = {
   .vbt_sdvo_panel_type = -1,
   .enable_rc6 = -1,
   .enable_fbc = -1,
 - .enable_execlists = -1,
 + .enable_execlists = 0,
   .enable_hangcheck = true,
   .enable_ppgtt = -1,
   .enable_psr = 0,
 @@ -122,7 +122,7 @@ MODULE_PARM_DESC(enable_ppgtt,
  module_param_named(enable_execlists, i915.enable_execlists, int, 0400);
  MODULE_PARM_DESC(enable_execlists,
   Override execlists usage. 
 - (-1=auto [default], 0=disabled, 1=enabled));
 + (-1=auto, 0=disabled [default], 1=enabled));

  module_param_named(enable_psr, i915.enable_psr, int, 0600);
  MODULE_PARM_DESC(enable_psr, Enable PSR (default: false));
 --
 1.8.3.1

 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx

 --
 Jani Nikula, Intel Open Source Technology Center
 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/bdw: Disable execlists by default

2014-08-15 Thread Damien Lespiau 
We still have a few missing bits and pieces to have execlists enabled by
default eg. the error capture or the render state initialization and so
it wouldn't be wise to enable it by default on BDW just yet.

Cc: Daniel Vetter daniel.vet...@ffwll.ch
Cc: Thomas Daniel thomas.dan...@intel.com
Signed-off-by: Damien Lespiau damien.lesp...@intel.com
---
 drivers/gpu/drm/i915/i915_params.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_params.c 
b/drivers/gpu/drm/i915/i915_params.c
index 0886aca..139f490 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = {
.vbt_sdvo_panel_type = -1,
.enable_rc6 = -1,
.enable_fbc = -1,
-   .enable_execlists = -1,
+   .enable_execlists = 0,
.enable_hangcheck = true,
.enable_ppgtt = -1,
.enable_psr = 0,
@@ -122,7 +122,7 @@ MODULE_PARM_DESC(enable_ppgtt,
 module_param_named(enable_execlists, i915.enable_execlists, int, 0400);
 MODULE_PARM_DESC(enable_execlists,
Override execlists usage. 
-   (-1=auto [default], 0=disabled, 1=enabled));
+   (-1=auto, 0=disabled [default], 1=enabled));
 
 module_param_named(enable_psr, i915.enable_psr, int, 0600);
 MODULE_PARM_DESC(enable_psr, Enable PSR (default: false));
-- 
1.8.3.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx