Re: [Intel-gfx] [PATCH] drm/i915/display: no need for gt/gen8_ppgtt.h
On Thu, 08 Dec 2022, Lucas De Marchi wrote: > On Thu, Dec 08, 2022 at 03:36:38PM +0200, Jani Nikula wrote: >>Remove an unnecessary include. >> >>Signed-off-by: Jani Nikula > > maybe we should run a script/something to check for unneeded includes > and commit everything? Then we can add a check in CI > > include-what-you-use does this, but I'm not sure it can grok > kernel / i915 > > Anyway, > > Reviewed-by: Lucas De Marchi Also, thanks. Pushed to drm-intel-next. BR, Jani. > > Lucas De Marchi > >>--- >> drivers/gpu/drm/i915/display/intel_display.c | 2 -- >> 1 file changed, 2 deletions(-) >> >>diff --git a/drivers/gpu/drm/i915/display/intel_display.c >>b/drivers/gpu/drm/i915/display/intel_display.c >>index 32b257157186..6cdfdae2c712 100644 >>--- a/drivers/gpu/drm/i915/display/intel_display.c >>+++ b/drivers/gpu/drm/i915/display/intel_display.c >>@@ -70,8 +70,6 @@ >> #include "gem/i915_gem_lmem.h" >> #include "gem/i915_gem_object.h" >> >>-#include "gt/gen8_ppgtt.h" >>- >> #include "g4x_dp.h" >> #include "g4x_hdmi.h" >> #include "hsw_ips.h" >>-- >>2.34.1 >> -- Jani Nikula, Intel Open Source Graphics Center
Re: [Intel-gfx] [PATCH] drm/i915/display: no need for gt/gen8_ppgtt.h
On Thu, 08 Dec 2022, Lucas De Marchi wrote: > On Thu, Dec 08, 2022 at 03:36:38PM +0200, Jani Nikula wrote: >>Remove an unnecessary include. >> >>Signed-off-by: Jani Nikula > > maybe we should run a script/something to check for unneeded includes > and commit everything? Then we can add a check in CI > > include-what-you-use does this, but I'm not sure it can grok > kernel / i915 Yeah I've looked at it. Would be nice to use it via CHECK=iwyu, but it needs a wrapper to deal with the parameters, and haven't gotten around to that yet. And from past experience with iwyu, I'm not really expecting a whole lot. It can be a bit overzealous. BR, Jani. > > Anyway, > > Reviewed-by: Lucas De Marchi > > Lucas De Marchi > >>--- >> drivers/gpu/drm/i915/display/intel_display.c | 2 -- >> 1 file changed, 2 deletions(-) >> >>diff --git a/drivers/gpu/drm/i915/display/intel_display.c >>b/drivers/gpu/drm/i915/display/intel_display.c >>index 32b257157186..6cdfdae2c712 100644 >>--- a/drivers/gpu/drm/i915/display/intel_display.c >>+++ b/drivers/gpu/drm/i915/display/intel_display.c >>@@ -70,8 +70,6 @@ >> #include "gem/i915_gem_lmem.h" >> #include "gem/i915_gem_object.h" >> >>-#include "gt/gen8_ppgtt.h" >>- >> #include "g4x_dp.h" >> #include "g4x_hdmi.h" >> #include "hsw_ips.h" >>-- >>2.34.1 >> -- Jani Nikula, Intel Open Source Graphics Center
Re: [Intel-gfx] [PATCH] drm/i915/display: no need for gt/gen8_ppgtt.h
On Thu, Dec 08, 2022 at 03:36:38PM +0200, Jani Nikula wrote: Remove an unnecessary include. Signed-off-by: Jani Nikula maybe we should run a script/something to check for unneeded includes and commit everything? Then we can add a check in CI include-what-you-use does this, but I'm not sure it can grok kernel / i915 Anyway, Reviewed-by: Lucas De Marchi Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 32b257157186..6cdfdae2c712 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -70,8 +70,6 @@ #include "gem/i915_gem_lmem.h" #include "gem/i915_gem_object.h" -#include "gt/gen8_ppgtt.h" - #include "g4x_dp.h" #include "g4x_hdmi.h" #include "hsw_ips.h" -- 2.34.1
[Intel-gfx] [PATCH] drm/i915/display: no need for gt/gen8_ppgtt.h
Remove an unnecessary include. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 32b257157186..6cdfdae2c712 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -70,8 +70,6 @@ #include "gem/i915_gem_lmem.h" #include "gem/i915_gem_object.h" -#include "gt/gen8_ppgtt.h" - #include "g4x_dp.h" #include "g4x_hdmi.h" #include "hsw_ips.h" -- 2.34.1
