Re: [Intel-gfx] [PATCH] drm/i915/pxp: prefer forward declaration over includes

2022-02-17 Thread Matt Roper
On Mon, Feb 14, 2022 at 07:36:44PM +0200, Jani Nikula wrote:
> Always use forward declarations instead of includes in headers if
> possible.
> 
> Signed-off-by: Jani Nikula 

Reviewed-by: Matt Roper 

> ---
>  drivers/gpu/drm/i915/pxp/intel_pxp_pm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_pm.h 
> b/drivers/gpu/drm/i915/pxp/intel_pxp_pm.h
> index 16990a3f2f85..586be769104f 100644
> --- a/drivers/gpu/drm/i915/pxp/intel_pxp_pm.h
> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_pm.h
> @@ -6,7 +6,7 @@
>  #ifndef __INTEL_PXP_PM_H__
>  #define __INTEL_PXP_PM_H__
>  
> -#include "intel_pxp_types.h"
> +struct intel_pxp;
>  
>  #ifdef CONFIG_DRM_I915_PXP
>  void intel_pxp_suspend_prepare(struct intel_pxp *pxp);
> -- 
> 2.30.2
> 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795


[Intel-gfx] [PATCH] drm/i915/pxp: prefer forward declaration over includes

2022-02-14 Thread Jani Nikula
Always use forward declarations instead of includes in headers if
possible.

Signed-off-by: Jani Nikula 
---
 drivers/gpu/drm/i915/pxp/intel_pxp_pm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_pm.h 
b/drivers/gpu/drm/i915/pxp/intel_pxp_pm.h
index 16990a3f2f85..586be769104f 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp_pm.h
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp_pm.h
@@ -6,7 +6,7 @@
 #ifndef __INTEL_PXP_PM_H__
 #define __INTEL_PXP_PM_H__
 
-#include "intel_pxp_types.h"
+struct intel_pxp;
 
 #ifdef CONFIG_DRM_I915_PXP
 void intel_pxp_suspend_prepare(struct intel_pxp *pxp);
-- 
2.30.2