Re: [Intel-gfx] [PATCH] drm/i915: Add media rc6 residency file to sysfs

2015-02-28 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: 
shuang...@intel.com)
Task id: 5841
-Summary-
Platform  Delta  drm-intel-nightly  Series Applied
PNV -1  282/282  281/282
ILK  308/308  308/308
SNB -1  326/326  325/326
IVB  379/379  379/379
BYT  294/294  294/294
HSW  387/387  387/387
BDW -1  316/316  315/316
-Detailed-
Platform  Testdrm-intel-nightly  Series 
Applied
 PNV  igt_gem_userptr_blits_minor-unsync-normal  DMESG_WARN(1)PASS(3)  
DMESG_WARN(1)PASS(1)
*SNB  igt_pm_rpm_fences-dpms  PASS(3)  DMESG_WARN(1)PASS(1)
*BDW  igt_gem_gtt_hog  PASS(15)  DMESG_WARN(1)PASS(1)
Note: You need to pay more attention to line start with '*'
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH] drm/i915: Add media rc6 residency file to sysfs

2015-02-26 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 09:10:27PM +0530, deepa...@linux.intel.com wrote:
> From: Ville Syrjälä 
> 
> On VLV/CHV the media well rc6 residency gets reported separately
> from the render well, so add another file to sysfs so that we can
> report the residency to the user.
> 
> Testcase: igt/pm_rc6_residency --run-subtest media-rc6-accuracy
> Reviewed-by: Chris Wilson 
> Signed-off-by: Ville Syrjälä 
> Signed-off-by: Deepak S 

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH] drm/i915: Add media rc6 residency file to sysfs

2015-02-26 Thread deepak . s
From: Ville Syrjälä 

On VLV/CHV the media well rc6 residency gets reported separately
from the render well, so add another file to sysfs so that we can
report the residency to the user.

Testcase: igt/pm_rc6_residency --run-subtest media-rc6-accuracy
Reviewed-by: Chris Wilson 
Signed-off-by: Ville Syrjälä 
Signed-off-by: Deepak S 
---
 drivers/gpu/drm/i915/i915_sysfs.c | 25 +
 1 file changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_sysfs.c 
b/drivers/gpu/drm/i915/i915_sysfs.c
index cdc9da0..1f269e0 100644
--- a/drivers/gpu/drm/i915/i915_sysfs.c
+++ b/drivers/gpu/drm/i915/i915_sysfs.c
@@ -127,10 +127,19 @@ show_rc6pp_ms(struct device *kdev, struct 
device_attribute *attr, char *buf)
return snprintf(buf, PAGE_SIZE, "%u\n", rc6pp_residency);
 }
 
+static ssize_t
+show_media_rc6_ms(struct device *kdev, struct device_attribute *attr, char 
*buf)
+{
+   struct drm_minor *dminor = dev_get_drvdata(kdev);
+   u32 rc6_residency = calc_residency(dminor->dev, VLV_GT_MEDIA_RC6);
+   return snprintf(buf, PAGE_SIZE, "%u\n", rc6_residency);
+}
+
 static DEVICE_ATTR(rc6_enable, S_IRUGO, show_rc6_mask, NULL);
 static DEVICE_ATTR(rc6_residency_ms, S_IRUGO, show_rc6_ms, NULL);
 static DEVICE_ATTR(rc6p_residency_ms, S_IRUGO, show_rc6p_ms, NULL);
 static DEVICE_ATTR(rc6pp_residency_ms, S_IRUGO, show_rc6pp_ms, NULL);
+static DEVICE_ATTR(media_rc6_residency_ms, S_IRUGO, show_media_rc6_ms, NULL);
 
 static struct attribute *rc6_attrs[] = {
&dev_attr_rc6_enable.attr,
@@ -153,6 +162,16 @@ static struct attribute_group rc6p_attr_group = {
.name = power_group_name,
.attrs =  rc6p_attrs
 };
+
+static struct attribute *media_rc6_attrs[] = {
+   &dev_attr_media_rc6_residency_ms.attr,
+   NULL
+};
+
+static struct attribute_group media_rc6_attr_group = {
+   .name = power_group_name,
+   .attrs =  media_rc6_attrs
+};
 #endif
 
 static int l3_access_valid(struct drm_device *dev, loff_t offset)
@@ -627,6 +646,12 @@ void i915_setup_sysfs(struct drm_device *dev)
if (ret)
DRM_ERROR("RC6p residency sysfs setup failed\n");
}
+   if (IS_VALLEYVIEW(dev)) {
+   ret = sysfs_merge_group(&dev->primary->kdev->kobj,
+   &media_rc6_attr_group);
+   if (ret)
+   DRM_ERROR("Media RC6 residency sysfs setup failed\n");
+   }
 #endif
if (HAS_L3_DPF(dev)) {
ret = device_create_bin_file(dev->primary->kdev, &dpf_attrs);
-- 
1.9.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx