Re: [Intel-gfx] [PATCH] drm/i915: Add new DG2 PCI IDs
On Wed, Oct 11, 2023 at 10:26:00AM +0530, Shekhar Chauhan wrote: > Add new PCI IDs which are recently added. > > BSpec: 44477 > Signed-off-by: Shekhar Chauhan > --- > include/drm/i915_pciids.h | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index 1256770d3827..deb2eb0b4979 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -692,7 +692,7 @@ > INTEL_VGA_DEVICE(0xA7A9, info), \ > INTEL_VGA_DEVICE(0xA7AC, info), \ > INTEL_VGA_DEVICE(0xA7AD, info) > - > +h Looks like some stray garbage accidentally ended up on this line. Aside from that, the actual changes below look good, so Reviewed-by: Matt Roper with that cleaned up. Matt > /* RPL-P */ > #define INTEL_RPLP_IDS(info) \ > INTEL_RPLU_IDS(info), \ > @@ -718,7 +718,11 @@ > INTEL_VGA_DEVICE(0x56A5, info), \ > INTEL_VGA_DEVICE(0x56A6, info), \ > INTEL_VGA_DEVICE(0x56B0, info), \ > - INTEL_VGA_DEVICE(0x56B1, info) > + INTEL_VGA_DEVICE(0x56B1, info), \ > + INTEL_VGA_DEVICE(0x56BA, info), \ > + INTEL_VGA_DEVICE(0x56BB, info), \ > + INTEL_VGA_DEVICE(0x56BC, info), \ > + INTEL_VGA_DEVICE(0x56BD, info) > > #define INTEL_DG2_G12_IDS(info) \ > INTEL_VGA_DEVICE(0x5696, info), \ > -- > 2.34.1 > -- Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [Intel-gfx] [PATCH] drm/i915: Add new DG2 PCI IDs
Hi Shekhar,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-tip/drm-tip]
url:
https://github.com/intel-lab-lkp/linux/commits/Shekhar-Chauhan/drm-i915-Add-new-DG2-PCI-IDs/20231011-125855
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link:
https://lore.kernel.org/r/20231011045600.2710486-1-shekhar.chauhan%40intel.com
patch subject: [Intel-gfx] [PATCH] drm/i915: Add new DG2 PCI IDs
config: i386-buildonly-randconfig-002-20231011
(https://download.01.org/0day-ci/archive/20231011/202310111551.luegqmmh-...@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20231011/202310111551.luegqmmh-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202310111551.luegqmmh-...@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/i915_pci.c:27:
>> include/drm/i915_pciids.h:695:2: error: expected ';' before 'enum'
695 | h
| ^
| ;
--
In file included from drivers/gpu/drm/i915/display/intel_display_device.c:6:
>> include/drm/i915_pciids.h:695:2: error: expected ';' before 'void'
695 | h
| ^
| ;
vim +695 include/drm/i915_pciids.h
27
28 /*
29 * A pci_device_id struct {
30 * __u32 vendor, device;
31 * __u32 subvendor, subdevice;
32 * __u32 class, class_mask;
33 * kernel_ulong_t driver_data;
34 * };
35 * Don't use C99 here because "class" is reserved and we want to
36 * give userspace flexibility.
37 */
38 #define INTEL_VGA_DEVICE(id, info) {\
39 0x8086, id, \
40 ~0, ~0, \
41 0x03, 0xff, \
42 (unsigned long) info }
43
44 #define INTEL_QUANTA_VGA_DEVICE(info) { \
45 0x8086, 0x16a, \
46 0x152d, 0x8990, \
47 0x03, 0xff, \
48 (unsigned long) info }
49
50 #define INTEL_I810_IDS(info)\
51 INTEL_VGA_DEVICE(0x7121, info), /* I810 */ \
52 INTEL_VGA_DEVICE(0x7123, info), /* I810_DC100 */\
53 INTEL_VGA_DEVICE(0x7125, info) /* I810_E */
54
55 #define INTEL_I815_IDS(info)\
56 INTEL_VGA_DEVICE(0x1132, info) /* I815*/
57
58 #define INTEL_I830_IDS(info)\
59 INTEL_VGA_DEVICE(0x3577, info)
60
61 #define INTEL_I845G_IDS(info) \
62 INTEL_VGA_DEVICE(0x2562, info)
63
64 #define INTEL_I85X_IDS(info)\
65 INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */ \
66 INTEL_VGA_DEVICE(0x358e, info)
67
68 #define INTEL_I865G_IDS(info) \
69 INTEL_VGA_DEVICE(0x2572, info) /* I865_G */
70
71 #define INTEL_I915G_IDS(info) \
72 INTEL_VGA_DEVICE(0x2582, info), /* I915_G */ \
73 INTEL_VGA_DEVICE(0x258a, info) /* E7221_G */
74
75 #define INTEL_I915GM_IDS(info) \
76 INTEL_VGA_DEVICE(0x2592, info) /* I915_GM */
77
78 #define INTEL_I945G_IDS(info) \
79 INTEL_VGA_DEVICE(0x2772, info) /* I945_G */
80
81 #define INTEL_I945GM_IDS(info) \
82 INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */ \
83 INTEL_VGA_DEVICE(0x27ae, info) /* I945_GME */
84
85 #define INTEL_I965G_IDS(info) \
86 INTEL_VGA_DEVICE(0x2972, info), /* I946_GZ */ \
87 INTEL_VGA_DEVICE(0x2982, info), /* G35_G */ \
88 INTEL_VGA_DEVICE(0x2992, info), /* I965_Q */\
89 INTEL_VGA_DEVICE(0x29a2, info) /* I965_G */
90
91 #define INTEL_G33_IDS(info) \
92 INTEL_VGA_DEVICE(0x29b2, info), /* Q35_G */ \
93 INTEL_VGA_DEVICE(0x29c2, info), /* G33_G */ \
94 INTEL_VGA_DEVICE(0x29d2, info) /* Q33_G */
95
96 #define INTEL_I965GM_IDS(info) \
97 INTEL_VGA_DEVICE(0x2a02, info), /* I965_GM */ \
98 INTEL_VGA_DEVICE(0x2a12, info) /* I965_GME */
99
100 #define INTEL_GM45_IDS(info)\
101 INTEL_VGA_DEVICE(0x2a42, info) /* GM45_G
Re: [Intel-gfx] [PATCH] drm/i915: Add new DG2 PCI IDs
Hi Shekhar,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-tip/drm-tip]
url:
https://github.com/intel-lab-lkp/linux/commits/Shekhar-Chauhan/drm-i915-Add-new-DG2-PCI-IDs/20231011-125855
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link:
https://lore.kernel.org/r/20231011045600.2710486-1-shekhar.chauhan%40intel.com
patch subject: [Intel-gfx] [PATCH] drm/i915: Add new DG2 PCI IDs
config: x86_64-randconfig-073-20231011
(https://download.01.org/0day-ci/archive/20231011/202310111502.xjyxwhlx-...@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20231011/202310111502.xjyxwhlx-...@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Closes:
https://lore.kernel.org/oe-kbuild-all/202310111502.xjyxwhlx-...@intel.com/
All errors (new ones prefixed by >>):
In file included from arch/x86/kernel/early-quirks.c:21:
>> include/drm/i915_pciids.h:695:2: error: expected ';' before 'extern'
695 | h
| ^
| ;
vim +695 include/drm/i915_pciids.h
27
28 /*
29 * A pci_device_id struct {
30 * __u32 vendor, device;
31 * __u32 subvendor, subdevice;
32 * __u32 class, class_mask;
33 * kernel_ulong_t driver_data;
34 * };
35 * Don't use C99 here because "class" is reserved and we want to
36 * give userspace flexibility.
37 */
38 #define INTEL_VGA_DEVICE(id, info) {\
39 0x8086, id, \
40 ~0, ~0, \
41 0x03, 0xff, \
42 (unsigned long) info }
43
44 #define INTEL_QUANTA_VGA_DEVICE(info) { \
45 0x8086, 0x16a, \
46 0x152d, 0x8990, \
47 0x03, 0xff, \
48 (unsigned long) info }
49
50 #define INTEL_I810_IDS(info)\
51 INTEL_VGA_DEVICE(0x7121, info), /* I810 */ \
52 INTEL_VGA_DEVICE(0x7123, info), /* I810_DC100 */\
53 INTEL_VGA_DEVICE(0x7125, info) /* I810_E */
54
55 #define INTEL_I815_IDS(info)\
56 INTEL_VGA_DEVICE(0x1132, info) /* I815*/
57
58 #define INTEL_I830_IDS(info)\
59 INTEL_VGA_DEVICE(0x3577, info)
60
61 #define INTEL_I845G_IDS(info) \
62 INTEL_VGA_DEVICE(0x2562, info)
63
64 #define INTEL_I85X_IDS(info)\
65 INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */ \
66 INTEL_VGA_DEVICE(0x358e, info)
67
68 #define INTEL_I865G_IDS(info) \
69 INTEL_VGA_DEVICE(0x2572, info) /* I865_G */
70
71 #define INTEL_I915G_IDS(info) \
72 INTEL_VGA_DEVICE(0x2582, info), /* I915_G */ \
73 INTEL_VGA_DEVICE(0x258a, info) /* E7221_G */
74
75 #define INTEL_I915GM_IDS(info) \
76 INTEL_VGA_DEVICE(0x2592, info) /* I915_GM */
77
78 #define INTEL_I945G_IDS(info) \
79 INTEL_VGA_DEVICE(0x2772, info) /* I945_G */
80
81 #define INTEL_I945GM_IDS(info) \
82 INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */ \
83 INTEL_VGA_DEVICE(0x27ae, info) /* I945_GME */
84
85 #define INTEL_I965G_IDS(info) \
86 INTEL_VGA_DEVICE(0x2972, info), /* I946_GZ */ \
87 INTEL_VGA_DEVICE(0x2982, info), /* G35_G */ \
88 INTEL_VGA_DEVICE(0x2992, info), /* I965_Q */\
89 INTEL_VGA_DEVICE(0x29a2, info) /* I965_G */
90
91 #define INTEL_G33_IDS(info) \
92 INTEL_VGA_DEVICE(0x29b2, info), /* Q35_G */ \
93 INTEL_VGA_DEVICE(0x29c2, info), /* G33_G */ \
94 INTEL_VGA_DEVICE(0x29d2, info) /* Q33_G */
95
96 #define INTEL_I965GM_IDS(info) \
97 INTEL_VGA_DEVICE(0x2a02, info), /* I965_GM */ \
98 INTEL_VGA_DEVICE(0x2a12, info) /* I965_GME */
99
100 #define INTEL_GM45_IDS(info)\
101 INTEL_VGA_DEVICE(0x2a42, info) /* GM45_G */
102
103 #define INTEL_G45_IDS(info) \
104 INTEL_VGA_DEVICE(0x2e02, info), /* IGD_E_G */ \
105 INTEL_VGA_DEVICE(0x2e12, info)
[Intel-gfx] [PATCH] drm/i915: Add new DG2 PCI IDs
Add new PCI IDs which are recently added. BSpec: 44477 Signed-off-by: Shekhar Chauhan --- include/drm/i915_pciids.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 1256770d3827..deb2eb0b4979 100644 --- a/include/drm/i915_pciids.h +++ b/include/drm/i915_pciids.h @@ -692,7 +692,7 @@ INTEL_VGA_DEVICE(0xA7A9, info), \ INTEL_VGA_DEVICE(0xA7AC, info), \ INTEL_VGA_DEVICE(0xA7AD, info) - +h /* RPL-P */ #define INTEL_RPLP_IDS(info) \ INTEL_RPLU_IDS(info), \ @@ -718,7 +718,11 @@ INTEL_VGA_DEVICE(0x56A5, info), \ INTEL_VGA_DEVICE(0x56A6, info), \ INTEL_VGA_DEVICE(0x56B0, info), \ - INTEL_VGA_DEVICE(0x56B1, info) + INTEL_VGA_DEVICE(0x56B1, info), \ + INTEL_VGA_DEVICE(0x56BA, info), \ + INTEL_VGA_DEVICE(0x56BB, info), \ + INTEL_VGA_DEVICE(0x56BC, info), \ + INTEL_VGA_DEVICE(0x56BD, info) #define INTEL_DG2_G12_IDS(info) \ INTEL_VGA_DEVICE(0x5696, info), \ -- 2.34.1
