Re: [Intel-gfx] [PATCH] drm/i915: Fix cursor visibility check with negative coordinates

[Chris Wilson]

On Mon, Sep 02, 2013 at 09:16:50PM +0300, ville.syrj...@linux.intel.com wrote:
 From: Ville Syrjälä ville.syrj...@linux.intel.com
 
 When the cursor x coordinate is exactly -cursor_width, the cursor is
 invisible. And obviously the same holds for the y coordinate and
 cursor_height.

And similarly for the earlier x == fb-width checks.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Fix cursor visibility check with negative coordinates

[ville . syrjala]

From: Ville Syrjälä ville.syrj...@linux.intel.com

When the cursor x coordinate is exactly -cursor_width, the cursor is
invisible. And obviously the same holds for the y coordinate and
cursor_height.

Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com
---
 drivers/gpu/drm/i915/intel_display.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c 
b/drivers/gpu/drm/i915/intel_display.c
index 17fe7ed..42e65ce 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6857,7 +6857,7 @@ static void intel_crtc_update_cursor(struct drm_crtc 
*crtc,
base = 0;
 
if (x  0) {
-   if (x + intel_crtc-cursor_width  0)
+   if (x + intel_crtc-cursor_width = 0)
base = 0;
 
pos |= CURSOR_POS_SIGN  CURSOR_X_SHIFT;
@@ -6866,7 +6866,7 @@ static void intel_crtc_update_cursor(struct drm_crtc 
*crtc,
pos |= x  CURSOR_X_SHIFT;
 
if (y  0) {
-   if (y + intel_crtc-cursor_height  0)
+   if (y + intel_crtc-cursor_height = 0)
base = 0;
 
pos |= CURSOR_POS_SIGN  CURSOR_Y_SHIFT;
-- 
1.8.1.5

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx