[Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
Our driver compiles clean (nowadays thanks to 0day) but for me, at least, it would be beneficial if the compiler threw an error rather than a warning when it found a piece of suspect code. (I use this to compile-check patch series and want to break on the first compiler error in order to fix the patch.) v2: Kick off a new "Debugging" submenu for i915.ko v3: Avoid enabling -Werror for allyesconfig/allmodconfig builds, using COMPILE_TEST as a suitable proxy suggested by Andrew Morton. (Damien) Only make the option available for EXPERT to reinforce that the option should not be casually enabled. Signed-off-by: Chris Wilson Cc: Jani Nikula Cc: Damien Lespiau --- drivers/gpu/drm/i915/Kconfig | 8 drivers/gpu/drm/i915/Kconfig.debug | 12 drivers/gpu/drm/i915/Makefile | 2 ++ 3 files changed, 22 insertions(+) create mode 100644 drivers/gpu/drm/i915/Kconfig.debug diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index fcd77b27514d..d493ec4c7399 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -48,3 +48,11 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT option changes the default for that module option. If in doubt, say "N". + +menu "DRM i915 Debugging" + +depends on DRM_I915 + +source drivers/gpu/drm/i915/Kconfig.debug + +endmenu diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug new file mode 100644 index ..1f10ee228eda --- /dev/null +++ b/drivers/gpu/drm/i915/Kconfig.debug @@ -0,0 +1,12 @@ +config DRM_I915_WERROR + bool "Force GCC to throw an error instead of a warning when compiling" + default n + # As this may inadvertently break the build, only allow the user + # to shoot oneself in the foot iff they aim really hard + depends on EXPERT + # We use the dependency on !COMPILE_TEST to not be enabled in + # allmodconfig or allyesconfig configurations + depends on !COMPILE_TEST + ---help--- + Add -Werror to the build flags for (and only for) i915.ko. + Do not enable this unless you are writing code for the i915.ko module. diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index 0851de07bd13..1e9895b9a546 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -2,6 +2,8 @@ # Makefile for the drm device driver. This driver provides support for the # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. +subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror + # Please keep these build lists sorted! # core driver code -- 2.6.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
Our driver compiles clean (nowadays thanks to 0day) but for me, at least, it would be beneficial if the compiler threw an error rather than a warning when it found a piece of suspect code. (I use this to compile-check patch series and want to break on the first compiler error in order to fix the patch.) v2: Kick off a new "Debugging" submenu for i915.ko At this point, we applied it to the kernel and promptly kicked it out again as it broke buildbots (due to a compiler warning on 32bits): commit 908d759b210effb33d927a8cb6603a16448474e4 Author: Daniel Vetter Date: Tue May 26 07:46:21 2015 +0200 Revert "drm/i915: Force clean compilation with -Werror" v3: Avoid enabling -Werror for allyesconfig/allmodconfig builds, using COMPILE_TEST as a suitable proxy suggested by Andrew Morton. (Damien) Only make the option available for EXPERT to reinforce that the option should not be casually enabled. Signed-off-by: Chris Wilson Cc: Jani Nikula Cc: Damien Lespiau Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/Kconfig | 8 drivers/gpu/drm/i915/Kconfig.debug | 12 drivers/gpu/drm/i915/Makefile | 2 ++ 3 files changed, 22 insertions(+) create mode 100644 drivers/gpu/drm/i915/Kconfig.debug diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index fcd77b27514d..d493ec4c7399 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -48,3 +48,11 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT option changes the default for that module option. If in doubt, say "N". + +menu "DRM i915 Debugging" + +depends on DRM_I915 + +source drivers/gpu/drm/i915/Kconfig.debug + +endmenu diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug new file mode 100644 index ..1f10ee228eda --- /dev/null +++ b/drivers/gpu/drm/i915/Kconfig.debug @@ -0,0 +1,12 @@ +config DRM_I915_WERROR + bool "Force GCC to throw an error instead of a warning when compiling" + default n + # As this may inadvertently break the build, only allow the user + # to shoot oneself in the foot iff they aim really hard + depends on EXPERT + # We use the dependency on !COMPILE_TEST to not be enabled in + # allmodconfig or allyesconfig configurations + depends on !COMPILE_TEST + ---help--- + Add -Werror to the build flags for (and only for) i915.ko. + Do not enable this unless you are writing code for the i915.ko module. diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index 0851de07bd13..1e9895b9a546 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -2,6 +2,8 @@ # Makefile for the drm device driver. This driver provides support for the # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. +subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror + # Please keep these build lists sorted! # core driver code -- 2.6.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
Our driver compiles clean (nowadays thanks to 0day) but for me, at least, it would be beneficial if the compiler threw an error rather than a warning when it found a piece of suspect code. (I use this to compile-check patch series and want to break on the first compiler error in order to fix the patch.) v2: Kick off a new "Debugging" submenu for i915.ko At this point, we applied it to the kernel and promptly kicked it out again as it broke buildbots (due to a compiler warning on 32bits): commit 908d759b210effb33d927a8cb6603a16448474e4 Author: Daniel Vetter Date: Tue May 26 07:46:21 2015 +0200 Revert "drm/i915: Force clean compilation with -Werror" v3: Avoid enabling -Werror for allyesconfig/allmodconfig builds, using COMPILE_TEST as a suitable proxy suggested by Andrew Morton. (Damien) Only make the option available for EXPERT to reinforce that the option should not be casually enabled. Signed-off-by: Chris Wilson Cc: Jani Nikula Cc: Damien Lespiau Reviewed-by: Daniel Vetter --- This is a test! I'm seeing whether I can route git send-email through gmail. Thanks for your patience. -Chris --- drivers/gpu/drm/i915/Kconfig | 6 ++ drivers/gpu/drm/i915/Kconfig.debug | 12 drivers/gpu/drm/i915/Makefile | 2 ++ 3 files changed, 20 insertions(+) create mode 100644 drivers/gpu/drm/i915/Kconfig.debug diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index b979295aab82..33e8563c2f99 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -59,3 +59,9 @@ config DRM_I915_USERPTR selected to enabled full userptr support. If in doubt, say "Y". + +menu "drm/i915 Debugging" +depends on DRM_I915 +depends on EXPERT +source drivers/gpu/drm/i915/Kconfig.debug +endmenu diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug new file mode 100644 index ..1f10ee228eda --- /dev/null +++ b/drivers/gpu/drm/i915/Kconfig.debug @@ -0,0 +1,12 @@ +config DRM_I915_WERROR + bool "Force GCC to throw an error instead of a warning when compiling" + default n + # As this may inadvertently break the build, only allow the user + # to shoot oneself in the foot iff they aim really hard + depends on EXPERT + # We use the dependency on !COMPILE_TEST to not be enabled in + # allmodconfig or allyesconfig configurations + depends on !COMPILE_TEST + ---help--- + Add -Werror to the build flags for (and only for) i915.ko. + Do not enable this unless you are writing code for the i915.ko module. diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index 0851de07bd13..1e9895b9a546 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -2,6 +2,8 @@ # Makefile for the drm device driver. This driver provides support for the # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. +subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror + # Please keep these build lists sorted! # core driver code -- 2.6.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
Our driver compiles clean (nowadays thanks to 0day) but for me, at least, it would be beneficial if the compiler threw an error rather than a warning when it found a piece of suspect code. (I use this to compile-check patch series and want to break on the first compiler error in order to fix the patch.) Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index b7ddf48e1d75..5b2a6e039500 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -2,6 +2,8 @@ # Makefile for the drm device driver. This driver provides support for the # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. +subdir-ccflags-y := -Werror + # Please keep these build lists sorted! # core driver code -- 2.1.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
Our driver compiles clean (nowadays thanks to 0day) but for me, at least, it would be beneficial if the compiler threw an error rather than a warning when it found a piece of suspect code. (I use this to compile-check patch series and want to break on the first compiler error in order to fix the patch.) v2: Kick off a new "Debugging" submenu for i915.ko Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Kconfig | 8 drivers/gpu/drm/i915/Kconfig.debug | 5 + drivers/gpu/drm/i915/Makefile | 2 ++ 3 files changed, 15 insertions(+) create mode 100644 drivers/gpu/drm/i915/Kconfig.debug diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 74acca9bcd9d..76c425ca2a2c 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -71,3 +71,11 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT option changes the default for that module option. If in doubt, say "N". + +menu "Debugging" + +depends on DRM_I915 + +source drivers/gpu/drm/i915/Kconfig.debug + +endmenu diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug new file mode 100644 index ..070a03527bc5 --- /dev/null +++ b/drivers/gpu/drm/i915/Kconfig.debug @@ -0,0 +1,5 @@ +config DRM_I915_WERROR + bool "Force GCC to throw an error instead of a warning when compiling" + default n + ---help--- + Add -Werror to the build flags for (and only for) i915.ko diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index b7ddf48e1d75..93d99b744531 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -2,6 +2,8 @@ # Makefile for the drm device driver. This driver provides support for the # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. +subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror + # Please keep these build lists sorted! # core driver code -- 2.1.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
On Mon, Dec 14, 2015 at 02:03:33PM +, Chris Wilson wrote: > Our driver compiles clean (nowadays thanks to 0day) but for me, at least, > it would be beneficial if the compiler threw an error rather than a > warning when it found a piece of suspect code. (I use this to > compile-check patch series and want to break on the first compiler error > in order to fix the patch.) > > v2: Kick off a new "Debugging" submenu for i915.ko > > v3: Avoid enabling -Werror for allyesconfig/allmodconfig builds, using > COMPILE_TEST as a suitable proxy suggested by Andrew Morton. (Damien) > Only make the option available for EXPERT to reinforce that the option > should not be casually enabled. > > Signed-off-by: Chris Wilson > Cc: Jani Nikula > Cc: Damien Lespiau Yeah I think we can give this another shot. Should probably reference the last revert: commit 908d759b210effb33d927a8cb6603a16448474e4 Author: Daniel Vetter Date: Tue May 26 07:46:21 2015 +0200 Revert "drm/i915: Force clean compilation with -Werror" With that added: Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/Kconfig | 8 > drivers/gpu/drm/i915/Kconfig.debug | 12 > drivers/gpu/drm/i915/Makefile | 2 ++ > 3 files changed, 22 insertions(+) > create mode 100644 drivers/gpu/drm/i915/Kconfig.debug > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > index fcd77b27514d..d493ec4c7399 100644 > --- a/drivers/gpu/drm/i915/Kconfig > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -48,3 +48,11 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT > option changes the default for that module option. > > If in doubt, say "N". > + > +menu "DRM i915 Debugging" > + > +depends on DRM_I915 > + > +source drivers/gpu/drm/i915/Kconfig.debug > + > +endmenu > diff --git a/drivers/gpu/drm/i915/Kconfig.debug > b/drivers/gpu/drm/i915/Kconfig.debug > new file mode 100644 > index ..1f10ee228eda > --- /dev/null > +++ b/drivers/gpu/drm/i915/Kconfig.debug > @@ -0,0 +1,12 @@ > +config DRM_I915_WERROR > + bool "Force GCC to throw an error instead of a warning when compiling" > + default n > + # As this may inadvertently break the build, only allow the user > + # to shoot oneself in the foot iff they aim really hard > + depends on EXPERT > + # We use the dependency on !COMPILE_TEST to not be enabled in > + # allmodconfig or allyesconfig configurations > + depends on !COMPILE_TEST > + ---help--- > + Add -Werror to the build flags for (and only for) i915.ko. > + Do not enable this unless you are writing code for the i915.ko module. > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index 0851de07bd13..1e9895b9a546 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -2,6 +2,8 @@ > # Makefile for the drm device driver. This driver provides support for the > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > +subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror > + > # Please keep these build lists sorted! > > # core driver code > -- > 2.6.4 > > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
On Wed, May 20, 2015 at 11:35:28AM +0100, Chris Wilson wrote: > Our driver compiles clean (nowadays thanks to 0day) but for me, at least, > it would be beneficial if the compiler threw an error rather than a > warning when it found a piece of suspect code. (I use this to > compile-check patch series and want to break on the first compiler error > in order to fix the patch.) > > Signed-off-by: Chris Wilson Just to repeat what was said on IRC. -Werror is usally a no-go outside of a development environment because different compilers (which includes different compiler versions) will have different sets of warnings, even with the same options. It also breaks bisecting if, for instance, or more recent toolchain produces a warning that it didn't in a previous version and we're trying to compile an old commit. -- Damien > --- > drivers/gpu/drm/i915/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index b7ddf48e1d75..5b2a6e039500 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -2,6 +2,8 @@ > # Makefile for the drm device driver. This driver provides support for the > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > +subdir-ccflags-y := -Werror > + > # Please keep these build lists sorted! > > # core driver code > -- > 2.1.4 > > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
On Wed, May 20, 2015 at 02:12:47PM +0100, Chris Wilson wrote: > Our driver compiles clean (nowadays thanks to 0day) but for me, at least, > it would be beneficial if the compiler threw an error rather than a > warning when it found a piece of suspect code. (I use this to > compile-check patch series and want to break on the first compiler error > in order to fix the patch.) > > v2: Kick off a new "Debugging" submenu for i915.ko > > Signed-off-by: Chris Wilson I believe we could shove a few interesting things into that menu, sounds like a potentially useful thing to me: Acked-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/Kconfig | 8 > drivers/gpu/drm/i915/Kconfig.debug | 5 + > drivers/gpu/drm/i915/Makefile | 2 ++ > 3 files changed, 15 insertions(+) > create mode 100644 drivers/gpu/drm/i915/Kconfig.debug > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > index 74acca9bcd9d..76c425ca2a2c 100644 > --- a/drivers/gpu/drm/i915/Kconfig > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -71,3 +71,11 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT > option changes the default for that module option. > > If in doubt, say "N". > + > +menu "Debugging" > + > +depends on DRM_I915 > + > +source drivers/gpu/drm/i915/Kconfig.debug > + > +endmenu > diff --git a/drivers/gpu/drm/i915/Kconfig.debug > b/drivers/gpu/drm/i915/Kconfig.debug > new file mode 100644 > index ..070a03527bc5 > --- /dev/null > +++ b/drivers/gpu/drm/i915/Kconfig.debug > @@ -0,0 +1,5 @@ > +config DRM_I915_WERROR > + bool "Force GCC to throw an error instead of a warning when compiling" > + default n > + ---help--- > + Add -Werror to the build flags for (and only for) i915.ko > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index b7ddf48e1d75..93d99b744531 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -2,6 +2,8 @@ > # Makefile for the drm device driver. This driver provides support for the > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > +subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror > + > # Please keep these build lists sorted! > > # core driver code > -- > 2.1.4 > > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
On Wed, May 20, 2015 at 02:55:35PM +0100, Damien Lespiau wrote: > On Wed, May 20, 2015 at 02:12:47PM +0100, Chris Wilson wrote: > > Our driver compiles clean (nowadays thanks to 0day) but for me, at least, > > it would be beneficial if the compiler threw an error rather than a > > warning when it found a piece of suspect code. (I use this to > > compile-check patch series and want to break on the first compiler error > > in order to fix the patch.) > > > > v2: Kick off a new "Debugging" submenu for i915.ko > > > > Signed-off-by: Chris Wilson > > I believe we could shove a few interesting things into that menu, sounds > like a potentially useful thing to me: > > Acked-by: Damien Lespiau > > -- > Damien > > > --- > > drivers/gpu/drm/i915/Kconfig | 8 > > drivers/gpu/drm/i915/Kconfig.debug | 5 + > > drivers/gpu/drm/i915/Makefile | 2 ++ > > 3 files changed, 15 insertions(+) > > create mode 100644 drivers/gpu/drm/i915/Kconfig.debug > > > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > > index 74acca9bcd9d..76c425ca2a2c 100644 > > --- a/drivers/gpu/drm/i915/Kconfig > > +++ b/drivers/gpu/drm/i915/Kconfig > > @@ -71,3 +71,11 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT > > option changes the default for that module option. > > > > If in doubt, say "N". > > + > > +menu "Debugging" This has to be something more like "DRM I915_Debugging" as it is presented to the user without context in make oldconfig and appears verbatim in .config. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
On Wed, 20 May 2015, Chris Wilson wrote: > Our driver compiles clean (nowadays thanks to 0day) but for me, at least, > it would be beneficial if the compiler threw an error rather than a > warning when it found a piece of suspect code. (I use this to > compile-check patch series and want to break on the first compiler error > in order to fix the patch.) > > v2: Kick off a new "Debugging" submenu for i915.ko > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/Kconfig | 8 > drivers/gpu/drm/i915/Kconfig.debug | 5 + > drivers/gpu/drm/i915/Makefile | 2 ++ > 3 files changed, 15 insertions(+) > create mode 100644 drivers/gpu/drm/i915/Kconfig.debug > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > index 74acca9bcd9d..76c425ca2a2c 100644 > --- a/drivers/gpu/drm/i915/Kconfig > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -71,3 +71,11 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT > option changes the default for that module option. > > If in doubt, say "N". > + > +menu "Debugging" > + > +depends on DRM_I915 > + > +source drivers/gpu/drm/i915/Kconfig.debug > + > +endmenu > diff --git a/drivers/gpu/drm/i915/Kconfig.debug > b/drivers/gpu/drm/i915/Kconfig.debug > new file mode 100644 > index ..070a03527bc5 > --- /dev/null > +++ b/drivers/gpu/drm/i915/Kconfig.debug > @@ -0,0 +1,5 @@ > +config DRM_I915_WERROR > + bool "Force GCC to throw an error instead of a warning when compiling" > + default n > + ---help--- > + Add -Werror to the build flags for (and only for) i915.ko > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index b7ddf48e1d75..93d99b744531 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -2,6 +2,8 @@ > # Makefile for the drm device driver. This driver provides support for the > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > +subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror arch/powerpc seems to have a similar thing. Acked-by: Jani Nikula --- I see that we're clean also with -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-override-init so could have those with e.g. subdir-ccflags-$(CONFIG_DRM_I915_WEXTRA). I might argue we could and should get rid of -Wno-missing-field-initializers -Wno-override-init too... BR, Jani. > + > # Please keep these build lists sorted! > > # core driver code > -- > 2.1.4 > > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
On Thu, May 21, 2015 at 10:22:17AM +0300, Jani Nikula wrote: > On Wed, 20 May 2015, Chris Wilson wrote: > > Our driver compiles clean (nowadays thanks to 0day) but for me, at least, > > it would be beneficial if the compiler threw an error rather than a > > warning when it found a piece of suspect code. (I use this to > > compile-check patch series and want to break on the first compiler error > > in order to fix the patch.) > > > > v2: Kick off a new "Debugging" submenu for i915.ko > > > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/i915/Kconfig | 8 > > drivers/gpu/drm/i915/Kconfig.debug | 5 + > > drivers/gpu/drm/i915/Makefile | 2 ++ > > 3 files changed, 15 insertions(+) > > create mode 100644 drivers/gpu/drm/i915/Kconfig.debug > > > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > > index 74acca9bcd9d..76c425ca2a2c 100644 > > --- a/drivers/gpu/drm/i915/Kconfig > > +++ b/drivers/gpu/drm/i915/Kconfig > > @@ -71,3 +71,11 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT > > option changes the default for that module option. > > > > If in doubt, say "N". > > + > > +menu "Debugging" > > + > > +depends on DRM_I915 > > + > > +source drivers/gpu/drm/i915/Kconfig.debug > > + > > +endmenu > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug > > b/drivers/gpu/drm/i915/Kconfig.debug > > new file mode 100644 > > index ..070a03527bc5 > > --- /dev/null > > +++ b/drivers/gpu/drm/i915/Kconfig.debug > > @@ -0,0 +1,5 @@ > > +config DRM_I915_WERROR > > + bool "Force GCC to throw an error instead of a warning when compiling" > > + default n > > + ---help--- > > + Add -Werror to the build flags for (and only for) i915.ko > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > > index b7ddf48e1d75..93d99b744531 100644 > > --- a/drivers/gpu/drm/i915/Makefile > > +++ b/drivers/gpu/drm/i915/Makefile > > @@ -2,6 +2,8 @@ > > # Makefile for the drm device driver. This driver provides support for the > > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > > > +subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror > > arch/powerpc seems to have a similar thing. > > Acked-by: Jani Nikula Ok let's give this a shot and see what happens. Queued for -next, thanks for the patch. -Daniel > > --- > > I see that we're clean also with > > -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers > -Wno-override-init > > so could have those with e.g. subdir-ccflags-$(CONFIG_DRM_I915_WEXTRA). > > I might argue we could and should get rid of > -Wno-missing-field-initializers -Wno-override-init too... > > BR, > Jani. > > > > > > + > > # Please keep these build lists sorted! > > > > # core driver code > > -- > > 2.1.4 > > > > ___ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Jani Nikula, Intel Open Source Technology Center > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6438 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 276/276 276/276 ILK 302/302 302/302 SNB -1 315/315 314/315 IVB 343/343 343/343 BYT 287/287 287/287 BDW 321/321 321/321 -Detailed- Platform Testdrm-intel-nightly Series Applied *SNB igt@pm_rpm@dpms-mode-unset-non-lpsp PASS(1) DMESG_WARN(1) (dmesg patch applied)WARNING:at_drivers/gpu/drm/i915/intel_uncore.c:#assert_device_not_suspended[i915]()@WARNING:.* at .* assert_device_not_suspended+0x Note: You need to pay more attention to line start with '*' ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6440 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 276/276 276/276 ILK 302/302 302/302 SNB -1 315/315 314/315 IVB 343/343 343/343 BYT 287/287 287/287 BDW 321/321 321/321 -Detailed- Platform Testdrm-intel-nightly Series Applied *SNB igt@pm_rpm@dpms-mode-unset-non-lpsp PASS(1) DMESG_WARN(1) (dmesg patch applied)WARNING:at_drivers/gpu/drm/i915/intel_uncore.c:#assert_device_not_suspended[i915]()@WARNING:.* at .* assert_device_not_suspended+0x Note: You need to pay more attention to line start with '*' ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
