Re: [Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT

[Andi Shyti]

Hi Jonathan and Chris,

On Mon, Oct 02, 2023 at 07:07:42AM -0700, Jonathan Cavitt wrote:
> From: Chris Wilson 
> 
> With multi-GT devices, the object may have been bound on each GT and so
> we need to invalidate the TLBs across all GT before releasing the pages
> back to the system.
> 
> Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT")
> Signed-off-by: Chris Wilson 
> Signed-off-by: Jonathan Cavitt 
> CC: Matt Roper 
> CC: Andi Shyti 
> Reviewed-by: Andi Shyti 

pushed to drm-intel-gt-next.

Thank you,
Andi

Re: [Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT

[Nirmoy Das]

+dri-devel

On 10/2/2023 4:07 PM, Jonathan Cavitt wrote:

From: Chris Wilson 

With multi-GT devices, the object may have been bound on each GT and so
we need to invalidate the TLBs across all GT before releasing the pages
back to the system.

Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT")
Signed-off-by: Chris Wilson 
Signed-off-by: Jonathan Cavitt 
CC: Matt Roper 
CC: Andi Shyti 
Reviewed-by: Andi Shyti 


Reviewed-by: Nirmoy Das 

Can't find it in dri-devel but if you didn't then Cc to 
dri-de...@lists.freedesktop.org for change that touches gt/gem files.



Regards,

Nirmoy


---
  drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c 
b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
index 6b6d22c194110..0ba955611dfb5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
@@ -198,7 +198,7 @@ static void flush_tlb_invalidate(struct drm_i915_gem_object 
*obj)
  
  	for_each_gt(gt, i915, id) {

if (!obj->mm.tlb[id])
-   return;
+   continue;
  
  		intel_gt_invalidate_tlb_full(gt, obj->mm.tlb[id]);

obj->mm.tlb[id] = 0;

[Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT

[Jonathan Cavitt]

From: Chris Wilson 

With multi-GT devices, the object may have been bound on each GT and so
we need to invalidate the TLBs across all GT before releasing the pages
back to the system.

Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT")
Signed-off-by: Chris Wilson 
Signed-off-by: Jonathan Cavitt 
CC: Matt Roper 
CC: Andi Shyti 
Reviewed-by: Andi Shyti 
---
 drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c 
b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
index 6b6d22c194110..0ba955611dfb5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
@@ -198,7 +198,7 @@ static void flush_tlb_invalidate(struct drm_i915_gem_object 
*obj)
 
for_each_gt(gt, i915, id) {
if (!obj->mm.tlb[id])
-   return;
+   continue;
 
intel_gt_invalidate_tlb_full(gt, obj->mm.tlb[id]);
obj->mm.tlb[id] = 0;
-- 
2.25.1