Re: [Intel-gfx] [PATCH] drm/i915: Remove pointless if-else from sdvo code

2018-06-21 Thread Chris Wilson 
Quoting Ville Syrjala (2018-06-21 18:46:58)
> From: Ville Syrjälä 
> 
> The return value is a bool so we can just return the result of
> the biwise AND. The compiler will take care of the rest.
> 
> Signed-off-by: Ville Syrjälä 
Reviewed-by: Chris Wilson 
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Remove pointless if-else from sdvo code

2018-06-21 Thread Ville Syrjala 
From: Ville Syrjälä 

The return value is a bool so we can just return the result of
the biwise AND. The compiler will take care of the rest.

Signed-off-by: Ville Syrjälä 
---
 drivers/gpu/drm/i915/intel_sdvo.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_sdvo.c 
b/drivers/gpu/drm/i915/intel_sdvo.c
index e6a64b3ecd91..c7f95c958660 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -1400,10 +1400,7 @@ static bool intel_sdvo_connector_get_hw_state(struct 
intel_connector *connector)
 
intel_sdvo_get_active_outputs(intel_sdvo, &active_outputs);
 
-   if (active_outputs & intel_sdvo_connector->output_flag)
-   return true;
-   else
-   return false;
+   return active_outputs & intel_sdvo_connector->output_flag;
 }
 
 bool intel_sdvo_port_enabled(struct drm_i915_private *dev_priv,
-- 
2.16.4

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx