Re: [Intel-gfx] [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint

[Sergey Senozhatsky]

On (08/08/19 18:22), Chris Wilson wrote:
[..]
> @@ -20,31 +20,18 @@ int i915_gemfs_init(struct drm_i915_private *i915)
>   if (!type)
>   return -ENODEV;
[..]
> + gemfs = kern_mount(type);
> + if (IS_ERR(gemfs))
> + return PTR_ERR(gemfs);
>  
>   i915->mm.gemfs = gemfs;

We still have to put_filesystem(). Right?

-ss
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint

[Sedat Dilek]

On Fri, Aug 9, 2019 at 8:52 PM Chris Wilson  wrote:
>
> Quoting Matthew Auld (2019-08-09 19:47:02)
> > On Thu, 8 Aug 2019 at 18:23, Chris Wilson  wrote:
> > >
> > > The filesystem reconfigure API is undergoing a transition, breaking our
> > > current code. As we only set the default options, we can simply remove
> > > the call to s_op->remount_fs(). In the future, when HW permits, we can
> > > try re-enabling huge page support, albeit as suggested with new per-file
> > > controls.
> > >
> > > Reported-by: Sergey Senozhatsky 
> > > Reported-by: Sedat Dilek 
> > > Suggested-by: Hugh Dickins 
> > > Signed-off-by: Chris Wilson 
> > > Cc: Matthew Auld 
> > > Cc: Hugh Dickins 
> > > Cc: Al Viro 
> > > Cc: Sergey Senozhatsky 
> > Reviewed-by: Matthew Auld 
>
> Thanks, picked up with the s/within/within_size/ fix.
> -Chris

For the records and followers:

[1] 
https://cgit.freedesktop.org/drm-intel/commit/?h=for-linux-next&id=72e67f04637432f91e4cc5e8e4f7eb4e38461e8e

Re: [Intel-gfx] [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint

[Chris Wilson]

Quoting Matthew Auld (2019-08-09 19:47:02)
> On Thu, 8 Aug 2019 at 18:23, Chris Wilson  wrote:
> >
> > The filesystem reconfigure API is undergoing a transition, breaking our
> > current code. As we only set the default options, we can simply remove
> > the call to s_op->remount_fs(). In the future, when HW permits, we can
> > try re-enabling huge page support, albeit as suggested with new per-file
> > controls.
> >
> > Reported-by: Sergey Senozhatsky 
> > Reported-by: Sedat Dilek 
> > Suggested-by: Hugh Dickins 
> > Signed-off-by: Chris Wilson 
> > Cc: Matthew Auld 
> > Cc: Hugh Dickins 
> > Cc: Al Viro 
> > Cc: Sergey Senozhatsky 
> Reviewed-by: Matthew Auld 

Thanks, picked up with the s/within/within_size/ fix.
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint

[Matthew Auld]

On Thu, 8 Aug 2019 at 18:23, Chris Wilson  wrote:
>
> The filesystem reconfigure API is undergoing a transition, breaking our
> current code. As we only set the default options, we can simply remove
> the call to s_op->remount_fs(). In the future, when HW permits, we can
> try re-enabling huge page support, albeit as suggested with new per-file
> controls.
>
> Reported-by: Sergey Senozhatsky 
> Reported-by: Sedat Dilek 
> Suggested-by: Hugh Dickins 
> Signed-off-by: Chris Wilson 
> Cc: Matthew Auld 
> Cc: Hugh Dickins 
> Cc: Al Viro 
> Cc: Sergey Senozhatsky 
Reviewed-by: Matthew Auld 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Stop reconfiguring our shmemfs mountpoint

[Hugh Dickins]

On Thu, 8 Aug 2019, Chris Wilson wrote:
> +  * By creating our own shmemfs mountpoint, we can pass in
> +  * mount flags that better match our usecase.
> +  *
> +  * One example, although it is probably better with a per-file
> +  * control, is selecting huge page allocations ("huge=within").

s/within/within_size/

Not that either of us is recommending that direction,
but since it's mentioned, better to give the correct name.

> +  * Currently unused due to bandwidth issues (slow reads) on Broadwell+.

Thanks,
Hugh
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx