Re: [Intel-gfx] [PATCH] drm/i915: ignore generated files for header test

2019-07-26 Thread Lucas De Marchi

On Fri, Jul 26, 2019 at 10:34:50PM +0100, Chris Wilson wrote:

Quoting Lucas De Marchi (2019-07-26 22:23:44)

These are generated source that can be ignored by git.


They're the stale generated headers from our old mechanism, right?


No. They are still in the Makefiles:

$ git grep -l header_test
drivers/gpu/drm/i915/.gitignore
drivers/gpu/drm/i915/display/Makefile.header-test
drivers/gpu/drm/i915/gem/Makefile.header-test
drivers/gpu/drm/i915/gt/Makefile.header-test
drivers/gpu/drm/i915/gt/uc/Makefile.header-test

From that commit it seems we should rather remove those sections from
these makefiles.

Lucas De Marchi



See commit e846f0dc57f441e5e93194d39bc9b8ac2ab5e0a4
Author: Jani Nikula 
Date:   Tue Jun 4 15:42:48 2019 +0300

   kbuild: add support for ensuring headers are self-contained

for when this ignore was dropped.
-Chris

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: ignore generated files for header test

2019-07-26 Thread Chris Wilson
Quoting Lucas De Marchi (2019-07-26 22:23:44)
> These are generated source that can be ignored by git.

They're the stale generated headers from our old mechanism, right?

See commit e846f0dc57f441e5e93194d39bc9b8ac2ab5e0a4
Author: Jani Nikula 
Date:   Tue Jun 4 15:42:48 2019 +0300

kbuild: add support for ensuring headers are self-contained

for when this ignore was dropped.
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: ignore generated files for header test

2019-07-26 Thread Lucas De Marchi
These are generated source that can be ignored by git.

Signed-off-by: Lucas De Marchi 
---
 drivers/gpu/drm/i915/.gitignore | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 drivers/gpu/drm/i915/.gitignore

diff --git a/drivers/gpu/drm/i915/.gitignore b/drivers/gpu/drm/i915/.gitignore
new file mode 100644
index ..a1691fc10c5c
--- /dev/null
+++ b/drivers/gpu/drm/i915/.gitignore
@@ -0,0 +1 @@
+header_test_*
-- 
2.21.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx