[Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This was a spurious issue happening on Apollolake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for BXT. Extending this fix to BXT as well. Tested on apollolake chromebook by stress test warm reboot with 2500 iterations. Bspec: 21829 Signed-off-by: Gaurav K Singh Reviewed-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 709d6ca68074..656f6c931341 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, struct drm_i915_private *dev_priv = kdev_to_i915(kdev); u32 tmp; - if (!IS_GEN9_BC(dev_priv)) + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) return; i915_audio_component_get_power(kdev); -- 1.9.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: Fix audio issue on BXT
On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This was a spurious issue happening on Apollolake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for BXT. Extending this fix to BXT as well. Tested on apollolake chromebook by stress test warm reboot with 2500 iterations. Bspec: 21829 Signed-off-by: Gaurav K Singh Reviewed-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 709d6ca68074..656f6c931341 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, struct drm_i915_private *dev_priv = kdev_to_i915(kdev); u32 tmp; - if (!IS_GEN9_BC(dev_priv)) + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) return; i915_audio_component_get_power(kdev); -- 1.9.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This was a spurious issue happening on Apollolake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for BXT. Extending this fix to BXT as well. Bspec: 21829 Tested on apollolake chromebook by stress test warm reboot with 2500 iterations. v2: * Mention Bspec Index in commit message(Dhinakaran Pandiyan) Signed-off-by: Gaurav K Singh Reviewed-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 709d6ca68074..656f6c931341 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, struct drm_i915_private *dev_priv = kdev_to_i915(kdev); u32 tmp; - if (!IS_GEN9_BC(dev_priv)) + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) return; i915_audio_component_get_power(kdev); -- 1.9.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
From: Gaurav Singh On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This was a spurious issue happening on Apollolake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for BXT. Extending this fix to BXT as well. Tested on apollolake chromebook by stress test warm reboot with 2500 iterations. Signed-off-by: Gaurav K Singh --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index f1502a0188eb..c71c04e1c3f6 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, struct drm_i915_private *dev_priv = kdev_to_i915(kdev); u32 tmp; - if (!IS_GEN9_BC(dev_priv)) + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) return; i915_audio_component_get_power(kdev); -- 1.9.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
On 3/5/2018 11:51 PM, Pandiyan, Dhinakaran wrote: On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: From: Gaurav Singh On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This was a spurious issue happening on Apollolake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for BXT. Extending this fix to BXT as well. Tested on apollolake chromebook by stress test warm reboot with 2500 iterations. Signed-off-by: Gaurav K Singh Might be worth adding Bspec: 21829 to the commit message. Reviewed-by: Dhinakaran Pandiyan Please rebase and send this patch to the list to CI it. Hi DK, Sure, i have added Bspec index and sent the updated patch. https://patchwork.freedesktop.org/patch/215067/ With regards, Gaurav --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index f1502a0188eb..c71c04e1c3f6 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, struct drm_i915_private *dev_priv = kdev_to_i915(kdev); u32 tmp; - if (!IS_GEN9_BC(dev_priv)) + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) return; i915_audio_component_get_power(kdev); ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Fix audio issue on BXT
On Thu, 2018-04-05 at 22:12 +0530, Gaurav K Singh wrote: > On Apollolake, with stress test warm reboot, audio card > was not getting enumerated after reboot. This was a > spurious issue happening on Apollolake. HW codec and > HD audio controller link was going out of sync for which > there was a fix in i915 driver but was not getting invoked > for BXT. Extending this fix to BXT as well. > > Tested on apollolake chromebook by stress test warm reboot > with 2500 iterations. > > Bspec: 21829 > R-B stands. Btw, it would be easier to spot this patch and pick this up for merging if you did not send this as a reply. I guess that's okay this time? Also, a minor nitpick, "drm/i915/audio" would have been a more appropriate prefix for the patch subject. > Signed-off-by: Gaurav K Singh > Reviewed-by: Dhinakaran Pandiyan > --- > drivers/gpu/drm/i915/intel_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_audio.c > b/drivers/gpu/drm/i915/intel_audio.c > index 709d6ca68074..656f6c931341 100644 > --- a/drivers/gpu/drm/i915/intel_audio.c > +++ b/drivers/gpu/drm/i915/intel_audio.c > @@ -729,7 +729,7 @@ static void > i915_audio_component_codec_wake_override(struct device *kdev, > struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > u32 tmp; > > - if (!IS_GEN9_BC(dev_priv)) > + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > return; > > i915_audio_component_get_power(kdev); ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Fix audio issue on BXT
On Thu, 05 Apr 2018, "Pandiyan, Dhinakaran" wrote: > On Thu, 2018-04-05 at 22:12 +0530, Gaurav K Singh wrote: >> On Apollolake, with stress test warm reboot, audio card >> was not getting enumerated after reboot. This was a >> spurious issue happening on Apollolake. HW codec and >> HD audio controller link was going out of sync for which >> there was a fix in i915 driver but was not getting invoked >> for BXT. Extending this fix to BXT as well. >> >> Tested on apollolake chromebook by stress test warm reboot >> with 2500 iterations. >> >> Bspec: 21829 >> > > R-B stands. > > Btw, it would be easier to spot this patch and pick this up for merging > if you did not send this as a reply. I guess that's okay this time? > Also, a minor nitpick, "drm/i915/audio" would have been a more > appropriate prefix for the patch subject. Thanks for the patch and review, pushed to dinq, with the patch title amended. Immediately after pushing I realized that this should have been Cc: stable. Joonas, after v4.17-rc1 is out and you've rebased drm-intel-fixes on it, please cherry-pick this one with Cc: stable added. Thanks, Jani. > > > >> Signed-off-by: Gaurav K Singh >> Reviewed-by: Dhinakaran Pandiyan >> --- >> drivers/gpu/drm/i915/intel_audio.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_audio.c >> b/drivers/gpu/drm/i915/intel_audio.c >> index 709d6ca68074..656f6c931341 100644 >> --- a/drivers/gpu/drm/i915/intel_audio.c >> +++ b/drivers/gpu/drm/i915/intel_audio.c >> @@ -729,7 +729,7 @@ static void >> i915_audio_component_codec_wake_override(struct device *kdev, >> struct drm_i915_private *dev_priv = kdev_to_i915(kdev); >> u32 tmp; >> >> -if (!IS_GEN9_BC(dev_priv)) >> +if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) >> return; >> >> i915_audio_component_get_power(kdev); -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
> -Original Message- > From: Runyan, Arthur J > Sent: Tuesday, January 9, 2018 11:55 AM > To: Pandiyan, Dhinakaran ; Singh, Gaurav K > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > Sorry, I've been out. I'm checking on this. Hi Art, Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration issues? -DK > > -Original Message- > From: Pandiyan, Dhinakaran > Sent: Thursday, 4 January, 2018 2:00 PM > To: Singh, Gaurav K > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; > subransu.s.pru...@intel.com; Runyan, Arthur J > Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > +Art > > On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote: > > > > On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: > > > On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: > > >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > > >>> From: Gaurav Singh > > >>> > > >>> On Apollolake, with stress test warm reboot, audio card was not > > >>> getting enumerated after reboot. This was a > > >> The problem looks similar to > > >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/14449 > > >> 5.html > > >> > > >> although the proposed solutions are vastly different. I have Cc'd > > >> some more people. > > >> > > >>> spurious issue happening on Apollolake. HW codec and HD audio > > >>> controller link was going out of sync for which there was a fix in > > >>> i915 driver but was not getting invoked for BXT. Extending this > > >>> fix to BXT as well. > > >>> > > >>> Tested on apollolake chromebook by stress test warm reboot with > > >>> 2500 iterations. > > >>> > > >>> Signed-off-by: Gaurav K Singh > > >>> --- > > >>> drivers/gpu/drm/i915/intel_audio.c | 2 +- > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>> > > >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c > > >>> b/drivers/gpu/drm/i915/intel_audio.c > > >>> index f1502a0188eb..c71c04e1c3f6 100644 > > >>> --- a/drivers/gpu/drm/i915/intel_audio.c > > >>> +++ b/drivers/gpu/drm/i915/intel_audio.c > > >>> @@ -729,7 +729,7 @@ static void > i915_audio_component_codec_wake_override(struct device *kdev, > > >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > > >>> u32 tmp; > > >>> > > >>> - if (!IS_GEN9_BC(dev_priv)) > > >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > > >> IS_GEN9()? GLK might need this too. > > > I think this is applicable for all Gen9 platforms. > > > > > if GLK need there is the possibility of CNL also needing it... > > > So not sure where to stop. > > > > > > Also looking to the original patch that introduced this function, > > > commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override > > > enabled/disable callback")' > > > > > > it tells that the reason was: > > > "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different > > > p$ wells, so it's necessary to reset display audio codecs when power > > > we$ otherwise display audio codecs will disappear when resume from > > > low p$ state." > > > > > > Is this the case here on BXT? > > Yes, its the same case with BXT. > > > > > > Another interesting thing I noticed on Spec when searching for this > > > bit was that this bit is related to an workaround on SKL/KBL/CFL... > > > no mention to BXT. > > > > > > "This workaround is needed for an HW issue in SKL and KBL in which > > > HW codec and HD audio controller link was going out of sync." > > Yes, in Bspec it has been mentioned only for SKL and KBL. But without > > this fix, sound card was not getting enumerated for BXT. > > > Art, > > Can you please help us here? To summarize, the question is what platforms need > the AUD_CHICKENBIT_REG:15 bit to be set to avoid code enumeration failures? > > -DK > > > > > > > Thanks, > > > Rodrigo. > > > > > >> > > >>> return; > > >>> > > >>> i915_audio_component_get_power(kdev); > > >> ___ > > >> Intel-gfx mailing list > > >> Intel-gfx@lists.freedesktop.org > > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
Abid or Hari, please check. There was a workaround to set AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL and KBL. Does it apply to BXT also? > -Original Message- > From: Pandiyan, Dhinakaran > Sent: Monday, 26 February, 2018 6:04 PM > To: Runyan, Arthur J ; Singh, Gaurav K > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; > Nikula, Jani > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > > > -Original Message- > > From: Runyan, Arthur J > > Sent: Tuesday, January 9, 2018 11:55 AM > > To: Pandiyan, Dhinakaran ; Singh, > Gaurav K > > > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo > > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > > > Sorry, I've been out. I'm checking on this. > > > Hi Art, > > Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration issues? > > -DK > > > > > -Original Message- > > From: Pandiyan, Dhinakaran > > Sent: Thursday, 4 January, 2018 2:00 PM > > To: Singh, Gaurav K > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; > > subransu.s.pru...@intel.com; Runyan, Arthur J > > > Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > > > +Art > > > > On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote: > > > > > > On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: > > > > On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran > wrote: > > > >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > > > >>> From: Gaurav Singh > > > >>> > > > >>> On Apollolake, with stress test warm reboot, audio card was not > > > >>> getting enumerated after reboot. This was a > > > >> The problem looks similar to > > > >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/14449 > > > >> 5.html > > > >> > > > >> although the proposed solutions are vastly different. I have Cc'd > > > >> some more people. > > > >> > > > >>> spurious issue happening on Apollolake. HW codec and HD audio > > > >>> controller link was going out of sync for which there was a fix in > > > >>> i915 driver but was not getting invoked for BXT. Extending this > > > >>> fix to BXT as well. > > > >>> > > > >>> Tested on apollolake chromebook by stress test warm reboot with > > > >>> 2500 iterations. > > > >>> > > > >>> Signed-off-by: Gaurav K Singh > > > >>> --- > > > >>> drivers/gpu/drm/i915/intel_audio.c | 2 +- > > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > > >>> > > > >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c > > > >>> b/drivers/gpu/drm/i915/intel_audio.c > > > >>> index f1502a0188eb..c71c04e1c3f6 100644 > > > >>> --- a/drivers/gpu/drm/i915/intel_audio.c > > > >>> +++ b/drivers/gpu/drm/i915/intel_audio.c > > > >>> @@ -729,7 +729,7 @@ static void > > i915_audio_component_codec_wake_override(struct device *kdev, > > > >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > > > >>> u32 tmp; > > > >>> > > > >>> - if (!IS_GEN9_BC(dev_priv)) > > > >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > > > >> IS_GEN9()? GLK might need this too. > > > > I think this is applicable for all Gen9 platforms. > > > > > > > if GLK need there is the possibility of CNL also needing it... > > > > So not sure where to stop. > > > > > > > > Also looking to the original patch that introduced this function, > > > > commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override > > > > enabled/disable callback")' > > > > > > > > it tells that the reason was: > > > > "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different > > > > p$ wells, so it's necessary to reset display audio codecs when power > > > > we$ otherwise display audio codecs will disappear when resume from > > > > low p$ state." > > > > > > > > Is this the case here on BXT? > > > Yes, its the same case with BXT. > > > > > &g
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
Yes. It will be needed for BXT also. -Original Message- From: Runyan, Arthur J Sent: Tuesday, February 27, 2018 8:49 AM To: Pandiyan, Dhinakaran ; Singh, Gaurav K ; Mullah, Abid A ; Neelagandan, Harigaran Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; Nikula, Jani Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT Abid or Hari, please check. There was a workaround to set AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL and KBL. Does it apply to BXT also? > -Original Message- > From: Pandiyan, Dhinakaran > Sent: Monday, 26 February, 2018 6:04 PM > To: Runyan, Arthur J ; Singh, Gaurav K > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo > ; Nikula, Jani > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > > > -Original Message- > > From: Runyan, Arthur J > > Sent: Tuesday, January 9, 2018 11:55 AM > > To: Pandiyan, Dhinakaran ; Singh, > Gaurav K > > > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo > > > > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > > > Sorry, I've been out. I'm checking on this. > > > Hi Art, > > Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration issues? > > -DK > > > > > -Original Message- > > From: Pandiyan, Dhinakaran > > Sent: Thursday, 4 January, 2018 2:00 PM > > To: Singh, Gaurav K > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo > > ; subransu.s.pru...@intel.com; Runyan, > > Arthur J > > > Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > > > +Art > > > > On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote: > > > > > > On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: > > > > On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran > wrote: > > > >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > > > >>> From: Gaurav Singh > > > >>> > > > >>> On Apollolake, with stress test warm reboot, audio card was > > > >>> not getting enumerated after reboot. This was a > > > >> The problem looks similar to > > > >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/1 > > > >> 4449 > > > >> 5.html > > > >> > > > >> although the proposed solutions are vastly different. I have > > > >> Cc'd some more people. > > > >> > > > >>> spurious issue happening on Apollolake. HW codec and HD audio > > > >>> controller link was going out of sync for which there was a > > > >>> fix in > > > >>> i915 driver but was not getting invoked for BXT. Extending > > > >>> this fix to BXT as well. > > > >>> > > > >>> Tested on apollolake chromebook by stress test warm reboot > > > >>> with > > > >>> 2500 iterations. > > > >>> > > > >>> Signed-off-by: Gaurav K Singh > > > >>> --- > > > >>> drivers/gpu/drm/i915/intel_audio.c | 2 +- > > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > > >>> > > > >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c > > > >>> b/drivers/gpu/drm/i915/intel_audio.c > > > >>> index f1502a0188eb..c71c04e1c3f6 100644 > > > >>> --- a/drivers/gpu/drm/i915/intel_audio.c > > > >>> +++ b/drivers/gpu/drm/i915/intel_audio.c > > > >>> @@ -729,7 +729,7 @@ static void > > i915_audio_component_codec_wake_override(struct device *kdev, > > > >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > > > >>> u32 tmp; > > > >>> > > > >>> - if (!IS_GEN9_BC(dev_priv)) > > > >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > > > >> IS_GEN9()? GLK might need this too. > > > > I think this is applicable for all Gen9 platforms. > > > > > > > if GLK need there is the possibility of CNL also needing it... > > > > So not sure where to stop. > > > > > > > > Also looking to the original patch that introduced this > > > > function, commit '632f3ab95fe2 ("drm/i915/audio: add codec > > > > wakeup override enabled/disable callback")' > > > > > > > > it tells tha
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
Ok, please update the workaround page to show all the impacted projects https://gfxspecs.intel.com/Predator/Home/Index/21829 > -Original Message- > From: Mullah, Abid A > Sent: Tuesday, 27 February, 2018 8:52 AM > To: Runyan, Arthur J ; Pandiyan, Dhinakaran > ; Singh, Gaurav K > ; Neelagandan, Harigaran > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; > Nikula, Jani > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > Yes. It will be needed for BXT also. > > -Original Message- > From: Runyan, Arthur J > Sent: Tuesday, February 27, 2018 8:49 AM > To: Pandiyan, Dhinakaran ; Singh, Gaurav > K ; Mullah, Abid A ; > Neelagandan, Harigaran > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; > Nikula, Jani > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > Abid or Hari, please check. There was a workaround to set > AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL > and KBL. Does it apply to BXT also? > > > -Original Message- > > From: Pandiyan, Dhinakaran > > Sent: Monday, 26 February, 2018 6:04 PM > > To: Runyan, Arthur J ; Singh, Gaurav K > > > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo > > ; Nikula, Jani > > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > > > > > > -Original Message- > > > From: Runyan, Arthur J > > > Sent: Tuesday, January 9, 2018 11:55 AM > > > To: Pandiyan, Dhinakaran ; Singh, > > Gaurav K > > > > > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo > > > > > > Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > > > > > Sorry, I've been out. I'm checking on this. > > > > > > Hi Art, > > > > Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration > issues? > > > > -DK > > > > > > > > -Original Message- > > > From: Pandiyan, Dhinakaran > > > Sent: Thursday, 4 January, 2018 2:00 PM > > > To: Singh, Gaurav K > > > Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo > > > ; subransu.s.pru...@intel.com; Runyan, > > > Arthur J > > > > > Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT > > > > > > +Art > > > > > > On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote: > > > > > > > > On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: > > > > > On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran > > wrote: > > > > >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > > > > >>> From: Gaurav Singh > > > > >>> > > > > >>> On Apollolake, with stress test warm reboot, audio card was > > > > >>> not getting enumerated after reboot. This was a > > > > >> The problem looks similar to > > > > >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/1 > > > > >> 4449 > > > > >> 5.html > > > > >> > > > > >> although the proposed solutions are vastly different. I have > > > > >> Cc'd some more people. > > > > >> > > > > >>> spurious issue happening on Apollolake. HW codec and HD audio > > > > >>> controller link was going out of sync for which there was a > > > > >>> fix in > > > > >>> i915 driver but was not getting invoked for BXT. Extending > > > > >>> this fix to BXT as well. > > > > >>> > > > > >>> Tested on apollolake chromebook by stress test warm reboot > > > > >>> with > > > > >>> 2500 iterations. > > > > >>> > > > > >>> Signed-off-by: Gaurav K Singh > > > > >>> --- > > > > >>> drivers/gpu/drm/i915/intel_audio.c | 2 +- > > > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > >>> > > > > >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c > > > > >>> b/drivers/gpu/drm/i915/intel_audio.c > > > > >>> index f1502a0188eb..c71c04e1c3f6 100644 > > > > >>> --- a/drivers/gpu/drm/i915/intel_audio.c > > > > >>> +++ b/drivers/gpu/drm/i915/intel_audio.c > > > > >>> @@ -729,7 +729,7 @@ static void > > > i915_audio_component_c
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
On 2/27/2018 11:00 PM, Runyan, Arthur J wrote: Ok, please update the workaround page to show all the impacted projects https://gfxspecs.intel.com/Predator/Home/Index/21829 Hi, Should we wait for Bspec to get updated or we can go ahead with the merge. Please advise. With regards, Gaurav -Original Message- From: Mullah, Abid A Sent: Tuesday, 27 February, 2018 8:52 AM To: Runyan, Arthur J ; Pandiyan, Dhinakaran ; Singh, Gaurav K ; Neelagandan, Harigaran Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; Nikula, Jani Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT Yes. It will be needed for BXT also. -Original Message- From: Runyan, Arthur J Sent: Tuesday, February 27, 2018 8:49 AM To: Pandiyan, Dhinakaran ; Singh, Gaurav K ; Mullah, Abid A ; Neelagandan, Harigaran Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; Nikula, Jani Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT Abid or Hari, please check. There was a workaround to set AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL and KBL. Does it apply to BXT also? -Original Message- From: Pandiyan, Dhinakaran Sent: Monday, 26 February, 2018 6:04 PM To: Runyan, Arthur J ; Singh, Gaurav K Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; Nikula, Jani Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT -Original Message- From: Runyan, Arthur J Sent: Tuesday, January 9, 2018 11:55 AM To: Pandiyan, Dhinakaran ; Singh, Gaurav K Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT Sorry, I've been out. I'm checking on this. Hi Art, Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration issues? -DK -Original Message- From: Pandiyan, Dhinakaran Sent: Thursday, 4 January, 2018 2:00 PM To: Singh, Gaurav K Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; subransu.s.pru...@intel.com; Runyan, Arthur J Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT +Art On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote: On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: From: Gaurav Singh On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This was a The problem looks similar to https://lists.freedesktop.org/archives/intel-gfx/2017-October/1 4449 5.html although the proposed solutions are vastly different. I have Cc'd some more people. spurious issue happening on Apollolake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for BXT. Extending this fix to BXT as well. Tested on apollolake chromebook by stress test warm reboot with 2500 iterations. Signed-off-by: Gaurav K Singh --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index f1502a0188eb..c71c04e1c3f6 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, struct drm_i915_private *dev_priv = kdev_to_i915(kdev); u32 tmp; - if (!IS_GEN9_BC(dev_priv)) + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) IS_GEN9()? GLK might need this too. I think this is applicable for all Gen9 platforms. if GLK need there is the possibility of CNL also needing it... So not sure where to stop. Also looking to the original patch that introduced this function, commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override enabled/disable callback")' it tells that the reason was: "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different p$ wells, so it's necessary to reset display audio codecs when power we$ otherwise display audio codecs will disappear when resume from low p$ state." Is this the case here on BXT? Yes, its the same case with BXT. Another interesting thing I noticed on Spec when searching for this bit was that this bit is related to an workaround on SKL/KBL/CFL... no mention to BXT. "This workaround is needed for an HW issue in SKL and KBL in which HW codec and HD audio controller link was going out of sync." Yes, in Bspec it has been mentioned only for SKL and KBL. But without this fix, sound card was not getting enumerated for BXT. Art, Can you please help us here? To summarize, the question is what platforms need the AUD_CHICKENBIT_REG:15 bit to be set to avoid code enumeration failures? -DK Thanks, Rodrigo. return; i915_audio_component_get_power(kdev);
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
Did u check the fix on bxt and if u didnt see any issue then u can go ahead. I will update bspec tomorrow Sent from my iPhone > On Mar 4, 2018, at 10:09 PM, Singh, Gaurav K wrote: > > > >> On 2/27/2018 11:00 PM, Runyan, Arthur J wrote: >> Ok, please update the workaround page to show all the impacted projects >> https://gfxspecs.intel.com/Predator/Home/Index/21829 > Hi, > > Should we wait for Bspec to get updated or we can go ahead with the merge. > Please advise. > > With regards, > Gaurav >> >> >>> -Original Message- >>> From: Mullah, Abid A >>> Sent: Tuesday, 27 February, 2018 8:52 AM >>> To: Runyan, Arthur J ; Pandiyan, Dhinakaran >>> ; Singh, Gaurav K >>> ; Neelagandan, Harigaran >>> >>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; >>> Nikula, Jani >>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT >>> >>> Yes. It will be needed for BXT also. >>> >>> -Original Message- >>> From: Runyan, Arthur J >>> Sent: Tuesday, February 27, 2018 8:49 AM >>> To: Pandiyan, Dhinakaran ; Singh, Gaurav >>> K ; Mullah, Abid A ; >>> Neelagandan, Harigaran >>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; >>> Nikula, Jani >>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT >>> >>> Abid or Hari, please check. There was a workaround to set >>> AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL >>> and KBL. Does it apply to BXT also? >>> >>>> -Original Message- >>>> From: Pandiyan, Dhinakaran >>>> Sent: Monday, 26 February, 2018 6:04 PM >>>> To: Runyan, Arthur J ; Singh, Gaurav K >>>> >>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo >>>> ; Nikula, Jani >>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT >>>> >>>> >>>>> -Original Message- >>>>> From: Runyan, Arthur J >>>>> Sent: Tuesday, January 9, 2018 11:55 AM >>>>> To: Pandiyan, Dhinakaran ; Singh, >>>> Gaurav K >>>>> >>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo >>>>> >>>>> Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT >>>>> >>>>> Sorry, I've been out. I'm checking on this. >>>> >>>> Hi Art, >>>> >>>> Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration >>> issues? >>>> -DK >>>> >>>>> -Original Message- >>>>> From: Pandiyan, Dhinakaran >>>>> Sent: Thursday, 4 January, 2018 2:00 PM >>>>> To: Singh, Gaurav K >>>>> Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo >>>>> ; subransu.s.pru...@intel.com; Runyan, >>>>> Arthur J >>>> >>>>> Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT >>>>> >>>>> +Art >>>>> >>>>>> On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote: >>>>>>> On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: >>>>>>> On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran >>>> wrote: >>>>>>>> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: >>>>>>>>> From: Gaurav Singh >>>>>>>>> >>>>>>>>> On Apollolake, with stress test warm reboot, audio card was >>>>>>>>> not getting enumerated after reboot. This was a >>>>>>>> The problem looks similar to >>>>>>>> https://lists.freedesktop.org/archives/intel-gfx/2017-October/1 >>>>>>>> 4449 >>>>>>>> 5.html >>>>>>>> >>>>>>>> although the proposed solutions are vastly different. I have >>>>>>>> Cc'd some more people. >>>>>>>> >>>>>>>>> spurious issue happening on Apollolake. HW codec and HD audio >>>>>>>>> controller link was going out of sync for which there was a >>>>>>>>> fix in >>>>>>>>> i915 driver but was not getting invoked for BXT. Extending >>>>>>>>> this fix to BXT as well. >>>>&
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
On 3/5/2018 12:13 PM, Mullah, Abid A wrote: Did u check the fix on bxt and if u didnt see any issue then u can go ahead. I will update bspec tomorrow Sent from my iPhone Tested on apollolake chromebook by stress test warm reboot with 2500 iterations and did not see any issue. With regards, Gaurav On Mar 4, 2018, at 10:09 PM, Singh, Gaurav K wrote: On 2/27/2018 11:00 PM, Runyan, Arthur J wrote: Ok, please update the workaround page to show all the impacted projects https://gfxspecs.intel.com/Predator/Home/Index/21829 Hi, Should we wait for Bspec to get updated or we can go ahead with the merge. Please advise. With regards, Gaurav -Original Message- From: Mullah, Abid A Sent: Tuesday, 27 February, 2018 8:52 AM To: Runyan, Arthur J ; Pandiyan, Dhinakaran ; Singh, Gaurav K ; Neelagandan, Harigaran Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; Nikula, Jani Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT Yes. It will be needed for BXT also. -Original Message- From: Runyan, Arthur J Sent: Tuesday, February 27, 2018 8:49 AM To: Pandiyan, Dhinakaran ; Singh, Gaurav K ; Mullah, Abid A ; Neelagandan, Harigaran Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; Nikula, Jani Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT Abid or Hari, please check. There was a workaround to set AUD_CHICKENBIT_REG bit 15 (Codec Wake overwrite to DACFEUNIT) on SKL and KBL. Does it apply to BXT also? -Original Message- From: Pandiyan, Dhinakaran Sent: Monday, 26 February, 2018 6:04 PM To: Runyan, Arthur J ; Singh, Gaurav K Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; Nikula, Jani Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT -Original Message- From: Runyan, Arthur J Sent: Tuesday, January 9, 2018 11:55 AM To: Pandiyan, Dhinakaran ; Singh, Gaurav K Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT Sorry, I've been out. I'm checking on this. Hi Art, Is AUD_CHICKENBIT_REG:15 needed for BXT to fix code enumeration issues? -DK -Original Message- From: Pandiyan, Dhinakaran Sent: Thursday, 4 January, 2018 2:00 PM To: Singh, Gaurav K Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; subransu.s.pru...@intel.com; Runyan, Arthur J Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT +Art On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote: On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: From: Gaurav Singh On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This was a The problem looks similar to https://lists.freedesktop.org/archives/intel-gfx/2017-October/1 4449 5.html although the proposed solutions are vastly different. I have Cc'd some more people. spurious issue happening on Apollolake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for BXT. Extending this fix to BXT as well. Tested on apollolake chromebook by stress test warm reboot with 2500 iterations. Signed-off-by: Gaurav K Singh --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index f1502a0188eb..c71c04e1c3f6 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, struct drm_i915_private *dev_priv = kdev_to_i915(kdev); u32 tmp; -if (!IS_GEN9_BC(dev_priv)) +if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) IS_GEN9()? GLK might need this too. I think this is applicable for all Gen9 platforms. if GLK need there is the possibility of CNL also needing it... So not sure where to stop. Also looking to the original patch that introduced this function, commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override enabled/disable callback")' it tells that the reason was: "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different p$ wells, so it's necessary to reset display audio codecs when power we$ otherwise display audio codecs will disappear when resume from low p$ state." Is this the case here on BXT? Yes, its the same case with BXT. Another interesting thing I noticed on Spec when searching for this bit was that this bit is related to an workaround on SKL/KBL/CFL... no mention to BXT. "This workaround is needed for an HW issue in SKL and KBL in which HW codec and HD audio controller link was going out of sync." Yes, in Bspec it has been mentioned only for SKL and KBL. But without this fix, sound card wa
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > From: Gaurav Singh > > On Apollolake, with stress test warm reboot, audio card > was not getting enumerated after reboot. This was a > spurious issue happening on Apollolake. HW codec and > HD audio controller link was going out of sync for which > there was a fix in i915 driver but was not getting invoked > for BXT. Extending this fix to BXT as well. > > Tested on apollolake chromebook by stress test warm reboot > with 2500 iterations. > > Signed-off-by: Gaurav K Singh Might be worth adding Bspec: 21829 to the commit message. Reviewed-by: Dhinakaran Pandiyan Please rebase and send this patch to the list to CI it. > --- > drivers/gpu/drm/i915/intel_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_audio.c > b/drivers/gpu/drm/i915/intel_audio.c > index f1502a0188eb..c71c04e1c3f6 100644 > --- a/drivers/gpu/drm/i915/intel_audio.c > +++ b/drivers/gpu/drm/i915/intel_audio.c > @@ -729,7 +729,7 @@ static void > i915_audio_component_codec_wake_override(struct device *kdev, > struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > u32 tmp; > > - if (!IS_GEN9_BC(dev_priv)) > + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > return; > > i915_audio_component_get_power(kdev); ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > From: Gaurav Singh > > On Apollolake, with stress test warm reboot, audio card > was not getting enumerated after reboot. This was a The problem looks similar to https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.html although the proposed solutions are vastly different. I have Cc'd some more people. > spurious issue happening on Apollolake. HW codec and > HD audio controller link was going out of sync for which > there was a fix in i915 driver but was not getting invoked > for BXT. Extending this fix to BXT as well. > > Tested on apollolake chromebook by stress test warm reboot > with 2500 iterations. > > Signed-off-by: Gaurav K Singh > --- > drivers/gpu/drm/i915/intel_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_audio.c > b/drivers/gpu/drm/i915/intel_audio.c > index f1502a0188eb..c71c04e1c3f6 100644 > --- a/drivers/gpu/drm/i915/intel_audio.c > +++ b/drivers/gpu/drm/i915/intel_audio.c > @@ -729,7 +729,7 @@ static void > i915_audio_component_codec_wake_override(struct device *kdev, > struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > u32 tmp; > > - if (!IS_GEN9_BC(dev_priv)) > + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) IS_GEN9()? GLK might need this too. > return; > > i915_audio_component_get_power(kdev); ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: > > On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > > From: Gaurav Singh > > > > On Apollolake, with stress test warm reboot, audio card > > was not getting enumerated after reboot. This was a > > The problem looks similar to > https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.html > > although the proposed solutions are vastly different. I have Cc'd some > more people. > > > spurious issue happening on Apollolake. HW codec and > > HD audio controller link was going out of sync for which > > there was a fix in i915 driver but was not getting invoked > > for BXT. Extending this fix to BXT as well. > > > > Tested on apollolake chromebook by stress test warm reboot > > with 2500 iterations. > > > > Signed-off-by: Gaurav K Singh > > --- > > drivers/gpu/drm/i915/intel_audio.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_audio.c > > b/drivers/gpu/drm/i915/intel_audio.c > > index f1502a0188eb..c71c04e1c3f6 100644 > > --- a/drivers/gpu/drm/i915/intel_audio.c > > +++ b/drivers/gpu/drm/i915/intel_audio.c > > @@ -729,7 +729,7 @@ static void > > i915_audio_component_codec_wake_override(struct device *kdev, > > struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > > u32 tmp; > > > > - if (!IS_GEN9_BC(dev_priv)) > > + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > > IS_GEN9()? GLK might need this too. if GLK need there is the possibility of CNL also needing it... So not sure where to stop. Also looking to the original patch that introduced this function, commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override enabled/disable callback")' it tells that the reason was: "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different p$ wells, so it's necessary to reset display audio codecs when power we$ otherwise display audio codecs will disappear when resume from low p$ state." Is this the case here on BXT? Another interesting thing I noticed on Spec when searching for this bit was that this bit is related to an workaround on SKL/KBL/CFL... no mention to BXT. "This workaround is needed for an HW issue in SKL and KBL in which HW codec and HD audio controller link was going out of sync." Thanks, Rodrigo. > > > > return; > > > > i915_audio_component_get_power(kdev); > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: From: Gaurav Singh On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This was a The problem looks similar to https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.html although the proposed solutions are vastly different. I have Cc'd some more people. spurious issue happening on Apollolake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for BXT. Extending this fix to BXT as well. Tested on apollolake chromebook by stress test warm reboot with 2500 iterations. Signed-off-by: Gaurav K Singh --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index f1502a0188eb..c71c04e1c3f6 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, struct drm_i915_private *dev_priv = kdev_to_i915(kdev); u32 tmp; - if (!IS_GEN9_BC(dev_priv)) + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) IS_GEN9()? GLK might need this too. I think this is applicable for all Gen9 platforms. if GLK need there is the possibility of CNL also needing it... So not sure where to stop. Also looking to the original patch that introduced this function, commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override enabled/disable callback")' it tells that the reason was: "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different p$ wells, so it's necessary to reset display audio codecs when power we$ otherwise display audio codecs will disappear when resume from low p$ state." Is this the case here on BXT? Yes, its the same case with BXT. Another interesting thing I noticed on Spec when searching for this bit was that this bit is related to an workaround on SKL/KBL/CFL... no mention to BXT. "This workaround is needed for an HW issue in SKL and KBL in which HW codec and HD audio controller link was going out of sync." Yes, in Bspec it has been mentioned only for SKL and KBL. But without this fix, sound card was not getting enumerated for BXT. Thanks, Rodrigo. return; i915_audio_component_get_power(kdev); ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
+Art On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote: > > On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: > > On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: > >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > >>> From: Gaurav Singh > >>> > >>> On Apollolake, with stress test warm reboot, audio card > >>> was not getting enumerated after reboot. This was a > >> The problem looks similar to > >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.html > >> > >> although the proposed solutions are vastly different. I have Cc'd some > >> more people. > >> > >>> spurious issue happening on Apollolake. HW codec and > >>> HD audio controller link was going out of sync for which > >>> there was a fix in i915 driver but was not getting invoked > >>> for BXT. Extending this fix to BXT as well. > >>> > >>> Tested on apollolake chromebook by stress test warm reboot > >>> with 2500 iterations. > >>> > >>> Signed-off-by: Gaurav K Singh > >>> --- > >>> drivers/gpu/drm/i915/intel_audio.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c > >>> b/drivers/gpu/drm/i915/intel_audio.c > >>> index f1502a0188eb..c71c04e1c3f6 100644 > >>> --- a/drivers/gpu/drm/i915/intel_audio.c > >>> +++ b/drivers/gpu/drm/i915/intel_audio.c > >>> @@ -729,7 +729,7 @@ static void > >>> i915_audio_component_codec_wake_override(struct device *kdev, > >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > >>> u32 tmp; > >>> > >>> - if (!IS_GEN9_BC(dev_priv)) > >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > >> IS_GEN9()? GLK might need this too. > > I think this is applicable for all Gen9 platforms. > > > if GLK need there is the possibility of CNL also needing it... > > So not sure where to stop. > > > > Also looking to the original patch that introduced this function, > > commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override > > enabled/disable callback")' > > > > it tells that the reason was: > > "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different p$ > > wells, so it's necessary to reset display audio codecs when power we$ > > otherwise display audio codecs will disappear when resume from low p$ > > state." > > > > Is this the case here on BXT? > Yes, its the same case with BXT. > > > > Another interesting thing I noticed on Spec when searching for this bit > > was that this bit is related to an workaround on SKL/KBL/CFL... no mention > > to BXT. > > > > "This workaround is needed for an HW issue in SKL and KBL in which HW codec > > and HD audio controller link was going out of sync." > Yes, in Bspec it has been mentioned only for SKL and KBL. But without > this fix, sound card was not getting enumerated for BXT. Art, Can you please help us here? To summarize, the question is what platforms need the AUD_CHICKENBIT_REG:15 bit to be set to avoid code enumeration failures? -DK > > > > Thanks, > > Rodrigo. > > > >> > >>> return; > >>> > >>> i915_audio_component_get_power(kdev); > >> ___ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT
Sorry, I've been out. I'm checking on this. -Original Message- From: Pandiyan, Dhinakaran Sent: Thursday, 4 January, 2018 2:00 PM To: Singh, Gaurav K Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; subransu.s.pru...@intel.com; Runyan, Arthur J Subject: Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT +Art On Thu, 2018-01-04 at 22:13 +0530, Singh, Gaurav K wrote: > > On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: > > On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: > >> On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > >>> From: Gaurav Singh > >>> > >>> On Apollolake, with stress test warm reboot, audio card > >>> was not getting enumerated after reboot. This was a > >> The problem looks similar to > >> https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.html > >> > >> although the proposed solutions are vastly different. I have Cc'd some > >> more people. > >> > >>> spurious issue happening on Apollolake. HW codec and > >>> HD audio controller link was going out of sync for which > >>> there was a fix in i915 driver but was not getting invoked > >>> for BXT. Extending this fix to BXT as well. > >>> > >>> Tested on apollolake chromebook by stress test warm reboot > >>> with 2500 iterations. > >>> > >>> Signed-off-by: Gaurav K Singh > >>> --- > >>> drivers/gpu/drm/i915/intel_audio.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c > >>> b/drivers/gpu/drm/i915/intel_audio.c > >>> index f1502a0188eb..c71c04e1c3f6 100644 > >>> --- a/drivers/gpu/drm/i915/intel_audio.c > >>> +++ b/drivers/gpu/drm/i915/intel_audio.c > >>> @@ -729,7 +729,7 @@ static void > >>> i915_audio_component_codec_wake_override(struct device *kdev, > >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > >>> u32 tmp; > >>> > >>> - if (!IS_GEN9_BC(dev_priv)) > >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > >> IS_GEN9()? GLK might need this too. > > I think this is applicable for all Gen9 platforms. > > > if GLK need there is the possibility of CNL also needing it... > > So not sure where to stop. > > > > Also looking to the original patch that introduced this function, > > commit '632f3ab95fe2 ("drm/i915/audio: add codec wakeup override > > enabled/disable callback")' > > > > it tells that the reason was: > > "In SKL, HDMI/DP codec and PCH HD Audio Controller are in different p$ > > wells, so it's necessary to reset display audio codecs when power we$ > > otherwise display audio codecs will disappear when resume from low p$ > > state." > > > > Is this the case here on BXT? > Yes, its the same case with BXT. > > > > Another interesting thing I noticed on Spec when searching for this bit > > was that this bit is related to an workaround on SKL/KBL/CFL... no mention > > to BXT. > > > > "This workaround is needed for an HW issue in SKL and KBL in which HW codec > > and HD audio controller link was going out of sync." > Yes, in Bspec it has been mentioned only for SKL and KBL. But without > this fix, sound card was not getting enumerated for BXT. Art, Can you please help us here? To summarize, the question is what platforms need the AUD_CHICKENBIT_REG:15 bit to be set to avoid code enumeration failures? -DK > > > > Thanks, > > Rodrigo. > > > >> > >>> return; > >>> > >>> i915_audio_component_get_power(kdev); > >> ___ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx