[Intel-gfx] [PATCH 0/5] drm/i915: conversion to new drm logging macros.
This series continues the conversion to the new struct drm_device based logging macros in drm/i915. These patches were mostly achieved using coccinelle: @rule1@ identifier fn, T; @@ fn(struct drm_i915_private *T,...) { <+... ( -DRM_INFO( +drm_info(&T->drm, ...) | -DRM_ERROR( +drm_err(&T->drm, ...) | -DRM_WARN( +drm_warn(&T->drm, ...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) ) ...+> } @rule2@ identifier fn, T; @@ fn(...) { ... struct drm_i915_private *T = ...; <+... ( -DRM_INFO( +drm_info(&T->drm, ...) | -DRM_ERROR( +drm_err(&T->drm, ...) | -DRM_WARN( +drm_warn(&T->drm, ...) | -DRM_DEBUG( +drm_dbg(&T->drm, ...) | -DRM_DEBUG_KMS( +drm_dbg_kms(&T->drm, ...) | -DRM_DEBUG_DRIVER( +drm_dbg(&T->drm, ...) ) ...+> } Wambui Karuga (5): drm/i915/atomic: use new logging macros for debug drm/i915/audio: convert to new drm logging macros. drm/i915/bios: convert to new drm logging macros. drm/i915/bw: convert to new drm_device based logging macros. drm/i915/cdclk: use new drm logging macros. drivers/gpu/drm/i915/display/intel_atomic_plane.c | 9 +- drivers/gpu/drm/i915/display/intel_audio.c| 71 ++-- drivers/gpu/drm/i915/display/intel_bios.c | 357 +++--- drivers/gpu/drm/i915/display/intel_bw.c | 29 +- drivers/gpu/drm/i915/display/intel_cdclk.c| 109 +++--- 5 files changed, 337 insertions(+), 238 deletions(-) -- 2.24.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/5] drm/i915: conversion to new drm logging macros.
On Fri, 10 Jan 2020, Jani Nikula wrote: On Tue, 07 Jan 2020, Wambui Karuga wrote: This series begins the conversion to using the new struct drm_device based logging macros in drm/i915. Wambui Karuga (5): drm/i915: convert to using the drm_dbg_kms() macro. drm/i915: use new struct drm_device logging macros. drm/i915: use new struct drm_device based logging macros. drm/i915: convert to using new struct drm_device logging macros drm/i915: use new struct drm_device based macros. Thanks for the patches, pushed to drm-intel-next-queued. As it's impossible to distinguish the commits from each other by the subject line alone, I've amended the prefix while pushing as follows: drm/i915/pch: convert to using the drm_dbg_kms() macro. drm/i915/pm: use new struct drm_device logging macros. drm/i915/lmem: use new struct drm_device based logging macros. drm/i915/sideband: convert to using new struct drm_device logging macros drm/i915/uncore: use new struct drm_device based macros. Please pay attention to this in future work. It's not always obvious what the prefix should be, but 'git log -- path/to/file.c' will go a long way. Sure, I'll do that from now on. Thanks. BR, Jani. drivers/gpu/drm/i915/intel_pch.c | 46 +-- drivers/gpu/drm/i915/intel_pm.c | 351 +-- drivers/gpu/drm/i915/intel_region_lmem.c | 10 +- drivers/gpu/drm/i915/intel_sideband.c| 29 +- drivers/gpu/drm/i915/intel_uncore.c | 25 +- 5 files changed, 254 insertions(+), 207 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/5] drm/i915: conversion to new drm logging macros.
On Tue, 07 Jan 2020, Wambui Karuga wrote: > This series begins the conversion to using the new struct drm_device > based logging macros in drm/i915. > > Wambui Karuga (5): > drm/i915: convert to using the drm_dbg_kms() macro. > drm/i915: use new struct drm_device logging macros. > drm/i915: use new struct drm_device based logging macros. > drm/i915: convert to using new struct drm_device logging macros > drm/i915: use new struct drm_device based macros. Thanks for the patches, pushed to drm-intel-next-queued. As it's impossible to distinguish the commits from each other by the subject line alone, I've amended the prefix while pushing as follows: drm/i915/pch: convert to using the drm_dbg_kms() macro. drm/i915/pm: use new struct drm_device logging macros. drm/i915/lmem: use new struct drm_device based logging macros. drm/i915/sideband: convert to using new struct drm_device logging macros drm/i915/uncore: use new struct drm_device based macros. Please pay attention to this in future work. It's not always obvious what the prefix should be, but 'git log -- path/to/file.c' will go a long way. BR, Jani. > > drivers/gpu/drm/i915/intel_pch.c | 46 +-- > drivers/gpu/drm/i915/intel_pm.c | 351 +-- > drivers/gpu/drm/i915/intel_region_lmem.c | 10 +- > drivers/gpu/drm/i915/intel_sideband.c| 29 +- > drivers/gpu/drm/i915/intel_uncore.c | 25 +- > 5 files changed, 254 insertions(+), 207 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/5] drm/i915: conversion to new drm logging macros.
This series begins the conversion to using the new struct drm_device based logging macros in drm/i915. Wambui Karuga (5): drm/i915: convert to using the drm_dbg_kms() macro. drm/i915: use new struct drm_device logging macros. drm/i915: use new struct drm_device based logging macros. drm/i915: convert to using new struct drm_device logging macros drm/i915: use new struct drm_device based macros. drivers/gpu/drm/i915/intel_pch.c | 46 +-- drivers/gpu/drm/i915/intel_pm.c | 351 +-- drivers/gpu/drm/i915/intel_region_lmem.c | 10 +- drivers/gpu/drm/i915/intel_sideband.c| 29 +- drivers/gpu/drm/i915/intel_uncore.c | 25 +- 5 files changed, 254 insertions(+), 207 deletions(-) -- 2.24.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx