Re: [Intel-gfx] [PATCH 0/8] drm: Clean up drm_crtc.h
Hi Ville, On Mon, Jun 13, 2022 at 11:03:09PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Eliminate unnecessary includes from drm_crtc.h to avoid > pointless rebuilds of the entire universe when touching > some random header. > > I didn't really feel like splitting this up per-driver since > that would have ended up being metric ton of one liners. > I'm thinking the conflicts (if any) should be trivial enough > to deal with even with bigger patches. Thanks for doing this! I would have been fine with a single bigger commit, as this is tedious manually jobs. It really does not make much sense if there is added 1 or 4 includes files when reviewing. And the bots will tell if build is broken somewhere. If we relax a little in the patch granularity, the chances we will see more similar cleanups are higher. I looked at a few - for the rest I trust the robots. So with the reported builderrros fixed and my alphabetic order comment addressed, then the full series are: Acked-by: Sam Ravnborg Sam
Re: [Intel-gfx] [PATCH 0/8] drm: Clean up drm_crtc.h
On Mon, 13 Jun 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Eliminate unnecessary includes from drm_crtc.h to avoid > pointless rebuilds of the entire universe when touching > some random header. > > I didn't really feel like splitting this up per-driver since > that would have ended up being metric ton of one liners. > I'm thinking the conflicts (if any) should be trivial enough > to deal with even with bigger patches. > > Also the cc list would have been massive so didn't do it. > Hopefully enough people actually read dri-devel... Seems like a good idea to me. FWIW, Acked-by: Jani Nikula Both the CI and the kernel bot found some issues, obviously those need to be addressed, but otherwise I'd just rely on build results for merging. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
[Intel-gfx] [PATCH 0/8] drm: Clean up drm_crtc.h
From: Ville Syrjälä Eliminate unnecessary includes from drm_crtc.h to avoid pointless rebuilds of the entire universe when touching some random header. I didn't really feel like splitting this up per-driver since that would have ended up being metric ton of one liners. I'm thinking the conflicts (if any) should be trivial enough to deal with even with bigger patches. Also the cc list would have been massive so didn't do it. Hopefully enough people actually read dri-devel... Ville Syrjälä (8): drm: Drop drm_edid.h from drm_crtc.h drm: Drop drm_framebuffer.h from drm_crtc.h drm: Drop drm_blend.h from drm_crtc.h drm: Drop drm_connector.h from drm_crtc.h drm: Remove unnecessary junk from drm_crtc.h drm: Remove linux/fb.h from drm_crtc.h drm: Remove linux/media-bus-format.h from drm_crtc.h drm: Remove linux/i2c.h from drm_crtc.h drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 1 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + .../drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h | 1 + .../gpu/drm/arm/display/komeda/d71/d71_dev.c| 1 + drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 + .../drm/arm/display/komeda/komeda_pipeline.c| 2 ++ .../gpu/drm/arm/display/komeda/komeda_plane.c | 1 + .../arm/display/komeda/komeda_wb_connector.c| 1 + drivers/gpu/drm/arm/hdlcd_crtc.c| 1 + drivers/gpu/drm/arm/malidp_crtc.c | 1 + drivers/gpu/drm/arm/malidp_mw.c | 2 ++ drivers/gpu/drm/arm/malidp_planes.c | 2 ++ drivers/gpu/drm/armada/armada_510.c | 1 + drivers/gpu/drm/armada/armada_fb.h | 2 ++ drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c| 1 + drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 + drivers/gpu/drm/ast/ast_mode.c | 1 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 1 + .../gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c| 1 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 ++ .../gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 2 ++ drivers/gpu/drm/bridge/chipone-icn6211.c| 1 + drivers/gpu/drm/bridge/chrontel-ch7033.c| 1 + drivers/gpu/drm/bridge/display-connector.c | 1 + drivers/gpu/drm/bridge/fsl-ldb.c| 1 + drivers/gpu/drm/bridge/ite-it66121.c| 1 + drivers/gpu/drm/bridge/lontium-lt8912b.c| 2 ++ drivers/gpu/drm/bridge/lontium-lt9211.c | 1 + drivers/gpu/drm/bridge/lontium-lt9611.c | 2 ++ drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 1 + drivers/gpu/drm/bridge/nwl-dsi.c| 1 + drivers/gpu/drm/bridge/parade-ps8640.c | 1 + drivers/gpu/drm/bridge/sii902x.c| 1 + drivers/gpu/drm/bridge/simple-bridge.c | 1 + drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + drivers/gpu/drm/bridge/tc358764.c | 1 + drivers/gpu/drm/bridge/tc358767.c | 1 + drivers/gpu/drm/bridge/tc358775.c | 1 + drivers/gpu/drm/bridge/ti-dlpc3433.c| 1 + drivers/gpu/drm/bridge/ti-sn65dsi83.c | 1 + drivers/gpu/drm/bridge/ti-tfp410.c | 2 ++ drivers/gpu/drm/display/drm_dp_helper.c | 2 ++ drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 + drivers/gpu/drm/drm_atomic.c| 2 ++ drivers/gpu/drm/drm_atomic_helper.c | 2 ++ drivers/gpu/drm/drm_atomic_state_helper.c | 2 ++ drivers/gpu/drm/drm_atomic_uapi.c | 1 + drivers/gpu/drm/drm_bridge.c| 1 + drivers/gpu/drm/drm_client_modeset.c| 1 + drivers/gpu/drm/drm_connector.c | 1 + drivers/gpu/drm/drm_crtc.c | 2 ++ drivers/gpu/drm/drm_crtc_helper.c | 1 + drivers/gpu/drm/drm_damage_helper.c | 1 + drivers/gpu/drm/drm_fb_helper.c | 1 + drivers/gpu/drm/drm_gem_atomic_helper.c | 1 + drivers/gpu/drm/drm_kms_helper_common.c | 1 + drivers/gpu/drm/drm_mipi_dbi.c | 2 ++ drivers/gpu/drm/drm_mode_config.c | 1 + drivers/gpu/drm/drm_modes.c | 2 ++ drivers/gpu/drm/drm_modeset_helper.c| 1 + drivers/gpu/drm/drm_of.c| 2 ++ drivers/gpu/drm/drm_writeback.c | 1 + drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 ++ drivers/gpu/drm/exynos/exynos7_drm_decon.c | 1 + drivers/gpu/drm/exynos/exynos_dp.c | 1 + drivers/gpu/drm/exynos/exynos_drm_dpi.c | 1 + drivers/gpu/drm/exynos/exynos_drm_fb.c | 1 + drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 + drivers/gpu/drm/exynos/exynos_drm_fimd.c| 2 ++ drivers/gpu/drm/exynos/exynos_drm_ipp.c | 1 + drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 ++ drivers/gpu/drm/exynos/exynos_drm_scaler.c | 1 +
