Re: [Intel-gfx] [PATCH 01/20] drm/i915: Adding drm helper function drm_plane_from_index().

2015-04-02 Thread Matt Roper
On Wed, Apr 01, 2015 at 07:59:30PM -0700, Chandra Konduru wrote:
 Adding drm helper function to return plane pointer from index where
 index is a returned by drm_plane_index.
 
 v2:
 -avoided nested loop by adding loop count (Daniel)
 
 Signed-off-by: Chandra Konduru chandra.kond...@intel.com

This should just have a drm: headline prefix and should have a Cc:
to dri-devel here since it's touching DRM core code.

Otherwise,

Reviewed-by: Matt Roper matthew.d.ro...@intel.com


 ---
  drivers/gpu/drm/drm_crtc.c |   22 ++
  include/drm/drm_crtc.h |1 +
  2 files changed, 23 insertions(+)
 
 diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
 index d576a4d..0f0159b 100644
 --- a/drivers/gpu/drm/drm_crtc.c
 +++ b/drivers/gpu/drm/drm_crtc.c
 @@ -1289,6 +1289,28 @@ unsigned int drm_plane_index(struct drm_plane *plane)
  EXPORT_SYMBOL(drm_plane_index);
  
  /**
 + * drm_plane_from_index - find the registered plane at an index
 + * @idx: index of registered plane to find for
 + *
 + * Given a plane index, return the registered plane from DRM device's
 + * list of planes with matching index.
 + */
 +struct drm_plane *
 +drm_plane_from_index(struct drm_device *dev, int idx)
 +{
 + struct drm_plane *plane;
 + unsigned int i = 0;
 +
 + list_for_each_entry(plane, dev-mode_config.plane_list, head) {
 + if (i == idx)
 + return plane;
 + i++;
 + }
 + return NULL;
 +}
 +EXPORT_SYMBOL(drm_plane_from_index);
 +
 +/**
   * drm_plane_force_disable - Forcibly disable a plane
   * @plane: plane to disable
   *
 diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
 index 7b5c661..6b30036 100644
 --- a/include/drm/drm_crtc.h
 +++ b/include/drm/drm_crtc.h
 @@ -1264,6 +1264,7 @@ extern int drm_plane_init(struct drm_device *dev,
 bool is_primary);
  extern void drm_plane_cleanup(struct drm_plane *plane);
  extern unsigned int drm_plane_index(struct drm_plane *plane);
 +extern struct drm_plane * drm_plane_from_index(struct drm_device *dev, int 
 idx);
  extern void drm_plane_force_disable(struct drm_plane *plane);
  extern int drm_plane_check_pixel_format(const struct drm_plane *plane,
   u32 format);
 -- 
 1.7.9.5
 

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling  Development
Intel Corporation
(916) 356-2795
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 01/20] drm/i915: Adding drm helper function drm_plane_from_index().

2015-04-01 Thread Chandra Konduru
Adding drm helper function to return plane pointer from index where
index is a returned by drm_plane_index.

v2:
-avoided nested loop by adding loop count (Daniel)

Signed-off-by: Chandra Konduru chandra.kond...@intel.com
---
 drivers/gpu/drm/drm_crtc.c |   22 ++
 include/drm/drm_crtc.h |1 +
 2 files changed, 23 insertions(+)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index d576a4d..0f0159b 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -1289,6 +1289,28 @@ unsigned int drm_plane_index(struct drm_plane *plane)
 EXPORT_SYMBOL(drm_plane_index);
 
 /**
+ * drm_plane_from_index - find the registered plane at an index
+ * @idx: index of registered plane to find for
+ *
+ * Given a plane index, return the registered plane from DRM device's
+ * list of planes with matching index.
+ */
+struct drm_plane *
+drm_plane_from_index(struct drm_device *dev, int idx)
+{
+   struct drm_plane *plane;
+   unsigned int i = 0;
+
+   list_for_each_entry(plane, dev-mode_config.plane_list, head) {
+   if (i == idx)
+   return plane;
+   i++;
+   }
+   return NULL;
+}
+EXPORT_SYMBOL(drm_plane_from_index);
+
+/**
  * drm_plane_force_disable - Forcibly disable a plane
  * @plane: plane to disable
  *
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 7b5c661..6b30036 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -1264,6 +1264,7 @@ extern int drm_plane_init(struct drm_device *dev,
  bool is_primary);
 extern void drm_plane_cleanup(struct drm_plane *plane);
 extern unsigned int drm_plane_index(struct drm_plane *plane);
+extern struct drm_plane * drm_plane_from_index(struct drm_device *dev, int 
idx);
 extern void drm_plane_force_disable(struct drm_plane *plane);
 extern int drm_plane_check_pixel_format(const struct drm_plane *plane,
u32 format);
-- 
1.7.9.5

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx