Re: [Intel-gfx] [PATCH 04/12] drm/i915: Remove double wait_for_vblank on broadwell.

[Daniel Vetter]

On Tue, Dec 08, 2015 at 04:14:58PM +0200, Ville Syrjälä wrote:
> On Wed, Nov 25, 2015 at 11:44:48AM +0200, Ander Conselvan De Oliveira wrote:
> > On Thu, 2015-11-19 at 16:07 +0100, Maarten Lankhorst wrote:
> > > wait_vblank is already set in intel_plane_atomic_calc_changes
> > > for broadwell, waiting for a double vblank is overkill.
> > > 
> > > Signed-off-by: Maarten Lankhorst 
> > 
> > Reviewed-by: Ander Conselvan de Oliveira 
> 
> I see this one got merged without the r-b tag in the commit message.

I guess we really need your dim xt ;-)
-Daniel

> 
> > 
> > > ---
> > >  drivers/gpu/drm/i915/intel_display.c | 8 
> > >  1 file changed, 8 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > > b/drivers/gpu/drm/i915/intel_display.c
> > > index 5345ffcce51e..60f17bc5f0ce 100644
> > > --- a/drivers/gpu/drm/i915/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/intel_display.c
> > > @@ -4657,14 +4657,6 @@ intel_post_enable_primary(struct drm_crtc *crtc)
> > >   int pipe = intel_crtc->pipe;
> > >  
> > >   /*
> > > -  * BDW signals flip done immediately if the plane
> > > -  * is disabled, even if the plane enable is already
> > > -  * armed to occur at the next vblank :(
> > > -  */
> > > - if (IS_BROADWELL(dev))
> > > - intel_wait_for_vblank(dev, pipe);
> > > -
> > > - /*
> > >* FIXME IPS should be fine as long as one plane is
> > >* enabled, but in practice it seems to have problems
> > >* when going from primary only to sprite only and vice
> > ___
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Ville Syrjälä
> Intel OTC
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 04/12] drm/i915: Remove double wait_for_vblank on broadwell.

[Maarten Lankhorst]

Op 08-12-15 om 15:14 schreef Ville Syrjälä:
> On Wed, Nov 25, 2015 at 11:44:48AM +0200, Ander Conselvan De Oliveira wrote:
>> On Thu, 2015-11-19 at 16:07 +0100, Maarten Lankhorst wrote:
>>> wait_vblank is already set in intel_plane_atomic_calc_changes
>>> for broadwell, waiting for a double vblank is overkill.
>>>
>>> Signed-off-by: Maarten Lankhorst 
>> Reviewed-by: Ander Conselvan de Oliveira 
> I see this one got merged without the r-b tag in the commit message.
>
>
Oops, my bad!

Waiting on git-patchwork to automate pulling tags. :)

~Maarten
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 04/12] drm/i915: Remove double wait_for_vblank on broadwell.

[Ville Syrjälä]

On Wed, Nov 25, 2015 at 11:44:48AM +0200, Ander Conselvan De Oliveira wrote:
> On Thu, 2015-11-19 at 16:07 +0100, Maarten Lankhorst wrote:
> > wait_vblank is already set in intel_plane_atomic_calc_changes
> > for broadwell, waiting for a double vblank is overkill.
> > 
> > Signed-off-by: Maarten Lankhorst 
> 
> Reviewed-by: Ander Conselvan de Oliveira 

I see this one got merged without the r-b tag in the commit message.

> 
> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 8 
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index 5345ffcce51e..60f17bc5f0ce 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -4657,14 +4657,6 @@ intel_post_enable_primary(struct drm_crtc *crtc)
> > int pipe = intel_crtc->pipe;
> >  
> > /*
> > -* BDW signals flip done immediately if the plane
> > -* is disabled, even if the plane enable is already
> > -* armed to occur at the next vblank :(
> > -*/
> > -   if (IS_BROADWELL(dev))
> > -   intel_wait_for_vblank(dev, pipe);
> > -
> > -   /*
> >  * FIXME IPS should be fine as long as one plane is
> >  * enabled, but in practice it seems to have problems
> >  * when going from primary only to sprite only and vice
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 04/12] drm/i915: Remove double wait_for_vblank on broadwell.

[Ander Conselvan De Oliveira]

On Thu, 2015-11-19 at 16:07 +0100, Maarten Lankhorst wrote:
> wait_vblank is already set in intel_plane_atomic_calc_changes
> for broadwell, waiting for a double vblank is overkill.
> 
> Signed-off-by: Maarten Lankhorst 

Reviewed-by: Ander Conselvan de Oliveira 

> ---
>  drivers/gpu/drm/i915/intel_display.c | 8 
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 5345ffcce51e..60f17bc5f0ce 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -4657,14 +4657,6 @@ intel_post_enable_primary(struct drm_crtc *crtc)
>   int pipe = intel_crtc->pipe;
>  
>   /*
> -  * BDW signals flip done immediately if the plane
> -  * is disabled, even if the plane enable is already
> -  * armed to occur at the next vblank :(
> -  */
> - if (IS_BROADWELL(dev))
> - intel_wait_for_vblank(dev, pipe);
> -
> - /*
>* FIXME IPS should be fine as long as one plane is
>* enabled, but in practice it seems to have problems
>* when going from primary only to sprite only and vice
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 04/12] drm/i915: Remove double wait_for_vblank on broadwell.

[Maarten Lankhorst]

wait_vblank is already set in intel_plane_atomic_calc_changes
for broadwell, waiting for a double vblank is overkill.

Signed-off-by: Maarten Lankhorst 
---
 drivers/gpu/drm/i915/intel_display.c | 8 
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c 
b/drivers/gpu/drm/i915/intel_display.c
index 5345ffcce51e..60f17bc5f0ce 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4657,14 +4657,6 @@ intel_post_enable_primary(struct drm_crtc *crtc)
int pipe = intel_crtc->pipe;
 
/*
-* BDW signals flip done immediately if the plane
-* is disabled, even if the plane enable is already
-* armed to occur at the next vblank :(
-*/
-   if (IS_BROADWELL(dev))
-   intel_wait_for_vblank(dev, pipe);
-
-   /*
 * FIXME IPS should be fine as long as one plane is
 * enabled, but in practice it seems to have problems
 * when going from primary only to sprite only and vice
-- 
2.1.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx