Re: [Intel-gfx] [PATCH 04/13] video: udlfb: don't restore fb_mmap after deferred IO cleanup

2019-11-27 Thread Daniel Vetter
On Wed, Nov 27, 2019 at 06:32:00PM +0200, Jani Nikula wrote:
> Deferred IO now preserves the fb_ops.
> 
> Cc: Bernie Thompson 
> Cc: linux-fb...@vger.kernel.org
> Signed-off-by: Jani Nikula 

Reviewed-by: Daniel Vetter 

Aside: I wonder whether we should start retiring all the fbdev drivers
which have kms drivers already ... you get fbdev for free with the latter.
-Daniel

> ---
>  drivers/video/fbdev/udlfb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
> index fe373b63ddd6..07905d385949 100644
> --- a/drivers/video/fbdev/udlfb.c
> +++ b/drivers/video/fbdev/udlfb.c
> @@ -1037,7 +1037,6 @@ static int dlfb_ops_release(struct fb_info *info, int 
> user)
>   fb_deferred_io_cleanup(info);
>   kfree(info->fbdefio);
>   info->fbdefio = NULL;
> - info->fbops->fb_mmap = dlfb_ops_mmap;
>   }
>  
>   dev_dbg(info->dev, "release, user=%d count=%d\n", user, dlfb->fb_count);
> -- 
> 2.20.1
> 
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 04/13] video: udlfb: don't restore fb_mmap after deferred IO cleanup

2019-11-27 Thread Jani Nikula
Deferred IO now preserves the fb_ops.

Cc: Bernie Thompson 
Cc: linux-fb...@vger.kernel.org
Signed-off-by: Jani Nikula 
---
 drivers/video/fbdev/udlfb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index fe373b63ddd6..07905d385949 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -1037,7 +1037,6 @@ static int dlfb_ops_release(struct fb_info *info, int 
user)
fb_deferred_io_cleanup(info);
kfree(info->fbdefio);
info->fbdefio = NULL;
-   info->fbops->fb_mmap = dlfb_ops_mmap;
}
 
dev_dbg(info->dev, "release, user=%d count=%d\n", user, dlfb->fb_count);
-- 
2.20.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx