[Intel-gfx] [PATCH 04/19] drm/i915: add IS_GEN7 macro to cover Ivy Bridge and later

2011-04-28 Thread Jesse Barnes
Note: IS_GEN* are for render related checks.  Display and other checks
should use IS_MOBILE, IS_$CHIPSET or test for specific features.

Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org
---
 drivers/gpu/drm/i915/i915_drv.h |7 +++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 4dfe3fa..93ac632 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -931,11 +931,18 @@ enum intel_chip_family {
 #define IS_IRONLAKE_M(dev) ((dev)-pci_device == 0x0046)
 #define IS_MOBILE(dev) (INTEL_INFO(dev)-is_mobile)
 
+/*
+ * The genX designation typically refers to the render engine, so render
+ * capability related checks should use IS_GEN, while display and other checks
+ * have their own (e.g. HAS_PCH_SPLIT for ILK+ display, IS_foo for particular
+ * chips, etc.).
+ */
 #define IS_GEN2(dev)   (INTEL_INFO(dev)-gen == 2)
 #define IS_GEN3(dev)   (INTEL_INFO(dev)-gen == 3)
 #define IS_GEN4(dev)   (INTEL_INFO(dev)-gen == 4)
 #define IS_GEN5(dev)   (INTEL_INFO(dev)-gen == 5)
 #define IS_GEN6(dev)   (INTEL_INFO(dev)-gen == 6)
+#define IS_GEN7(dev)   (INTEL_INFO(dev)-gen == 7)
 
 #define HAS_BSD(dev)(INTEL_INFO(dev)-has_bsd_ring)
 #define HAS_BLT(dev)(INTEL_INFO(dev)-has_blt_ring)
-- 
1.7.4.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 04/19] drm/i915: add IS_GEN7 macro to cover Ivy Bridge and later

2011-04-28 Thread Keith Packard
On Thu, 28 Apr 2011 15:12:50 -0700, Jesse Barnes jbar...@virtuousgeek.org 
wrote:
 Note: IS_GEN* are for render related checks.  Display and other checks
 should use IS_MOBILE, IS_$CHIPSET or test for specific features.
 
 Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

Reviewed-by: Keith Packard kei...@keithp.com

-- 
keith.pack...@intel.com


pgpsB6S4fLOTt.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx