Re: [Intel-gfx] [PATCH 05/20] drm/i915: don't forget to uninstall the PM IRQs

2014-03-18 Thread Ben Widawsky
On Fri, Mar 07, 2014 at 08:10:21PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni 
> 
> It's the only thihg missing, apparently.

s/thihg/thing

There is a potential fixup in patch 3, but with or without,
everything up through here is:
Reviewed-by: Ben Widawsky 

> 
> Signed-off-by: Paulo Zanoni 
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index a9f173c..f681462 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3314,6 +3314,8 @@ static void ironlake_irq_uninstall(struct drm_device 
> *dev)
>   I915_WRITE(GEN7_ERR_INT, I915_READ(GEN7_ERR_INT));
>  
>   GEN5_IRQ_FINI(GT);
> + if (INTEL_INFO(dev)->gen >= 6)
> + GEN5_IRQ_FINI(GEN6_PM);
>  
>   if (HAS_PCH_NOP(dev))
>   return;
> -- 
> 1.8.5.3
> 
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ben Widawsky, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 05/20] drm/i915: don't forget to uninstall the PM IRQs

2014-03-07 Thread Paulo Zanoni
From: Paulo Zanoni 

It's the only thihg missing, apparently.

Signed-off-by: Paulo Zanoni 
---
 drivers/gpu/drm/i915/i915_irq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index a9f173c..f681462 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -3314,6 +3314,8 @@ static void ironlake_irq_uninstall(struct drm_device *dev)
I915_WRITE(GEN7_ERR_INT, I915_READ(GEN7_ERR_INT));
 
GEN5_IRQ_FINI(GT);
+   if (INTEL_INFO(dev)->gen >= 6)
+   GEN5_IRQ_FINI(GEN6_PM);
 
if (HAS_PCH_NOP(dev))
return;
-- 
1.8.5.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx