[Intel-gfx] [PATCH 08/49] drm/i915: Re-enable RPS wait-boosting for all engines
This reverts commit ec5cc0f9b019af95e4571a9fa162d94294c8d90b Author: Chris Wilson Date: Thu Jun 12 10:28:55 2014 +0100 drm/i915: Restrict GPU boost to the RCS engine The premise that media/blitter workloads are not affected by boosting is patently false with a trip through igt. The question that remains is what exactly is going wrong with the media workload that prompted this? Hopefully that would be fixed by the missing agressive downclocking, in addition to the extra restrictions imposed on how frequent a process is allowed to boost. Signed-off-by: Chris Wilson Cc: Deepak S Cc: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index d54f6a277d82..05f94ee8ea37 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1222,7 +1222,7 @@ int __i915_wait_request(struct drm_i915_gem_request *req, timeout_expire = timeout ? jiffies + nsecs_to_jiffies_timeout((u64)*timeout) : 0; - if (ring->id == RCS && INTEL_INFO(dev)->gen >= 6) + if (INTEL_INFO(dev)->gen >= 6) gen6_rps_boost(dev_priv, file_priv); if (!irq_test_in_progress && WARN_ON(!ring->irq_get(ring))) -- 2.1.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 08/49] drm/i915: Re-enable RPS wait-boosting for all engines
On Friday 27 March 2015 04:31 PM, Chris Wilson wrote: This reverts commit ec5cc0f9b019af95e4571a9fa162d94294c8d90b Author: Chris Wilson Date: Thu Jun 12 10:28:55 2014 +0100 drm/i915: Restrict GPU boost to the RCS engine The premise that media/blitter workloads are not affected by boosting is patently false with a trip through igt. The question that remains is what exactly is going wrong with the media workload that prompted this? Hopefully that would be fixed by the missing agressive downclocking, in addition to the extra restrictions imposed on how frequent a process is allowed to boost. we may have to look at media workload. Last time when we observed that for a 1080p HD clip GPU freq was staying at Rp0 most of the time. Hopefully aggressive downclocking should help Acked-by: Deepak S Signed-off-by: Chris Wilson Cc: Deepak S Cc: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index d54f6a277d82..05f94ee8ea37 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1222,7 +1222,7 @@ int __i915_wait_request(struct drm_i915_gem_request *req, timeout_expire = timeout ? jiffies + nsecs_to_jiffies_timeout((u64)*timeout) : 0; - if (ring->id == RCS && INTEL_INFO(dev)->gen >= 6) + if (INTEL_INFO(dev)->gen >= 6) gen6_rps_boost(dev_priv, file_priv); if (!irq_test_in_progress && WARN_ON(!ring->irq_get(ring))) ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 08/49] drm/i915: Re-enable RPS wait-boosting for all engines
On Thu, Apr 02, 2015 at 04:39:56PM +0530, Deepak S wrote: > > > On Friday 27 March 2015 04:31 PM, Chris Wilson wrote: > >This reverts commit ec5cc0f9b019af95e4571a9fa162d94294c8d90b > >Author: Chris Wilson > >Date: Thu Jun 12 10:28:55 2014 +0100 > > > > drm/i915: Restrict GPU boost to the RCS engine > > > >The premise that media/blitter workloads are not affected by boosting is > >patently false with a trip through igt. The question that remains is > >what exactly is going wrong with the media workload that prompted this? > >Hopefully that would be fixed by the missing agressive downclocking, in > >addition to the extra restrictions imposed on how frequent a process is > >allowed to boost. > > we may have to look at media workload. Last time when we observed that for > a 1080p HD clip GPU freq was staying at Rp0 most of the time. > Hopefully aggressive downclocking should help > > Acked-by: Deepak S I think here what will help most is limiting the RPS boost to once per client (per busy period). I've actually found a couple of other places where we will artificially boost clocks: mmioflips and sw-semaphores. I've patches to also restrict those to once per busy period. The plan is that we only give RPS boosts to missed pageflips (via the vblank tracker) and only the first time a client stalls on a bo. I think with those in place, we can have the best of both worlds - instant boost for compute/gpu bound applications, and low render frequencies for sustained throughput. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
