Re: [Intel-gfx] [PATCH 1/2] drm: Fix example comment of format modifier blob

2017-09-04 Thread Daniel Vetter 
On Thu, Aug 31, 2017 at 01:00:35PM -0700, Ben Widawsky wrote:
> On 17-08-31 16:52:14, Gabriel Krisman Bertazi wrote:
> > To represent formats 98-102, the supported formats mask must be
> > 0x7c and not 0x3c.
> > 
> > Signed-off-by: Gabriel Krisman Bertazi 
> > ---
> > include/uapi/drm/drm_mode.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> > index 54fc38c3c3f1..34b6bb34b002 100644
> > --- a/include/uapi/drm/drm_mode.h
> > +++ b/include/uapi/drm/drm_mode.h
> > @@ -749,9 +749,9 @@ struct drm_format_modifier {
> >  * If the number formats grew to 128, and formats 98-102 are
> >  * supported with the modifier:
> >  *
> > -* 0x003c 
> > +* 0x007c 
> >  *^
> > -*|__offset = 64, formats = 0x3c
> > +*|__offset = 64, formats = 0x7c
> >  *
> >  */
> > __u64 formats;
> > -- 
> 
> > > > hex(0x1f << 98)
> '0x7c'
> Reviewed-by: Ben Widawsky 

Applied to drm-misc-next, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm: Fix example comment of format modifier blob

2017-08-31 Thread Ben Widawsky 

On 17-08-31 16:52:14, Gabriel Krisman Bertazi wrote:

To represent formats 98-102, the supported formats mask must be
0x7c and not 0x3c.

Signed-off-by: Gabriel Krisman Bertazi 
---
include/uapi/drm/drm_mode.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
index 54fc38c3c3f1..34b6bb34b002 100644
--- a/include/uapi/drm/drm_mode.h
+++ b/include/uapi/drm/drm_mode.h
@@ -749,9 +749,9 @@ struct drm_format_modifier {
 * If the number formats grew to 128, and formats 98-102 are
 * supported with the modifier:
 *
-* 0x003c 
+* 0x007c 
 *^
-*|__offset = 64, formats = 0x3c
+*|__offset = 64, formats = 0x7c
 *
 */
__u64 formats;
--



hex(0x1f << 98)

'0x7c'
Reviewed-by: Ben Widawsky 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/2] drm: Fix example comment of format modifier blob

2017-08-31 Thread Gabriel Krisman Bertazi 
To represent formats 98-102, the supported formats mask must be
0x7c and not 0x3c.

Signed-off-by: Gabriel Krisman Bertazi 
---
 include/uapi/drm/drm_mode.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
index 54fc38c3c3f1..34b6bb34b002 100644
--- a/include/uapi/drm/drm_mode.h
+++ b/include/uapi/drm/drm_mode.h
@@ -749,9 +749,9 @@ struct drm_format_modifier {
 * If the number formats grew to 128, and formats 98-102 are
 * supported with the modifier:
 *
-* 0x003c 
+* 0x007c 
 *^
-*|__offset = 64, formats = 0x3c
+*|__offset = 64, formats = 0x7c
 *
 */
__u64 formats;
-- 
2.11.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx