Re: [Intel-gfx] [PATCH 1/3] Revert "Skip intel_crt_init for Dell XPS 8700"

[Ville Syrjälä]

On Wed, Oct 05, 2016 at 03:56:39PM +0200, Daniel Vetter wrote:
> On Mon, Sep 26, 2016 at 12:20:44PM +0300, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä 
> > 
> > This reverts commit 10b6ee4a87811a110cb01eaca01eb04da6801baf.
> > 
> > According to [1] Dell XPS8700 VBT says 'int_crt_support 0', so thanks
> > to commit e4abb733bb72 ("drm/i915: Check VBT for CRT port presence on
> > HSW/BDW") we no longer need to blacklist it based on DMI.
> > 
> > Looking through the bug report, SFUSE_STRAP based detection was
> > apparently also tried and failed, but the VBT based one should still
> > work just fine.
> > 
> > The commit says that the symptom was a frozen machine, but based on the
> > bug report it doesn't look like the CRT detection was at least directly
> > responsible for such a drastic outcome.
> > 
> > Cc: Giacomo Comes 
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=73559
> > References: 
> > http://lists.freedesktop.org/archives/intel-gfx/2014-January/038178.html [1]
> > Signed-off-by: Ville Syrjälä 
> 
> Seems all rather reasonable. On all 3 patches:
> 
> Reviewed-by: Daniel Vetter 

Thanks. Series pushed to dinq.

> 
> > ---
> >  drivers/gpu/drm/i915/intel_crt.c | 8 
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_crt.c 
> > b/drivers/gpu/drm/i915/intel_crt.c
> > index 88ebbdde185a..ba372c239d48 100644
> > --- a/drivers/gpu/drm/i915/intel_crt.c
> > +++ b/drivers/gpu/drm/i915/intel_crt.c
> > @@ -823,14 +823,6 @@ static const struct dmi_system_id intel_no_crt[] = {
> > DMI_MATCH(DMI_PRODUCT_NAME, "ZGB"),
> > },
> > },
> > -   {
> > -   .callback = intel_no_crt_dmi_callback,
> > -   .ident = "DELL XPS 8700",
> > -   .matches = {
> > -   DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > -   DMI_MATCH(DMI_PRODUCT_NAME, "XPS 8700"),
> > -   },
> > -   },
> > { }
> >  };
> >  
> > -- 
> > 2.7.4
> > 
> > ___
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Ville Syrjälä
Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/3] Revert "Skip intel_crt_init for Dell XPS 8700"

[Daniel Vetter]

On Mon, Sep 26, 2016 at 12:20:44PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä 
> 
> This reverts commit 10b6ee4a87811a110cb01eaca01eb04da6801baf.
> 
> According to [1] Dell XPS8700 VBT says 'int_crt_support 0', so thanks
> to commit e4abb733bb72 ("drm/i915: Check VBT for CRT port presence on
> HSW/BDW") we no longer need to blacklist it based on DMI.
> 
> Looking through the bug report, SFUSE_STRAP based detection was
> apparently also tried and failed, but the VBT based one should still
> work just fine.
> 
> The commit says that the symptom was a frozen machine, but based on the
> bug report it doesn't look like the CRT detection was at least directly
> responsible for such a drastic outcome.
> 
> Cc: Giacomo Comes 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=73559
> References: 
> http://lists.freedesktop.org/archives/intel-gfx/2014-January/038178.html [1]
> Signed-off-by: Ville Syrjälä 

Seems all rather reasonable. On all 3 patches:

Reviewed-by: Daniel Vetter 

> ---
>  drivers/gpu/drm/i915/intel_crt.c | 8 
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_crt.c 
> b/drivers/gpu/drm/i915/intel_crt.c
> index 88ebbdde185a..ba372c239d48 100644
> --- a/drivers/gpu/drm/i915/intel_crt.c
> +++ b/drivers/gpu/drm/i915/intel_crt.c
> @@ -823,14 +823,6 @@ static const struct dmi_system_id intel_no_crt[] = {
>   DMI_MATCH(DMI_PRODUCT_NAME, "ZGB"),
>   },
>   },
> - {
> - .callback = intel_no_crt_dmi_callback,
> - .ident = "DELL XPS 8700",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_PRODUCT_NAME, "XPS 8700"),
> - },
> - },
>   { }
>  };
>  
> -- 
> 2.7.4
> 
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/3] Revert "Skip intel_crt_init for Dell XPS 8700"

[ville . syrjala]

From: Ville Syrjälä 

This reverts commit 10b6ee4a87811a110cb01eaca01eb04da6801baf.

According to [1] Dell XPS8700 VBT says 'int_crt_support 0', so thanks
to commit e4abb733bb72 ("drm/i915: Check VBT for CRT port presence on
HSW/BDW") we no longer need to blacklist it based on DMI.

Looking through the bug report, SFUSE_STRAP based detection was
apparently also tried and failed, but the VBT based one should still
work just fine.

The commit says that the symptom was a frozen machine, but based on the
bug report it doesn't look like the CRT detection was at least directly
responsible for such a drastic outcome.

Cc: Giacomo Comes 
References: https://bugs.freedesktop.org/show_bug.cgi?id=73559
References: 
http://lists.freedesktop.org/archives/intel-gfx/2014-January/038178.html [1]
Signed-off-by: Ville Syrjälä 
---
 drivers/gpu/drm/i915/intel_crt.c | 8 
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index 88ebbdde185a..ba372c239d48 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
@@ -823,14 +823,6 @@ static const struct dmi_system_id intel_no_crt[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "ZGB"),
},
},
-   {
-   .callback = intel_no_crt_dmi_callback,
-   .ident = "DELL XPS 8700",
-   .matches = {
-   DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
-   DMI_MATCH(DMI_PRODUCT_NAME, "XPS 8700"),
-   },
-   },
{ }
 };
 
-- 
2.7.4

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx