Re: [Intel-gfx] [PATCH 1/3] drm/i915/oa: add content to Makefile

2019-08-01 Thread Jani Nikula 
On Tue, 30 Jul 2019, Michal Wajdeczko  wrote:
> On Tue, 30 Jul 2019 13:34:30 +0200, Jani Nikula   
> wrote:
>
>> Apparently the empty Makefile has caused some confusion. Add the
>> subdir-cc-flags-y as in 7fcc7ca549d4 ("drm/i915: add header search path
>> to subdir Makefiles") which should be useful.
>>
>> The generated headers still aren't self-contained, so can't add that.
>>
>> References:  
>> http://marc.info/?i=80bf2204-558a-6d3f-c493-bf17b891f...@infradead.org
>> Cc: Chris Wilson 
>> Cc: Lionel Landwerlin 
>> Cc: Michal Wajdeczko 
>> Signed-off-by: Jani Nikula 
>>
>
> Reviewed-by: Michal Wajdeczko 

Thanks, pushed the one patch to dinq. May I trouble you for review on
patches 2 and 3 as well please?

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/3] drm/i915/oa: add content to Makefile

2019-07-30 Thread Michal Wajdeczko 
On Tue, 30 Jul 2019 13:34:30 +0200, Jani Nikula   
wrote:



Apparently the empty Makefile has caused some confusion. Add the
subdir-cc-flags-y as in 7fcc7ca549d4 ("drm/i915: add header search path
to subdir Makefiles") which should be useful.

The generated headers still aren't self-contained, so can't add that.

References:  
http://marc.info/?i=80bf2204-558a-6d3f-c493-bf17b891f...@infradead.org

Cc: Chris Wilson 
Cc: Lionel Landwerlin 
Cc: Michal Wajdeczko 
Signed-off-by: Jani Nikula 



Reviewed-by: Michal Wajdeczko 

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/3] drm/i915/oa: add content to Makefile

2019-07-30 Thread Jani Nikula 
Apparently the empty Makefile has caused some confusion. Add the
subdir-cc-flags-y as in 7fcc7ca549d4 ("drm/i915: add header search path
to subdir Makefiles") which should be useful.

The generated headers still aren't self-contained, so can't add that.

References: 
http://marc.info/?i=80bf2204-558a-6d3f-c493-bf17b891f...@infradead.org
Cc: Chris Wilson 
Cc: Lionel Landwerlin 
Cc: Michal Wajdeczko 
Signed-off-by: Jani Nikula 

---

This should fix the kernel header generation:
https://github.com/rib/gputop/pull/203
---
 drivers/gpu/drm/i915/oa/Makefile | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/oa/Makefile b/drivers/gpu/drm/i915/oa/Makefile
index e69de29bb2d1..256bfde4a287 100644
--- a/drivers/gpu/drm/i915/oa/Makefile
+++ b/drivers/gpu/drm/i915/oa/Makefile
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: MIT
+
+# For building individual subdir files on the command line
+subdir-ccflags-y += -I$(srctree)/$(src)/..
-- 
2.20.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx