Re: [Intel-gfx] [PATCH 1/4] drm: Nuke unused drm_display_info.pixel_clock

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 07:33:58PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä 
> 
> drm_display_info.pixel_clock is unused. Let's get rid of it.
> 
> Signed-off-by: Ville Syrjälä 
> ---
>  include/drm/drm_connector.h | 6 --
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index bb3bd8e1633a..fcdca46e0c24 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -369,12 +369,6 @@ struct drm_display_info {
>*/
>   unsigned int height_mm;
>  
> - /**
> -  * @pixel_clock: Maximum pixel clock supported by the sink, in units of
> -  * 100Hz. This mismatches the clock in _display_mode (which is in
> -  * kHZ), because that's what the EDID uses as base unit.
> -  */
> - unsigned int pixel_clock;

I'm wondering how I've come up with this fantasy of a text, because afaict
it wasn't ever used. At least seems unused back when I wrote the
kerneldoc.

*shrug*

Reviewed-by: Daniel Vetter 

>   /**
>* @bpc: Maximum bits per color channel. Used by HDMI and DP outputs.
>*/
> -- 
> 2.19.2
> 
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/4] drm: Nuke unused drm_display_info.pixel_clock

2019-03-26 Thread Ville Syrjala
From: Ville Syrjälä 

drm_display_info.pixel_clock is unused. Let's get rid of it.

Signed-off-by: Ville Syrjälä 
---
 include/drm/drm_connector.h | 6 --
 1 file changed, 6 deletions(-)

diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index bb3bd8e1633a..fcdca46e0c24 100644
--- a/include/drm/drm_connector.h
+++ b/include/drm/drm_connector.h
@@ -369,12 +369,6 @@ struct drm_display_info {
 */
unsigned int height_mm;
 
-   /**
-* @pixel_clock: Maximum pixel clock supported by the sink, in units of
-* 100Hz. This mismatches the clock in _display_mode (which is in
-* kHZ), because that's what the EDID uses as base unit.
-*/
-   unsigned int pixel_clock;
/**
 * @bpc: Maximum bits per color channel. Used by HDMI and DP outputs.
 */
-- 
2.19.2

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx