Re: [Intel-gfx] [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
On Tue, Sep 11, 2018 at 10:47:34AM +0200, Bartlomiej Zolnierkiewicz wrote: > On 09/11/2018 09:42 AM, Daniel Vetter wrote: > > On Mon, Sep 10, 2018 at 02:48:43PM +0200, Bartlomiej Zolnierkiewicz wrote: > >> > >> On 08/22/2018 10:54 AM, Daniel Vetter wrote: > >>> This was only added for the drm's fbdev emulation support, so that it > >>> would try harder to show the Oops. > >>> > >>> Unfortunately this never really worked reliably, and in practice ended > >>> up pushing the real Oops off the screen due to plentyfull locking, > >>> sleep-while-atomic and other issues. So we removed all that support > >>> from the fbdev emulation a while back. Aside: We've also removed the > >>> kgdb support, for similar reasons. > >>> > >>> Since it's such a small patch I figured I don't split this up into the > >>> usual 3-phase removal. > >>> > >>> Cc: Ben Skeggs > >>> Cc: Bartlomiej Zolnierkiewicz > >>> Cc: Greg Kroah-Hartman > >>> Cc: Hans de Goede > >>> Cc: Daniel Vetter > >>> Cc: Alexander Kapshuk > >>> Cc: Kees Cook > >>> Cc: Thierry Reding > >>> Cc: David Lechner > >>> Cc: nouv...@lists.freedesktop.org > >>> Cc: linux-fb...@vger.kernel.org > >>> Signed-off-by: Daniel Vetter > >> > >> Acked-by: Bartlomiej Zolnierkiewicz > > > > Ack for merging the entire series through drm-misc-next? > > Yes, thanks for taking care of this. Thanks, all merged into drm-misc-next for 4.20. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
On 09/11/2018 09:42 AM, Daniel Vetter wrote: > On Mon, Sep 10, 2018 at 02:48:43PM +0200, Bartlomiej Zolnierkiewicz wrote: >> >> On 08/22/2018 10:54 AM, Daniel Vetter wrote: >>> This was only added for the drm's fbdev emulation support, so that it >>> would try harder to show the Oops. >>> >>> Unfortunately this never really worked reliably, and in practice ended >>> up pushing the real Oops off the screen due to plentyfull locking, >>> sleep-while-atomic and other issues. So we removed all that support >>> from the fbdev emulation a while back. Aside: We've also removed the >>> kgdb support, for similar reasons. >>> >>> Since it's such a small patch I figured I don't split this up into the >>> usual 3-phase removal. >>> >>> Cc: Ben Skeggs >>> Cc: Bartlomiej Zolnierkiewicz >>> Cc: Greg Kroah-Hartman >>> Cc: Hans de Goede >>> Cc: Daniel Vetter >>> Cc: Alexander Kapshuk >>> Cc: Kees Cook >>> Cc: Thierry Reding >>> Cc: David Lechner >>> Cc: nouv...@lists.freedesktop.org >>> Cc: linux-fb...@vger.kernel.org >>> Signed-off-by: Daniel Vetter >> >> Acked-by: Bartlomiej Zolnierkiewicz > > Ack for merging the entire series through drm-misc-next? Yes, thanks for taking care of this. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
On Mon, Sep 10, 2018 at 02:48:43PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On 08/22/2018 10:54 AM, Daniel Vetter wrote: > > This was only added for the drm's fbdev emulation support, so that it > > would try harder to show the Oops. > > > > Unfortunately this never really worked reliably, and in practice ended > > up pushing the real Oops off the screen due to plentyfull locking, > > sleep-while-atomic and other issues. So we removed all that support > > from the fbdev emulation a while back. Aside: We've also removed the > > kgdb support, for similar reasons. > > > > Since it's such a small patch I figured I don't split this up into the > > usual 3-phase removal. > > > > Cc: Ben Skeggs > > Cc: Bartlomiej Zolnierkiewicz > > Cc: Greg Kroah-Hartman > > Cc: Hans de Goede > > Cc: Daniel Vetter > > Cc: Alexander Kapshuk > > Cc: Kees Cook > > Cc: Thierry Reding > > Cc: David Lechner > > Cc: nouv...@lists.freedesktop.org > > Cc: linux-fb...@vger.kernel.org > > Signed-off-by: Daniel Vetter > > Acked-by: Bartlomiej Zolnierkiewicz Ack for merging the entire series through drm-misc-next? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
On 08/22/2018 10:54 AM, Daniel Vetter wrote: > This was only added for the drm's fbdev emulation support, so that it > would try harder to show the Oops. > > Unfortunately this never really worked reliably, and in practice ended > up pushing the real Oops off the screen due to plentyfull locking, > sleep-while-atomic and other issues. So we removed all that support > from the fbdev emulation a while back. Aside: We've also removed the > kgdb support, for similar reasons. > > Since it's such a small patch I figured I don't split this up into the > usual 3-phase removal. > > Cc: Ben Skeggs > Cc: Bartlomiej Zolnierkiewicz > Cc: Greg Kroah-Hartman > Cc: Hans de Goede > Cc: Daniel Vetter > Cc: Alexander Kapshuk > Cc: Kees Cook > Cc: Thierry Reding > Cc: David Lechner > Cc: nouv...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Daniel Vetter Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
This was only added for the drm's fbdev emulation support, so that it
would try harder to show the Oops.
Unfortunately this never really worked reliably, and in practice ended
up pushing the real Oops off the screen due to plentyfull locking,
sleep-while-atomic and other issues. So we removed all that support
from the fbdev emulation a while back. Aside: We've also removed the
kgdb support, for similar reasons.
Since it's such a small patch I figured I don't split this up into the
usual 3-phase removal.
Cc: Ben Skeggs
Cc: Bartlomiej Zolnierkiewicz
Cc: Greg Kroah-Hartman
Cc: Hans de Goede
Cc: Daniel Vetter
Cc: Alexander Kapshuk
Cc: Kees Cook
Cc: Thierry Reding
Cc: David Lechner
Cc: nouv...@lists.freedesktop.org
Cc: linux-fb...@vger.kernel.org
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/nouveau/nouveau_fbcon.c | 1 -
drivers/staging/vboxvideo/vbox_fb.c | 3 +--
drivers/video/fbdev/core/fbcon.c| 1 -
include/linux/fb.h | 4
4 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index 844498c4267c..20a260887be3 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -379,7 +379,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_COPYAREA |
FBINFO_HWACCEL_FILLRECT |
FBINFO_HWACCEL_IMAGEBLIT;
- info->flags |= FBINFO_CAN_FORCE_OUTPUT;
info->fbops = &nouveau_fbcon_sw_ops;
info->fix.smem_start = fb->nvbo->bo.mem.bus.base +
fb->nvbo->bo.mem.bus.offset;
diff --git a/drivers/staging/vboxvideo/vbox_fb.c
b/drivers/staging/vboxvideo/vbox_fb.c
index 43c39eca4ae1..034f8ffa8f20 100644
--- a/drivers/staging/vboxvideo/vbox_fb.c
+++ b/drivers/staging/vboxvideo/vbox_fb.c
@@ -155,8 +155,7 @@ static int vboxfb_create(struct drm_fb_helper *helper,
* The last flag forces a mode set on VT switches even if the kernel
* does not think it is needed.
*/
- info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT |
- FBINFO_MISC_ALWAYS_SETPAR;
+ info->flags = FBINFO_DEFAULT | FBINFO_MISC_ALWAYS_SETPAR;
info->fbops = &vboxfb_ops;
/*
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 5fb156bdcf4e..2b5bb52b1798 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -1104,7 +1104,6 @@ static void fbcon_init(struct vc_data *vc, int init)
if (p->userfont)
charcnt = FNTCHARCNT(p->fontdata);
- vc->vc_panic_force_write = !!(info->flags & FBINFO_CAN_FORCE_OUTPUT);
vc->vc_can_do_color = (fb_get_color_depth(&info->var, &info->fix)!=1);
vc->vc_complement_mask = vc->vc_can_do_color ? 0x7700 : 0x0800;
if (charcnt == 256) {
diff --git a/include/linux/fb.h b/include/linux/fb.h
index aa74a228bb92..fa8c6f9c9c3a 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -457,10 +457,6 @@ struct fb_tile_ops {
*/
#define FBINFO_BE_MATH 0x10
-/* report to the VT layer that this fb driver can accept forced console
- output like oopses */
-#define FBINFO_CAN_FORCE_OUTPUT 0x20
-
struct fb_info {
atomic_t count;
int node;
--
2.18.0
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
