Re: [Intel-gfx] [PATCH 18/19] drm/i915: set IBX pch type explicitly

2011-04-28 Thread Keith Packard
On Thu, 28 Apr 2011 15:13:04 -0700, Jesse Barnes  
wrote:

> This is a little less confusing than relying on the implicit zeroing of
> the dev_priv.

Thanks.

Reviewed-by: Keith Packard 

-- 
keith.pack...@intel.com


pgpFuOeuyyxOq.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 18/19] drm/i915: set IBX pch type explicitly

2011-04-28 Thread Jesse Barnes
This is a little less confusing than relying on the implicit zeroing of
the dev_priv.

Signed-off-by: Jesse Barnes 
---
 drivers/gpu/drm/i915/i915_drv.c |6 +-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 14b9c6f..9290abd 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -254,6 +254,7 @@ MODULE_DEVICE_TABLE(pci, pciidlist);
 #endif
 
 #define INTEL_PCH_DEVICE_ID_MASK   0xff00
+#define INTEL_PCH_IBX_DEVICE_ID_TYPE   0x3b00
 #define INTEL_PCH_CPT_DEVICE_ID_TYPE   0x1c00
 #define INTEL_PCH_PPT_DEVICE_ID_TYPE   0x1e00
 
@@ -274,7 +275,10 @@ void intel_detect_pch (struct drm_device *dev)
int id;
id = pch->device & INTEL_PCH_DEVICE_ID_MASK;
 
-   if (id == INTEL_PCH_CPT_DEVICE_ID_TYPE) {
+   if (id == INTEL_PCH_IBX_DEVICE_ID_TYPE) {
+   dev_priv->pch_type = PCH_IBX;
+   DRM_DEBUG_KMS("Found Ibex Peak PCH\n");
+   } else if (id == INTEL_PCH_CPT_DEVICE_ID_TYPE) {
dev_priv->pch_type = PCH_CPT;
DRM_DEBUG_KMS("Found CougarPoint PCH\n");
} else if (id == INTEL_PCH_PPT_DEVICE_ID_TYPE) {
-- 
1.7.4.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx