Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Mark conn as initialised by iterator

2019-10-28 Thread Mika Kuoppala
Chris Wilson  writes:

> smatch complains about
> drivers/gpu/drm/i915//display/intel_display.c:14403 
> intel_set_dp_tp_ctl_normal() error: uninitialized symbol 'conn'.
> because it has no way to determine that the loop must have an entry.
> Tell the static analysers to ignore the local, it will always be set.
>
> Signed-off-by: Chris Wilson 

Reviewed-by: Mika Kuoppala 

> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c 
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 0f0c582a56d5..9dce2e9e5376 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -14391,8 +14391,8 @@ static void intel_crtc_enable_trans_port_sync(struct 
> intel_crtc *crtc,
>  static void intel_set_dp_tp_ctl_normal(struct intel_crtc *crtc,
>  struct intel_atomic_state *state)
>  {
> + struct drm_connector *uninitialized_var(conn);
>   struct drm_connector_state *conn_state;
> - struct drm_connector *conn;
>   struct intel_dp *intel_dp;
>   int i;
>  
> -- 
> 2.24.0.rc1
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 2/2] drm/i915/display: Mark conn as initialised by iterator

2019-10-28 Thread Chris Wilson
smatch complains about
drivers/gpu/drm/i915//display/intel_display.c:14403 
intel_set_dp_tp_ctl_normal() error: uninitialized symbol 'conn'.
because it has no way to determine that the loop must have an entry.
Tell the static analysers to ignore the local, it will always be set.

Signed-off-by: Chris Wilson 
---
 drivers/gpu/drm/i915/display/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c 
b/drivers/gpu/drm/i915/display/intel_display.c
index 0f0c582a56d5..9dce2e9e5376 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -14391,8 +14391,8 @@ static void intel_crtc_enable_trans_port_sync(struct 
intel_crtc *crtc,
 static void intel_set_dp_tp_ctl_normal(struct intel_crtc *crtc,
   struct intel_atomic_state *state)
 {
+   struct drm_connector *uninitialized_var(conn);
struct drm_connector_state *conn_state;
-   struct drm_connector *conn;
struct intel_dp *intel_dp;
int i;
 
-- 
2.24.0.rc1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx