Re: [Intel-gfx] [PATCH 2/3] drm/i915: Don't send idle pattern after DP2.0 link training

2023-03-02 Thread Imre Deak 
On Tue, Feb 14, 2023 at 03:43:47PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä 
> 
> Bspec calls us to select pattern 2 after link training for
> DP 2.0. Let's do that... by doing nothing because we will
> be transmitting pattern 2 at the end of the link training
> already.
> 
> Signed-off-by: Ville Syrjälä 

Reviewed-by: Imre Deak 

> ---
>  drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4 
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c 
> b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> index 3d3efcf02011..b35af21a2761 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> @@ -1379,10 +1379,6 @@ intel_dp_128b132b_lane_cds(struct intel_dp *intel_dp,
>   }
>   }
>  
> - /* FIXME: Should DP_TRAINING_PATTERN_DISABLE be written first? */
> - if (intel_dp->set_idle_link_train)
> - intel_dp->set_idle_link_train(intel_dp, crtc_state);
> -
>   return true;
>  }
>  
> -- 
> 2.39.1
>

[Intel-gfx] [PATCH 2/3] drm/i915: Don't send idle pattern after DP2.0 link training

2023-02-14 Thread Ville Syrjala 
From: Ville Syrjälä 

Bspec calls us to select pattern 2 after link training for
DP 2.0. Let's do that... by doing nothing because we will
be transmitting pattern 2 at the end of the link training
already.

Signed-off-by: Ville Syrjälä 
---
 drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c 
b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
index 3d3efcf02011..b35af21a2761 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
@@ -1379,10 +1379,6 @@ intel_dp_128b132b_lane_cds(struct intel_dp *intel_dp,
}
}
 
-   /* FIXME: Should DP_TRAINING_PATTERN_DISABLE be written first? */
-   if (intel_dp->set_idle_link_train)
-   intel_dp->set_idle_link_train(intel_dp, crtc_state);
-
return true;
 }
 
-- 
2.39.1