Re: [Intel-gfx] [PATCH 2/3] drm/i915: Don't try indexed reads to alternate slave addresses

[Chris Wilson]

Quoting Ville Syrjala (2017-11-23 19:41:56)
> From: Ville Syrjälä 
> 
> We can only specify the one slave address to indexed reads/writes.
> Make sure the messages we check are destined to the same slave
> address before deciding to do an indexed transfer.
> 
> Cc: sta...@vger.kernel.org
> Cc: Daniel Kurtz 
> Cc: Chris Wilson 
> Cc: Daniel Vetter 
> Cc: Sean Paul 
> Fixes: 56f9eac05489 ("drm/i915/intel_i2c: use INDEX cycles for i2c read 
> transactions")
> Signed-off-by: Ville Syrjälä 
Reviewed-by: Chris Wilson 
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 2/3] drm/i915: Don't try indexed reads to alternate slave addresses

[Ville Syrjala]

From: Ville Syrjälä 

We can only specify the one slave address to indexed reads/writes.
Make sure the messages we check are destined to the same slave
address before deciding to do an indexed transfer.

Cc: sta...@vger.kernel.org
Cc: Daniel Kurtz 
Cc: Chris Wilson 
Cc: Daniel Vetter 
Cc: Sean Paul 
Fixes: 56f9eac05489 ("drm/i915/intel_i2c: use INDEX cycles for i2c read 
transactions")
Signed-off-by: Ville Syrjälä 
---
 drivers/gpu/drm/i915/intel_i2c.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
index 165375cbef2f..4b4528d7010f 100644
--- a/drivers/gpu/drm/i915/intel_i2c.c
+++ b/drivers/gpu/drm/i915/intel_i2c.c
@@ -438,6 +438,7 @@ static bool
 gmbus_is_index_read(struct i2c_msg *msgs, int i, int num)
 {
return (i + 1 < num &&
+   msgs[i].addr == msgs[i + 1].addr &&
!(msgs[i].flags & I2C_M_RD) && msgs[i].len <= 2 &&
(msgs[i + 1].flags & I2C_M_RD));
 }
-- 
2.13.6

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx