Re: [Intel-gfx] [PATCH 3/4] drm/dp-mst: Remove debug WARN_ON

2015-08-04 Thread Thierry Reding
On Mon, Aug 03, 2015 at 05:24:10PM +0200, Daniel Vetter wrote:
 Apparently been in there since forever and fairly easy to hit when
 hotplugging really fast. I can do that since my mst hub has a manual
 button to flick the hpd line for reprobing. The resulting WARNING spam
 isn't pretty.
 
 Cc: Dave Airlie airl...@gmail.com
 Cc: sta...@vger.kernel.org
 Signed-off-by: Daniel Vetter daniel.vet...@intel.com
 ---
  drivers/gpu/drm/drm_dp_mst_topology.c | 1 -
  1 file changed, 1 deletion(-)
 
 diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c 
 b/drivers/gpu/drm/drm_dp_mst_topology.c
 index 778bbb6425b8..b0487c9f018c 100644
 --- a/drivers/gpu/drm/drm_dp_mst_topology.c
 +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
 @@ -1294,7 +1294,6 @@ retry:
   goto retry;
   }
   DRM_DEBUG_KMS(failed to dpcd write %d %d\n, tosend, 
 ret);
 - WARN(1, fail\n);
  
   return -EIO;
   }

Reviewed-by: Thierry Reding tred...@nvidia.com


signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 3/4] drm/dp-mst: Remove debug WARN_ON

2015-08-03 Thread Daniel Vetter
Apparently been in there since forever and fairly easy to hit when
hotplugging really fast. I can do that since my mst hub has a manual
button to flick the hpd line for reprobing. The resulting WARNING spam
isn't pretty.

Cc: Dave Airlie airl...@gmail.com
Cc: sta...@vger.kernel.org
Signed-off-by: Daniel Vetter daniel.vet...@intel.com
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c 
b/drivers/gpu/drm/drm_dp_mst_topology.c
index 778bbb6425b8..b0487c9f018c 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -1294,7 +1294,6 @@ retry:
goto retry;
}
DRM_DEBUG_KMS(failed to dpcd write %d %d\n, tosend, 
ret);
-   WARN(1, fail\n);
 
return -EIO;
}
-- 
2.5.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx