Re: [Intel-gfx] [PATCH 3/4] drm/i915/uc: Update messages from fw upload step

2019-08-11 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-11 20:51:31)
> Our old messages were redundant or misleading (as loaded is
> not the same as running). Keep only one message for debug.
> 
> Signed-off-by: Michal Wajdeczko 
> Cc: Daniele Ceraolo Spurio 
> Cc: Chris Wilson 

One is still one too many :)
Reviewed-by: Chris Wilson 
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 3/4] drm/i915/uc: Update messages from fw upload step

2019-08-11 Thread Michal Wajdeczko
Our old messages were redundant or misleading (as loaded is
not the same as running). Keep only one message for debug.

Signed-off-by: Michal Wajdeczko 
Cc: Daniele Ceraolo Spurio 
Cc: Chris Wilson 
---
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 14 +++---
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c 
b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
index 22828a76626d..5665019d341a 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
@@ -493,9 +493,6 @@ int intel_uc_fw_upload(struct intel_uc_fw *uc_fw, struct 
intel_gt *gt,
 {
int err;
 
-   DRM_DEBUG_DRIVER("%s fw load %s\n",
-intel_uc_fw_type_repr(uc_fw->type), uc_fw->path);
-
/* make sure the status was cleared the last time we reset the uc */
GEM_BUG_ON(intel_uc_fw_is_loaded(uc_fw));
 
@@ -514,14 +511,9 @@ int intel_uc_fw_upload(struct intel_uc_fw *uc_fw, struct 
intel_gt *gt,
goto fail;
 
uc_fw->status = INTEL_UC_FIRMWARE_TRANSFERRED;
-   DRM_DEBUG_DRIVER("%s fw xfer completed\n",
-intel_uc_fw_type_repr(uc_fw->type));
-
-   DRM_INFO("%s: Loaded firmware %s (version %u.%u)\n",
-intel_uc_fw_type_repr(uc_fw->type),
-uc_fw->path,
-uc_fw->major_ver_found, uc_fw->minor_ver_found);
-
+   DRM_DEV_DEBUG_DRIVER(gt->i915->drm.dev, "%s firmware %s: %s\n",
+intel_uc_fw_type_repr(uc_fw->type), uc_fw->path,
+intel_uc_fw_status_repr(uc_fw->status));
return 0;
 
 fail:
-- 
2.19.2

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx