Re: [Intel-gfx] [PATCH 3/7] drm/i915/icl: Enable media sampler powergate

2019-04-10 Thread Chris Wilson
Quoting Mika Kuoppala (2019-04-10 11:59:19)
> Enable media sampler powergate as recommended.
> 
> v2: use REG_BIT (Chris)
> 
> Cc: Chris Wilson 
> Signed-off-by: Mika Kuoppala 
Acked-by: Chris Wilson 
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 3/7] drm/i915/icl: Enable media sampler powergate

2019-04-10 Thread Mika Kuoppala
Enable media sampler powergate as recommended.

v2: use REG_BIT (Chris)

Cc: Chris Wilson 
Signed-off-by: Mika Kuoppala 
---
 drivers/gpu/drm/i915/i915_reg.h | 5 +++--
 drivers/gpu/drm/i915/intel_pm.c | 4 +++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 9c206e803ab3..3c243025ea3e 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -8687,8 +8687,9 @@ enum {
 #define GEN9_MEDIA_PG_IDLE_HYSTERESIS  _MMIO(0xA0C4)
 #define GEN9_RENDER_PG_IDLE_HYSTERESIS _MMIO(0xA0C8)
 #define GEN9_PG_ENABLE _MMIO(0xA210)
-#define GEN9_RENDER_PG_ENABLE  (1 << 0)
-#define GEN9_MEDIA_PG_ENABLE   (1 << 1)
+#define GEN9_RENDER_PG_ENABLE  REG_BIT(0)
+#define GEN9_MEDIA_PG_ENABLE   REG_BIT(1)
+#define GEN11_MEDIA_SAMPLER_PG_ENABLE  REG_BIT(2)
 #define GEN8_PUSHBUS_CONTROL   _MMIO(0xA248)
 #define GEN8_PUSHBUS_ENABLE_MMIO(0xA250)
 #define GEN8_PUSHBUS_SHIFT _MMIO(0xA25C)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 3a157bdbee2a..5aac4abb820c 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7185,7 +7185,9 @@ static void gen11_enable_rc6(struct drm_i915_private 
*dev_priv)
 * 3b: Enable Coarse Power Gating only when RC6 is enabled.
 */
I915_WRITE(GEN9_PG_ENABLE,
-  GEN9_RENDER_PG_ENABLE | GEN9_MEDIA_PG_ENABLE);
+  GEN9_RENDER_PG_ENABLE |
+  GEN9_MEDIA_PG_ENABLE |
+  GEN11_MEDIA_SAMPLER_PG_ENABLE);
 
intel_uncore_forcewake_put(_priv->uncore, FORCEWAKE_ALL);
 }
-- 
2.17.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx