Re: [Intel-gfx] [PATCH 30/24] drm/i915/icl: update VBT's child_device_config flags2 field

[Rodrigo Vivi]

On Thu, May 24, 2018 at 04:42:41PM -0700, Paulo Zanoni wrote:
> Some bits from the flags2 field are going to be used in the next
> patches, so replace the whole-byte definition with the actual bits and
> document their versions.
> 
> This patch is based on a patch by Animesh Manna.
> 
> Cc: Animesh Manna 
> Credits-to: Animesh Manna 
> Signed-off-by: Paulo Zanoni 
> ---
>  drivers/gpu/drm/i915/intel_vbt_defs.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h 
> b/drivers/gpu/drm/i915/intel_vbt_defs.h
> index 7c798c18600e..4dc907e47262 100644
> --- a/drivers/gpu/drm/i915/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
> @@ -420,7 +420,9 @@ struct child_device_config {
>   u16 extended_type;
>   u8 dvo_function;
>   u8 dp_usb_type_c:1; /* 195 */
> - u8 flags2_reserved:7;   /* 195 */
> + u8 tbt:1;   /* 209 */
> + u8 flags2_reserved:2;   /* 195 */
> + u8 dp_port_trace_length:4;  /* 209 */

The reversal order always confuses me :P

Reviewed-by: Rodrigo Vivi 


>   u8 dp_gpio_index;   /* 195 */
>   u16 dp_gpio_pin_num;/* 195 */
>   u8 dp_iboost_level:4;   /* 196 */
> -- 
> 2.14.3
> 
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 30/24] drm/i915/icl: update VBT's child_device_config flags2 field

[Paulo Zanoni]

Some bits from the flags2 field are going to be used in the next
patches, so replace the whole-byte definition with the actual bits and
document their versions.

This patch is based on a patch by Animesh Manna.

Cc: Animesh Manna 
Credits-to: Animesh Manna 
Signed-off-by: Paulo Zanoni 
---
 drivers/gpu/drm/i915/intel_vbt_defs.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h 
b/drivers/gpu/drm/i915/intel_vbt_defs.h
index 7c798c18600e..4dc907e47262 100644
--- a/drivers/gpu/drm/i915/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
@@ -420,7 +420,9 @@ struct child_device_config {
u16 extended_type;
u8 dvo_function;
u8 dp_usb_type_c:1; /* 195 */
-   u8 flags2_reserved:7;   /* 195 */
+   u8 tbt:1;   /* 209 */
+   u8 flags2_reserved:2;   /* 195 */
+   u8 dp_port_trace_length:4;  /* 209 */
u8 dp_gpio_index;   /* 195 */
u16 dp_gpio_pin_num;/* 195 */
u8 dp_iboost_level:4;   /* 196 */
-- 
2.14.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx