Re: [Intel-gfx] [PATCH 37/37] drm/i915/dg1: Remove SHPD_FILTER_CNT register programming

2020-05-26 Thread Souza, Jose 
On Wed, 2020-05-20 at 17:38 -0700, Lucas De Marchi wrote:
> From: Anusha Srivatsa 
> 
> Bspec asks us to remove the special programming of the
> SHPD_FILTER_CNT register which we have been doing since CNP+.
> 
> Bspec: 49305
> 

Reviewed-by: José Roberto de Souza 

> Cc: Matt Roper 
> Signed-off-by: Anusha Srivatsa 
> Signed-off-by: Lucas De Marchi 
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index ca35edef492d..d4061d5b4d67 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3274,7 +3274,8 @@ static void icp_hpd_irq_setup(struct drm_i915_private 
> *dev_priv,
>   hotplug_irqs = sde_ddi_mask | sde_tc_mask;
>   enabled_irqs = intel_hpd_enabled_irqs(dev_priv, 
> dev_priv->hotplug.pch_hpd);
>  
> - I915_WRITE(SHPD_FILTER_CNT, SHPD_FILTER_CNT_500_ADJ);
> + if (INTEL_PCH_TYPE(dev_priv) <= PCH_TGP)
> + I915_WRITE(SHPD_FILTER_CNT, SHPD_FILTER_CNT_500_ADJ);
>  
>   ibx_display_interrupt_update(dev_priv, hotplug_irqs, enabled_irqs);
>  
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 37/37] drm/i915/dg1: Remove SHPD_FILTER_CNT register programming

2020-05-20 Thread Lucas De Marchi 
From: Anusha Srivatsa 

Bspec asks us to remove the special programming of the
SHPD_FILTER_CNT register which we have been doing since CNP+.

Bspec: 49305

Cc: Matt Roper 
Signed-off-by: Anusha Srivatsa 
Signed-off-by: Lucas De Marchi 
---
 drivers/gpu/drm/i915/i915_irq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index ca35edef492d..d4061d5b4d67 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -3274,7 +3274,8 @@ static void icp_hpd_irq_setup(struct drm_i915_private 
*dev_priv,
hotplug_irqs = sde_ddi_mask | sde_tc_mask;
enabled_irqs = intel_hpd_enabled_irqs(dev_priv, 
dev_priv->hotplug.pch_hpd);
 
-   I915_WRITE(SHPD_FILTER_CNT, SHPD_FILTER_CNT_500_ADJ);
+   if (INTEL_PCH_TYPE(dev_priv) <= PCH_TGP)
+   I915_WRITE(SHPD_FILTER_CNT, SHPD_FILTER_CNT_500_ADJ);
 
ibx_display_interrupt_update(dev_priv, hotplug_irqs, enabled_irqs);
 
-- 
2.26.2

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx